Re: Problems with printk logs and my driver

2015-10-14 Thread Eric Curtin
On 4 October 2015 at 16:28, Alan Stern wrote: > On Sun, 4 Oct 2015, Eric Curtin wrote: > >> Ok so for the fun of it, I changed the VENDOR_ID and DEVICE_ID of my >> keyboard to use the driver for this samsung Wireless keyboard and >> mouse, crazy I know since I have a dif

Re: Problems with printk logs and my driver

2015-10-04 Thread Eric Curtin
On 30 September 2015 at 13:07, Austin S Hemmelgarn wrote: > On 2015-09-29 18:11, Eric Curtin wrote: >> >> On 25 September 2015 at 16:45, Austin S Hemmelgarn >> wrote: >>> >>> On 2015-09-25 08:02, Jiri Kosina wrote: >>>> >>>> >

Re: Problems with printk logs and my driver

2015-09-29 Thread Eric Curtin
On 25 September 2015 at 16:45, Austin S Hemmelgarn wrote: > On 2015-09-25 08:02, Jiri Kosina wrote: >> >> On Fri, 25 Sep 2015, Felipe Tonello wrote: >> >>> Maybe a better description on Kconfig and/or comments on source code >>> it's enough. >> >> >> I personally find the current Kconfig descripti

Re: First kernel patch (optimization)

2015-09-29 Thread Eric Curtin
On 29 September 2015 at 14:51, Austin S Hemmelgarn wrote: > On 2015-09-26 09:28, Eric Curtin wrote: >> >> Hi Dimitry, >> >>> Is it Debian-derivative by any chance? Their capslock setup is wonky >>> because CapsLock key does no actually set up as a CapsLock

Re: First kernel patch (optimization)

2015-09-26 Thread Eric Curtin
Hi Dimitry, > Is it Debian-derivative by any chance? Their capslock setup is wonky > because CapsLock key does no actually set up as a CapsLock but another > modifier. Also is it in X or is it on text console? Because X handles > led state on its own... I'm on Fedora 22. Yeah, you're correct X is

Problems with printk logs and my driver

2015-09-23 Thread Eric Curtin
Hi Guys, Just wondering what I am doing wrong. I can't see my logs. I figured out what driver is used for my keyboard and started adding logging: [curtine@localhost ~]$ sudo lsusb -v | grep eyboard -B 13 Bus 001 Device 003: ID 04ca:008d Lite-On Technology Corp. Device Descriptor: bLength

Re: First kernel patch (optimization)

2015-09-22 Thread Eric Curtin
On 22 September 2015 at 18:38, Linus Torvalds wrote: > On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: >> My first kernel patch, hope I did everything correctly! Instead of calling >> strlen on every iteration of the for loop, just call it once instead and >> store i

Re: First kernel patch (optimization)

2015-09-16 Thread Eric Curtin
On 16 September 2015 at 21:02, Greg KH wrote: > On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: >> Hi Greg, >> >> As I said in the subject of the mail (which I have been since told I >> shouldn't have done this), I'm a noob to kernel code. I

Re: First kernel patch (optimization)

2015-09-16 Thread Eric Curtin
:45:53AM -0400, Austin S Hemmelgarn wrote: > > On 2015-09-15 20:09, Steve Calfee wrote: > > >On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin > > >wrote: > > >>Signed-off-by: Eric Curtin > > >> > > >>diff --git a/tools/usb/usbip/src/usb

tools: usbip: detach: avoid calling strlen() at each iteration

2015-09-15 Thread Eric Curtin
Instead of calling strlen on every iteration of the for loop, just call it once and cache the result in a temporary local variable which will be used in the for loop instead. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index

First kernel patch (optimization)

2015-09-15 Thread Eric Curtin
My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index