Re: [PATCH v1 04/14] usb: dwc2: Fix suspend state in host mode for partial power down.

Hi, On Tue, Apr 30, 2019 at 12:11 AM Artur Petrosyan wrote: > > Hi, > > On 4/29/2019 21:35, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 29, 2019 at 4:03 AM Artur Petrosyan > > wrote: > >> > >> Hi, > >> > >> On 4/27/201

Re: [PATCH 01/14] usb: dwc2: Fix dwc2_restore_device_registers() function.

Hi, On Mon, Apr 29, 2019 at 11:59 PM Artur Petrosyan wrote: > > On 4/29/2019 21:34, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 29, 2019 at 3:51 AM Artur Petrosyan > > wrote: > >> > >> On 4/27/2019 00:43, Doug Anderson wrote: > >&g

Re: [PATCH v1 08/14] usb: dwc2: Add default param to control power optimization.

Hi, On Tue, Apr 30, 2019 at 5:45 AM Artur Petrosyan wrote: > > > If setting "power_down = 0" is wrong then please update your patch to > > remove all the mainline code that sets power_down to 0. Presumably > > this means you'd want to convert that code over to using "power_saving > > = False".

Re: [PATCH v1 14/14] usb: dwc2: Add enter/exit hibernation from system issued suspend/resume

Hi, On Mon, Apr 29, 2019 at 5:01 AM Artur Petrosyan wrote: > > Hi, > > On 4/27/2019 01:01, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan > > wrote: > >> > >> Added a new flow of entering and exiti

Re: [PATCH v1 08/14] usb: dwc2: Add default param to control power optimization.

Hi, On Mon, Apr 29, 2019 at 4:30 AM Artur Petrosyan wrote: > > Hi, > > On 4/27/2019 00:46, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan > > wrote: > >> > >> - Added a default param "power_saving

Re: [PATCH v1 04/14] usb: dwc2: Fix suspend state in host mode for partial power down.

Hi, On Mon, Apr 29, 2019 at 4:03 AM Artur Petrosyan wrote: > > Hi, > > On 4/27/2019 00:45, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan > > wrote: > >> > >> - In dwc2_port_suspend() function added wait

Re: [PATCH 01/14] usb: dwc2: Fix dwc2_restore_device_registers() function.

Hi, On Mon, Apr 29, 2019 at 3:51 AM Artur Petrosyan wrote: > > On 4/27/2019 00:43, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 12, 2019 at 6:38 AM Artur Petrosyan > > wrote: > >> > >> - Added backup of DCFG register. > >> - Added Se

Re: [PATCH v1 14/14] usb: dwc2: Add enter/exit hibernation from system issued suspend/resume

Hi, On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan wrote: > > Added a new flow of entering and exiting hibernation when PC is > hibernated or suspended. > > Signed-off-by: Artur Petrosyan > --- > drivers/usb/dwc2/hcd.c | 128 > +++-- > 1 file change

Re: [PATCH v1 12/14] usb: dwc2: Clear fifo_map when resetting core.

Hi, On Fri, Apr 19, 2019 at 1:06 PM Artur Petrosyan wrote: > > If core enters host hibernation when switching from > device mode to host mode disconnection of host cable > asserts a WARNING in dwc2_hsotg_init_fifo() that > fifo_map is not cleared. > > To avoid the WARNING, fifo_map should be clea

Re: [PATCH v1 09/14] usb: dwc2: Update dwc2_handle_usb_suspend_intr function.

Hi, On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan wrote: > > To avoid working in two modes (partial power down > and hibernation) changed conditions for entering > partial power down or hibernation. > > Instead of checking hw_params.power_optimized and > hw_params.hibernation now checking powe

Re: [PATCH v1 08/14] usb: dwc2: Add default param to control power optimization.

Hi, On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan wrote: > > - Added a default param "power_saving" to enable or > disable hibernation or partial power down features. > > - Printed hibernation param in hw_params_show and > power_saving param in params_show. > > Signed-off-by: Artur Petrosy

Re: [PATCH v1 06/14] usb: dwc2: Add part. power down exit from dwc2_conn_id_status_change().

Hi, On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan wrote: > > Before changing to connector B exiting from Partial > Power Down is required. > > - Added exiting from Partial Power Down mode when > connector ID status changes to "connId B". > Because if connector ID status changed to B connec

Re: [PATCH v1 05/14] usb: dwc2: Add port conn. sts. checking in _dwc2_hcd_resume() function.

Hi, On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan wrote: > > Added port connection status checking which prevents exiting from > Partial Power Down mode from _dwc2_hcd_resume() when no entering > to Partial Power Down mode happened. > > Signed-off-by: Artur Petrosyan > --- > drivers/usb/dwc2

Re: [PATCH v1 04/14] usb: dwc2: Fix suspend state in host mode for partial power down.

Hi, On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan wrote: > > - In dwc2_port_suspend() function added waiting for the > HPRT0.PrtSusp register field to be set. > > - In _dwc2_hcd_suspend() function added checking of > "hsotg->flags.b.port_connect_status" port connection > status if port co

Re: [PATCH v1 03/14] usb: dwc2: Fix wakeup detected and session request interrupt handlers.

Hi, On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan wrote: > > @@ -426,8 +438,6 @@ static void dwc2_handle_wakeup_detected_intr(struct > dwc2_hsotg *hsotg) > /* Change to L0 state */ > hsotg->lx_state = DWC2_L0; > } else { > - if (hsotg->para

Re: [PATCH 01/14] usb: dwc2: Fix dwc2_restore_device_registers() function.

Hi, On Fri, Apr 12, 2019 at 6:38 AM Artur Petrosyan wrote: > > - Added backup of DCFG register. > - Added Set the Power-On Programming done bit. > > Signed-off-by: Artur Petrosyan > --- > drivers/usb/dwc2/gadget.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/usb/

Re: [balbi-usb:testing/next 19/42] drivers/usb/dwc2/core_intr.c:448:25: error: 'struct dwc2_hsotg' has no member named 'phy_reset_work'

Hi, On Thu, Apr 25, 2019 at 8:02 AM Doug Anderson wrote: > > Hi, > > On Thu, Apr 25, 2019 at 6:14 AM kbuild test robot wrote: > > > >439 /* > >440 * If we've got this quirk then th

Re: [balbi-usb:testing/next 19/42] drivers/usb/dwc2/core_intr.c:448:25: error: 'struct dwc2_hsotg' has no member named 'phy_reset_work'

Hi, On Thu, Apr 25, 2019 at 6:14 AM kbuild test robot wrote: > >439 /* >440 * If we've got this quirk then the PHY is > stuck upon >441 * wakeup. Assert reset. This will > propagate out and >442

Re: lan78xx: About 8000 usb interrupts per second when idle

Hi, On Sun, Apr 14, 2019 at 12:46 PM Lukas Wunner wrote: > > On Tue, Apr 09, 2019 at 09:28:16AM +, Minas Harutyunyan wrote: > > Am 09.04.19 um 08:54 schrieb Jisheng Zhang: > > > The second one: 8000 usb interrupts per second when idle. > > > This is abnormal. any idea? Is it due to the lan78x

Re: [RESEND PATCH v2] usb: dwc2: disable power_down on rockchip for regression

Hi, On Fri, Oct 26, 2018 at 7:38 AM Hal Emmerich wrote: > > > From 04fbf78e4e569bf872f1ffcb0a6f9b89569dc913 Mon Sep 17 00:00:00 2001 > From: Hal Emmerich > Date: Thu, 19 Jul 2018 21:48:08 -0500 > Subject: [PATCH] usb: dwc2: disable power_down on rockchip devices > > The bug would let the usb co

Re: [PATCH v2] usb: dwc2: host: use hrtimer for NAK retries

Felipe, On Tue, Nov 20, 2018 at 11:16 PM Minas Harutyunyan wrote: > > On 11/14/2018 3:30 AM, Doug Anderson wrote: > > Hi, > > > > On Sun, Sep 9, 2018 at 9:24 PM Terin Stock wrote: > >> > >> Modify the wait delay utilize the high resolution timer API

Re: [PATCH v2] usb: dwc2: host: use hrtimer for NAK retries

Hi, On Sun, Sep 9, 2018 at 9:24 PM Terin Stock wrote: > > Modify the wait delay utilize the high resolution timer API to allow for > more precisely scheduled callbacks. > > A previous commit added a 1ms retry delay after multiple consecutive > NAKed transactions using jiffies. On systems with a l

Re: [PATCH] usb: dwc2: host: use hrtimer for NAK retries

Hi, On Tue, Aug 28, 2018 at 11:04 AM, Terin Stock wrote: >> It would also be good to document what device you were plugging in >> that you were having problems with and what system you were running >> on. That would help someone else if they ever wanted to modify the >> same area of code and re-

Re: [PATCH] usb: dwc2: host: use hrtimer for NAK retries

Hi, On Sat, Aug 25, 2018 at 8:45 PM, Terin Stock wrote: > Upon upgrading a Raspberry Pi 3B-based project from vanilla 4.14, > attempts to mount a floppy disk in a generic USB floppy drive would hang > until the floppy drive was removed from the system. > > Tracing shows that during mounting the d

Re: [PATCH 2/2] usb: dwc2: Fix inefficient copy of unaligned buffers

Hi, On Thu, Jul 5, 2018 at 7:31 AM, Antti Seppälä wrote: > Make sure only to copy any actual data rather than the whole buffer, > when releasing the temporary buffer used for unaligned non-isochronous > transfers. > > Taken directly from commit 0efd937e27d5e ("USB: ehci-tegra: fix inefficient > c

Re: [PATCH 1/2] usb: dwc2: Fix DMA alignment to start at allocated boundary

Hi, On Thu, Jul 5, 2018 at 7:31 AM, Antti Seppälä wrote: > The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more > supported way") introduced a common way to align DMA allocations. > The code in the commit aligns the struct dma_aligned_buffer but the > actual DMA address pointed by

Re: usb: dwc2: crash regression in commit 3bc04e28a030 (bisected)

Hi, On Sun, Jul 1, 2018 at 11:30 PM, Antti Seppälä wrote: > On 30 June 2018 at 02:57, Doug Anderson wrote: >> Hi, >> >> On Fri, Jun 29, 2018 at 11:29 AM, Antti Seppälä wrote: >>> Hi Doug, John and linux-usb. >>> >>> I'd like to report a r

Re: usb: dwc2: crash regression in commit 3bc04e28a030 (bisected)

Hi, On Fri, Jun 29, 2018 at 11:29 AM, Antti Seppälä wrote: > Hi Doug, John and linux-usb. > > I'd like to report a regression in commit 3bc04e28a030 (usb: dwc2: > host: Get aligned DMA in a more supported way) Seems unlikely, but any chance that hel

Re: [PATCH] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB

Hi, On Wed, May 30, 2018 at 4:04 AM, Manu Gautam wrote: > Move from dwc3-of-simple to dwc3-qcom glue driver to > support peripheral mode which requires qscratch wrapper > programming on VBUS event. Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") > Signed-off-by: Manu Gautam >

Re: [PATCH] usb: dwc2: fix the incorrect bitmaps for the ports of multi_tt hub

Hi, On Mon, May 21, 2018 at 3:12 AM, William Wu wrote: > The dwc2_get_ls_map() use ttport to reference into the > bitmap if we're on a multi_tt hub. But the bitmaps index > from 0 to (hub->maxchild - 1), while the ttport index from > 1 to hub->maxchild. This will cause invalid memory access > whe

Re: [PATCH v4 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Wed, May 9, 2018 at 3:11 AM, William Wu wrote: > The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in > a more supported way") rips out a lot of code to simply the > allocation of aligned DMA. However, it also introduces a new > issue when use isoc split in transfer. > > In my tes

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Wed, May 9, 2018 at 1:55 AM, wlf wrote: > + } else if (hsotg->params.host_dma) { Are you sure this is "else if"? Can't you have descriptor DMA enabled in the controller and still need to do a normal DMA transfer if you plug in a hub? Seems like this should b

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Tue, May 8, 2018 at 12:43 AM, wlf wrote: > Dear Doug, > > 在 2018年05月08日 13:11, Doug Anderson 写道: >> >> Hi, >> >> On Mon, May 7, 2018 at 8:07 PM, William Wu >> wrote: >>> >>> +static int

Re: [PATCH v3 2/2] usb: dwc2: fix isoc split in transfer with no data

Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > If isoc split in transfer with no data (the length of DATA0 > packet is zero), we can't simply return immediately. Because > the DATA0 can be the first transaction or the second transaction > for the isoc split in transaction. If the DATA0 p

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, > + struct dwc2_qh *qh, > + struct dwc2_host_chan *chan) > +{ > + if (!hsotg->un

Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Rob, On Mon, May 7, 2018 at 8:53 AM, Rob Herring wrote: > On Thu, May 03, 2018 at 02:36:13AM +0530, Manu Gautam wrote: >> To improve eye diagram for PHYs on different boards of same SOC, >> some parameters may need to be changed. Provide device tree >> properties to override these from board spec

Re: [PATCH v5 1/7] clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk

Hi, On Wed, May 2, 2018 at 2:06 PM, Manu Gautam wrote: > The USB and PCIE pipe clocks are sourced from external clocks > inside the QMP USB/PCIE PHYs. Enabling or disabling of PIPE RCG > clocks is dependent on PHY initialization sequence hence > update halt_check to BRANCH_HALT_SKIP for these clo

Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

Hi, On Wed, May 2, 2018 at 2:06 PM, Manu Gautam wrote: > To improve eye diagram for PHYs on different boards of same SOC, > some parameters may need to be changed. Provide device tree > properties to override these from board specific device tree > files. While at it, replace "qcom,qusb2-v2-phy"

Re: [PATCH v5 7/7] phy: qcom-qusb2: Add QUSB2 PHYs support for sdm845

Hi, On Wed, May 2, 2018 at 2:06 PM, Manu Gautam wrote: > There are two QUSB2 PHYs present on sdm845. In order > to improve eye diagram for both the PHYs some parameters > need to be changed. Provide device tree properties to > override these from board specific device tree files. > > Signed-off-b

Re: [PATCH v5 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On Wed, May 2, 2018 at 2:06 PM, Manu Gautam wrote: > QMP PHY for USB/PCIE requires pipe_clk for locking of > retime buffers at the pipe interface. Driver checks for > PHY_STATUS without enabling pipe_clk due to which > phy_init() fails with initialization timeout. > Though pipe_clk is output

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Wed, May 2, 2018 at 10:14 AM, wlf wrote: > It's a good way to allocate an extra 3 bytes in the original bounce buffer > for this unaligned > issue， it's similar to the tailroom of sk_buff. However, just as you said, > we'd better find > the special cases where we need an oversized bounce b

Re: [PATCH v2 2/2] usb: dwc2: fix isoc split in transfer with no data

Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: > If isoc split in transfer with no data (the length of DATA0 > packet is zero), we can't simply return immediately. Because > the DATA0 can be the first transaction or the second transaction > for the isoc split in transaction. If the DATA0 p

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

Hi, On Tue, May 1, 2018 at 8:04 PM, William Wu wrote: > The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in > a more supported way") rips out a lot of code to simply the > allocation of aligned DMA. However, it also introduces a new > issue when use isoc split in transfer. > > In my tes

Re: [PATCH v5 00/17] Support for Qualcomm QUSBv2 and QMPv3 USB PHYs

Manu, On Mon, Feb 19, 2018 at 9:21 PM, Manu Gautam wrote: > Hi Kishon, > > > On 2/16/2018 5:19 PM, Kishon Vijay Abraham I wrote: >> >> On Thursday 01 February 2018 06:08 PM, Kishon Vijay Abraham I wrote: >>> >>> The series looks good. I'll start merging once -rc1 is tagged. >> merged, thanks! >>

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Tue, Dec 19, 2017 at 8:56 AM, Stefan Wahren wrote: > Hi Doug, > >> Doug Anderson hat am 19. Dezember 2017 um 16:57 >> geschrieben: >> >> >> Felipe, >> >> On Tue, Dec 12, 2017 at 10:30 AM, Douglas Anderson >> wrote: >> ... >

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

Felipe, On Tue, Dec 12, 2017 at 10:30 AM, Douglas Anderson wrote: > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cause the system to lockup, especially > if the CPU Frequency was at one of the slower operating points (like > 100 MHz / 200

Re: [PATCH] phy: rockchip-typec: Try to turn the PHY on several times

Hi, On Wed, Dec 13, 2017 at 4:41 AM, Enric Balletbo Serra wrote: > Hi Doug, > > 2017-12-11 22:45 GMT+01:00 Douglas Anderson : >> Bind / unbind stress testing of the USB controller on rk3399 found >> that we'd often end up with lots of failures that looked like this: >> >> phy phy-ff80.phy.9

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Tue, Dec 12, 2017 at 3:06 AM, Felipe Balbi wrote: > > Hi, > > Douglas Anderson writes: >> On rk3288-veyron devices on Chrome OS it was found that plugging in an >> Arduino-based USB device could cause the system to lockup, especially >> if the CPU Frequency was at one of the slower operat

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Tue, Nov 28, 2017 at 6:37 AM, Stefan Wahren wrote: > Hi Doug, > > Doug Anderson hat am 30. Oktober 2017 um 18:14 > geschrieben: > > Hi, > > On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi wrote: >> > > Hi, > > Doug Anderson writes: > >

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi wrote: > > Hi, > > Doug Anderson writes: >> Hi, >> >> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren >> wrote: >>> Hi Doug, >>> >>> [add Felipe since this should go through his

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren wrote: > Hi Doug, > > [add Felipe since this should go through his tree] Ah. Sorry Felipe! I know you've landed some dwc2 stuff in the past but for some reason get_maintainer didn't ID you so I thought maybe you weren't doing it anymore. Plea

Re: [PATCH] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Wed, Oct 25, 2017 at 2:08 PM, Douglas Anderson wrote: > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cause the system to lockup, especially > if the CPU Frequency was at one of the slower operating points (like > 100 MHz / 200 MHz)

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Mon, Oct 16, 2017 at 1:49 PM, Julius Werner wrote: >> d9a14b00 339317035 C Ii:1:004:1 -32:1 0 >> d9a14b00 339317049 S Ii:1:004:1 -115:1 10 < >> d9a14b00 339318040 C Ii:1:004:1 -32:1 0 >> d9a14b00 339318057 S Ii:1:004:1 -115:1 10 < >> d9a14b00 339319042 C Ii:1:004:1 -32:1 0 >> d9a14b00 3393

Re: [PATCH V4] r8152: add Linksys USB3GIGV1 id

Grant, On Thu, Sep 28, 2017 at 11:35 AM, Grant Grundler wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler > --- > drivers/net/usb/cdc_ether.c | 10 +++

Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

Hi, On Thu, Sep 28, 2017 at 3:28 PM, Rustad, Mark D wrote: > >> On Sep 27, 2017, at 9:39 AM, Grant Grundler wrote: >> >> On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote: >>> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >>>>

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

Hi, On Wed, Sep 27, 2017 at 5:07 PM, Grant Grundler wrote: >>> #define DELL_VENDOR_ID 0x413C >>> #define REALTEK_VENDOR_ID 0x0bda >>> #define SAMSUNG_VENDOR_ID 0x04e8 >>> +#define LINKSYS_VENDOR_ID 0x13b1 >>> #define LENOVO_VENDOR_ID 0x17ef >> >> Slight nit that "

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

Hi, On Wed, Sep 27, 2017 at 10:28 AM, Grant Grundler wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler > --- > drivers/net/usb/cdc_ether.c | 10 ++

Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

Hi On Mon, Sep 25, 2017 at 6:09 PM, Grant Grundler wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler > --- > drivers/net/usb/cdc_ether.c | 8

Re: [RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent()

Hi, On Tue, Sep 19, 2017 at 1:37 PM, Oliver Neukum wrote: > Am Dienstag, den 19.09.2017, 09:15 -0700 schrieb Douglas Anderson: >> In general when you've got a flag communicating that "something needs >> to be done" you want to clear that flag _before_ doing the task. If >> you clear the flag _af

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

ahren hat am 22. April 2017 um 22:50 >> > > geschrieben: >> > > >> > > >> > > Hi, >> > > >> > > > Eric Anholt hat am 20. April 2017 um 20:54 >> > > > geschrieben: >> > > > >> > > > >> >

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Thu, Apr 20, 2017 at 12:57 PM, Eric Anholt wrote: > Doug Anderson writes: > >> Hi, >> >> On Thu, Apr 20, 2017 at 11:54 AM, Eric Anholt wrote: >>> Stefan Wahren writes: >>> >>>> Hi, >>>> >>>>> Doug Anderso

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Thu, Apr 20, 2017 at 11:54 AM, Eric Anholt wrote: > Stefan Wahren writes: > >> Hi, >> >>> Doug Anderson hat am 18. April 2017 um 22:41 >>> geschrieben: >>> >>> >>> It's hard to know for sure that all of this time is re

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Thu, Apr 20, 2017 at 12:46 AM, Stefan Wahren wrote: > Am 19.04.2017 um 23:47 schrieb Doug Anderson: >> Hi, >> >> On Wed, Apr 19, 2017 at 1:25 PM, Stefan Wahren >> wrote: >>> Hi, >>> >>>> Doug Anderson hat am 18. April 2017 um

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Wed, Apr 19, 2017 at 1:25 PM, Stefan Wahren wrote: > Hi, > >> Doug Anderson hat am 18. April 2017 um 22:41 >> geschrieben: >> >> >> It's hard to know for sure that all of this time is really in >> urb_enqueue(). Possible we could have

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Stefan, On Tue, Apr 18, 2017 at 1:25 PM, Stefan Wahren wrote: > Hi, > > [add Johan] > >> Stefan Wahren hat am 18. April 2017 um 10:07 >> geschrieben: >> >> >> Am 18.04.2017 um 00:37 schrieb Doug Anderson: >> > Hi, >> > >> >

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Tue, Apr 18, 2017 at 1:07 AM, Stefan Wahren wrote: >> 1. With dwc2 you often end up in the situation where you need to >> service an interrupt every 125 uS. If servicing that interrupt takes >> anywhere near 125 uS in the common case then you'll be in trouble. > > I will try to measure th

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

Hi, On Mon, Apr 17, 2017 at 4:05 AM, Stefan Wahren wrote: > Hi, > >> Stefan Wahren hat am 31. Oktober 2016 um 21:34 >> geschrieben: >> >> >> I inspired by this issue [1] i build up a slightly modified setup with a >> Raspberry Pi B (mainline kernel 4.9rc3), a powered 7 port USB hub and 5 >> Pr

Re: [PATCH v3] usb: hub: Fix error loop seen after hub communication errors

Hi, On Thu, Mar 16, 2017 at 12:24 PM, Guenter Roeck wrote: > @@ -1198,7 +1201,7 @@ static void hub_activate(struct usb_hub *hub, enum > hub_activation_type type) > > /* Scan all ports that need attention */ > kick_hub_wq(hub); > - > +abort: One tiny nit that could be done when a

Re: [PATCH v8 3/3] arm64: dts: rockchip: add usb2-phy support for rk3399

Hi, On Tue, Jul 19, 2016 at 12:28 AM, Frank Wang wrote: You need a patch description here, even for simple patches. All you have now is a subject. > Signed-off-by: Frank Wang > --- > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 19 +++ > arch/arm64/boot/dts/rockchip/rk3399.dtsi

Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

William, On Mon, May 9, 2016 at 4:46 AM, William Wu wrote: > Signed-off-by: William Wu > --- > drivers/usb/dwc3/dwc3-of-simple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/dwc3-of-simple.c > b/drivers/usb/dwc3/dwc3-of-simple.c > index 9743353..1f3665b 100644 > --

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

John, On Tue, Mar 22, 2016 at 12:26 PM, John Youn wrote: > Thanks for the debug logs and everyones help. > > After reviewing with our hardware engineers, it seems this is likely > to do with the IDDIG debounce filtering when switching between > modes. You can see if this is enabled in your core b

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Hi, On Wed, Mar 16, 2016 at 11:28 AM, John Youn wrote: > On 3/10/2016 11:14 AM, John Youn wrote: >> On 3/9/2016 11:06 AM, Doug Anderson wrote: >>> Stefan, >>> >>> On Wed, Mar 9, 2016 at 11:01 AM, Stefan Wahren >>> wrote: >>>> >>&g

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Stefan, On Wed, Mar 9, 2016 at 11:01 AM, Stefan Wahren wrote: > >> Doug Anderson hat am 7. März 2016 um 22:30 >> geschrieben: >> >> >> Stefan, >> >> On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren >> wrote: >> > Hi Dou

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Stefan, On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren wrote: > Hi Doug, > >> Douglas Anderson hat am 4. März 2016 um 19:23 >> geschrieben: >> >> >> This reverts commit 192cb07f7928 ("usb: dwc2: Fix probe problem on >> bcm2835") now that we've found the root cause. See the change >> titled ("usb

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

Hi, On Sat, Mar 5, 2016 at 12:41 PM, Michael Niewoehner wrote: > Hi Douglas, > Hi John, > > Am 05.03.2016 um 01:33 schrieb Doug Anderson : > >> Michael, >> >> On Fri, Mar 4, 2016 at 4:09 PM, Michael Niewoehner >> wrote: >>>>> From tes

Re: Odd merge 3b30be3b6487 ("Merge tag 'v4.5-rc6' into next")

Hi, On Fri, Mar 4, 2016 at 5:56 PM, John Youn wrote: > On 3/4/2016 5:04 PM, Doug Anderson wrote: >> Felipe, >> >> Michael pointed out that there's an odd merge that happened. >> Specifically it looks like commit bd84f4ae9986 ("usb: dwc2: Add extra >> de

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

Hi, On Fri, Mar 4, 2016 at 4:33 PM, Doug Anderson wrote: > Michael, > > On Fri, Mar 4, 2016 at 4:09 PM, Michael Niewoehner > wrote: >>>> From testing and trying to make sense of the documentation, it appears >>>> that a 10 ms delay is needed after

Odd merge 3b30be3b6487 ("Merge tag 'v4.5-rc6' into next")

Felipe, Michael pointed out that there's an odd merge that happened. Specifically it looks like commit bd84f4ae9986 ("usb: dwc2: Add extra delay when forcing dr_mode") got lost somehow in the merge commit 3b30be3b6487 ("Merge tag 'v4.5-rc6' into next") Specifically: $ git blame 3b30be3b6487 -- d

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

Hi, On Fri, Mar 4, 2016 at 3:46 PM, Karl Palsson wrote: >> + /* >> + * Sleep for 10-15 ms after the reset to let it finish. >> + * >> + * It's been confirmed on at least one version of the controller >> + * that this is a requirement that this is a requirement in order for

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

Michael, On Fri, Mar 4, 2016 at 4:09 PM, Michael Niewoehner wrote: >>> From testing and trying to make sense of the documentation, it appears >>> that a 10 ms delay is needed after resetting the core to make sure that >>> everything is stable and consistent. Let's add it. >>> >>> In my testing (

Re: [PATCH] usb: move usb_calc_bus_time into common code

John, On Fri, Feb 19, 2016 at 6:55 PM, John Youn wrote: > On 2/19/2016 2:48 PM, Doug Anderson wrote: >> Hi, >> >> On Fri, Feb 19, 2016 at 1:52 PM, Alan Stern >> wrote: >>> On Fri, 19 Feb 2016, Arnd Bergmann wrote: >>> >>>> The

Re: [PATCH] usb: move usb_calc_bus_time into common code

Hi, On Fri, Feb 19, 2016 at 1:52 PM, Alan Stern wrote: > On Fri, 19 Feb 2016, Arnd Bergmann wrote: > >> The dwc2 dual-role USB controller driver has started calling >> usb_calc_bus_time, and does so regardless of whether it is >> being built as a host controller or gadget. In case all > > Out of

Re: [PATCH v6 17/22] usb: dwc2: host: Manage frame nums better in scheduler

Hi, On Thu, Jan 28, 2016 at 6:20 PM, Douglas Anderson wrote: > static void dwc2_qh_init(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh, > struct dwc2_hcd_urb *urb) > { > @@ -569,11 +655,6 @@ static void dwc2_qh_init(struct dwc2_hsotg *hsotg, > struct dwc2_qh *qh, >

Re: [PATCH v6 0/22] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

John, On Tue, Feb 2, 2016 at 3:57 PM, John Youn wrote: > On 1/28/2016 6:20 PM, Douglas Anderson wrote: >> This is a bit of catchall series for all the bug fix and performance >> patches I've been working on over the last few months. Note that for >> dwc2 we need to do LOTS in software and need s

Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time

Kever, On Mon, Feb 1, 2016 at 11:04 PM, Kever Yang wrote: >>> Oh, now I get what you're saying! >>> >>> A) You've got dwc2_release_channel() -> dwc2_deactivate_qh() -> >>> dwc2_hcd_qh_deactivate() >>> ...and always in that case we'll do a select / queue, so we don't need it >>> there. >>> >>> B)

Re: [PATCH v6 20/22] usb: dwc2: host: Properly set even/odd frame

Kever, On Mon, Feb 1, 2016 at 11:46 PM, Kever Yang wrote: > Doug, > > > On 01/29/2016 10:20 AM, Douglas Anderson wrote: >> >> When setting up ISO and INT transfers dwc2 needs to specify whether the >> transfer is for an even or an odd frame (or microframe if the controller >> is running in high s

Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time

Kever, On Sun, Jan 31, 2016 at 8:36 PM, Doug Anderson wrote: > Kever, > > On Sun, Jan 31, 2016 at 7:32 PM, Kever Yang wrote: >> Doug, >> >> >> On 02/01/2016 06:09 AM, Doug Anderson wrote: >>> >>> Kever, >>> >>> O

Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time

Kever, On Sun, Jan 31, 2016 at 7:32 PM, Kever Yang wrote: > Doug, > > > On 02/01/2016 06:09 AM, Doug Anderson wrote: >> >> Kever, >> >> On Sun, Jan 31, 2016 at 1:36 AM, Kever Yang >> wrote: >>> >>> Doug, >>>

Re: [PATCH v6 10/22] usb: dwc2: host: Properly set the HFIR

Kever, On Sun, Jan 31, 2016 at 1:23 AM, Kever Yang wrote: > Doug, > > On 01/29/2016 10:20 AM, Douglas Anderson wrote: >> >> According to the most up to date version of the dwc2 databook, the FRINT >> field of the HFIR register should be programmed to: >> * 125 us * (PHY clock freq for HS) - 1 >>

Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time

Kever, On Sun, Jan 31, 2016 at 1:36 AM, Kever Yang wrote: > Doug, > > > On 01/29/2016 10:20 AM, Douglas Anderson wrote: >> >> In dwc2_hcd_qh_deactivate() we will put some things on the >> periodic_sched_ready list. These things won't be taken off the ready >> list until the next SOF, which might

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Stefan, On Fri, Jan 29, 2016 at 7:28 AM, Stefan Wahren wrote: > Hi Doug, > > Am 27.01.2016 um 21:43 schrieb Doug Anderson: >> Stefan, >> >> On Wed, Jan 27, 2016 at 12:36 PM, Stefan Wahren >> wrote: >>> i can only give you feedback from a user perspec

Re: [PATCH v5 05/21] usb: dwc2: host: Avoid use of chan->qh after qh freed

Hi, On Wed, Jan 27, 2016 at 7:25 PM, Kever Yang wrote: > Hi Doug, > > The NULL pointer bug is one of the most frequent issue we met > during hot plug stress test, thanks for this bug fix. > > Reviewed-by: Kever Yang > > Thanks, > - Kever Thanks for your review. I think I actually found one mor

Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066

Hi, On Thu, Jan 28, 2016 at 10:16 AM, Doug Anderson wrote: > Kever, > > > On Wed, Jan 27, 2016 at 10:41 PM, Kever Yang > wrote: >> Hi Doug, >> >> We are in HOST mode, we only need to receive data from USB camera >> with RX FIFO, and no need to use TX F

Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066

Kever, On Wed, Jan 27, 2016 at 10:41 PM, Kever Yang wrote: > Hi Doug, > > We are in HOST mode, we only need to receive data from USB camera > with RX FIFO, and no need to use TX FIFO for USB webcam, right? :) > > Any way, I think we need to NAK this patch after look into the design > of dwc2 con

Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066

Kever, On Wed, Jan 27, 2016 at 7:10 PM, Kever Yang wrote: > Hi Doug, > > We are using the minimum FIFO size mode for TX now, which only > equal to one max packet size. > > The addition FIFO size may help shorten the inter-packet data > prepare latency when the bus/DRAM is busy. > > For the actual

Re: Bug in split transactions on Raspberry Pi

Hi, On Wed, Jan 27, 2016 at 2:03 PM, Alan Stern wrote: > On Wed, 27 Jan 2016, Doug Anderson wrote: > >> Alan, >> >> On Wed, Jan 27, 2016 at 1:34 PM, Alan Stern >> wrote: >> > On Wed, 27 Jan 2016, Doug Anderson wrote: >> > >> >> This

Re: Bug in split transactions on Raspberry Pi

Alan, On Wed, Jan 27, 2016 at 1:34 PM, Alan Stern wrote: > On Wed, 27 Jan 2016, Doug Anderson wrote: > >> This patch should fix ya. >> >> FIXUP: FROMLIST: usb: dwc2: host: Manage frame nums better in scheduler >> https://chromium-review.googlesource.com/324185 >

Re: Bug in split transactions on Raspberry Pi

Hi, On Wed, Jan 27, 2016 at 12:59 PM, Alan Stern wrote: > On Wed, 27 Jan 2016, Doug Anderson wrote: > >> > In the end I just used the contents of the dwc2 directory from Linus's >> > current tree -- I don't think it has changed since 4.5-rc1. Your >>

Re: [PATCH v5 16/21] usb: dwc2: host: Manage frame nums better in scheduler

Hi, On Fri, Jan 22, 2016 at 10:18 AM, Douglas Anderson wrote: > The dwc2 scheduler (contained in hcd_queue.c) was a bit confusing in the > way it initted / kept track of which frames a QH was going to be active > in. Let's clean things up a little bit in preparation for a rewrite of > the microf

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Stefan, On Wed, Jan 27, 2016 at 12:36 PM, Stefan Wahren wrote: > i can only give you feedback from a user perspective. My keyboard and C-Media > USB Audio still works as expected. OK, thanks! So you had no problems before my patches and you still have no problems after my patches. ...but your

  1   2   3   >