Re: [PATCH] Input: gtco - bounds check collection indent level

2019-07-13 Thread Dmitry Torokhov
On Thu, Jul 11, 2019 at 03:22:32PM -0700, Grant Hernandez wrote: > The GTCO tablet input driver configures itself from an HID report sent > via USB during the initial enumeration process. Some debugging messages > are generated during the parsing. A debugging message indentation > counter is not bo

Re: Extending USB_CONNECTINFO ioctl

2019-06-10 Thread Dmitry Torokhov
On Tue, Jun 04, 2019 at 06:48:53PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 04, 2019 at 09:14:51AM -0700, Dmitry Torokhov wrote: > > Hi Alan, > > > > On Tue, Jun 04, 2019 at 10:17:25AM -0400, Alan Stern wrote: > > > On Mon, 3 Jun 2019, Dmitry Torokhov wrote

Re: Extending USB_CONNECTINFO ioctl

2019-06-04 Thread Dmitry Torokhov
Hi Alan, On Tue, Jun 04, 2019 at 10:17:25AM -0400, Alan Stern wrote: > On Mon, 3 Jun 2019, Dmitry Torokhov wrote: > > > Hi Alan, Greg, > > > > When running software in a jailed environment where sysfs or udev is not > > readily available and one can only have a

Extending USB_CONNECTINFO ioctl

2019-06-03 Thread Dmitry Torokhov
Hi Alan, Greg, When running software in a jailed environment where sysfs or udev is not readily available and one can only have an FD to usbdevfs device passed into the jail, there is a desire to allow libusb working. Alan recently added USBDEVFS_GET_SPEED, but we are still missing bus number and

[PATCH] usb: core: add option of only authorizing internal devices

2019-02-16 Thread Dmitry Torokhov
connected to the internal ports. Previously we could either authorize all or none (or, by default, we'd only authorize wired devices). The behavior is controlled via usbcore.authorized_default command line option. Signed-off-by: Dmitry Torokhov --- .../admin-guide/kernel-parameter

Re: [PATCH v4 1/5] usb: split code locating ACPI companion into port and device

2019-01-22 Thread Dmitry Torokhov
anion() into usb_acpi_find_companion_for_device() and > > > usb_acpi_find_companion_for_port(). > > > > > > Signed-off-by: Dmitry Torokhov > > > Signed-off-by: Rajat Jain > > > Acked-by: Greg Kroah-Hartman > > > Tested-by: Sukumar Ghor

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2017-09-19 Thread Dmitry Torokhov
On Mon, Sep 11, 2017 at 4:29 PM, Benson Leung wrote: > Hi Oliver, > > On Mon, Sep 11, 2017 at 01:02:52PM -0700, Benson Leung wrote: >> Thanks for the pointer. I'll respin the patch with the no_resume version of >> usb_autopm_get_interface and retest. >> > > I went and tried this patch but with usb

Re: usb/gadget: stalls in dummy_timer

2017-09-12 Thread Dmitry Torokhov
On Tue, Sep 12, 2017 at 05:48:51PM +0200, Andrey Konovalov wrote: > On Mon, Sep 11, 2017 at 8:54 PM, Dmitry Torokhov > wrote: > > On Mon, Sep 11, 2017 at 8:15 AM, Andrey Konovalov > > wrote: > >> On Mon, Sep 11, 2017 at 3:25 PM, Alan Stern > >> wrot

Re: usb/gadget: stalls in dummy_timer

2017-09-11 Thread Dmitry Torokhov
On Mon, Sep 11, 2017 at 8:15 AM, Andrey Konovalov wrote: > On Mon, Sep 11, 2017 at 3:25 PM, Alan Stern wrote: >> On Mon, 11 Sep 2017, Andrey Konovalov wrote: >> >>> Hi! >>> >>> I've been getting stall reports like this one while fuzzing the USB >>> stack with gadgetfs. I'm wondering whether this

[PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2017-09-08 Thread Dmitry Torokhov
t the device to sleep. Signed-off-by: Benson Leung Signed-off-by: Dmitry Torokhov --- drivers/hid/usbhid/hid-core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 089bad8a9a21..174d87f0e3e6 100644 --- a/driver

[PATCH] HID: usbhid: fix "always poll" quirk

2017-07-12 Thread Dmitry Torokhov
("HID: usbhid: remove custom locking from usbhid_open...") Signed-off-by: Dmitry Torokhov --- drivers/hid/usbhid/hid-core.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 76013eb5cb7f..c0

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-05-22 Thread Dmitry Torokhov
gt; drivers/input/misc/twl4030-vibra.c | 2 +- Acked-by: Dmitry Torokhov > drivers/mfd/twl-core.c | 6 +++--- > drivers/mfd/twl4030-audio.c | 2 +- > drivers/mfd/twl4030-irq.c | 2 +- > drivers/mfd/twl4030-power.c | 2 +- > dri

Re: [PATCH 0/7] Input: fix NULL-derefs at probe

2017-03-17 Thread Dmitry Torokhov
On Fri, Mar 17, 2017 at 11:53:37AM +0100, Johan Hovold wrote: > On Thu, Mar 16, 2017 at 03:37:28PM -0700, Dmitry Torokhov wrote: > > On Mon, Mar 13, 2017 at 04:45:52PM +0100, Johan Hovold wrote: > > > On Mon, Mar 13, 2017 at 04:15:18PM +0100, Oliver Neukum wrote: > > >

Re: [PATCH 0/7] Input: fix NULL-derefs at probe

2017-03-16 Thread Dmitry Torokhov
On Mon, Mar 13, 2017 at 04:45:52PM +0100, Johan Hovold wrote: > On Mon, Mar 13, 2017 at 04:15:18PM +0100, Oliver Neukum wrote: > > Am Montag, den 13.03.2017, 13:35 +0100 schrieb Johan Hovold: > > > This series fixes a number of NULL-pointer dereferences due to > > > missing > > > endpoint sanity ch

Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

2017-03-01 Thread Dmitry Torokhov
On Wed, Mar 01, 2017 at 09:59:31PM +0200, Avraham Shukron wrote: > > > > This kind of change is definitely not helpful. The original table was > > Nx16, you converted it to Nx14. Why do you think original table used 16 > > columns? > > > > Regardless, it's a very old driver, just let it be. > >

Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

2017-03-01 Thread Dmitry Torokhov
Hi Avraham, On Tue, Feb 21, 2017 at 07:26:50PM +0200, Avraham Shukron wrote: > - Broke long lines > - Added spaces where needed > - Removed unnecessary / trailing whitespaces > - Extracted assignments outside of 'if' statements > > Signed-off-by: Avraham Shukron > --- > drivers/hid/usbhid/usbkb

Re: [RFC PATCH] usb: core: correct usb_get_dev() documentation

2016-10-27 Thread Dmitry Torokhov
es "parent = get_device(dev->parent);" as part of device_add() when registering new interfaces. Reviewed-by: Dmitry Torokhov > --- > This reflects my understanding (and testing), as well as the majority of usage > -- there are *very* few interface drivers that actually call u

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-07-08 Thread Dmitry Torokhov
On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote: > Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: > > Hi Martin, > > > > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: > >> static int pegasus_reset_resume(struct usb_interface

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-06-23 Thread Dmitry Torokhov
sb_autopm calls to be balanced * In reset_resume() we need to set the device mode * In suspend() we must cancel the workqueue's work Signed-off-by: Martin Kepplinger Signed-off-by: Dmitry Torokhov --- drivers/input/tablet/pegasus_notetaker.c | 46 -- 1 fil

Re: [PATCH v7] input: tablet: add Pegasus Notetaker tablet driver

2016-06-01 Thread Dmitry Torokhov
Hi Martin, On Wed, Jun 01, 2016 at 02:55:03PM +0200, Martin Kepplinger wrote: > This adds a driver for the Pegasus Notetaker Pen. When connected, > this uses the Pen as an input tablet. > > This device was sold in various different brandings, for example > "Pegasus Mobile Notetaker M210", >

Re: [PATCH v5] input: tablet: add Pegasus Notetaker tablet driver

2016-05-27 Thread Dmitry Torokhov
Hi Martin, On Fri, May 27, 2016 at 11:46:21AM +0200, Martin Kepplinger wrote: > This adds a driver for the Pegasus Notetaker Pen. When connected, > this uses the Pen as an input tablet. > > This device was sold in various different brandings, for example > "Pegasus Mobile Notetaker M210", >

Re: [PATCH v4] input: tablet: add Pegasus Notetaker tablet driver

2016-05-25 Thread Dmitry Torokhov
Hi Martin, On Wed, May 25, 2016 at 09:44:34AM +0200, Martin Kepplinger wrote: > This adds a driver for the Pegasus Notetaker Pen. When connected, > this uses the Pen as an input tablet. > > This device was sold in various different brandings, for example > "Pegasus Mobile Notetaker M210", >

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

2016-04-06 Thread Dmitry Torokhov
On Wed, Apr 6, 2016 at 3:27 AM, Sedat Dilek wrote: > On Wed, Apr 6, 2016 at 11:35 AM, Sedat Dilek wrote: >> On Wed, Apr 6, 2016 at 11:27 AM, Sedat Dilek wrote: >>> Hi, >>> >>> I cannot use cursor up and down on my notebook and see this in my dmesg. >>> >>> [ 685.425634] atkbd serio0: Unknown ke

Re: [PATCH 1/4] acecad: stop saving struct usb_device

2016-03-31 Thread Dmitry Torokhov
On Tue, Mar 22, 2016 at 04:04:54PM +0100, Oliver Neukum wrote: > static int usb_acecad_open(struct input_dev *dev) > { > struct usb_acecad *acecad = input_get_drvdata(dev); > > - acecad->irq->dev = acecad->usbdev; > + acecad->irq->dev = interface_to_usbdev(acecad->intf); By the w

Re: [PATCH 0/4] tablet: remove private copy to USB device

2016-03-31 Thread Dmitry Torokhov
On Tue, Mar 22, 2016 at 04:04:53PM +0100, Oliver Neukum wrote: > We now have a macro to easily get to the USB device from the interface. > So we are cleaning up all drivers to not store a private pointer. Applied all 4, thank you. > > Oliver Neukum (4): > acecad: stop saving struct usb_device

Re: [PATCH] Input: gtco: fix crash on detecting device without endpoints

2016-03-31 Thread Dmitry Torokhov
On Fri, Mar 18, 2016 at 07:35:00PM +0100, Vladis Dronov wrote: > The gtco driver expects at least one valid endpoint. If given > malicious descriptors that specify 0 for the number of endpoints, > it will crash in the probe function. Ensure there is at least > one endpoint on the interface before u

Re: [PATCH] ims-pcu: sanity check against missing interfaces

2016-03-19 Thread Dmitry Torokhov
On Thu, Mar 17, 2016 at 03:10:47PM +0100, Oliver Neukum wrote: > A malicious device missing interface can make the driver oops. > Add sanity checking. > > Signed-off-by: Oliver Neukum > CC: sta...@vger.kernel.org Applied, thank you. > --- > drivers/input/misc/ims-pcu.c | 4 > 1 file chang

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Dmitry Torokhov
On Mon, Mar 14, 2016 at 9:46 AM, Josh Boyer wrote: > On Mon, Mar 14, 2016 at 12:15 PM, Greg Kroah-Hartman > wrote: >> On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: >>> The powermate driver expects at least one valid USB endpoint in its >>> probe function. If given malicious descrip

Re: [PATCH] USB: input: powermate: fix oops with malicious USB descriptors

2016-03-14 Thread Dmitry Torokhov
On Mon, Mar 14, 2016 at 09:15:48AM -0700, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 10:12:53AM -0400, Josh Boyer wrote: > > The powermate driver expects at least one valid USB endpoint in its > > probe function. If given malicious descriptors that specify 0 for > > the number of endpoint

Re: [PATCHv3] Input: xpad - Fix double URB submission races

2015-12-09 Thread Dmitry Torokhov
Hi Laura, On Mon, Nov 16, 2015 at 02:47:13PM -0800, Laura Abbott wrote: > +static int __xpad_submit_urb(struct usb_xpad *xpad, > + unsigned char odata[XPAD_PKT_LEN], int transfer_length, > + int type, bool safe_submit) > +{ > + int ret; > + > + if (s

Re: [PATCH] usb: interface: allow drivers declare number of endpoints they need

2015-12-01 Thread Dmitry Torokhov
On Tue, Dec 1, 2015 at 11:46 AM, Josh Boyer wrote: > On Mon, Nov 30, 2015 at 7:47 PM, Dmitry Torokhov > wrote: >> On Mon, Nov 30, 2015 at 3:36 PM, Greg Kroah-Hartman >> wrote: >>> On Mon, Nov 30, 2015 at 02:56:09PM -0800, Dmitry Torokhov wrote: >>>> On M

Re: [PATCH] usb: interface: allow drivers declare number of endpoints they need

2015-11-30 Thread Dmitry Torokhov
On Mon, Nov 30, 2015 at 3:36 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 30, 2015 at 02:56:09PM -0800, Dmitry Torokhov wrote: >> On Mon, Nov 30, 2015 at 2:18 PM, Greg Kroah-Hartman >> wrote: >> > On Mon, Nov 30, 2015 at 01:11:50PM -0800, Dmitry Torokhov wrote: >> &g

Re: [PATCH] usb: interface: allow drivers declare number of endpoints they need

2015-11-30 Thread Dmitry Torokhov
On Mon, Nov 30, 2015 at 2:18 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 30, 2015 at 01:11:50PM -0800, Dmitry Torokhov wrote: >> USB interface drivers need to check number of endpoints before trying to >> access/use them. Quite a few drivers only use the default setting >&g

Re: [PATCH] usb: interface: allow drivers declare number of endpoints they need

2015-11-30 Thread Dmitry Torokhov
On Mon, Nov 30, 2015 at 03:39:43PM -0600, Felipe Balbi wrote: > > Hi, > > Dmitry Torokhov writes: > > USB interface drivers need to check number of endpoints before trying to > > access/use them. Quite a few drivers only use the default setting > > (altsetting 0),

[PATCH] usb: interface: allow drivers declare number of endpoints they need

2015-11-30 Thread Dmitry Torokhov
aving every driver implement check manually. For compatibility, if driver does not specify number of endpoints (i.e. number of endpoints is left at 0) we bypass the check in USB core and expect the driver perform necessary checks on its own. Acked-by: Alan Stern Signed-off-by: Dmitry Tor

Re: First kernel patch (optimization)

2015-09-25 Thread Dmitry Torokhov
Hi Erik, > > Yeah, I'm still reading this email thread and learned lots from it. > I'm working on something more meaningful, but it's not going to be > ground breaking of course, there is a led on my capslock key on a new > machine I won at work that does not switch off properly after it is > swit

Re: [PATCHv2] Input: xpad - Fix double URB submission races

2015-08-26 Thread Dmitry Torokhov
On Mon, Aug 24, 2015 at 9:22 PM, Laura Abbott wrote: > On 08/21/2015 09:50 AM, Dmitry Torokhov wrote: >> >> Hi Laura, >> >> On Mon, Aug 10, 2015 at 05:26:12PM -0700, Laura Abbott wrote: >>> >>> v2: Created a proper queue for events instead of just dro

Re: [PATCHv2] Input: xpad - Fix double URB submission races

2015-08-21 Thread Dmitry Torokhov
Hi Laura, On Mon, Aug 10, 2015 at 05:26:12PM -0700, Laura Abbott wrote: > v2: Created a proper queue for events instead of just dropping them How long does it take for the queue to exhaust your memory if you keep bombarding the driver with requests? I do not think you need a queue. I believe the

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

2015-07-30 Thread Dmitry Torokhov
Hi Javier, On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: > Hello, > > Short version: > > This series add the missing MODULE_DEVICE_TABLE() for OF and I2C tables > to export that information so modules have the correct aliases built-in > and autoloading works correctly

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

2015-07-30 Thread Dmitry Torokhov
On Thu, Jul 30, 2015 at 09:35:17AM -0700, Dmitry Torokhov wrote: > Hi Javier, > > On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: > > Hello, > > > > Short version: > > > > This series add the missing MODULE_DEVICE_TABLE() f

Re: [PATCH] Input: xpad - Fix double URB submission races

2015-07-29 Thread Dmitry Torokhov
Hi Laura, On Wed, Jul 29, 2015 at 02:27:23PM -0700, Laura Abbott wrote: @@ -791,6 +796,9 @@ static int xpad_play_effect(struct input_dev *dev, void *data, struct ff_effect > { > struct usb_xpad *xpad = input_get_drvdata(dev); > > + if (test_and_set_bit(OUT_IRQ_SUBMITTED, &xpad->odata

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Dmitry Torokhov
On Mon, Jul 20, 2015 at 03:40:33PM -0700, Greg KH wrote: > On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote: > > On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: > > > On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: > > > &

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Dmitry Torokhov
On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: > On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin > > > + > > + /* sysfs setup */ > > + err = sysfs_create_group(&intf->dev.kobj, &ebeam_attr_group); > > Ick, you just added the sysfs files t

Re: [PATCH] ff-core: use new debug macros

2015-04-14 Thread Dmitry Torokhov
On Tue, Apr 14, 2015 at 02:06:10PM +0200, Oliver Neukum wrote: > Replace old pr_* with dev_* debugging macros Not so new anymore ;) Applied, thank you. > > Signed-off-by: Oliver Neukum > --- > drivers/input/ff-core.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff

Re: [PATCH v2 7/7] USB / PM: Allow USB devices to remain runtime-suspended when sleeping

2015-04-03 Thread Dmitry Torokhov
Hi Tomeu, On Fri, Apr 03, 2015 at 02:57:56PM +0200, Tomeu Vizoso wrote: > Have dev_pm_ops.prepare return 1 for USB devices, interfaces, endpoints > and ports so that USB devices can remain runtime-suspended when the > system goes to a sleep state, if their wakeup state is correct. > > Also enable

Re: [PATCH 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core

2015-03-26 Thread Dmitry Torokhov
On Wed, Mar 25, 2015 at 05:04:32PM -0700, Arun Ramamurthy wrote: > > > On 15-03-25 03:03 PM, Kishon Vijay Abraham I wrote: > >Hi, > > > >On Saturday 21 March 2015 02:59 AM, Arun Ramamurthy wrote: > >> > >> > >>On 15-03-20 02:26 PM, Dmitry T

Re: [PATCH 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-03-20 Thread Dmitry Torokhov
Hi Arun, On Fri, Mar 20, 2015 at 02:07:09PM -0700, Arun Ramamurthy wrote: > Getting phys by index instead of phy names so that the dt > bindings phy-names remain consistent when multiple phys are present > > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > Signed-off-by: Arun Ramamurthy > -

Re: [PATCH 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core

2015-03-20 Thread Dmitry Torokhov
Hi Arun, On Fri, Mar 20, 2015 at 02:07:08PM -0700, Arun Ramamurthy wrote: > Adding devm_of_phy_get_by_index to get phys by supplying an index > and not a phy name when multiple phys are declared > > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > Signed-off-by: Arun Ramamurthy > --- > dri

Re: [PATCH] Remove deprecated IRQF_DISABLED flag entirely

2015-03-06 Thread Dmitry Torokhov
On Thu, Mar 5, 2015 at 5:11 AM, Hannes Reinecke wrote: > On 03/05/2015 01:59 PM, Valentin Rothberg wrote: >> The IRQF_DISABLED is a NOOP and has been scheduled for removal since >> Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from >> core code"). >> >> According to commit e5

[PATCH] usb: musb: blackfin: remove incorrect __exit_p()

2015-01-31 Thread Dmitry Torokhov
bfin_remove() is not (nor should it be) marked as __exit, so we should not be using __exit_p() wrapper with it, otherwise unbinding through sysfs does not work properly. Signed-off-by: Dmitry Torokhov --- Not tested, sorry. drivers/usb/musb/blackfin.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] Input: usbtouchscreen - separate report and transmit buffer size handling

2013-10-15 Thread Dmitry Torokhov
Hi Christian, On Tue, Oct 15, 2013 at 04:50:00PM +0200, Christian Engelmayer wrote: > This patch supports the separate handling of the USB transfer buffer length > and the length of the buffer used for multi packet support. The USB transfer > size can now be explicitly configured via the device_in

Re: [PATCH v1 26/49] input: cm109: prepare for enabling irq in complete()

2013-08-17 Thread Dmitry Torokhov
Hi Ming, On Sun, Aug 18, 2013 at 12:24:51AM +0800, Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). I think cm109 needs some love in it's URB handling, but this patch does not change anything, so: Acked-by: Dmitry Torokhov Or do

[RESEND PATCH] USB: xhci - fix bit definitions for IMAN register

2013-02-25 Thread Dmitry Torokhov
to 1 so it was clearing itself even though we were setting IMAN_IE instead of IMAN_IP), we should still correct the values. Signed-off-by: Dmitry Torokhov --- drivers/usb/host/xhci.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.h b/drivers/usb

[PATCH] USB: remove incorrect __exit markups

2013-02-24 Thread Dmitry Torokhov
: Dmitry Torokhov --- drivers/usb/host/ehci-mxc.c| 2 +- drivers/usb/host/ehci-orion.c | 4 ++-- drivers/usb/host/ehci-sh.c | 4 ++-- drivers/usb/otg/isp1301_omap.c | 4 ++-- drivers/usb/otg/twl4030-usb.c | 4 ++-- drivers/usb/otg/twl6030-usb.c | 4 ++-- drivers/usb/phy/mv_u3d_phy.c | 2

[PATCH 2/3] Input: add IMS Passenger Control Unit driver

2013-02-18 Thread Dmitry Torokhov
to uinput), but the device also has backlighted keys which can not be supported via uinput. Signed-off-by: Dmitry Torokhov --- drivers/input/misc/Kconfig | 10 + drivers/input/misc/Makefile |1 + drivers/input/misc/ims-pcu.c | 1907 ++ 3 files

[PATCH 3/3] USB: cdc-acm - blacklist IMS PCU device

2013-02-18 Thread Dmitry Torokhov
The IMS PCU (Passenger Control Unit) device used custom protocol over serial line, so it is presenting itself as CDC ACM device. Now that we have proper in-kernel driver for it we need to black-list the device in cdc-acm driver. Signed-off-by: Dmitry Torokhov --- drivers/usb/class/cdc-acm.c

[PATCH 0/3] Introduce driver for IMS PCU devices

2013-02-18 Thread Dmitry Torokhov
IMS, an In Flight Entertainment System provider, has a number of seat displays Linux. To interact with the user IMS uses a passenger Control Unit (PCU), which communicates with Rave Display Unit via a USB interface. Originally large part of the PCU handling was done from userspace and so it presen

[PATCH 1/3] Input: add new keycodes for passenger control units

2013-02-18 Thread Dmitry Torokhov
Entertainment systems used in aircraft need additional keycodes for their Passenger Control Units, so let's add them. Signed-off-by: Dmitry Torokhov --- include/uapi/linux/input.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/in

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Dmitry Torokhov
Hi Yuanhan, On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: > The current kfifo API take the kfifo size as input, while it rounds > _down_ the size to power of 2 at __kfifo_alloc. This may introduce > potential issue. > > Take the code at drivers/hid/hid-logitech-dj.c as example: >

[PATCH] USB: xhci - fix bit definitions for IMAN register

2012-12-19 Thread Dmitry Torokhov
According to XHCI specification (5.5.2.1) the IP is bit 0 and IE is bit 1 of IMAN register. Previously their definitions were reversed. Signed-off-by: Dmitry Torokhov --- Sarah, I did not see any ill effects from using the old definitions (I think because IMAN_IP is RW1C and in legacy PCI case

Re: [PATCH v2 0/1] Input: xpad - Implement wireless controller LED setting and fix connect time LED setting

2012-12-02 Thread Dmitry Torokhov
On Fri, Nov 30, 2012 at 08:13:29PM -0800, Chris Moeller wrote: > On Fri, 30 Nov 2012 14:30:23 -0800 > Dmitry Torokhov wrote: > > > Hi Chris, > > > > On Friday, November 30, 2012 01:54:06 PM Chris Moeller wrote: > > > I've submitted versions of this with

Re: [PATCH v2 0/1] Input: xpad - Implement wireless controller LED setting and fix connect time LED setting

2012-11-30 Thread Dmitry Torokhov
ris Moeller This patch removes the non-functional bulk output URB method for setting XBox360 Wireless Controller player number indicators on controller activation, and replaces it with a functional IRQ output URB method. It also implements the LED command control for

Re: [PATCH 02/10] arm: at91: move platfarm_data to include/linux/platform_data/atmel.h

2012-11-10 Thread Dmitry Torokhov
> > For preparation to switch to arm multiarch kernel > > Acked-by: Marc Kleine-Budde (for the CAN related > changes) Acked-by: Dmitry Torokhov for input piece. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ebeam PATCH v2 1/2] hid: Blacklist eBeam devices

2012-10-10 Thread Dmitry Torokhov
Jiri, Are you OK with this change? Yann, Is the device usable at all with generic HID driver? If it isn't then maybe we should blacklist it unconditionally? Thanks. On Sat, Oct 06, 2012 at 03:14:46PM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin > --- > drivers/hid/hid-core.c |

Re: [PATCH] drivers: phy: add generic PHY framework

2012-09-26 Thread Dmitry Torokhov
On Wednesday, September 26, 2012 09:57:57 AM Joe Perches wrote: > On Wed, 2012-09-26 at 20:31 +0530, Kishon Vijay Abraham I wrote: > > The PHY framework provides a set of API's for the PHY drivers to > > create/destroy a PHY and API's > > Just some trivial notes. > > > diff --git a/drivers/phy/ph

Re: [PATCH resend2] Input: usbtouchscreen - initialize eGalax devices

2012-09-10 Thread Dmitry Torokhov
On Friday, September 07, 2012 04:42:32 PM Forest Bond wrote: > Hi Dmitry, > > On Tue, Sep 04, 2012 at 11:07:04PM -0700, Dmitry Torokhov wrote: > > On Mon, Sep 03, 2012 at 01:33:50PM -0400, Forest Bond wrote: > > > From: Forest Bond > > > > > > Certa

Re: [PATCH resend2] Input: usbtouchscreen - initialize eGalax devices

2012-09-04 Thread Dmitry Torokhov
On Mon, Sep 03, 2012 at 01:33:50PM -0400, Forest Bond wrote: > From: Forest Bond > > Certain eGalax devices expose an interface with class HID and protocol > None. Some work with usbhid and some work with usbtouchscreen, but > there is no easy way to differentiate. Sending an eGalax diagnostic

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 06:53:53PM -0400, Forest Bond wrote: > Hi, > > On Fri, Aug 31, 2012 at 04:04:58PM -0400, Alan Stern wrote: > > On Fri, 31 Aug 2012, Dmitry Torokhov wrote: > > > > > > > + /* Send a "check active"

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 10:50:38PM +0400, Sergei Shtylyov wrote: > Hello. > > On 08/31/2012 05:56 PM, Forest Bond wrote: > > > From: Forest Bond > > > Certain eGalax devices expose an interface with class HID and protocol > > None. Some work with usbhid and some work with usbtouchscreen, but >

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 09:56:58AM -0400, Forest Bond wrote: > From: Forest Bond > > Certain eGalax devices expose an interface with class HID and protocol > None. Some work with usbhid and some work with usbtouchscreen, but > there is no easy way to differentiate. Sending an eGalax diagnostic

Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device

2012-08-06 Thread Dmitry Torokhov
On Tue, Aug 07, 2012 at 03:21:45AM +0200, Yann Cantin wrote: > Le 07/08/2012 00:07, Dmitry Torokhov a écrit : > > On Monday, August 06, 2012 02:43:40 PM Greg KH wrote: > >> On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote: > >>> Signed-off-by: Yann Cantin

Re: [RFC ebeam PATCH v3 2/2] input: misc: New USB eBeam input driver.

2012-08-06 Thread Dmitry Torokhov
On Tue, Aug 07, 2012 at 02:56:40AM +0200, Yann Cantin wrote: > Hi, > > Le 06/08/2012 23:43, Greg KH a écrit : > > On Mon, Aug 06, 2012 at 11:21:44PM +0200, Yann Cantin wrote: > >> > >> Signed-off-by: Yann Cantin > >> --- > >> drivers/input/misc/ebeam.c | 764 > >> ++

Re: [RFC ebeam PATCH v3 0/2]

2012-08-06 Thread Dmitry Torokhov
On Monday, August 06, 2012 02:44:23 PM Greg KH wrote: > On Mon, Aug 06, 2012 at 11:21:42PM +0200, Yann Cantin wrote: > > Hi, > > > > New USB input driver for eBeam devices. > > > > Currently, only the Luidia eBeam classic projection model is supported. > > Edge model and a NEC interactive video-p

Re: [RFC ebeam PATCH v3 1/2] hid: Blacklist new eBeam classic device

2012-08-06 Thread Dmitry Torokhov
On Monday, August 06, 2012 02:43:40 PM Greg KH wrote: > On Mon, Aug 06, 2012 at 11:21:43PM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin > > --- > > > > drivers/hid/hid-core.c |3 +++ > > drivers/hid/hid-ids.h |3 +++ > > 2 files changed, 6 insertions(+) > > > > diff --git a

Re: [RFC ebeam PATCH 3/3] input: misc: New USB eBeam input driver.

2012-07-29 Thread Dmitry Torokhov
On Sat, Jul 28, 2012 at 11:02:13AM +0200, Yann Cantin wrote: > Hi Dmitry, > > >> +config INPUT_EBEAM_USB_CLASSIC > >> + bool "eBeam Classic Projection support" > >> + depends on INPUT_EBEAM_USB > >> + default y > > > > Will there be support for other eBean devices (are there any)? If there > >

Re: [RFC ebeam PATCH 3/3] input: misc: New USB eBeam input driver.

2012-07-27 Thread Dmitry Torokhov
Hi Yann, On Sat, Jul 28, 2012 at 02:02:34AM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin > --- > drivers/input/misc/Kconfig | 21 + > drivers/input/misc/Makefile |1 + > drivers/input/misc/ebeam.c | 895 > +++ > 3 files changed, 917

Re: [PATCH v4 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad

2012-07-11 Thread Dmitry Torokhov
On Wed, Jul 11, 2012 at 02:02:19PM +0700, Yuri Khan wrote: > * Add this device to usbhid ignore list > > Signed-off-by: Yuri Khan > Acked-by: Jiri Kosina Applied, thank you Yuri. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majo

Re: [PATCH v3 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad

2012-07-10 Thread Dmitry Torokhov
Hi Yuri, On Wed, Jul 11, 2012 at 12:33:22AM +0700, Yuri Khan wrote: > * Add this device to usbhid ignore list Please do not forget your "Signed-off-by: " so that I can apply the patch. Thanks. > --- > drivers/hid/hid-core.c|1 + > drivers/hid/hid-ids.h |3 +++ > drivers

Re: [PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad

2012-07-06 Thread Dmitry Torokhov
gt; following patch, the device works as expected. Dmitry Torokhov, the > > current maintainer of input drivers, suggested that I include a change > > to add the usbhid quirk in my patch. > > Of course the good idea only ever comes after the fact. If I change > usbhid to ignore