Re: From: Konstantin Filatov

2013-06-24 Thread Denis V. Lunev
On 6/24/13 6:35 PM, Felipe Balbi wrote: Hi, On Mon, Jun 24, 2013 at 06:31:07PM +0400, Denis V. Lunev wrote: with a length that isn't multiply by max pkt size for this endpoint. The commit 689d6eac (USB: UHCI: add native scatter-gather support(v1)) introduced an implementation of sc

[v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Denis V. Lunev
D in sg element. Signed-off-by: Konstantin Filatov Signed-off-by: Denis V. Lunev Acked-by: Alan Stern CC: Ming Lei CC: Sebastian Andrzej Siewior CC: linux-usb@vger.kernel.org --- Changes from v3: - fixed subject Changes from v2: - changed subject as suggested by Alan Stern - edited description

From: Konstantin Filatov

2013-06-24 Thread Denis V. Lunev
-by: Konstantin Filatov Signed-off-by: Denis V. Lunev Acked-by: Alan Stern CC: Ming Lei CC: Sebastian Andrzej Siewior CC: linux-usb@vger.kernel.org --- Changes from v2: - changed subject as suggested by Alan Stern - edited description - shortened the referenced commit descriptions Changes from v1

Re: [v2] usb: UHCI: fix pkt size in TD for a non-aligned sg element

2013-06-21 Thread Denis V. Lunev
On 6/21/13 7:19 PM, Alan Stern wrote: On Fri, 21 Jun 2013, Konstantin Filatov wrote: Your patch skips a chunk of data to transfer. This is a corruption of data. It's unacceptable. We can return an error code if we treat the request as malformed, but we can't transfer data selectively. I agree

usb: UHCI: fix pkt size in TD for a non-aligned sg element

2013-06-21 Thread Denis V. Lunev
t only for the last TD in sg list, but also for the last TD in sg element. Signed-off-by: Konstantin Filatov Signed-off-by: Denis V. Lunev CC: Alan Stern CC: linux-usb@vger.kernel.org --- drivers/usb/host/uhci-q.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/uhci-q.c