[PATCH v2] USB: misc: uss720: more vendor/product ID's

2018-03-20 Thread Daniel Gimpelevich
m Design ISD-101 label on one side, sold as an early Belkin F5U002 (05ab:0002). Signed-off-by: Daniel Gimpelevich --- drivers/usb/misc/uss720.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 263c97f..de9a502 1006

Re: [PATCH] USB: misc: uss720: more vendor/product ID's

2018-03-20 Thread Daniel Gimpelevich
On Tue, 2018-03-20 at 10:21 +0100, Greg KH wrote: > On Tue, Mar 20, 2018 at 02:13:48AM -0700, Daniel Gimpelevich wrote: > > On Tue, 2018-03-20 at 10:08 +0100, Greg KH wrote: > > > Put the device "type" or "name" as a comment, that makes more sense > &g

Re: [PATCH] USB: misc: uss720: more vendor/product ID's

2018-03-20 Thread Daniel Gimpelevich
On Tue, 2018-03-20 at 10:08 +0100, Greg KH wrote: > Put the device "type" or "name" as a comment, that makes more sense > and > follows what almost all other drivers do. I strongly considered this, but I ultimately decided against it in consideration of the limited space for comments on the right,

Re: [PATCH] USB: misc: uss720: more vendor/product ID's

2018-03-20 Thread Daniel Gimpelevich
On Tue, 2018-03-20 at 09:36 +0100, Greg KH wrote: > Who is "Rab" and why do you need to name who added what id to the > patch? > I copied that part from the web page I referenced in the commit message. It's evidently a reference to the page's author. I tried to send an e-mail to the address at the

[PATCH] USB: misc: uss720: more vendor/product ID's

2018-03-14 Thread Daniel Gimpelevich
m Design ISD-101 label on one side, sold as an early Belkin F5U002 (05ab:0002). Signed-off-by: Daniel Gimpelevich --- drivers/usb/misc/uss720.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 263c97f..a208e4b 1006

Re: [PATCH] Fix stack corruption on some architectures

2013-08-21 Thread Daniel Gimpelevich
On Tue, 2013-08-20 at 23:29 -0700, David Miller wrote: > Please submit this with a more appropriate subject line. > > After '[PATCH] ' there should be a subsystem or driver name > prefix, followed up a semicolon. Here it could be "hso: ", > so something like: > > [PATCH] hso: Fix stack corrupti

[PATCH 2/2] hso: Fix stack corruption on some architectures

2013-08-21 Thread Daniel Gimpelevich
hers) Signed-off-by: Daniel Gimpelevich --- drivers/net/usb/hso.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 5fb36ed..86292e6 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -2816,13 +2816,16

[PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread Daniel Gimpelevich
There is no need to get an interface specification if we know it's the wrong one. Signed-off-by: Daniel Gimpelevich --- drivers/net/usb/hso.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index cba1d46..5f

Re: [PATCH] Fix stack corruption on some architectures

2013-08-19 Thread Daniel Gimpelevich
On Tue, 2013-08-20 at 02:31 +0400, Sergei Shtylyov wrote: > Hello. > > On 08/20/2013 12:37 AM, Daniel Gimpelevich wrote: > > > There is no need to get an interface specification if we know it's the > > wrong one; trivial change. > > Is it related to stack

[PATCH] Fix stack corruption on some architectures

2013-08-19 Thread Daniel Gimpelevich
k is prohibited [Mon 2013-08-19 12:35:58 PM PDT] and EHCI uses DMA on control xfers (as well as all the others) Signed-off-by: Daniel Gimpelevich --- drivers/net/usb/hso.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/ne