Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-10 Thread Dan Murphy
On 10/10/2013 07:39 AM, Ming Lei wrote: > On Thu, Oct 10, 2013 at 8:08 PM, Dan Murphy wrote: >> You are correct I don't expect a match for PnP devices only devices that are >> hard wired. >> >> After thinking of it I should move the OF code below the EEPROM co

Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-10 Thread Dan Murphy
Ming On 10/07/2013 06:42 AM, Ming Lei wrote: > On Mon, Oct 7, 2013 at 1:31 AM, Dan Murphy wrote: >> On 10/06/2013 10:05 AM, Ming Lei wrote: >>> On Sat, Oct 5, 2013 at 2:25 AM, Dan Murphy wrote: >>>> If the smsc95xx does not have a valid MAC address stored within

Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-07 Thread Dan Murphy
On 10/07/2013 06:42 AM, Ming Lei wrote: > On Mon, Oct 7, 2013 at 1:31 AM, Dan Murphy wrote: >> On 10/06/2013 10:05 AM, Ming Lei wrote: >>> On Sat, Oct 5, 2013 at 2:25 AM, Dan Murphy wrote: >>>> If the smsc95xx does not have a valid MAC address stored within >&g

Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-06 Thread Dan Murphy
On 10/06/2013 10:05 AM, Ming Lei wrote: > On Sat, Oct 5, 2013 at 2:25 AM, Dan Murphy wrote: >> If the smsc95xx does not have a valid MAC address stored within >> the eeprom then a random number is generated. The MAC can also >> be set by uBoot but the smsc95xx does not ha

[PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-04 Thread Dan Murphy
from the modified DTB file. Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/net/smsc95xx.txt | 17 ++ drivers/net/usb/smsc95xx.c | 24 2 files changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-30 Thread Dan Murphy
Fix spelling in my own comments On 05/30/2013 03:31 PM, Dan Murphy wrote: > On 05/30/2013 03:14 PM, Ruchika Kharwar wrote: >> This patch adds an optional parameter "dr_mode" to the dwc3 core device node. >> In the case the compile flag for the DWC3 controller is set to

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-05-30 Thread Dan Murphy
_mode, "drd") == 0) > + mode = DWC3_MODE_DRD; > + else { > + dev_err(dev, "invalid dr_mode property > value\n"); > + goto err0; This should be err1 since core init is called prior to this >