On Thu, Oct 19, 2017 at 5:05 PM, Laurent Pinchart
wrote:
> Hi Christoph,
>
> On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote:
>> > Now we have 9 const instances of the config_item_type structure that are
>> > identical, with only the .ct_owner field set. Should they be all merge
to the argument of the function config_group_init_type_name
which is now const.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patches and the constification
patches into a series.
fs/configfs/dir.c| 10 +-
fs/configfs/item.c | 6 +++---
fs
Make these structures const as they are only passed to the const
argument of the functions config_{group/item}_init_type_name.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patches and the constification
patches into a series.
drivers/usb/gadget/function/f_acm.c
are
stored in the const "ci_type" field of a config_item structure.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patches and the constification
patches into a series.
drivers/iio/dummy/iio_simple_dummy.c | 2 +-
drivers/iio/industrialio-configfs.c| 2 +
Make these structures const as they are either passed to the functions
having the argument as const or stored as a reference in the "ci_type"
const field of a config_item structure.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
Make config_item_type structures const as they are either passed to a
function having the argument as const or stored in the const "ci_type"
field of a config_item structure.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
Make config_item_type structures const as they are either passed to a
function having the argument as const or used inside an if statement or
stored in the const "ci_type" field of a config_item structure.
Done using Coccinelle
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combi
Make config_item_type structures const as they are either passed to a
function having the argument as const or stored in the const "ci_type"
field of a config_item structure.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
Make these structures const as they are either passed to the functions
having the argument as const or stored as a reference in the "ci_type"
const field of a config_item structure.
Done using Coccienlle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
Make these structures const as they are either passed to the functions
having the argument as const or stored as a reference in the "ci_type"
const field of a config_item structure.
Done using Coccienlle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
Make these structures const as they are either passed to the functions
having the argument as const or stored as a reference in the "ci_type"
const field of a config_item structure.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patches and the constificati
Make config_item_type structures const as they are either passed to a
function having the argument as const or used inside a if statement or
stored in the const "ci_type" field of a config_item structure.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combi
Make config_item_type structures const as they are either passed to a
function having the argument as const or stored in the const "ci_type"
field of a config_item structure.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
Make config_item_type structures const as they are either passed to a
function having the argument as const or stored in the const "ci_type"
field of a config_item structure.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
Make these structures const as they are either passed to the functions
having the argument as const or stored as a reference in the "ci_type"
const field of a config_item structure.
Done using Coccienlle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
Make the ci_type field and some function arguments as const. After this
change, make config_item_type structures as const.
* Changes in v2- Combine all the followup patches and the constification
patches into a series.
Bhumika Goyal (15):
configfs: make ci_type field, some pointers and
Make these structures const as they are either passed to the functions
having the argument as const or stored as a reference in the "ci_type"
const field of a config_item structure.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
* Changes in v2- Combine all the followup patch
On Thu, Oct 12, 2017 at 3:03 PM, Bhumika Goyal wrote:
> This is a followup patch for:
> https://patchwork.kernel.org/patch/649/ and
> https://lkml.org/lkml/2017/10/11/375
>
> Make config_item_type structures const as they are either passed to a
> function having the ar
sition ref.p;
identifier rule1.x;
@@
x@p
@depends on forall !bad disable optional_qualifier@
identifier rule1.x;
@@
static
+ const
struct config_item_type x={...};
Signed-off-by: Bhumika Goyal
---
drivers/usb/gadget/function/f_acm.c | 2 +-
drivers/usb/gadget/function/f_ecm.c | 2 +-
Make this const as it is only stored in the const field of a structure
video_device in the file referencing it. Make the declaration const too.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/usb/gadget/function/uvc_v4l2.c | 2 +-
drivers/usb/gadget/function/uvc_v4l2.h | 2
Make this const as it is not modified anywhere.
Signed-off-by: Bhumika Goyal
---
drivers/usb/host/imx21-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/imx21-hcd.c b/drivers/usb/host/imx21-hcd.c
index e25d72e..39ae7fb 100644
--- a/drivers/usb/host
Make this const as it is not modified anywhere.
Signed-off-by: Bhumika Goyal
---
drivers/usb/usbip/vhci_hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index c747623..11b9a22 100644
--- a/drivers/usb/usbip
Make this structure const as it is not modified. And replace __initdata
with __initconst to avoid section conflict error.
Signed-off-by: Bhumika Goyal
---
drivers/usb/host/ehci-fsl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb
Make these const as they are only used during a copy operation.
Signed-off-by: Bhumika Goyal
---
Changes in v2:
* Combine the patch series sent for drivers/media/usb/ into a
single patch.
drivers/media/usb/airspy/airspy.c| 2 +-
drivers/media/usb/cpia2/cpia2_v4l.c | 2 +-
drivers
Make video_device const.
Bhumika Goyal (11):
[media] zr364xx: make video_device const
[media] stkwebcam: make video_device const
[media] stk1160: make video_device const
[media] s2255drv: make video_device const
[media] pwc: make video_device const
[media] pvrusb2: make video_device
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/zr364xx/zr364xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/zr364xx/zr364xx.c
b/drivers/media/usb/zr364xx/zr364xx.c
index d4bb56b..4ff8d0a
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/stk1160/stk1160-v4l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/stk1160/stk1160-v4l.c
b/drivers/media/usb/stk1160/stk1160-v4l.c
index a132faa
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/s2255/s2255drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255/s2255drv.c
index 23f606e..b2f239c 100644
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/stkwebcam/stk-webcam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c
b/drivers/media/usb/stkwebcam/stk-webcam.c
index
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/msi2500/msi2500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/msi2500/msi2500.c
b/drivers/media/usb/msi2500/msi2500.c
index 79bfd2d..a097d3d
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/pwc/pwc-if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
index 22420c1..eb6921d 100644
--- a/drivers
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/hackrf/hackrf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/hackrf/hackrf.c
b/drivers/media/usb/hackrf/hackrf.c
index a41b305..7eb5351 100644
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/go7007/go7007-v4l2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/go7007/go7007-v4l2.c
b/drivers/media/usb/go7007/go7007-v4l2.c
index 445f17b
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/airspy/airspy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/airspy/airspy.c
b/drivers/media/usb/airspy/airspy.c
index 07f3f4e..e70c9e2 100644
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/cpia2/cpia2_v4l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/cpia2/cpia2_v4l.c
b/drivers/media/usb/cpia2/cpia2_v4l.c
index 7122023..3dedd83
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
index
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/scsi/fcoe/fcoe_sysfs.c | 4 ++--
drivers/scsi/scsi_transport_iscsi.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/usb/common/ulpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/staging/greybus/gbphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/gbphy.c b/drivers
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/remoteproc/remoteproc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/platform/x86/wmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/wmi.c b/drivers
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/s390/crypto/ap_card.c | 2 +-
drivers/s390/crypto/ap_queue.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/phy/tegra/xusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/mux/mux-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c
index
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/pci/endpoint/pci-epf-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/endpoint/pci-epf-core.c
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/mtd/mtdcore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/media/rc/rc-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/misc/mei/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/media/i2c/soc_camera/mt9t031.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/soc_camera/mt9t031.c
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
---
drivers/gpu/drm/drm_sysfs.c | 2 +-
drivers/gpu/drm/ttm/ttm_module.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_sysfs.c
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/edac/edac_mc_sysfs.c | 8
drivers/edac/i7core_edac.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff
Make device_type const. Done using Coccinelle.
Bhumika Goyal (15):
EDAC: make device_type const
drm: make device_type const
[media] i2c: make device_type const
[media] rc: make device_type const
mei: make device_type const
mtd: make device_type const
mux: make device_type const
Make this const as it is only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
b
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/media/tuners/tda18271-maps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/tuners/tda18271-maps.c
b/drivers/media/tuners
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio
Make this const as it is only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/usb/gadget/function/u_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/u_audio.c
b/drivers/usb/gadget/function
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/media/pci/cobalt/cobalt-alsa-pcm.c | 4 ++--
drivers/media/pci/cx18/cx18-alsa-pcm.c | 2 +-
drivers/media/pci/cx23885/cx23885-alsa.c | 2 +-
drivers/media/pci
Make snd_pcm_hardware structures const.
Bhumika Goyal (6):
[media] usb: make snd_pcm_hardware const
[media] pci: make snd_pcm_hardware const
drm: bridge: dw-hdmi: make snd_pcm_hardware const
usb: gadget: make snd_pcm_hardware const
staging: bcm2835-audio: make snd_pcm_hardware const
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/media/usb/cx231xx/cx231xx-audio.c | 2 +-
drivers/media/usb/em28xx/em28xx-audio.c | 2 +-
drivers/media/usb/go7007/snd-go7007.c | 2 +-
drivers/media/usb/tm6000
Make the structure const as it is only stored in the ops field of a
usb_ep structure, which is of type const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc
Make the structure const as it is only stored in the ops field of a
usb_ep structure, which is of type const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers
Make the structure const as it is only stored in the ops field of a
usb_ep structure, which is of type const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/usb/renesas_usbhs/mod_gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
Constify usb_ep_ops structures.
Bhumika Goyal (3):
usb: renesas_usbhs: gadget: make usb_ep_ops const
usb: gadget: udc: renesas_usb3: make usb_ep_ops const
usb: dwc2: gadget: make usb_ep_ops const
drivers/usb/dwc2/gadget.c | 2 +-
drivers/usb/gadget/udc/renesas_usb3.c | 2
Make these const as they are only passed to the function
atm_dev_register and the corresponding argument is of type const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/usb/atm/usbatm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/atm
9604 381 29 200144e2e drivers/mmc/host/vub300.o
5487 376 0586316e7 drivers/mmc/host/wmt-sdmmc.o
5639 220 0585916e3 drivers/mmc/host/wmt-sdmmc.o
Signed-off-by: Bhumika Goyal
---
drivers/mmc/host/moxart-mmc.c | 2 +-
drivers/mmc/host/mtk-
hex filename
3668 864 0453211b4 drivers/usb/musb/ux500.o
File size after:
textdata bss dec hex filename
3724 808 0453211b4 drivers/usb/musb/ux500.o
Signed-off-by: Bhumika Goyal
---
drivers/usb/musb/jz4740.c | 2 +-
drivers/usb/
dc.o
18740 192 16 189484a04 usb/gadget/udc/r8a66597-udc.o
Files: drivers/usb/gadget/udc/{s3c-hsudc.o/omap_udc.o/fsl_qe_udc.o} did
not complie.
Signed-off-by: Bhumika Goyal
---
drivers/usb/gadget/udc/fotg210-udc.c | 2 +-
drivers/usb/gadget/udc/fsl_qe_udc.c | 2 +-
drivers/us
Signed-off-by: Bhumika Goyal
---
drivers/usb/musb/omap2430.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 8b73214..456f3e6 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -575,7
size before:
textdata bss dec hex filename
3183 372 03555 de3 drivers/usb/host/ehci-fsl.o
File size after:
textdata bss dec hex filename
3275 280 03555 de3 drivers/usb/host/ehci-fsl.o
Signed-off-by: Bhumika Goyal
size before:
textdata bss dec hex filename
7559 384 879511f0f usb/gadget/udc/fotg210-udc.o
File size after:
textdata bss dec hex filename
7655 288 879511f0f usb/gadget/udc/fotg210-udc.o
Signed-off-by: Bhumika G
usb/isp1760/isp1760-udc.o
Signed-off-by: Bhumika Goyal
---
drivers/usb/isp1760/isp1760-udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/isp1760/isp1760-udc.c
b/drivers/usb/isp1760/isp1760-udc.c
index 1c3d0fd..69400f3 100644
--- a/drivers/usb/isp1760/isp1760-u
71 matches
Mail list logo