Re: [PATCH] Remove VLAIS usage from gadget code - alternate patch

2013-09-24 Thread Behan Webster
o the kmalloc-ed memory buffer using macros. The previous patch required multiple kmalloc and kfree calls. Signed-off-by: Mark Charlebois Signed-off-by: Behan Webster This one uses macros and carves up a single piece of memory from one kmalloc. Behan -- Behan Webster beh...@converseincode.com

Re: [PATCH] usb: LLVMLinux: Remove VLAIS from USB gadget

2013-09-23 Thread Behan Webster
adget driver. This version has been tested to compile cleanly. Signed-off-by: Mark Charlebois Signed-off-by: Behan Webster This is the fixed patch which was sent to Andrzej Pietrasiewicz. Behan -- Behan Webster beh...@converseincode.com -- To unsubscribe from this list: send the line "u

Re: [PATCH] USB: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Behan Webster
On 09/23/13 16:24, Felipe Balbi wrote: Hi, On Thu, Aug 01, 2013 at 09:35:44PM -0400, beh...@converseincode.com wrote: From: Behan Webster The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instanc

Re: [PATCH] usb: gadget LLVMLinux: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Behan Webster
an certainly do that instead. I believe I already have a version of the patch which does just that (without using macros). I will post it for comment. Thanks, Behan -- Behan Webster beh...@converseincode.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in t

Re: [PATCH] usb: gadget LLVMLinux: Removing the use of VLAIS from the gadget driver

2013-09-23 Thread Behan Webster
On 09/23/13 14:30, Felipe Balbi wrote: Hi, On Thu, Sep 05, 2013 at 08:07:11PM -0400, Behan Webster wrote: Replying to my patch email just in case it was missed before. I remember there was a discussion of not dropping variable length array support, wasn't there ? There was mostly an obje

Re: [PATCH] usb: gadget LLVMLinux: Removing the use of VLAIS from the gadget driver

2013-09-05 Thread Behan Webster
Replying to my patch email just in case it was missed before. Thanks, Behan On 08/01/13 21:35, beh...@converseincode.com wrote: From: Behan Webster The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-04 Thread Behan Webster
On 12-12-04 11:24 PM, Sebastian Andrzej Siewior wrote: On Mon, Dec 03, 2012 at 07:57:33PM +0100, Behan Webster wrote: However, in order to approximate what gcc is doing in code, obviously some math is required. The thought was that macros would hide the worst of it, trying not to obfuscate what

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-03 Thread Behan Webster
trying to get the toolchain from one working with the code from the other. The LLVMLinux project isn't trying to replace, nor break gcc (in fact all the project's kernel patches are tested with gcc as well). The idea is to bring another toolchain and set of tools to the table and th

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Behan Webster
On 12-10-31 09:28 AM, Felipe Balbi wrote: hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This

[PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-30 Thread Behan Webster
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch instead calculates offsets into the kmalloc-ed memory buffer using macros from valign.h. Signed-off-by:

[PATCH V2 3/3] Remove VLAIS usage from netfilter

2012-10-30 Thread Behan Webster
ign.h. Patch from series at http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142707.html by PaX Team. Signed-off-by: Jan-Simon Möller Cc: pagee...@freemail.hu [Modified to use macros from valign.h] Signed-off-by: Behan Webster --- net/netfilter/xt_repldata.h |

[PATCH V2 1/3] Helper macros used for replacing the use of VLAIS

2012-10-30 Thread Behan Webster
er of memory taking into account alignment issues. Signed-off-by: Behan Webster --- include/linux/valign.h | 87 1 file changed, 87 insertions(+) create mode 100644 include/linux/valign.h diff --git a/include/linux/valign.h b/include/linux/val

[PATCH V2 0/3] Removing the use of VLAIS from USB Gadget and netfilter

2012-10-30 Thread Behan Webster
ce of using the Clang compiler toolchain. This is a part of a series of patches which remove the use of VLAIS from crypto code, dm-crypt, jbd2, libcrc32c, netfilter, and usb gadget. Other patches to allow Clang to be used to compile the Linux kernel will follow. Behan Webster (2): Helper macros use

Re: [PATCH 1/2] Helper macros used for replacing the use of VLAIS

2012-10-30 Thread Behan Webster
On 12-10-30 03:20 PM, Greg KH wrote: On Tue, Oct 30, 2012 at 02:25:19PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This new header

[PATCH 1/2] Helper macros used for replacing the use of VLAIS

2012-10-30 Thread Behan Webster
er of memory taking into account alignment issues. Signed-off-by: Behan Webster --- include/linux/valign.h | 87 1 file changed, 87 insertions(+) create mode 100644 include/linux/valign.h diff --git a/include/linux/valign.h b/include/linux/val

[PATCH 2/2] Remove VLAIS usage from gadget code

2012-10-30 Thread Behan Webster
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch instead calculates offsets into the kmalloc-ed memory buffer using macros from valign.h. Signed-off-by:

[PATCH 0/2] Removing the use of VLAIS from the Linux Kernel

2012-10-30 Thread Behan Webster
Clang compiler toolchain. This is a part of a series of patches which remove the use of VLAIS from crypto code, dm-crypt, jbd2, libcrc32c, netfilter, and usb gadget. Other patches to allow Clang to be used will follow. Behan Webster (2): Helper macros used for replacing the use of VLAIS Remove