2015-02-08 12:15 GMT+01:00 Sergei Shtylyov :
> Hello.
>
> On 2/8/2015 12:55 AM, Bas Peters wrote:
>
>> This patch removes assignment of variables in if conditions,
>> as specified in CodingStyle.
>
>
>> Signed-off-by: Bas Peters
>> ---
>> drivers
2015-02-09 3:15 GMT+01:00 Peter Chen :
> On Sat, Feb 07, 2015 at 10:55:01PM +0100, Bas Peters wrote:
>> This patch removes assignment of variables in if conditions in
>> accordance witht the CodingStyle.
>
> %s/witht/with
Typo, my bad. Should I fix the commit message and re
This patchset adresses checkpatch errors in a few of the files in usb
storage. More to follow.
Bas Peters (3):
drivers: usb: storage: alauda.c: properly place braces after function
declarations
drivers: usb: storage: cypress_atacb.c: trivial checkpatch fixes
drivers: usb: storage
Fixes errors thrown by checkpatch over a space issue and the
incorrect indentation of a switch statement.
Signed-off-by: Bas Peters
---
drivers/usb/storage/cypress_atacb.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/storage/cypress_atacb.c
This patch places braces on a new line following function declarations.
Signed-off-by: Bas Peters
---
drivers/usb/storage/alauda.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
index 62c2d9d
This patch cleans up a variety of checkpatch errors:
Bunch of space issues.
C99 comments converted to /* */ format.
Some switch statement indentations.
"foo * bar" -> "foo *bar"
Signed-off-by: Bas Peters
---
drivers/usb/
This patchset adresses many checkpatch errors found in the act2000 driver.
Bas Peters (7):
drivers: isdn: act2000: act2000_isa.c: Fix checkpatch errors
drivers: isdn: act2000: capi.c: fix checkpatch errors
drivers: isdn: act2000: remove assignments of variables in if
conditions
This patch removes all assignments of if conditions, which is not in
accordance with the CodingStyle.
---
drivers/isdn/act2000/module.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/isdn/act2000/module.c b/drivers/isdn/act2000/module.c
This patchset adresses various checkpatch errors found when running the
checkpatch script on the directory.
Bas Peters (6):
drivers: usb: core: devio.c: remove assignment of variables in if
conditions.
drivers: usb: core: devio.c: fix whitespace errors thrown by
checkpatch.pl
This patch fixes the following checkpatch errors:
1. trailing statement
1. assignment of variable in if condition
1. incorrectly placed brace after function definition
Signed-off-by: Bas Peters
---
drivers/isdn/act2000/capi.c | 9 ++---
1 file changed, 6 insertions
GCC takes care of this for us, thus it is not needed and theoretically
only hoggs memory, allbeit only a bit.
---
drivers/isdn/act2000/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/act2000/module.c b/drivers/isdn/act2000/module.c
index 352916a..9359b36 1
This patch adds the \ that was accidentally deleted in patch 2. It also adds a
brace after the else statement, which is required due to the fact that the if
statement has braces.
---
drivers/isdn/act2000/capi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/isdn/a
This patch adresses various checkpatch errors:
3 assignments in if conditions
1 return value enclosed in parenthesis
Signed-off-by: Bas Peters
---
drivers/isdn/act2000/act2000_isa.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/isdn
return is not a function, therefore parentheses are not needed.
---
drivers/isdn/act2000/module.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/isdn/act2000/module.c b/drivers/isdn/act2000/module.c
index 9359b36..889ffcb 100644
--- a/drivers/isdn/act2000/
Please discard all these e-mails, something went wrong and I sent the
wrong directory of patches.
2015-02-07 22:54 GMT+01:00 Bas Peters :
> Signed-off-by: Bas Peters
> ---
> drivers/isdn/isdnloop/isdnloop.c | 18 ++
> 1 file changed, 10 insertions(+), 8 deletions
NULL initialization of static variables is unnecessary as GCC kindly does
this for us.
Signed-off-by: Bas Peters
---
drivers/usb/core/hub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index aeb50bb..82983d9 100644
--- a
This patch removes assignment of variables in if conditions,
as specified in CodingStyle.
Signed-off-by: Bas Peters
---
drivers/usb/core/hcd.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 11cee55
Changes space-based indentation to tab-based indentation.
Signed-off-by: Bas Peters
---
drivers/usb/core/endpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/endpoint.c b/drivers/usb/core/endpoint.c
index 39a2402..101983b 100644
--- a/drivers/usb/core
This patch fixes errors generated by checkpatch.pl relating to
whitespace issues.
Signed-off-by: Bas Peters
---
drivers/usb/core/devio.c | 61
1 file changed, 31 insertions(+), 30 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb
As specified in the CodingStyle.
Signed-off-by: Bas Peters
---
drivers/usb/core/hub.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 82983d9..9afe8b0 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core
This patch removes assignment of variables in if conditions in
accordance witht the CodingStyle.
Signed-off-by: Bas Peters
---
drivers/usb/core/devio.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index
This patch cleans up various trivial checkpatch errors such as variable
declarations in if statements, return values in parenthesis and a
wrongly placed brace.
Signed-off-by: Bas Peters
---
drivers/isdn/icn/icn.c | 52 ++
1 file changed, 31
Please discard this
2015-02-07 22:53 GMT+01:00 Bas Peters :
> This patchset adresses many checkpatch errors found in the act2000 driver.
>
> Bas Peters (7):
> drivers: isdn: act2000: act2000_isa.c: Fix checkpatch errors
> drivers: isdn: act2000: capi.c: fix checkpatch errors
&g
Trivial, but why not? :)
Signed-off-by: Bas Peters
---
drivers/isdn/act2000/module.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/isdn/act2000/module.c b/drivers/isdn/act2000/module.c
index 889ffcb..9ba98ce 100644
--- a/drivers/isdn/act2000/module.c
+++ b
This patch cleans up all checkpatch errors in the icn directory.
Bas Peters (2):
drivers: isdn: icn: icn.c: clean up all checkpatch errors
drivers: isdn: icn: icn.h Clean up trivial checkpatch errors.
drivers/isdn/icn/icn.c | 52 ++
drivers
Please discard this
2015-02-07 22:53 GMT+01:00 Bas Peters :
> This patch adresses various checkpatch errors:
> 3 assignments in if conditions
> 1 return value enclosed in parenthesis
>
> Signed-off-by: Bas Peters
> ---
> drivers/isdn/act2000/act2000_isa.c
Signed-off-by: Bas Peters
---
drivers/isdn/isdnloop/isdnloop.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/isdn/isdnloop/isdnloop.c b/drivers/isdn/isdnloop/isdnloop.c
index 5a4da94..af96317 100644
--- a/drivers/isdn/isdnloop/isdnloop.c
+++ b
This patchset adresses various checkpatch errors in the abovementioned driver.
Bas Peters (3):
drivers: isdn: isdnloop: isdnloop.c: remove assignment of variables in
if conditions, in accordance with the CodingStyle.
drivers: isdn: isdnloop: isdnloop.c: Fix brace positions according
Signed-off-by: Bas Peters
---
drivers/isdn/icn/icn.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/isdn/icn/icn.h b/drivers/isdn/icn/icn.h
index b713466..05daed2 100644
--- a/drivers/isdn/icn/icn.h
+++ b/drivers/isdn/icn/icn.h
@@ -54,7 +54,7 @@ typedef struct
29 matches
Mail list logo
