Re: [PATCH v5 2/6] usb: gadget: u_serial: reimplement console support

2019-07-22 Thread Baolin Wang
d char *line_num) > { > struct usb_cdc_line_coding coding; > + struct gs_port *port; > struct device *tty_dev; > int ret; > int port_num; > @@ -1231,23

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Baolin Wang
On 5 March 2018 at 19:14, Roger Quadros wrote: > On 05/03/18 13:06, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>>>> Roger Quadros writes: >>>>>>> Roger Quadros writes: >>>>>>>> In the follo

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Baolin Wang
Hi Roger, On 5 March 2018 at 17:45, Roger Quadros wrote: > Felipe, > > On 05/03/18 10:49, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: Roger Quadros writes: > In the following test we get stuck by sleeping forever in _dwc3_set_mode() > after which dual-role switching d

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-02-27 Thread Baolin Wang
Hi Roger, On 27 February 2018 at 19:22, Roger Quadros wrote: > In the following test we get stuck by sleeping forever in _dwc3_set_mode() > after which dual-role switching doesn't work. > > On dra7-evm's dual-role port, > - Load g_zero gadget driver and enumerate to host > - suspend to mem > - di

[PATCH] usb: phy: Factor out the usb charger initialization

2017-12-06 Thread Baolin Wang
charger initialization. Signed-off-by: Baolin Wang --- drivers/usb/phy/phy.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index f97cb47..bceb2c9 100644 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c

Re: [PATCH resend 2/2] usb: phy: mxs: add usb charger type detection

2017-09-04 Thread Baolin Wang
Hi, On 4 September 2017 at 23:14, Li Jun wrote: > mxs phy has data pin contact and usb charger detector blocks which > can be controlled by software to detect charger type for SDP, CDP and > DCP. > > Signed-off-by: Li Jun For USB charger part: Reviewed-by: Baolin Wang -- B

Re: [PATCH resend 1/2] usb: chipidea: do charger detection in vbus session

2017-09-04 Thread Baolin Wang
ady = 1; > spin_unlock_irqrestore(&ci->lock, flags); > > + if (ci->usb_phy) > + usb_phy_set_charger_state(ci->usb_phy, is_active ? > + USB_CHARGER_PRESENT : USB_CHARGER_ABSENT); For USB charger part: Reviewed-by: Baolin

[PATCH] usb: dwc3: of-simple: Add compatible for Spreadtrum SC9860 platform

2017-08-30 Thread Baolin Wang
Add compatible string to use this generic glue layer to support Spreadtrum SC9860 platform's dwc3 controller. Signed-off-by: Baolin Wang --- drivers/usb/dwc3/dwc3-of-simple.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dw

[PATCH] usb: phy: Avoid unchecked dereference warning

2017-08-28 Thread Baolin Wang
Move the USB phy NULL checking before issuing usb_phy_set_charger_current() to avoid unchecked dereference warning. Signed-off-by: Baolin Wang --- include/linux/usb/phy.h |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h

Re: [bug report] usb: phy: Add USB charger support

2017-08-28 Thread Baolin Wang
Hi Felipe, On 28 August 2017 at 15:58, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Hi Dan, >> >> On 25 August 2017 at 20:20, Dan Carpenter wrote: >>> Hello Baolin Wang, >>> >>> This is a semi-automatic email about new stat

Re: [bug report] usb: phy: Add USB charger support

2017-08-27 Thread Baolin Wang
Hi Dan, On 25 August 2017 at 20:20, Dan Carpenter wrote: > Hello Baolin Wang, > > This is a semi-automatic email about new static checker warnings. > > The patch a9081a008f84: "usb: phy: Add USB charger support" from Aug > 15, 2017, leads to the following Smatch comp

Re: [PATCH v4 0/3] Introduce USB charger support in USB phy

2017-08-15 Thread Baolin Wang
Hi Felipe, On 15 August 2017 at 17:53, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>> Currently the Linux kernel does not provide any standard integration of this >>> feature that integrates the USB subsystem with the system power regulation >>>

[PATCH v5 2/3] usb: phy: Add USB charger support

2017-08-15 Thread Baolin Wang
: Baolin Wang --- drivers/usb/phy/phy.c | 272 +++ include/linux/usb/phy.h | 49 + 2 files changed, 321 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 032f5af..2dc48bb 100644 --- a/drivers/usb/phy/phy.c +++ b

[PATCH v5 0/3] Introduce USB charger support in USB phy

2017-08-15 Thread Baolin Wang
ges since v2: - Add DT binding documentation for wm831x_power driver. - Change 'usb-phy' as one optional property for wm831x_power driver. Changes since v1: - Fix building errors. Baolin Wang (3): include: uapi: usb: Introduce USB charger type and state definition usb: phy: A

[PATCH v5 1/3] include: uapi: usb: Introduce USB charger type and state definition

2017-08-15 Thread Baolin Wang
Introducing USB charger type and state definition can help to support USB charging which will be added in USB phy core. Signed-off-by: Baolin Wang --- include/uapi/linux/usb/charger.h | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 include/uapi/linux

[PATCH v5 3/3] power: wm831x_power: Support USB charger current limit management

2017-08-15 Thread Baolin Wang
-by: Mark Brown Signed-off-by: Baolin Wang Acked-by: Lee Jones Acked-by: Charles Keepax Acked-by: Sebastian Reichel --- Documentation/devicetree/bindings/mfd/wm831x.txt |1 + drivers/power/supply/wm831x_power.c | 72 ++ 2 files changed, 73 insertions

Re: [PATCH v4 0/3] Introduce USB charger support in USB phy

2017-08-08 Thread Baolin Wang
Hi Felipe, On 27 July 2017 at 13:14, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their ker

Re: [PATCH v4 3/3] power: wm831x_power: Support USB charger current limit management

2017-08-03 Thread Baolin Wang
On 4 August 2017 at 03:16, Rob Herring wrote: > On Thu, Jul 27, 2017 at 01:14:38PM +0800, Baolin Wang wrote: >> Integrate with the newly added USB charger interface to limit the current >> we draw from the USB input based on the input device configuration >> identified by th

[PATCH v4 1/3] include: uapi: usb: Introduce USB charger type and state definition

2017-07-26 Thread Baolin Wang
Introducing USB charger type and state definition can help to support USB charging which will be added in USB phy core. Signed-off-by: Baolin Wang --- include/uapi/linux/usb/charger.h | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 include/uapi/linux

[PATCH v4 2/3] usb: phy: Add USB charger support

2017-07-26 Thread Baolin Wang
: Baolin Wang --- drivers/usb/phy/phy.c | 272 +++ include/linux/usb/phy.h | 49 + 2 files changed, 321 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 032f5af..2dc48bb 100644 --- a/drivers/usb/phy/phy.c +++ b

[PATCH v4 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-26 Thread Baolin Wang
-by: Mark Brown Signed-off-by: Baolin Wang Acked-by: Lee Jones Acked-by: Charles Keepax --- Documentation/devicetree/bindings/mfd/wm831x.txt |1 + drivers/power/supply/wm831x_power.c | 72 ++ 2 files changed, 73 insertions(+) diff --git a/Documentation

[PATCH v4 0/3] Introduce USB charger support in USB phy

2017-07-26 Thread Baolin Wang
l property for wm831x_power driver. Changes since v1: - Fix building errors. Baolin Wang (3): include: uapi: usb: Introduce USB charger type and state definition usb: phy: Add USB charger support power: wm831x_power: Support USB charger current limit management Documentation/devicetree/bi

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-26 Thread Baolin Wang
Hi, On 26 July 2017 at 20:08, Sebastian Reichel wrote: > Hi, > > On Wed, Jul 26, 2017 at 11:05:25AM +0800, Baolin Wang wrote: >> On 25 July 2017 at 17:59, Sebastian Reichel >> wrote: >> > On Tue, Jul 25, 2017 at 04:00:01PM +0800, Baolin Wang wrote: >> &

Re: [PATCH v3 2/3] usb: phy: Add USB charger support

2017-07-25 Thread Baolin Wang
Hi Manu, On 25 July 2017 at 19:19, Manu Gautam wrote: > Hi, > > > On 7/25/2017 1:30 PM, Baolin Wang wrote: >> This patch introduces the usb charger support based on usb phy that >> makes an enhancement to a power driver. The basic conception of the >> usb charger is

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-25 Thread Baolin Wang
Hi, On 25 July 2017 at 17:59, Sebastian Reichel wrote: > Hi, > > On Tue, Jul 25, 2017 at 04:00:01PM +0800, Baolin Wang wrote: >> Integrate with the newly added USB charger interface to limit the current >> we draw from the USB input based on the input device configuration

[PATCH v3 0/3] Introduce USB charger support in USB phy

2017-07-25 Thread Baolin Wang
/bq24190_charger.c drivers/power/supply/charger-manager.c drivers/power/supply/qcom_smbb.c Changes since v1: - Fix building errors. Changes since v2: - Add DT binding documentation for wm831x_power driver. - Change 'usb-phy' as one optional property for wm831x_power driver. Baol

[PATCH v3 1/3] include: uapi: usb: Introduce USB charger type and state definition

2017-07-25 Thread Baolin Wang
Introducing USB charger type and state definition can help to support USB charging which will be added in USB phy core. Signed-off-by: Baolin Wang --- include/uapi/linux/usb/charger.h | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 include/uapi/linux

[PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-25 Thread Baolin Wang
-by: Mark Brown Signed-off-by: Baolin Wang --- Documentation/devicetree/bindings/mfd/wm831x.txt |1 + drivers/power/supply/wm831x_power.c | 58 ++ 2 files changed, 59 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/wm831x.txt b

[PATCH v3 2/3] usb: phy: Add USB charger support

2017-07-25 Thread Baolin Wang
: Baolin Wang --- drivers/usb/phy/phy.c | 272 +++ include/linux/usb/phy.h | 49 + 2 files changed, 321 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 032f5af..2dc48bb 100644 --- a/drivers/usb/phy/phy.c +++ b

Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume

2017-07-24 Thread Baolin Wang
Hi Manu, On 24 July 2017 at 17:38, Manu Gautam wrote: > Hi, > > > On 7/24/2017 2:45 PM, Baolin Wang wrote: >> Hi Manu, >> >> On 24 July 2017 at 16:42, Manu Gautam wrote: >>> Hi Baolin, >>> >>> >>> On 7/24/2017 11:26 AM, B

Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume

2017-07-24 Thread Baolin Wang
Hi Manu, On 24 July 2017 at 16:42, Manu Gautam wrote: > Hi Baolin, > > > On 7/24/2017 11:26 AM, Baolin Wang wrote: > >>>>> Other than what I pushed in my patch - >>>>> ("usb: dwc3: Don't reinitialize core during host bus-suspend/resume&quo

Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume

2017-07-23 Thread Baolin Wang
Hi, On 21 July 2017 at 17:13, Manu Gautam wrote: > Hi, > > On 7/21/2017 2:31 PM, Baolin Wang wrote: >> On 21 July 2017 at 16:45, Manu Gautam wrote: >>> Hi, >>> >>> >>> On 7/21/2017 12:28 PM, Baolin Wang wrote: >>>> For so

Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume

2017-07-21 Thread Baolin Wang
On 21 July 2017 at 16:45, Manu Gautam wrote: > Hi, > > > On 7/21/2017 12:28 PM, Baolin Wang wrote: >> For some mobile devices with strict power management, we also want to >> suspend the host when the slave was detached for power saving. Thus >> adding the host suspe

Re: [PATCH 1/2] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-07-21 Thread Baolin Wang
Hi Manu, On 21 July 2017 at 10:32, Baolin Wang wrote: > Hi Manu, > > On 20 July 2017 at 19:12, Manu Gautam wrote: >> Hi, >> >> >> On 7/13/2017 1:13 PM, Baolin Wang wrote: >>> Hi, >>> >>> On 13 July 2017 at 15:26, Manu Gautam wrote:

[PATCH] usb: dwc3: Support the dwc3 host suspend/resume

2017-07-21 Thread Baolin Wang
the child device (xHCI device) in runtime resume callback (dwc3_host_resume()) of dwc3 device, now the dwc3 device's runtime state is not RPM_ACTIVE, which will block to resume its child device (xHCI device). Add ignore children flag can avoid this situation. Signed-off-by: Baolin

Re: [PATCH 1/2] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-07-20 Thread Baolin Wang
Hi Manu, On 20 July 2017 at 19:12, Manu Gautam wrote: > Hi, > > > On 7/13/2017 1:13 PM, Baolin Wang wrote: >> Hi, >> >> On 13 July 2017 at 15:26, Manu Gautam wrote: >>> >>> On 7/13/2017 11:33 AM, Baolin Wang wrote: >>>> On 12 July 2

Re: [PATCH v2 0/3] Introduce USB charger support in USB phy

2017-07-18 Thread Baolin Wang
Hi, On 3 July 2017 at 14:07, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their kernels

Re: [PATCH 1/2] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-07-13 Thread Baolin Wang
Hi, On 13 July 2017 at 15:26, Manu Gautam wrote: > > > On 7/13/2017 11:33 AM, Baolin Wang wrote: >> On 12 July 2017 at 16:58, Manu Gautam wrote: >>> >>> On 7/12/2017 2:06 PM, Baolin Wang wrote: >>>> Hi, >>>> >>>> On 12 July

Re: [PATCH 1/2] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-07-12 Thread Baolin Wang
On 12 July 2017 at 16:58, Manu Gautam wrote: > > > On 7/12/2017 2:06 PM, Baolin Wang wrote: >> >> Hi, >> >> On 12 July 2017 at 15:25, Manu Gautam wrote: >>> >>> >>> On 7/12/2017 12:19 PM, Baolin Wang wrote: >>>> >>&g

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

2017-07-12 Thread Baolin Wang
Hi, On 13 July 2017 at 07:20, gustavo panizzo wrote: > Hello Wang > > thanks for your response > > > On Wed, Jul 12, 2017 at 02:08:04PM +0800, Baolin Wang wrote: >> >> Hi, >> >> On 12 July 2017 at 11:52, gustavo panizzo wrote: >>> >>

Re: [PATCH 1/2] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-07-12 Thread Baolin Wang
Hi, On 12 July 2017 at 15:25, Manu Gautam wrote: > > > On 7/12/2017 12:19 PM, Baolin Wang wrote: >> >> Hi, >> >> On 3 July 2017 at 19:25, Manu Gautam wrote: >>> >>> Driver powers-off PHYs and reinitializes DWC3 core and gadget on >>&g

Re: [PATCH 1/2] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-07-11 Thread Baolin Wang
Hi, On 3 July 2017 at 19:25, Manu Gautam wrote: > Driver powers-off PHYs and reinitializes DWC3 core and gadget on > resume. While this works fine for gadget mode but in host > mode there is not re-initialization of host stack. Also, resetting > bus as part of bus_suspend/resume is not correct wh

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

2017-07-11 Thread Baolin Wang
Hi, On 12 July 2017 at 11:52, gustavo panizzo wrote: > The dwc3 could not release resources when the module is built-in > because this module does not have shutdown method. This causes the USB > 3.0 hub is not able to detect after warm boot. > > Original patch by Brian Kim, updated and submitted

Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-04 Thread Baolin Wang
Hi, On 3 July 2017 at 16:53, Charles Keepax wrote: > On Mon, Jul 03, 2017 at 02:07:15PM +0800, Baolin Wang wrote: >> Integrate with the newly added USB charger interface to limit the current >> we draw from the USB input based on the input device configuration >> identi

Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-04 Thread Baolin Wang
Hi, On 3 July 2017 at 23:50, Sebastian Reichel wrote: > Hi, > > On Mon, Jul 03, 2017 at 02:07:15PM +0800, Baolin Wang wrote: >> Integrate with the newly added USB charger interface to limit the current >> we draw from the USB input based on the input device configuration >

[PATCH v2 2/3] usb: phy: Add USB charger support

2017-07-02 Thread Baolin Wang
: Baolin Wang --- drivers/usb/phy/phy.c | 265 +++ include/linux/usb/phy.h | 49 + 2 files changed, 314 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 032f5af..db72802 100644 --- a/drivers/usb/phy/phy.c +++ b

[PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-02 Thread Baolin Wang
-by: Mark Brown Signed-off-by: Baolin Wang --- drivers/power/supply/wm831x_power.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/drivers/power/supply/wm831x_power.c b/drivers/power/supply/wm831x_power.c index 7082301..3e3480708 100644 --- a/drivers

[PATCH v2 1/3] include: uapi: usb: Introduce USB charger type and state definition

2017-07-02 Thread Baolin Wang
Introducing USB charger type and state definition can help to support USB charging which will be added in USB phy core. Signed-off-by: Baolin Wang --- include/uapi/linux/usb/charger.h | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 include/uapi/linux

[PATCH v2 0/3] Introduce USB charger support in USB phy

2017-07-02 Thread Baolin Wang
behave as they should. Thus provide a standard USB charger support in USB phy core for doing this in kernel. Now introduce one user with wm831x_power to support and test the usb charger. Changes since v1: - Fix building errors. Baolin Wang (3): include: uapi: usb: Introduce USB charger type

Re: Crash in gs_write_room() in kernel 4.4, and your gs_start_tx() patch

2017-06-29 Thread Baolin Wang
On 29 June 2017 at 07:01, Stephen Warren wrote: > > > Baolin, > > I have a question about the following commit: > > 511a36d2f357 "usb: gadget: Add the gserial port checking in gs_start_tx()" > >> When usb gadget is set gadget serial function, it will be crash in below >> situation. >> >> It will c

Re: [PATCH 2/3] usb: phy: Add USB charger support

2017-06-27 Thread Baolin Wang
lp improve the system] > > url: > https://github.com/0day-ci/linux/commits/Baolin-Wang/include-uapi-usb-Introduce-USB-charger-type-and-state-definition/20170628-093530 > base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > config: i386-randconfig-x076-06262345 (at

[PATCH 3/3] power: wm831x_power: Support USB charger current limit management

2017-06-27 Thread Baolin Wang
-by: Mark Brown Signed-off-by: Baolin Wang --- drivers/power/supply/wm831x_power.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/drivers/power/supply/wm831x_power.c b/drivers/power/supply/wm831x_power.c index 7082301..3e3480708 100644 --- a/drivers

[PATCH 2/3] usb: phy: Add USB charger support

2017-06-27 Thread Baolin Wang
: Baolin Wang --- drivers/usb/phy/phy.c | 265 +++ include/linux/usb/phy.h | 48 + 2 files changed, 313 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 032f5af..db72802 100644 --- a/drivers/usb/phy/phy.c +++ b

[PATCH 1/3] include: uapi: usb: Introduce USB charger type and state definition

2017-06-27 Thread Baolin Wang
Introducing USB charger type and state definition can help to support USB charging which will be added in USB phy core. Signed-off-by: Baolin Wang --- include/uapi/linux/usb/charger.h | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 include/uapi/linux

[PATCH v3 3/3] usb: phy: phy-msm-usb: Remove redundant extcon register/unregister

2017-05-04 Thread Baolin Wang
Since usb phy core has added common code to register or unregister extcon device, then phy-msm-usb driver does not need its own code to register/unregister extcon device, then remove them. Signed-off-by: Baolin Wang --- drivers/usb/phy/phy-msm-usb.c | 85

[PATCH v3 1/3] usb: phy: Introduce one extcon device into usb phy

2017-05-04 Thread Baolin Wang
, and some other helper functions to register extcon. Signed-off-by: Baolin Wang --- drivers/usb/phy/Kconfig |6 ++--- drivers/usb/phy/phy.c | 57 +++ include/linux/usb/phy.h |7 ++ 3 files changed, 67 insertions(+), 3 deletions(-) diff

[PATCH v3 2/3] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister

2017-05-04 Thread Baolin Wang
Since usb phy core has added common code to register or unregister extcon device, then phy-qcom-8x16-usb driver does not need its own code to register/unregister extcon device, then remove them. Signed-off-by: Baolin Wang --- drivers/usb/phy/phy-qcom-8x16-usb.c | 20 +--- 1

[PATCH v3 0/3] Introduce one extcon device into usb phy

2017-05-04 Thread Baolin Wang
: - Fix build errors with random config. Baolin Wang (3): usb: phy: Introduce one extcon device into usb phy usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister usb: phy: phy-msm-usb: Remove redundant extcon register/unregister drivers/usb/phy/Kconfig

Re: [PATCH] usb: gadget: gserial: check if console kthread exists

2017-04-29 Thread Baolin Wang
Hi Mirea, On 29 April 2017 at 17:58, Mirea, Bogdan-Stefan wrote: > Hi Baolin, > > On April 29, 2017 at 5:14, Baolin Wang wrote: >> Hi, >> >> On 28 April 2017 at 21:26, Bogdan Mirea >> wrote: >> > In the current implementation we get a Kernel Oops w

Re: [PATCH] usb: gadget: gserial: check if console kthread exists

2017-04-28 Thread Baolin Wang
Hi, On 28 April 2017 at 21:26, Bogdan Mirea wrote: > In the current implementation we get a Kernel Oops when calling rmmod > for g_serial driver. This happens because the function that creates the > kthread (gs_console_setup) which should be called at driver probing is > never called for ttyGS* r

[PATCH v2] usb: host: plat: Enable xHCI plat runtime PM

2017-04-13 Thread Baolin Wang
Enable the xHCI plat runtime PM for parent device to suspend/resume xHCI. Also call pm_runtime_forbid() in probe() function to force users to explicitly enable runtime pm using power/control in sysfs, in case some parent devices didn't implement runtime PM callbacks. Signed-off-by: Baolin

Re: [PATCH] usb: host: plat: Enable xHCI plat runtime PM

2017-04-10 Thread Baolin Wang
Hi Mathias, On 10 April 2017 at 18:09, Mathias Nyman wrote: > On 10.04.2017 10:57, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 30 March 2017 at 11:26, Baolin Wang wrote: >>> >>> Enable the xHCI plat runtime PM for parent device to suspend/resu

Re: [PATCH] usb: host: plat: Enable xHCI plat runtime PM

2017-04-10 Thread Baolin Wang
Hi Mathias, On 30 March 2017 at 11:26, Baolin Wang wrote: > Enable the xHCI plat runtime PM for parent device to suspend/resume > xHCI. Also call pm_runtime_forbid() in probe() function to force users > to explicitly enable runtime pm using power/control in sysfs, in case > some pa

[PATCH] usb: host: plat: Enable xHCI plat runtime PM

2017-03-29 Thread Baolin Wang
Enable the xHCI plat runtime PM for parent device to suspend/resume xHCI. Also call pm_runtime_forbid() in probe() function to force users to explicitly enable runtime pm using power/control in sysfs, in case some parent devices didn't implement runtime PM callbacks. Signed-off-by: Baolin

Re: [PATCH v2 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister

2017-03-29 Thread Baolin Wang
Hi, On 28 March 2017 at 21:42, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Since usb phy core has added common code to register or unregister >> extcon device, then phy-qcom-8x16-usb driver does not need its own >> code to register/unregister e

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-29 Thread Baolin Wang
Hi, On 29 March 2017 at 07:04, NeilBrown wrote: > On Tue, Mar 07 2017, Baolin Wang wrote: > >> On 3 March 2017 at 10:23, NeilBrown wrote: >> >>> >>> I understand your reluctance to change drivers that you cannot test. >>> An alternative it do ch

Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-29 Thread Baolin Wang
Hi, On 29 March 2017 at 06:56, NeilBrown wrote: > On Thu, Mar 23 2017, Baolin Wang wrote: > >> Usually usb phy need register one extcon device to get the connection >> notifications. It will remove some duplicate code if the extcon device >> is registered using common

Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-29 Thread Baolin Wang
Hi, On 28 March 2017 at 21:40, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Usually usb phy need register one extcon device to get the connection >> notifications. It will remove some duplicate code if the extcon device >> is registered using common c

[PATCH] usb: phy: Remove unused config

2017-03-23 Thread Baolin Wang
Since the old common Samsung USB PHY code has been removed by commit ea2fdf8423 ("usb: phy: samsung: remove old common USB PHY code"), thus remove the unused config. Signed-off-by: Baolin Wang --- drivers/usb/phy/Kconfig |7 --- drivers/usb/phy/Makefile |1 - 2 files

[PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-23 Thread Baolin Wang
, and some other helper functions to register extcon. Suggested-by: NeilBrown Signed-off-by: Baolin Wang --- Changes since v1: - Fix build errors with random config. --- drivers/usb/phy/Kconfig |6 +++--- drivers/usb/phy/phy.c | 44 include

[PATCH v2 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister

2017-03-23 Thread Baolin Wang
Since usb phy core has added common code to register or unregister extcon device, then phy-qcom-8x16-usb driver does not need its own code to register/unregister extcon device, then remove them. Signed-off-by: Baolin Wang --- Changes since v1: - No updates. --- drivers/usb/phy/phy-qcom-8x16

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-22 Thread Baolin Wang
Hi, On 22 March 2017 at 20:43, Mathias Nyman wrote: > On 22.03.2017 12:40, Baolin Wang wrote: >> >> Hi, >> >> On 22 March 2017 at 17:00, Felipe Balbi wrote: >>> >>> >>> Hi, >>> >>> Baolin Wang writes: >>>&g

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-22 Thread Baolin Wang
Hi, On 22 March 2017 at 17:00, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>>>>> I don't yet understand why we can't just keep runtime pm disabled as a >>>>>> default for xhci platform devices. >>>>>> It coul

Re: [kbuild-all] [PATCH 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-21 Thread Baolin Wang
Hi, On 22 March 2017 at 14:32, Ye Xiaolong wrote: > On 03/20, Baolin Wang wrote: >>Hi, >> >> >>On 19 March 2017 at 19:42, kbuild test robot wrote: >>> Hi Baolin, >>> >>> [auto build test ERROR on balbi-usb/next] >>> [also bui

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-21 Thread Baolin Wang
Hi, On 21 March 2017 at 16:07, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>>> I don't yet understand why we can't just keep runtime pm disabled as a >>>> default for xhci platform devices. >>>> It could be enabled by whatev

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-21 Thread Baolin Wang
Hi Mathias, On 21 February 2017 at 10:09, Baolin Wang wrote: >>>>>> Do you have any comments about this patch? Thanks. >>>>>> >>>>>>>drivers/usb/host/xhci-plat.c | 41 >>>>>>>

Re: [PATCH 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-20 Thread Baolin Wang
t; > url: > https://github.com/0day-ci/linux/commits/Baolin-Wang/usb-phy-Introduce-one-extcon-device-into-usb-phy/20170319-175509 > base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > config: i386-randconfig-i1-201712 (attached as .config) > compiler: gcc-4.

[PATCH 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister

2017-03-16 Thread Baolin Wang
Since usb phy core has added common code to register or unregister extcon device, then phy-qcom-8x16-usb driver does not need its own code to register/unregister extcon device, then remove them. Signed-off-by: Baolin Wang --- drivers/usb/phy/phy-qcom-8x16-usb.c | 20 +--- 1

[PATCH 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-16 Thread Baolin Wang
, and some other helper functions to register extcon. Suggested-by: NeilBrown Signed-off-by: Baolin Wang --- drivers/usb/phy/Kconfig | 17 ++--- drivers/usb/phy/phy.c | 44 include/linux/usb/phy.h |6 ++ 3 files changed, 64

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-14 Thread Baolin Wang
Hi, On 14 March 2017 at 17:57, Lee Jones wrote: > On Mon, 20 Feb 2017, Baolin Wang wrote: > > [...] > >> drivers/power/supply/wm831x_power.c | 63 +++ >> drivers/usb/gadget/Kconfig |8 + >> drivers/usb/gadget/udc/Makefile |1 + >&g

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-13 Thread Baolin Wang
On 14 March 2017 at 09:10, Jun Li wrote: > Hi, > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Monday, March 13, 2017 4:44 PM >> To: Jun Li >> Cc: NeilBrown ; Felipe Balbi ; Greg KH >> ; Sebastian Re

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-13 Thread Baolin Wang
On 13 March 2017 at 09:09, Jun Li wrote: > Hi, > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Friday, March 10, 2017 6:52 PM >> To: Jun Li >> Cc: NeilBrown ; Felipe Balbi ; Greg KH >> ; Sebastian Re

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-10 Thread Baolin Wang
On 10 March 2017 at 16:27, Jun Li wrote: > Hi > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Friday, March 10, 2017 3:15 PM >> To: Jun Li >> Cc: NeilBrown ; Felipe Balbi ; Greg KH >> ; Sebastian Reichel ; Dm

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-09 Thread Baolin Wang
On 10 March 2017 at 14:30, Jun Li wrote: >> >> > >> >> > Will generic phy need add extcon as well? >> >> >> >> Yes, will add a 'struct extcon_dev*' in 'struct usb_phy', which will >> >> be common code. >> >> >> > >> > I mean the common code need add 'struct extcon_dev' into both 'struct >> > phy'

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-09 Thread Baolin Wang
On 9 March 2017 at 18:34, Jun Li wrote: > > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Thursday, March 09, 2017 2:11 PM >> To: Jun Li >> Cc: NeilBrown ; Felipe Balbi ; Greg KH >> ; Sebastian Reichel ; Dm

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-08 Thread Baolin Wang
Hi, On 9 March 2017 at 09:50, Jun Li wrote: > Hi, > >> -Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Tuesday, March 07, 2017 5:39 PM >> To: NeilBrown >> Cc: Felipe Balbi ; Greg KH ; >> Sebastian Reichel ; Dm

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-07 Thread Baolin Wang
On 3 March 2017 at 10:23, NeilBrown wrote: > On Mon, Feb 20 2017, Baolin Wang wrote: > >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >> provided by PMICs mea

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-03-02 Thread Baolin Wang
Hi, On 28 February 2017 at 06:11, Alan Stern wrote: > On Tue, 21 Feb 2017, Baolin Wang wrote: > >> On 17 February 2017 at 16:04, Felipe Balbi wrote: >> > >> > Hi, >> > >> > Baolin Wang writes: >> >>>> (One possible approach woul

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-02-21 Thread Baolin Wang
On 17 February 2017 at 16:04, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>>> (One possible approach would be to have the setup routine return >>>> different values for explicit and implicit status stages -- for >>>> example, return 1

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-02-20 Thread Baolin Wang
On 20 February 2017 at 23:10, Mathias Nyman wrote: > On 20.02.2017 04:47, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 6 February 2017 at 13:26, Baolin Wang wrote: >>> >>> Hi Mathias, >>> >>> On 31 January 2017 at 21:14, Mathias Nym

Re: [PATCH v19 2/4] usb: gadget: Support for the usb charger framework

2017-02-20 Thread Baolin Wang
improve the system] > > url: > https://github.com/0day-ci/linux/commits/Baolin-Wang/Introduce-usb-charger-framework-to-deal-with-the-usb-gadget-power-negotation/20170220-173051 > config: i386-randconfig-x015-201708 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

[PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-02-20 Thread Baolin Wang
tate() function to check charger state. - Remove the mutex lock in usb_charger_set_cur_limit_by_type() function in case will be issued in atomic context. Baolin Wang (4): usb: gadget: Introduce the usb charger framework usb: gadget: Support for the usb charger framework usb: gadget: Integr

[PATCH v19 2/4] usb: gadget: Support for the usb charger framework

2017-02-20 Thread Baolin Wang
For supporting the usb charger, it adds the usb_charger_init() and usb_charger_exit() functions for usb charger initialization and exit. It will report to the usb charger when the gadget state is changed, then the usb charger can do the power things. Signed-off-by: Baolin Wang Reviewed-by: Li

[PATCH v19 4/4] power: wm831x_power: Support USB charger current limit management

2017-02-20 Thread Baolin Wang
-by: Mark Brown Signed-off-by: Baolin Wang Acked-by: Lee Jones Acked-by: Charles Keepax Acked-by: Peter Chen Acked-by: Sebastian Reichel --- drivers/power/supply/wm831x_power.c | 63 +++ 1 file changed, 63 insertions(+) diff --git a/drivers/power/supply

[PATCH v19 3/4] usb: gadget: Integrate with the usb gadget supporting for usb charger

2017-02-20 Thread Baolin Wang
When the usb gadget supporting for usb charger is ready, the usb charger can implement the usb_charger_plug_by_gadget() function, usb_charger_exit() function and dev_to_uchger() function by getting 'struct usb_charger' from 'struct gadget'. Signed-off-by: Baolin Wang Reviewe

[PATCH v19 1/4] usb: gadget: Introduce the usb charger framework

2017-02-20 Thread Baolin Wang
usb gadget state. This patch doesn't yet integrate with the gadget code, so some functions which rely on the 'gadget' are not completed, that will be implemented in the following patches. Signed-off-by: Baolin Wang Reviewed-by: Li Jun Tested-by: Li Jun --- drivers/usb

Re: [PATCH RESEND v7 1/1] usb: xhci: plat: Enable async suspend/resume

2017-02-19 Thread Baolin Wang
57,7 @@ static int xhci_plat_probe(struct platform_device *pdev) > > pm_runtime_set_active(&pdev->dev); > pm_runtime_enable(&pdev->dev); > + device_enable_async_suspend(&pdev->dev); > > return 0; > > -- > 2.11.0.453.g787f75f05 > Reviewed-by: Bao

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-02-19 Thread Baolin Wang
Hi Mathias, On 6 February 2017 at 13:26, Baolin Wang wrote: > Hi Mathias, > > On 31 January 2017 at 21:14, Mathias Nyman > wrote: >> On 16.01.2017 12:56, Baolin Wang wrote: >>> >>> Hi Mathias, >> >> >> Hi >> >> Sorry about the

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-02-19 Thread Baolin Wang
On 17 February 2017 at 16:04, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>>> (One possible approach would be to have the setup routine return >>>> different values for explicit and implicit status stages -- for >>>> example, return 1

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-02-16 Thread Baolin Wang
truct usb_gadget which, if set, >>> will tell composite.c (or whatever) that the UDC wants explicitly queued >>> ctrl phases. >> >> The term used in the USB spec is "stage", not "phase". "Phase" refers >> to the packets making up a sin

  1   2   3   4   5   6   >