Re: usb: dwc2: RODATA_FULL_DEFAULT_ENABLED causes kernel oops

2019-05-26 Thread Ard Biesheuvel
On Sun, 26 May 2019 at 14:58, Ard Biesheuvel wrote: > > On Sun, 26 May 2019 at 12:45, Antti Seppälä wrote: > > > > On Sun, 26 May 2019 at 13:11, Stefan Wahren wrote: > > > > > > Hi, > > > > > > i want to remind about an issue which was orig

Re: usb: dwc2: RODATA_FULL_DEFAULT_ENABLED causes kernel oops

2019-05-26 Thread Ard Biesheuvel
On Sun, 26 May 2019 at 12:45, Antti Seppälä wrote: > > On Sun, 26 May 2019 at 13:11, Stefan Wahren wrote: > > > > Hi, > > > > i want to remind about an issue which was originally reported by Wayne > > Piekarski [1]. I'm able to reproduce this oops with Mainline Linux 5.0.2 > > on a Raspberry Pi 3

Re: [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 13:09, Jann Horn wrote: > > On Wed, Jan 23, 2019 at 1:04 PM Greg KH wrote: > > On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > > > Variables declared in a switch statement before any case statements > > > cannot be initialized, so move all instances out of the

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-05-03 Thread Ard Biesheuvel
On 3 May 2018 at 11:41, Marc Zyngier wrote: > On 03/05/18 09:42, Faiz Abbas wrote: >> Hi Marc, >> >> On Thursday 03 May 2018 01:44 PM, Marc Zyngier wrote: >>> On 03/05/18 05:49, Faiz Abbas wrote: Hi Everyone, On Wednesday 11 April 2018 07:32 PM, Marc Zyngier wrote: > On Wed, 11

Re: Regression due to "Workaround for uPD72020x USB3 chips"

2018-05-02 Thread Ard Biesheuvel
On 2 May 2018 at 11:18, Domenico Andreoli wrote: > On Wed, May 02, 2018 at 10:22:05AM +0200, Ard Biesheuvel wrote: >> On 2 May 2018 at 10:06, Domenico Andreoli >> wrote: >> > Dear all, >> > >> > my home machine stopped to boot starting from kernel ve

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-04-11 Thread Ard Biesheuvel
On 12 April 2018 at 07:05, Bockholdt Arne wrote: > > On Wed, 2018-04-11 at 15:02 +0100, Marc Zyngier wrote: > > On Wed, 11 Apr 2018 14:11:52 +0100, > Bockholdt Arne wrote: > > > Hi all, > > is there anything new, I've just tried the new stable 4.16.1 kernel > without any change. The Renesys USB3 c

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
> On 25 Mar 2018, at 15:14, Marc Zyngier wrote: > > On Sun, 25 Mar 2018 14:26:58 +0100 > Ard Biesheuvel wrote: > >>> On 25 March 2018 at 13:52, Marc Zyngier wrote: >>> On Sun, 25 Mar 2018 13:38:19 +0100, >>> Ard Biesheuvel wrote: >>>>

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
On 25 March 2018 at 13:52, Marc Zyngier wrote: > On Sun, 25 Mar 2018 13:38:19 +0100, > Ard Biesheuvel wrote: >> >> On 25 March 2018 at 13:31, Marc Zyngier wrote: >> > On Sun, 25 Mar 2018 12:57:55 +0100, >> > Ard Biesheuvel wrote: >> >> >

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
On 25 March 2018 at 13:31, Marc Zyngier wrote: > On Sun, 25 Mar 2018 12:57:55 +0100, > Ard Biesheuvel wrote: >> >> On 25 March 2018 at 12:51, Marc Zyngier wrote: >> > On Sun, 25 Mar 2018 11:48:35 +0100, >> > Ard Biesheuvel wrote: >> > >> >

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
On 25 March 2018 at 12:51, Marc Zyngier wrote: > On Sun, 25 Mar 2018 11:48:35 +0100, > Ard Biesheuvel wrote: > > Hi Ard, > > [...] > >> > I finally found some time to work on this, and came up with an >> > alternative approach (it turns out that this

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-03-25 Thread Ard Biesheuvel
On 25 March 2018 at 11:37, Marc Zyngier wrote: > On Fri, 02 Mar 2018 17:38:26 +, > Bockholdt Arne wrote: > > Hi Arne, > >> >> On Thu, 2018-03-01 at 17:37 +, Marc Zyngier wrote: >> > On 01/03/18 08:01, Bockholdt Arne wrote: >> > > >> > > On Thu, 2018-02-15 at 19:29 +, Marc Zyngier wrote

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-02-15 Thread Ard Biesheuvel
On 15 February 2018 at 19:29, Marc Zyngier wrote: > [+ Ard, who helped me chasing the initial issue] > > On 15/02/18 06:43, Bockholdt Arne wrote: >> Hi all, >> >> on our Intel Atom C2578 server with a SuperMicro A1SAi board and a >> Renesas uPD720201 USB 3.0 host controller the controller has stop

Re: [PATCH] usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201

2017-12-12 Thread Ard Biesheuvel
in with this patch (and I've done a fair but of soak > testing with the camera since). > > Cc: > Signed-off-by: Daniel Thompson I have been setting this quirk manually for ages on my kernel command line, for the same reason (MS HD Webcam), and with the same positive r

Re: Possible regression between 4.9 and 4.13

2017-08-30 Thread Ard Biesheuvel
On 30 August 2017 at 09:55, Mason wrote: > On 30/08/2017 08:02, Greg Kroah-Hartman wrote: > >> To get back to the original issue here, the hardware seems to have died, >> the driver stops talking to it, and all is good. The "regression" here >> is that we now properly can determine that the hardw

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

2017-08-01 Thread Ard Biesheuvel
On 1 August 2017 at 22:44, Bjorn Helgaas wrote: > On Thu, Jul 13, 2017 at 10:26:40AM +0200, Greg Kroah-Hartman wrote: >> On Wed, Jul 12, 2017 at 10:12:34PM -0500, Bjorn Helgaas wrote: >> > On Mon, Jul 10, 2017 at 04:52:28PM +0100, Marc Zyngier wrote: >> > > Ard and myself have just spent quite som

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

2017-07-12 Thread Ard Biesheuvel
On 13 July 2017 at 04:12, Bjorn Helgaas wrote: > On Mon, Jul 10, 2017 at 04:52:28PM +0100, Marc Zyngier wrote: >> Ard and myself have just spent quite some time lately trying to pin >> down an issue in the DMA code which was taking the form of a PCIe USB3 >> controller issuing a DMA access at some

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

2017-07-12 Thread Ard Biesheuvel
On 10 July 2017 at 18:21, Ard Biesheuvel wrote: > On 10 July 2017 at 16:52, Marc Zyngier wrote: >> Ard and myself have just spent quite some time lately trying to pin >> down an issue in the DMA code which was taking the form of a PCIe USB3 >> controller issuing a DMA a

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

2017-07-10 Thread Ard Biesheuvel
On 10 July 2017 at 16:52, Marc Zyngier wrote: > Ard and myself have just spent quite some time lately trying to pin > down an issue in the DMA code which was taking the form of a PCIe USB3 > controller issuing a DMA access at some bizarre address, and being > caught red-handed by the IOMMU. > > Af

Re: Panic in quirk_usb_early_handoff

2017-03-04 Thread Ard Biesheuvel
> On 4 Mar 2017, at 17:29, Mason wrote: > >> On 04/03/2017 18:16, Ard Biesheuvel wrote: >> >> After pc, the link register is the most likely to legally point into >> the kernel .text section so it makes sense imo to decode the address >> into a function name

Re: Panic in quirk_usb_early_handoff

2017-03-04 Thread Ard Biesheuvel
> On 4 Mar 2017, at 16:57, Mason wrote: > >> On 04/03/2017 09:07, Ard Biesheuvel wrote: >>> On 4 March 2017 at 00:24, Mason wrote: >>>> On 03/03/2017 20:02, Robin Murphy wrote: >>>> >>>>> On 03/03/17 17:15, Mason wrote: >>&

Re: Panic in quirk_usb_early_handoff

2017-03-04 Thread Ard Biesheuvel
On 4 March 2017 at 00:24, Mason wrote: > On 03/03/2017 20:02, Robin Murphy wrote: > >> On 03/03/17 17:15, Mason wrote: >> >>> [1.261813] Unable to handle kernel paging request at virtual address >>> d08611e4 >>> [1.269167] pgd = c0004000 >>> [1.271979] [d08611e4] *pgd=8f804811, *pte=0