Re: [PATCH] udc: Memory leak on error path and use after free

2017-08-22 Thread Anton Vasilyev
Sorry for delayed reply. On 16.08.2017 19:35, Alan Stern wrote: On Wed, 16 Aug 2017, Anton Vasilyev wrote: On 16.08.2017 18:29, Alan Stern wrote: On Wed, 16 Aug 2017, Anton Vasilyev wrote: gadget_release() is responsible for cleanup dev memory. But if net2280_probe() fails after dev

Re: [PATCH] udc: Memory leak on error path and use after free

2017-08-16 Thread Anton Vasilyev
On 16.08.2017 18:29, Alan Stern wrote: On Wed, 16 Aug 2017, Anton Vasilyev wrote: gadget_release() is responsible for cleanup dev memory. But if net2280_probe() fails after dev allocation, then gadget_release() become unregistered and dev memory leaks. This isn't need

[PATCH] udc: Memory leak on error path and use after free

2017-08-16 Thread Anton Vasilyev
that dev will be deallocated exactly after this call and leads to use after free. The patch moves deallocation from gadget_release() to net2280_remove(). Found by Linux Driver Verififcation project (linuxtesting.org). Signed-off-by: Anton Vasilyev --- drivers/usb/gadget/udc/net2280.c | 14