> From: Bin Liu [mailto:b-...@ti.com]
> On Thu, Oct 06, 2016 at 02:45:30PM +, Andrew Goodbody wrote:
> > I am trying to investigate an issue on a TI Sitara CPU, AM3352 with
> > the musb USB controller.
> >
> > The scenario is that a device has been in use and wor
Ping.
> -Original Message-
>
> I am trying to investigate an issue on a TI Sitara CPU, AM3352 with the musb
> USB controller.
>
> The scenario is that a device has been in use and working correctly. The
> device is an Android device and is presenting as an MTP device. That first
> sessio
I am trying to investigate an issue on a TI Sitara CPU, AM3352 with the musb
USB controller.
The scenario is that a device has been in use and working correctly. The device
is an Android device and is presenting as an MTP device. That first session of
use is finished and the port is reset but t
> -Original Message-
> Hello,
> I am having some difficulties with kernel module Gadget Serial v2.4.
> g_serial is used on ARM machine BeagleBone Black with Arch Linux 4.6.3-1
> which is communicating with host PC. I originally reported it here:
> bugzilla.kernel.org/show_bug.cgi?id=121441
from musb_rx_reinit before it was thrown away.
The data thrown away was a valid packet that had been correctly
ACKed which meant the host and device got out of sync.
Signed-off-by: Andrew Goodbody
Cc: sta...@vger.kernel.org
---
V3 removed the old comment, moved the new comment in place of the old one
a race condition caused by
not stopping the dedicated endpoint for bulk packets before
rotating its queue which allowed a packet to be recieved and then
thrown away.
V3 Updated the comment to better reference the manual
V2 added a comment and removed debugging code
Andrew Goodbody (2):
usb: musb
shared_fifo endpoints would only get a previous tx state cleared
out, the rx state was only cleared for non shared_fifo endpoints
Change this so that the rx state is cleared for all endpoints.
This addresses an issue that resulted in rx packets being dropped
silently.
Signed-off-by: Andrew
own away.
> >>>> The data thrown away was a valid packet that had been correctly
> >>>> ACKed which meant the host and device got out of sync.
> >>>>
> >>>> Signed-off-by: Andrew Goodbody
>
> >>>> Cc: sta...@vger.kernel.org
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
>
> Hello.
>
> On 5/23/2016 3:00 PM, Andrew Goodbody wrote:
>
> > Ensure that the endpoint is stopped by clearing REQPKT before clearing
> > DATAERR_NAKTIMEOUT before rotating the queue on t
shared_fifo endpoints would only get a previous tx state cleared
out, the rx state was only cleared for non shared_fifo endpoints
Change this so that the rx state is cleared for all endpoints.
This addresses an issue that resulted in rx packets being dropped
silently.
Signed-off-by: Andrew
from musb_rx_reinit before it was thrown away.
The data thrown away was a valid packet that had been correctly
ACKed which meant the host and device got out of sync.
Signed-off-by: Andrew Goodbody
Cc: sta...@vger.kernel.org
---
V2 added comment about clearing REQPKT before DATAERR_NAKTIMEOUT
a race condition caused by
not stopping the dedicated endpoint for bulk packets before
rotating its queue which allowed a packet to be recieved and then
thrown away.
V2 added a comment and removed debugging code
Andrew Goodbody (2):
usb: musb: Ensure rx reinit occurs for shared_fifo endpoints
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
> On 05/20/2016 08:06 PM, Andrew Goodbody wrote:
>
> >>> Ensure that the endpoint is stopped by clearing REQPKT before
> >>> clearing DATAERR_NAKTIMEOUT before rotating the queue on the
> >
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
> On 05/20/2016 05:51 PM, Andrew Goodbody wrote:
>
> > Ensure that the endpoint is stopped by clearing REQPKT before clearing
> > DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk
> > e
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
>
> Hello.
>
> On 05/20/2016 05:51 PM, Andrew Goodbody wrote:
>
> > shared_fifo endpoints would only get a previous tx state cleared out,
> > the rx state was only cleared for non shared_fifo end
a race condition caused by
not stopping the dedicated endpoint for bulk packets before
rotating its queue which allowed a packet to be recieved and then
thrown away.
Andrew Goodbody (2):
usb: musb: Ensure rx reinit occurs for shared_fifo endpoints
usb: musb: Stop bulk endpoint while queue is
shared_fifo endpoints would only get a previous tx state cleared
out, the rx state was only cleared for non shared_fifo endpoints
Change this so that the rx state is cleared for all endpoints.
This addresses an issue that resulted in rx packets being dropped
silently.
Signed-off-by: Andrew
from musb_rx_reinit before it was thrown away.
The data thrown away was a valid packet that had been correctly
ACKed which meant the host and device got out of sync.
Signed-off-by: Andrew Goodbody
Cc: sta...@vger.kernel.org
---
drivers/usb/musb/musb_host.c | 2 ++
1 file changed, 2 insertions
> From: Bin Liu [mailto:b-...@ti.com]
> Hi,
>
> On Fri, May 06, 2016 at 10:41:46AM +0000, Andrew Goodbody wrote:
> > > From: Bin Liu [mailto:b-...@ti.com]
> > > On Thu, May 05, 2016 at 04:02:55PM +, Andrew Goodbody wrote:
> > > > > From: Bin Liu
> -Original Message-
> > From: Bin Liu [mailto:b-...@ti.com]
> > On Thu, May 05, 2016 at 04:02:55PM +, Andrew Goodbody wrote:
> > > > From: Bin Liu [mailto:b-...@ti.com] On Thu, May 05, 2016 at
> > > > 03:12:00PM +, Andrew Goodbody wro
> From: Bin Liu [mailto:b-...@ti.com]
> On Thu, May 05, 2016 at 04:02:55PM +, Andrew Goodbody wrote:
> > > From: Bin Liu [mailto:b-...@ti.com]
> > > On Thu, May 05, 2016 at 03:12:00PM +, Andrew Goodbody wrote:
> > > > > From: Bin Liu [mailto:b-...
> From: Bin Liu [mailto:b-...@ti.com]
> On Thu, May 05, 2016 at 03:12:00PM +, Andrew Goodbody wrote:
> > > From: Bin Liu [mailto:b-...@ti.com]
> > > Hi,
> > >
> > > On Thu, May 05, 2016 at 12:22:33PM +, Andrew Goodbody wrote:
> &
> From: Bin Liu [mailto:b-...@ti.com]
> Hi,
>
> On Thu, May 05, 2016 at 12:22:33PM +0000, Andrew Goodbody wrote:
> > > From: Bin Liu [mailto:b-...@ti.com]
> > > Hi,
> > >
> > > On Wed, May 04, 2016 at 03:48:50PM +, Andrew Goodbody wrote:
>
> From: Bin Liu [mailto:b-...@ti.com]
> Hi,
>
> On Wed, May 04, 2016 at 03:48:50PM +0000, Andrew Goodbody wrote:
> > Hi,
> >
> > I have been investigating communication issues with iPads. When the
> > system is busy it seems that the musb driver is silently dro
Hi,
I have been investigating communication issues with iPads. When the system is
busy it seems that the musb driver is silently dropping occasional packets. I
have a usbmon trace that does not show the packet and I have a trace from a
hardware USB analyser that does show the packet. So the dev
Change spin_lock calls to spin_lock_irqsave to prevent
attmpted recursive lock taking in interrupt context.
This patch fixes Bug 109351
https://bugzilla.kernel.org/show_bug.cgi?id=109351
Signed-off-by: Andrew Goodbody
---
drivers/usb/usbip/usbip_event.c | 5 ++-
drivers/usb/usbip/vhci_hcd.c
Is there anyone who can help me with this deadlock?
Thanks,
Andrew
> -Original Message-
> From: Andrew Goodbody
> Sent: 14 December 2015 16:23
> To: linux-usb@vger.kernel.org
> Subject: Deadlock in USB/IP driver
>
> https://bugzilla.kernel.org/show_bug.cgi?id=109
https://bugzilla.kernel.org/show_bug.cgi?id=109351
I posted the log snippet to this list on Friday with no response so far, so I
filed a bug on it. Greg Kroah-Hartman responded to the bug to ask me to post on
this list.
Outlook messed up the text formatting from the syslog on my first attempt so
I have an application using the USB/IP drivers and I turned on the lock
debugging and checking options in the kernel.
I now get this deadlock report in syslog
Dec 11 15:03:20 cbrx-fw01 kernel: [ 220.497958] usbip_core: USB/IP Core v1.0.0
Dec 10 15:03:20 cbrx-fw01 kernel: [ 220.499707] vhci_hcd
29 matches
Mail list logo
