Re: [PATCH] xhci: use dma_alloc_coherent with fully cleared pages

2015-02-19 Thread Andi Kleen
> Great. Thanks for fixing this. Not great. This still leaves all the other drivers which may be affected by similar problems. IMHO Tim's original patch is still needed. -Andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-18 Thread Andi Kleen
> > Have you tried doing the experiments I suggested in > > > > http://marc.info/?l=linux-usb&m=142272448620716&w=2 > > > > to determine where the problem occurs? > > > > I was bogged down with other things lately and I haven't got a chance to > test that. But as you said, there's very

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Andi Kleen
> We don't "need" any backward compatility, why not fix the broken drivers > that are using memory outside of what they are asking for? That's not > ok no matter what, right? How would you find them all? We don't even know which place in XHCI is the culprit here. Yes iff you can find them it wo

[PATCH] dwc3: Only build debugfs when DWC3_GADGET/DUAL_ROLE is enabled

2013-08-05 Thread Andi Kleen
From: Andi Kleen Fix (randconfig) build problem with DEBUG_FS on Cc: ba...@ti.com Cc: linux-usb@vger.kernel.org Signed-off-by: Andi Kleen --- drivers/usb/dwc3/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile

Re: [PATCH] Fix initconst in ehci driver

2013-04-22 Thread Andi Kleen
> What do you mean? Take a look at ehci-msm.c, for example, starting > around line 198: Maybe you changed it recently. It's not in 3.8-rc* My LTO tree is only based on 3.8 at this point, not linux-next. -Andi > > static const struct ehci_driver_overrides msm_overrides __initdata = { > .r

Re: [PATCH] Fix initconst in ehci driver

2013-04-22 Thread Andi Kleen
On Mon, Apr 22, 2013 at 01:16:11PM -0400, Alan Stern wrote: > On Mon, 22 Apr 2013, Andi Kleen wrote: > > > From: Andi Kleen > > > > Signed-off-by: Andi Kleen > > > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c > > &g

[PATCH] Fix initconst in ehci driver

2013-04-22 Thread Andi Kleen
From: Andi Kleen Signed-off-by: Andi Kleen diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index e9301fb..0a2efca 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -47,7 +47,7 @@ struct ehci_mxc_priv { static struct hc_driver __read_mostly

[PATCH] More initconst in ehci driver

2013-04-20 Thread Andi Kleen
From: Andi Kleen Signed-off-by: Andi Kleen diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index ca75063..6a18f11 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c @@ -58,7 +58,7 @@ static int ehci_platform_reset(struct

[PATCH] Fix initconst in ehci driver

2013-04-20 Thread Andi Kleen
From: Andi Kleen Signed-off-by: Andi Kleen diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c index 170b939..b0fe8b5 100644 --- a/drivers/usb/host/ehci-pci.c +++ b/drivers/usb/host/ehci-pci.c @@ -385,7 +385,7 @@ static int ehci_pci_resume(struct usb_hcd *hcd, bool

Re: [PATCH] USB: Build usb_speed_string unconditionally

2012-08-20 Thread Andi Kleen
> Andi, care to try this again with this .config on Linus's tree to see if > it all now works properly? Works in mainline. Thanks. -Andi -- a...@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to major

Re: [PATCH] USB: Build usb_speed_string unconditionally

2012-08-20 Thread Andi Kleen
On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote: > On Mon, 20 Aug 2012, Andi Kleen wrote: > > > From: Andi Kleen > > > > The usb core uses usb_speed_string(). But it's only selected > > for USB_GADGET. Enable it unconditionally. > > What

[PATCH] USB: Build usb_speed_string unconditionally

2012-08-20 Thread Andi Kleen
From: Andi Kleen The usb core uses usb_speed_string(). But it's only selected for USB_GADGET. Enable it unconditionally. Fixes a lot of randconfig builds. Cc: g...@kroah.com Signed-off-by: Andi Kleen --- drivers/usb/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)