This patchset fixes and improves host mode external vbus supply management,
mainly around suspend/resume use cases. It also avoid 'vbus regulator"
to be requested lots of times upon each call to dwc2_vbus_supply_init(),
especially when pm runtime is enabled.
Fabrice Gasnier (4):
usb: dwc2: get o
e external
vbus supply")
Signed-off-by: Fabrice Gasnier
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/hcd.c | 12 +++-
drivers/usb/dwc2/platform.c | 8
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
in
pport for host mode external
vbus supply")
Signed-off-by: Fabrice Gasnier
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/hcd.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
ind
after hub resume.
Fixes: 531ef5ebea96 ("usb: dwc2: add support for host mode external
vbus supply")
Signed-off-by: Fabrice Gasnier
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/hcd.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/hcd.
off-by: Fabrice Gasnier
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/hcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index bb72517..e8a480e 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -4484,7 +4484,
t correctly propagate any
> other errors. Also propagate the error from _dwc2_hcd_start.
>
> Fixes: 531ef5ebea96 ("usb: dwc2: add support for host mode external vbus
> supply")
> Cc: Amelie Delaunay
> Signed-off-by: Tomeu Vizoso
>
> ---
>
> v2: Only overwrite
_dwc2_hcd_start.
>>>
>>> Fixes: 531ef5ebea96 ("usb: dwc2: add support for host mode external vbus
>>> supply") Cc: Amelie Delaunay
>>> Signed-off-by: Tomeu Vizoso
>>
>> Thanks for catching that oops in your tests.
>> Reviewed-b
On 03/06/2018 03:40 PM, Rob Herring wrote:
> On Tue, Mar 6, 2018 at 8:09 AM, Robin Murphy wrote:
>> On 06/03/18 01:57, Rob Herring wrote:
>>>
>>> On Thu, Mar 01, 2018 at 10:51:38AM +0100, Amelie Delaunay wrote:
>>>>
>>>> On some boards,
This patchset fixes STM32F7 DWC2 OTG HS binding. It actually
re-applies the v2 former patches adding STM32F7 DWC2 OTG HS support.
Bindings reviewed by Rob Herring.
Amelie Delaunay (2):
dt-bindings: usb: fix the STM32F7 DWC2 OTG HS core binding
usb: dwc2: fix STM32F7 USB OTG HS compatible
2F7xx DWC2 ...")
Signed-off-by: Amelie Delaunay
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings/usb/dwc2.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt
b/Documentation/devicetree/bindings/usb/dwc2.txt
ind
TG HS")
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/params.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 03fd20f..c4a4749 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -13
ch an external vbus
supply depends on the platform, is used to make it generic.
Signed-off-by: Amelie Delaunay
---
Documentation/devicetree/bindings/usb/usb-ehci.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/usb-ehci.txt
b/Documentation/devic
On some boards, especially when vbus supply requires large current,
and the charge pump on the PHY isn't enough, an external vbus power switch
may be used.
Add support for optional external vbus supply per port in ehci-platform.
Signed-off-by: Amelie Delaunay
Reviewed-by: Roger Qu
e one
external vbus supply per port, so add support to get as many optional
regulator as implemented ports on the host controller.
Changes in v2:
* Address Roger Quadros comments: move regulator_enable/disable from
ehci_platform_power_on/off to ehci_platform_port_power.
Amelie Delaunay (2):
Hi Robin,
On 02/28/2018 02:33 PM, Robin Murphy wrote:
> Hi Amelie,
>
> Just a couple of drive-by coding style comments...
>
> On 23/02/18 13:46, Amelie Delaunay wrote:
>> On some boards, especially when vbus supply requires large current,
>> and the charge pump
Hi Roger,
On 02/28/2018 12:01 PM, Roger Quadros wrote:
> Hi Amelie,
>
> On 23/02/18 15:46, Amelie Delaunay wrote:
>> On some boards, especially when vbus supply requires large current,
>> and the charge pump on the PHY isn't enough, an external vbus power switch
>
On some boards, especially when vbus supply requires large current,
and the charge pump on the PHY isn't enough, an external vbus power switch
may be used.
Add support for optional external vbus supply per port in ehci-platform.
Signed-off-by: Amelie Delaunay
---
Changes in v3:
* Ad
On 02/22/2018 07:27 PM, Alan Stern wrote:
> On Thu, 22 Feb 2018, Amelie DELAUNAY wrote:
>
>>>>>>> --- a/Documentation/devicetree/bindings/usb/usb-ehci.txt
>>>>>>> +++ b/Documentation/devicetree/bindings/usb/usb-ehci.txt
>>>>&g
Hi,
On 02/20/2018 07:10 PM, Alan Stern wrote:
> On Tue, 20 Feb 2018, Roger Quadros wrote:
>
>> On 20/02/18 16:46, Amelie DELAUNAY wrote:
>>> Hi,
>>>
>>> On 02/20/2018 03:00 PM, Roger Quadros wrote:
>>>> Hi,
>>>>
>>>> On 2
Hi,
On 02/20/2018 03:00 PM, Roger Quadros wrote:
> Hi,
>
> On 20/02/18 14:58, Amelie Delaunay wrote:
>> On some boards, especially when vbus supply requires large current,
>> and the charge pump on the PHY isn't enough, an external vbus power switch
>> may
Hi,
On 02/20/2018 02:02 PM, Felipe Balbi wrote:
>
> Hi,
>
> Amelie Delaunay writes:
>> On some boards, especially when vbus supply requires large current,
>> and the charge pump on the PHY isn't enough, an external vbus power switch
>> may be used.
>&g
On some boards, especially when vbus supply requires large current,
and the charge pump on the PHY isn't enough, an external vbus power switch
may be used.
Add support for this optional external vbus supply in ehci-platform.
Signed-off-by: Amelie Delaunay
---
Changes in v2:
* Address
Hi,
On 02/20/2018 10:27 AM, Roger Quadros wrote:
> Hi,
>
> On 20/02/18 11:11, Amelie Delaunay wrote:
>> On some boards, especially when vbus supply requires large current,
>> and the charge pump on the PHY isn't enough, an external vbus power switch
>> may
On some boards, especially when vbus supply requires large current,
and the charge pump on the PHY isn't enough, an external vbus power switch
may be used.
Add support for this optional external vbus supply in ehci-platform.
Signed-off-by: Amelie Delaunay
---
Documentation/devicetree/bin
This patchset fixes STM32F7 DWC2 OTG HS binding. It actually
re-applies the v2 former patches adding STM32F7 DWC2 OTG HS support.
Amelie Delaunay (2):
dt-bindings: usb: fix the STM32F7 DWC2 OTG HS core binding
usb: dwc2: fix STM32F7 USB OTG HS compatible
Documentation/devicetree/bindings
This patchset fixes STM32F7 DWC2 OTG HS binding. It actually
re-applies the v2 former patches adding STM32F7 DWC2 OTG HS support.
Amelie Delaunay (2):
dt-bindings: usb: fix the STM32F7 DWC2 OTG HS core binding
usb: dwc2: fix STM32F7 USB OTG HS compatible
Documentation/devicetree/bindings
2F7xx DWC2 ...")
Signed-off-by: Amelie Delaunay
---
Documentation/devicetree/bindings/usb/dwc2.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt
b/Documentation/devicetree/bindings/usb/dwc2.txt
index e64d903..46da5f1 10
TG HS")
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/params.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 03fd20f..c4a4749 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -13
Forget this one! Sorry for the inconvenience.
> -Original Message-
> From: Amelie DELAUNAY
> Sent: jeudi 15 février 2018 16:47
> To: John Youn ; Felipe Balbi ;
> Greg Kroah-Hartman ; Rob Herring
> ; Mark Rutland
> Cc: linux-usb@vger.kernel.org; devicet...@vger.ker
/pipermail/u-boot/2017-March/283434.html
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/core.h | 2 ++
drivers/usb/dwc2/hcd.c | 26 ++
2 files changed, 28 insertions(+)
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index cd77af3..8ebc85c 100644
--- a
Hi Minas,
On 11/30/2017 10:43 AM, Minas Harutyunyan wrote:
> Hi Amelie,
>
> On 11/27/2017 6:42 PM, Amelie Delaunay wrote:
>> In case of OTG mode, with an OTG adapter plugged, the
>> dwc2_check_param_tx_fifo_sizes function reads DPTXFSIZN registers while
>> the cont
dwc2: gadget: Add checking for g-tx-fifo-size
parameter")
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/params.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index ef73af6..302fefb 100644
--- a/drivers/usb/dwc2/para
t;>>> Hi,
>>>>
>>>> Alexandre Torgue writes:
>>>>> Hi Felip
>>>>>
>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>&
Hi,
Gentle ping for driver review submitted on August 28th.
Thanks,
Amelie
On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
> This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.
>
> Signed-off-by: Amelie Delaunay
> ---
> drivers/usb/dwc2/params.c | 11 +++
This patch enables USB FS on stm32f746-disco (Host mode) with 5V VBUS
enable.
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32f746-disco.dts | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746-disco.dts
b/arch/arm/boot/dts/stm32f746
This patch enables USB HS on stm32746g-eval (Host mode).
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32746g-eval.dts | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/stm32746g-eval.dts
b/arch/arm/boot/dts/stm32746g-eval.dts
index 69a9579
This patch adds binding documentation for DWC2 controller in HS mode found
on STMicroelectronics STM32F7 SoC.
Signed-off-by: Amelie Delaunay
---
Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt
b
The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
OTG FS and the other is USB OTG HS. The USB FS core only works with its
internal phy whilst the USB HS core can work in HS with external ULPI phy
or in FS/LS with the on-chip FS phy.
Amelie Delaunay (7):
dt-bindings: usb
This patch adds the USB pins and nodes for USB HS core on STM32F746 SoC.
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32f746.dtsi | 49
1 file changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts
This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC.
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32f746.dtsi | 31 +++
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
This patch enables USB HS on stm32f746-disco (Host mode).
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32f746-disco.dts | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746-disco.dts
b/arch/arm/boot/dts/stm32f746-disco.dts
index 18f6560
This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/params.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index a3ffe97..d5b672d 100644
--- a/drivers
On 08/22/2017 04:10 AM, Rob Herring wrote:
> On Thu, Aug 17, 2017 at 11:33:00AM +0200, Amelie Delaunay wrote:
>> This patch adds binding documentation for DWC2 controller in HS mode found
>> on STMicroelectronics STM32F7xx SoC.
>>
>> Signed-off-by: Amelie Delaunay
On 08/17/2017 12:47 PM, Sergei Shtylyov wrote:
> On 8/17/2017 12:33 PM, Amelie Delaunay wrote:
>
>> This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC.
>>
>> Signed-off-by: Amelie Delaunay
>> ---
>> a
Hi!
On 08/17/2017 12:44 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 8/17/2017 12:33 PM, Amelie Delaunay wrote:
>
>> This patch enables USB HS on stm32746g-eval (Host mode).
>>
>> Signed-off-by: Amelie Delaunay
>> ---
>> arch/arm/boot/dts/stm32746g-
This patch adds the dwc2_set_params function for STM32F7xx USB OTG HS.
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/params.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index a3ffe97..015d23e 100644
--- a/drivers
The STM32F7xx MCU family embeds two DWC2 USB OTG cores. One core is USB
OTG FS and the other is USB OTG HS. The USB FS core only works with its
internal phy whilst the USB HS core can work in HS with external ULPI phy
or in FS/LS with the on-chip FS phy.
Amelie Delaunay (7):
dt-bindings: usb
This patch adds binding documentation for DWC2 controller in HS mode found
on STMicroelectronics STM32F7xx SoC.
Signed-off-by: Amelie Delaunay
---
Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt
This patch enables USB FS on stm32f746-disco (Host mode) with 5V VBUS
enable.
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32f746-disco.dts | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746-disco.dts
b/arch/arm/boot/dts/stm32f746
This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC.
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32f746.dtsi | 31 +++
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
This patch adds the USB pins and nodes for USB HS core on STM32F746 SoC.
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32f746.dtsi | 49
1 file changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts
This patch enables USB HS on stm32f746-disco (Host mode).
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32f746-disco.dts | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/stm32f746-disco.dts
b/arch/arm/boot/dts/stm32f746-disco.dts
index 18f6560
This patch enables USB HS on stm32746g-eval (Host mode).
Signed-off-by: Amelie Delaunay
---
arch/arm/boot/dts/stm32746g-eval.dts | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/stm32746g-eval.dts
b/arch/arm/boot/dts/stm32746g-eval.dts
index 69a9579
).
That's why we need to clear GUSBCFG.USBTRDTIM mask before setting USBTrdTim
value, to ensure USBTrdTim is correctly set in case of 8-bit UTMI+.
Fixes: ecd9a7ad453c ("usb: dwc2: do not override forced dr_mode in gadget
setup")
Signed-off-by: Amelie Delaunay
---
v2: add Fixes: in
Hi all,
Sorry, I did not see Pengcheng Li patch which is exactly the same:
https://patchwork.kernel.org/patch/9347979/
Regards
On 01/12/2017 04:36 PM, Amelie Delaunay wrote:
USBTrdTim must be programmed to 0x5 when phy has a UTMI+ 16-bit wide
interface or 0x9 when it has a 8-bit wide interface
).
That's why we need to clear GUSBCFG.USBTRDTIM mask before setting USBTrdTim
value, to ensure USBTrdTim is correctly set in case of 8-bit UTMI+.
Signed-off-by: Amelie Delaunay
---
drivers/usb/dwc2/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb
This problem was spotted during code review. It appears that USBTrdTim value
is not correctly set in case of 8-bit UTMI+ phy, because it is ORed with
USBCFG.USBTRDTIM reset value, which is 0x5.
I have no hardware to test it.
Amelie Delaunay (1):
usb: dwc2: gadget: Fix GUSBCFG.USBTRDTIM value
57 matches
Mail list logo
