[PATCH v2] lan78xx: Connect phy early

2018-04-03 Thread Alexander Graf
applied, I can successfully run wicked on my system and bring the interface up and down as many times as I want, without getting NULL pointer dereferences in between. Signed-off-by: Alexander Graf --- v1 -> v2: - move debug message (Andrew Lunn) - check for phydev != NULL before phy_stop (Sa

[PATCH] lan78xx: Connect phy early

2018-03-14 Thread Alexander Graf
applied, I can successfully run wicked on my system and bring the interface up and down as many times as I want, without getting NULL pointer dereferences in between. Signed-off-by: Alexander Graf --- drivers/net/usb/lan78xx.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 15:58, Thomas Abraham wrote: > On 14 March 2013 17:31, Alexander Graf wrote: >> >> On 14.03.2013, at 05:19, Thomas Abraham wrote: >> >>> On 14 March 2013 05:29, Alexander Graf wrote: >>>> On my Exynos 5 based Arndale system, I need

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 04:38, Doug Anderson wrote: > Alexander, > > On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf wrote: >> On my Exynos 5 based Arndale system, I need to pull the reset line down >> and then let it go up again to actually perform a reset. Without that >&

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 05:19, Thomas Abraham wrote: > On 14 March 2013 05:29, Alexander Graf wrote: >> On my Exynos 5 based Arndale system, I need to pull the reset line down >> and then let it go up again to actually perform a reset. Without that >> reset, I can't f

[PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alexander Graf
found. This way we don't accidently reserve the vbus GPIO pin, but later on defer the creation of our controller, because the phy device tree node hasn't been probed yet. This patch implements the above logic, making EHCI and OHCI work on Arndale systems for me. Signed-off-by: Alexander

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alexander Graf
On 13.03.2013, at 18:59, Doug Anderson wrote: > Alexander, > > On Wed, Mar 13, 2013 at 10:45 AM, Alexander Graf wrote: >> >>>> + gpio_free(gpio); >>> >>> Freeing the gpio is a little on the iffy side since you actually care >>> ab

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alexander Graf
On 13.03.2013, at 18:28, Doug Anderson wrote: > Alexander, > > On Tue, Mar 12, 2013 at 6:09 PM, Alexander Graf wrote: >> - err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, "ehci_vbus_gpio"); >> - if (err) >> + /* reset pulls the line

[PATCH] USB: ehci-s5p: Fix phy reset

2013-03-12 Thread Alexander Graf
rk on Arndale systems for me. Signed-off-by: Alexander Graf CC: Vivek Gautam CC: Jingoo Han CC: Alan Stern CC: Kukjin Kim CC: Felipe Balbi CC: Greg Kroah-Hartman --- As this affects 3.9, this patch should definitely be considered for inclusion there. --- drivers/usb/host/ehci-s5p.c