Re: [PATCH] [PATCH v8] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-10-23 Thread Johan Hovold
On Tue, Sep 24, 2019 at 08:14:00PM +0800, Charles Yeh wrote: > Prolific has developed a new USB to UART chip: PL2303HXN > PL2303HXN : PL2303GC/PL2303GS/PL2303GT/PL2303GL/PL2303GE/PL2303GB > The Vendor request used by the PL2303HXN (TYPE_HXN) is different from > the existing PL2303 series (TYPE_HX &

[GIT PULL] USB-serial fixes for 5.4-rc4

2019-10-18 Thread Johan Hovold
lated clean up. Both have been in linux-next with no reported issues. Signed-off-by: Johan Hovold Johan Hovold (2): USB: serial: ti_usb_3410_5052: fix port-close races USB: serial: ti_usb_3410_5052: clean up serial

Re: [RFT PATCH] xhci: Fix use-after-free regression in xhci clear hub TT implementation

2019-10-14 Thread Johan Hovold
bling endpoints, so we want this in xhci as well. > > The added xhci_endpoint_disable() is based on ehci_endpoint_disable() > > Fixes: ef513be0a905 ("usb: xhci: Add Clear_TT_Buffer") > Cc: # v5.3 > Reported-by: Johan Hovold > Signed-off-by: Mathias Nyman > ---

Re: [PATCH v2] USB: legousbtower: fix a signedness bug in tower_probe()

2019-10-11 Thread Johan Hovold
at probe") > Signed-off-by: Dan Carpenter Acked-by: Johan Hovold > --- > v2: style improvement suggested by Walter Harms. > > drivers/usb/misc/legousbtower.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/legousb

Re: [PATCH] USB: legousbtower: fix a signedness bug in tower_probe()

2019-10-11 Thread Johan Hovold
On Fri, Oct 11, 2019 at 04:58:56PM +0300, Dan Carpenter wrote: > On Fri, Oct 11, 2019 at 03:51:26PM +0200, walter harms wrote: > > > > > > Am 11.10.2019 15:35, schrieb Dan Carpenter: > > > The problem is that sizeof() is unsigned long so negative error codes > > > are type promoted to high positi

Re: [PATCH] USB: legousbtower: fix a signedness bug in tower_probe()

2019-10-11 Thread Johan Hovold
, "get version request failed: %d\n", result); Bah, I should have noticed. Thanks for fixing this! Acked-by: Johan Hovold Johan

Re: [PATCH 2/2] USB: serial: ti_usb_3410_5052: clean up serial data access

2019-10-11 Thread Johan Hovold
On Fri, Oct 11, 2019 at 11:57:36AM +0200, Johan Hovold wrote: > Use the tdev pointer directly instead of going through the port data > when accessing the serial data in open(). hmm, s/open/close/. > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/ti_usb_3410_5052.c | 4

[PATCH 1/2] USB: serial: ti_usb_3410_5052: fix port-close races

2019-10-11 Thread Johan Hovold
Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/ti_usb_3410_5052.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index dd0ad67aa71e..9174ba2e06da 10

[PATCH 2/2] USB: serial: ti_usb_3410_5052: clean up serial data access

2019-10-11 Thread Johan Hovold
Use the tdev pointer directly instead of going through the port data when accessing the serial data in open(). Signed-off-by: Johan Hovold --- drivers/usb/serial/ti_usb_3410_5052.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b

Re: [PATCH 5/5] USB: yurex: fix NULL-derefs on disconnect

2019-10-10 Thread Johan Hovold
On Wed, Oct 09, 2019 at 05:38:48PM +0200, Johan Hovold wrote: > The driver was using its struct usb_interface pointer as an inverted > disconnected flag, but was setting it to NULL without making sure all > code paths that used it were done with it. > > Before commit ef61eb43ad

[PATCH 3/3] USB: usb-skeleton: drop redundant in-urb check

2019-10-09 Thread Johan Hovold
The driver bails out at probe if we can't find a bulk-in endpoint or if we fail to allocate the URB, so drop the check in read(). Signed-off-by: Johan Hovold --- drivers/usb/usb-skeleton.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/usb-skeleton.c b/dr

[PATCH 2/3] USB: usb-skeleton: fix use-after-free after driver unbind

2019-10-09 Thread Johan Hovold
The driver failed to stop its read URB on disconnect, something which could lead to a use-after-free in the completion handler after driver unbind in case the character device has been closed. Fixes: e7389cc9a7ff ("USB: skel_read really sucks royally") Signed-off-by: Johan Hovold --

[PATCH 1/3] USB: usb-skeleton: fix NULL-deref on disconnect

2019-10-09 Thread Johan Hovold
("USB: usb-skeleton.c: remove err() usage") Fixes: 5c290a5e42c3 ("USB: usb-skeleton: fix runtime PM after driver unbind") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/usb-skeleton.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH 0/3] USB: usb-skeleton: regression fix

2019-10-09 Thread Johan Hovold
it in usb-linus for usb-skeleton. :/ Included are also a use-after-free fix and a related clean up. Johan Johan Hovold (3): USB: usb-skeleton: fix NULL-deref on disconnect USB: usb-skeleton: fix use-after-free after driver unbind USB: usb-skeleton: drop redundant in-urb check drivers/us

[PATCH 0/5] USB: misc: fix disconnect bugs

2019-10-09 Thread Johan Hovold
structures (leading to use-after-free on release()). I've already fixed up a few of these USB character device drivers separately, and the uss720 driver has similar bugs that remain to be fixed. Johan Johan Hovold (5): USB: adutux: fix use-after-free on release USB: chaoskey: fix use-after-fr

[PATCH 2/5] USB: chaoskey: fix use-after-free on release

2019-10-09 Thread Johan Hovold
e (v2)") Cc: stable # 4.1 Signed-off-by: Johan Hovold --- drivers/usb/misc/chaoskey.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c index cf5828ce927a..34e6cd6f40d3 100644 --- a/drivers/usb/misc/chaosk

[PATCH 4/5] USB: legousbtower: fix use-after-free on release

2019-10-09 Thread Johan Hovold
Cc: stable # 3.12 Signed-off-by: Johan Hovold --- drivers/usb/misc/legousbtower.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 44d6a3381804..9d4c52a7ebe0 100644 --- a/drivers/usb/misc/legousbtow

[PATCH 3/5] USB: ldusb: fix NULL-derefs on driver unbind

2019-10-09 Thread Johan Hovold
: 2824bd250f0b ("[PATCH] USB: add ldusb driver") Cc: stable # 2.6.13 Signed-off-by: Johan Hovold --- drivers/usb/misc/ldusb.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index 65

[PATCH 5/5] USB: yurex: fix NULL-derefs on disconnect

2019-10-09 Thread Johan Hovold
table # 3.5: ef61eb43ada6 Signed-off-by: Johan Hovold --- drivers/usb/misc/yurex.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/yurex.c b/drivers/usb/misc/yurex.c index 8d52d4336c29..be0505b8b5d4 100644 --- a/drivers/usb/misc/yurex.c

[PATCH 1/5] USB: adutux: fix use-after-free on release

2019-10-09 Thread Johan Hovold
Cc: stable # 3.12 Signed-off-by: Johan Hovold --- drivers/usb/misc/adutux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index f9efec719359..6f5edb9fc61e 100644 --- a/drivers/usb/misc/adutux.c +++ b/drivers/usb/mis

[PATCH] USB: core: drop OOM message

2019-10-08 Thread Johan Hovold
Drop redundant OOM message on allocation failures which would already have been logged by the allocator. This also allows us to clean up the error paths somewhat. Signed-off-by: Johan Hovold --- drivers/usb/core/config.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff

Re: [PATCH 8/8] xhci: Fix NULL pointer dereference in xhci_clear_tt_buffer_complete()

2019-10-07 Thread Johan Hovold
> scheduled, and by then usb core might have freed and allocated a > new udev for the next enumeration attempt. > > Fixes: ef513be0a905 ("usb: xhci: Add Clear_TT_Buffer") > Cc: # v5.3 > Reported-by: Johan Hovold > Signed-off-by: Mathias Nyman > --- >

[GIT PULL] USB-serial fixes for 5.4-rc2

2019-10-04 Thread Johan Hovold
could lead to NULL-pointer dereferences when a device had unexpected endpoint descriptors. Included are also some new device IDs. All but the last two commits have been in linux-next with no reported issues. Signed-off-by: Johan H

Re: [PATCH] USB: serial: option: add support for Cinterion CLS8 devices

2019-10-03 Thread Johan Hovold
On Thu, Oct 03, 2019 at 06:53:21PM +0200, Reinhard Speyerer wrote: > Add support for the serial ports of Cinterion CLS8 devices. > > T: Bus=01 Lev=03 Prnt=05 Port=01 Cnt=02 Dev#= 25 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=1e2d ProdID=00b0 Rev=

[PATCH] USB: serial: keyspan: fix NULL-derefs on open() and write()

2019-10-03 Thread Johan Hovold
: fdcba53e2d58 ("fix for bugzilla #7544 (keyspan USB-to-serial converter)") Cc: stable # 2.6.21 Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keysp

[PATCH] USB: microtek: fix info-leak at probe

2019-10-03 Thread Johan Hovold
Add missing bulk-in endpoint sanity check to prevent uninitialised stack data from being reported to the system log and used as endpoint addresses. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Reported-by: syzbot+5630ca7c3b2be5c9d...@syzkaller.appspotmail.com Signed-off-by: Jo

Re: [PATCH v2 1/1] usb: serial: option: add Telit FN980 compositions

2019-10-02 Thread Johan Hovold
On Mon, Sep 23, 2019 at 12:23:28PM +0200, Daniele Palmas wrote: > This patch adds the following Telit FN980 compositions: > > 0x1050: tty, adb, rmnet, tty, tty, tty, tty > 0x1051: tty, adb, mbim, tty, tty, tty, tty > 0x1052: rndis, tty, adb, tty, tty, tty, tty > 0x1053: tty, adb, ecm, tty, tty, tt

Re: [PATCH] USB: serial: FTDI: Add device IDs for Sienna and Echelon PL-20

2019-10-02 Thread Johan Hovold
On Thu, Sep 05, 2019 at 12:26:20AM +0200, beni.mah...@gmx.net wrote: > From: Beni Mahler > > Both devices added here have a FTDI chip inside. The device from Echelon > is called 'Network Interface' it is actually a LON network gateway. > > ID 0403:8348 Future Technology Devices International, L

Re: musb: cppi41: broken high speed FTDI functionality when connected to musb directly

2019-10-01 Thread Johan Hovold
On Mon, Sep 30, 2019 at 09:54:11PM +0200, Sebastian Reichel wrote: > Hi, > > On Mon, Sep 30, 2019 at 08:23:30AM -0700, Tony Lindgren wrote: > > Actually playing with the cppi41 timeout might be more suitable here, > > they use the same module clock from what I remember though. So > > maybe increa

NULL-deref in xhci_clear_tt_buffer_complete()

2019-09-30 Thread Johan Hovold
Hi Mathias, I hit this NULL-deref in xhci_clear_tt_buffer_complete() with usb-next after an external HS hub with a connected FS device got into some weird state this morning: [ 66.833702] usb 2-2.4: USB disconnect, device number 5 [ 66.834756] usblcd 2-2.4:1.0: USB LCD #144 now disconnected

Re: [PATCH 0/4] USB: usblcd: disconnect fix and locking clean ups

2019-09-26 Thread Johan Hovold
On Thu, Sep 26, 2019 at 11:12:24AM +0200, Johan Hovold wrote: > This series fixes a failure to stop I/O on disconnect() in the usblcd > driver. Turns out there was a lot of legacy cruft in this driver which > could simply be removed. My apologies for the double post. Johan

[PATCH 1/4] USB: usblcd: fix I/O after disconnect

2019-09-26 Thread Johan Hovold
has run. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable # 7bbe990c989e Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/mis

[PATCH 1/4] USB: usblcd: fix I/O after disconnect

2019-09-26 Thread Johan Hovold
has run. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable # 7bbe990c989e Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/mis

[PATCH 3/4] USB: usblcd: drop redundant lcd mutex

2019-09-26 Thread Johan Hovold
d. Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index b898650a5570..732eb1f81368 100644 --- a/drivers/usb/misc/usblcd.c +++ b/drivers/usb/misc/usblcd.c @@ -30,7 +30,6 @

[PATCH 4/4] USB: usblcd: use pr_err()

2019-09-26 Thread Johan Hovold
Replace the one remaining printk with pr_err(). Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index 732eb1f81368..61e9e987fe4a 100644 --- a/drivers/usb/misc

[PATCH 0/4] USB: usblcd: disconnect fix and locking clean ups

2019-09-26 Thread Johan Hovold
. I was tempted to rip out the custom ioctls() used to retrieve the driver version and bcdDevice (sic!), but decided to leave them in. I doubt anyone would miss them though so perhaps we should give it a go? Tested using a mockup device. Johan Johan Hovold (4): USB: usblcd: fix I/O after

[PATCH 3/4] USB: usblcd: drop redundant lcd mutex

2019-09-26 Thread Johan Hovold
d. Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index b898650a5570..732eb1f81368 100644 --- a/drivers/usb/misc/usblcd.c +++ b/drivers/usb/misc/usblcd.c @@ -30,7 +30,6 @

[PATCH 0/4] USB: usblcd: disconnect fix and locking clean ups

2019-09-26 Thread Johan Hovold
. I was tempted to rip out the custom ioctls() used to retrieve the driver version and bcdDevice (sic!), but decided to leave them in. I doubt anyone would miss them though so perhaps we should give it a go? Tested using a mockup device. Johan Johan Hovold (4): USB: usblcd: fix I/O after

[PATCH 2/4] USB: usblcd: drop redundant disconnect mutex

2019-09-26 Thread Johan Hovold
completed and that no new calls to open() will occur after usb_deregister_dev() returns. Hence there is no need use the driver data as an inverted disconnected flag. Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 18 +- 1 file changed, 1 insertion(+), 17 deletion

[PATCH 2/4] USB: usblcd: drop redundant disconnect mutex

2019-09-26 Thread Johan Hovold
completed and that no new calls to open() will occur after usb_deregister_dev() returns. Hence there is no need use the driver data as an inverted disconnected flag. Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 18 +- 1 file changed, 1 insertion(+), 17 deletion

[PATCH 4/4] USB: usblcd: use pr_err()

2019-09-26 Thread Johan Hovold
Replace the one remaining printk with pr_err(). Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index 732eb1f81368..61e9e987fe4a 100644 --- a/drivers/usb/misc

Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-09-25 Thread Johan Hovold
On Wed, Sep 25, 2019 at 05:36:23PM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年9月25日 週三 下午4:06寫道: > > Meanwhile you can double check that you've considered all > > review-feedback you've gotten so far. > > > > I don't think you ever replied to my las

[PATCH 2/2] USB: adutux: fix NULL-derefs on disconnect

2019-09-25 Thread Johan Hovold
d128 ("USB: adutux: remove custom debug macro") Cc: stable # 3.12 Signed-off-by: Johan Hovold --- drivers/usb/misc/adutux.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index bcc138990e2f.

[PATCH 1/2] USB: adutux: fix use-after-free on disconnect

2019-09-25 Thread Johan Hovold
pspotmail.com Tested-by: syzbot+0243cb250a51eeefb...@syzkaller.appspotmail.com Signed-off-by: Johan Hovold --- drivers/usb/misc/adutux.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index 344d523b0502..bcc138990e2f

Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-09-25 Thread Johan Hovold
On Wed, Sep 25, 2019 at 09:20:07AM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年9月23日 週一 下午9:08寫道: > > > > Yes, the above looks good. > > > > Thank you for your reply > > I have already written a new patch[v8] file, > if you have free time. Please check

Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-09-23 Thread Johan Hovold
On Mon, Sep 23, 2019 at 06:35:19PM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年9月23日 週一 下午6:24寫道: > > That looks much better. But please move the reset defines above the > > flow control ones to keep the registers sorted by address (0x7 < 0xa). > > Thank you for you

Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-09-23 Thread Johan Hovold
On Mon, Sep 23, 2019 at 05:53:34PM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年9月20日 週五 下午3:56寫道: > > Yes, that's better, but you're mixing register addresses, bit values and > > masks above. Perhaps things would be more clear if you but a _REG suffix > > on

Re: Linux Keyspan USB serial driver ignoring XOFF

2019-09-23 Thread Johan Hovold
me to cook up a proper patch to make this configurable later this week. Johan >From 55b46d78fe63f182923e4674659fa18f4624d6b8 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Mon, 23 Sep 2019 12:14:56 +0200 Subject: [PATCH] USB: serial: keyspan: enable XON flow control Signed-off-by: Johan Hovold --- drivers

Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-09-20 Thread Johan Hovold
On Tue, Aug 27, 2019 at 04:40:39PM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年7月16日 週二 下午4:49寫道: > > > #define PL2303_FLOWCTRL_MASK 0xf0 > > > +#define PL2303_HXN_FLOWCTRL_MASK 0x1C > > > +#define PL2303_HXN_FLOWCTRL 0x0A > > >

[PATCH RESEND 2/4] USB: legousbtower: fix deadlock on disconnect

2019-09-19 Thread Johan Hovold
prevent char device open/deregister race"). Fixes: 78663ecc344b ("USB: disconnect open race in legousbtower") Cc: stable # 2.6.24 Reported-by: syzbot+f9549f5ee8a5416f0...@syzkaller.appspotmail.com Tested-by: syzbot+f9549f5ee8a5416f0...@syzkaller.appspotmail.com Signed-off

[PATCH RESEND 3/4] USB: legousbtower: fix potential NULL-deref on disconnect

2019-09-19 Thread Johan Hovold
t;USB: legousbtower.c: remove err() usage") Fixes: fef526cae700 ("USB: legousbtower: remove custom debug macro") Fixes: 4dae99638097 ("USB: legotower: remove custom debug macro and module parameter") Cc: stable # 3.5 Signed-off-by: Johan Hovold --- driver

[PATCH RESEND 4/4] USB: legousbtower: fix open after failed reset request

2019-09-19 Thread Johan Hovold
2-rc2") Signed-off-by: Johan Hovold --- drivers/usb/misc/legousbtower.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 4fa999882635..44d6a3381804 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/d

[PATCH RESEND 1/4] USB: legousbtower: fix slab info leak at probe

2019-09-19 Thread Johan Hovold
Make sure to check for short transfers when retrieving the version information at probe to avoid leaking uninitialised slab data when logging it. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/misc/legousbtower.c | 6 -- 1 file

[PATCH RESEND 0/4] USB: legousbtower: misc fixes

2019-09-19 Thread Johan Hovold
ee. Johan Johan Hovold (4): USB: legousbtower: fix slab info leak at probe USB: legousbtower: fix deadlock on disconnect USB: legousbtower: fix potential NULL-deref on disconnect USB: legousbtower: fix open after failed reset request drivers/usb/misc/legousbto

[PATCH 3/4] USB: legousbtower: fix potential NULL-deref on disconnect

2019-09-19 Thread Johan Hovold
t;USB: legousbtower.c: remove err() usage") Fixes: fef526cae700 ("USB: legousbtower: remove custom debug macro") Fixes: 4dae99638097 ("USB: legotower: remove custom debug macro and module parameter") Cc: stable # 3.5 Signed-off-by: Johan Hovold --- driver

[PATCH 1/4] USB: legousbtower: fix slab info leak at probe

2019-09-19 Thread Johan Hovold
Make sure to check for short transfers when retrieving the version information at probe to avoid leaking uninitialised slab data when logging it. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/misc/legousbtower.c | 6 -- 1 file

[PATCH 0/4] USB: legousbtower: misc fixes

2019-09-19 Thread Johan Hovold
This series fixes a few issues found in the legousbtower driver. The potential deadlock issue was reported by syzbot, and the rest was found through inspection. I have bunch of clean ups for this driver as well that I'll post once these are in Linus's tree. Johan Johan Hovold

[PATCH 2/4] USB: legousbtower: fix deadlock on disconnect

2019-09-19 Thread Johan Hovold
prevent char device open/deregister race"). Fixes: 78663ecc344b ("USB: disconnect open race in legousbtower") Cc: stable # 2.6.24 Reported-by: syzbot+f9549f5ee8a5416f0...@syzkaller.appspotmail.com Tested-by: syzbot+f9549f5ee8a5416f0...@syzkaller.appspotmail.com Signed-off

[PATCH 4/4] USB: legousbtower: fix open after failed reset request

2019-09-19 Thread Johan Hovold
2-rc2") Signed-off-by: Johan Hovold --- drivers/usb/misc/legousbtower.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 4fa999882635..44d6a3381804 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/d

[GIT PULL] USB-serial updates for 5.4-rc1

2019-09-04 Thread Johan Hovold
commit adding support for the CBUS GPIOs on FT232H devices. This change has spent a week in linux-next with no reported issues. Signed-off-by: Johan Hovold Matthew Michilot (1): USB: serial: ftdi_sio: add support for FT232H

[GIT PULL] USB-serial fixes for 5.3-rc5

2019-08-17 Thread Johan Hovold
issues. Signed-off-by: Johan Hovold Bob Ham (1): USB: serial: option: add the BroadMobi BM818 card Rogan Dawes (1): USB: serial: option: add D-Link DWM-222 device ID Tony Lindgren (1): USB: serial: option: Add

Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card

2019-08-15 Thread Johan Hovold
On Thu, Aug 15, 2019 at 01:19:19PM +0100, Bob Ham wrote: > On 15/08/2019 12:49, Johan Hovold wrote: > > On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: > >> On 05/08/2019 12:47, Johan Hovold wrote: > >>> On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainsl

Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card

2019-08-15 Thread Johan Hovold
On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: > On 05/08/2019 12:47, Johan Hovold wrote: > > On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: > >> From: Bob Ham > >> > >> Add a VID:PID for the BroadModi BM818 M.2 card > >

Re: [PATCHv2] USB: serial: option: Add Motorola modem UARTs

2019-08-15 Thread Johan Hovold
> > As the Motorola USB serial ports have an interrupt endpoint as shown > with lsusb -v, we should use option.c instead of qcaux.c as pointed out > by Johan Hovold . > > The ff/ff/ff interfaces seem to always be UARTs on Motorola devices. > For the other interfaces, class 0x0a

Re: Fwd: Re: New USB Device

2019-08-13 Thread Johan Hovold
On Wed, Jul 31, 2019 at 07:32:29PM +0200, Markus Breunig wrote: > > > Am 16.07.2019 um 11:23 schrieb Johan Hovold: > > [ Pleas avoid top posting. ] > > > > On Sun, Jul 07, 2019 at 09:38:00PM +0200, Markus Breunig wrote: > >> Hi Greg, > >> > >&g

Re: [PATCH] USB: serial: ftdi_sio: add support for FT232H CBUS gpios

2019-08-13 Thread Johan Hovold
On Thu, Aug 08, 2019 at 10:23:48PM +, Matthew Michilot wrote: > Enable support for cbus gpios on FT232H. The cbus configuration is > stored in one word in the EEPROM at byte-offset 0x1a with the mux > config for ACBUS5, ACBUS6, ACBUS8 and ACBUS9 (only pins that can be > configured as I/O mode).

Re: [PATCH] USB: serial: ftdi_sio: add support for FT232H CBUS gpios

2019-08-13 Thread Johan Hovold
On Thu, Aug 08, 2019 at 10:23:48PM +, Matthew Michilot wrote: > Enable support for cbus gpios on FT232H. The cbus configuration is > stored in one word in the EEPROM at byte-offset 0x1a with the mux It seems to be stored in two words. > config for ACBUS5, ACBUS6, ACBUS8 and ACBUS9 (only pins

Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card

2019-08-05 Thread Johan Hovold
On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: > From: Bob Ham > > Add a VID:PID for the BroadModi BM818 M.2 card Would you mind posting the output of usb-devices (or lsusb -v) for this device? > Signed-off-by: Bob Ham > Signed-off-by: Angus Ainslie (Purism) > --- >

Re: [PATCH v6] USB: serial: option: add D-Link DWM-222 device ID

2019-08-05 Thread Johan Hovold
On Wed, Jul 17, 2019 at 11:11:34AM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222 A2. > > MI_00 D-Link HS-USB Diagnostics > MI_01 D-Link HS-USB Modem > MI_02 D-Link HS-USB AT Port > MI_03 D-Link HS-USB NMEA > MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) > MI_05 USB Mass Storage Device

Re: [PATCH v3] USB: serial: option: Add support for ZTE MF871A

2019-08-05 Thread Johan Hovold
On Sat, Jul 20, 2019 at 10:23:18PM +0900, Yoshiaki Okamoto wrote: > This patch adds support for MF871A USB modem (aka Speed USB STICK U03) > to option driver. This modem is manufactured by ZTE corporation, and > sold by KDDI. > Co-developed-by: Hiroyuki Yamamoto > Signed-off-by: Hiroyuki Yamamoto

[PATCH] NFC: nfcmrvl: fix gpio-handling regression

2019-08-05 Thread Johan Hovold
com Tested-by: syzbot+cf35b76f35e068a11...@syzkaller.appspotmail.com Signed-off-by: Johan Hovold --- drivers/nfc/nfcmrvl/main.c | 4 ++-- drivers/nfc/nfcmrvl/uart.c | 4 ++-- drivers/nfc/nfcmrvl/usb.c | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/nfcmrvl/main.c

Re: [PATCH v6] USB: serial: option: add D-Link DWM-222 device ID

2019-07-17 Thread Johan Hovold
On Wed, Jul 17, 2019 at 11:11:34AM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222 A2. > > MI_00 D-Link HS-USB Diagnostics > MI_01 D-Link HS-USB Modem > MI_02 D-Link HS-USB AT Port > MI_03 D-Link HS-USB NMEA > MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) > MI_05 USB Mass Storage Device

Re: WARNING in gpio_to_desc

2019-07-17 Thread Johan Hovold
(no time to play with it right now). Note that this issue has been there since 4.12, so guess no one uses these devices... Johan >From e9d9d0ef5ffd6b306cffb2f4e2514f503aa626a5 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Wed, 17 Jul 2019 11:07:13 +0200 Subject: [PATCH] NFC: nfcmrvl: fi

Re: [PATCH v2] USB: serial: option: Add support for ZTE MF871A

2019-07-16 Thread Johan Hovold
On Wed, Jul 17, 2019 at 02:40:16PM +0900, Yoshiaki Okamoto wrote: > This patch adds support for MF871A USB modem (aka Speed USB STICK U03) > to option driver. This modem is manufactured by ZTE corporation, and > sold by KDDI. > > Interface layout: > 0: AT > 1: MODEM > > usb-devices output: > T:

Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID

2019-07-16 Thread Johan Hovold
On Tue, Jul 16, 2019 at 08:43:52PM -0500, Dan Williams wrote: > On Tue, 2019-07-16 at 21:12 +0200, Rogan Dawes wrote: > > Add device id for D-Link DWM-222. > > @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = { > > .driver_info = RSVD(4) }, > > { USB_DEVICE_INTERFAC

Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID

2019-07-16 Thread Johan Hovold
On Tue, Jul 16, 2019 at 09:12:05PM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222. > > Cc: sta...@vger.kernel.org > --- > Also add the qmi_wwan entry, since it was blacklisted already in option > > Apologies for the spam! No worries, you're getting there. :) > drivers/net/usb/qmi

Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2]

2019-07-16 Thread Johan Hovold
On Tue, Jul 16, 2019 at 09:34:56PM +0700, Lars Melin wrote: > On 7/16/2019 18:17, Johan Hovold wrote: > > snip > > > Ok, thanks. Do you have any idea what all those vendor interface are > > for? Some of the other D-Link entries blacklist a speech and debug port > >

Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2]

2019-07-16 Thread Johan Hovold
On Tue, Jul 16, 2019 at 12:55:17PM +0200, Rogan Dawes wrote: > After binding the Option driver, lsusb -v -d 2001:7e3d > > Bus 001 Device 062: ID 2001:7e3d D-Link Corp. Mobile Connect > Device Descriptor: > bLength18 > bDescriptorType 1 > bcdUSB 2.01 >

Re: Fwd: Re: New USB Device

2019-07-16 Thread Johan Hovold
[ Pleas avoid top posting. ] On Sun, Jul 07, 2019 at 09:38:00PM +0200, Markus Breunig wrote: > Hi Greg, > > also the company GNS has a fragmented homepage, the handbook ist > available here: > http://www.servicedocs.com/ARTIKELEN/7200284490001.pdf > habe a look to page 10 "Remarks to Linux" > >

Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2]

2019-07-16 Thread Johan Hovold
On Thu, Jul 11, 2019 at 12:34:57PM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222. > > Cc: sta...@vger.kernel.org > Signed-Off-By: Rogan Dawes > --- > Apologies, a typo crept in when submitting this previously. Thanks for the patch, all looks good, but next time add the version inf

Re: [PATCH] USB: serial: option: Add support for ZTE MF871A

2019-07-16 Thread Johan Hovold
On Thu, Jul 11, 2019 at 03:53:24PM +0900, Yoshiaki Okamoto wrote: > This patch adds support for MF871A USB modem (aka Speed USB STICK U03) > to option driver. This modem is manufactured by ZTE corporation, and > sold by KDDI. > > Interface layout: > 0: AT > 1: MODEM > > usb-devices output: > T:

Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-07-16 Thread Johan Hovold
On Tue, Jul 02, 2019 at 08:30:06PM +0800, Charles Yeh wrote: > Prolific has developed a new USB to UART chip: PL2303HXN > PL2303HXN : PL2303GC/PL2303GS/PL2303GT/PL2303GL/PL2303GE/PL2303GB > The Vendor request used by the PL2303HXN (TYPE_HXN) is different from > the existing PL2303 series (TYPE_HX &

Re: [PATCH] [PATCH v6] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-07-16 Thread Johan Hovold
[ Please do not top post, reply inline and trim irrelevant context. Specifically do not copy context to the top of the mail. Reordering your reply below. ] On Wed, Jul 03, 2019 at 12:22:45AM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年7月1日 週一 下午11:29寫道: > > On Mon, Jul 01, 2019

[GIT PULL] USB-serial updates for 5.3-rc1

2019-07-02 Thread Johan Hovold
have been in linux-next with no reported issues. Signed-off-by: Johan Hovold Andreas Fritiofson (1): USB: serial: ftdi_sio: add ID for isodebug v1 Jörgen Storvist (1): USB: serial: option: add support for GosunCn ME3630

Re: [PATCH] [PATCH v6] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-07-01 Thread Johan Hovold
On Mon, Jul 01, 2019 at 11:11:02PM +0800, Charles Yeh wrote: > > > + if (spriv->quirks & PL2303_QUIRK_LEGACY) { > > > + pl2303_update_reg(serial, 0, PL2303_FLOWCTRL_MASK, > > > + 0x40); > > > > No need to break this line even if you end up

Re: [PATCH] [PATCH v6] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-07-01 Thread Johan Hovold
On Mon, Jul 01, 2019 at 03:32:33PM +0200, Johan Hovold wrote: > On Mon, Jul 01, 2019 at 08:21:14PM +0800, Charles Yeh wrote: > > #define PL2303_FLOWCTRL_MASK 0xf0 > > +#define PL2303_HXN_FLOWCTRL_MASK 0x1C > > Move after PL2303_HXN_RESET_CONTROL as I sugge

Re: [PATCH] [PATCH v6] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-07-01 Thread Johan Hovold
On Mon, Jul 01, 2019 at 08:21:14PM +0800, Charles Yeh wrote: > Prolific has developed a new USB to UART chip: PL2303HXN > PL2303HXN : PL2303GC/PL2303GS/PL2303GT/PL2303GL/PL2303GE/PL2303GB > The Vendor request used by the PL2303HXN (TYPE_HXN) is different from > the existing PL2303 series (TYPE_HX &

Re: [PATCH] [PATCH v5] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-06-28 Thread Johan Hovold
On Thu, Jun 13, 2019 at 09:45:44PM +0800, Charles Yeh wrote: > Prolific has developed a new USB to UART chip: PL2303HXN > PL2303HXN : PL2303GC/PL2303GS/PL2303GT/PL2303GL/PL2303GE/PL2303GB > The Vendor request used by the PL2303HXN (TYPE_HXN) is different from > the existing PL2303 series (TYPE_HX &

Re: [PATCH] gpss: core: no waiters left behind on deregister

2019-06-26 Thread Johan Hovold
On Wed, Jun 26, 2019 at 01:04:07PM +0200, Oliver Neukum wrote: > Am Dienstag, den 25.06.2019, 09:04 +0200 schrieb Johan Hovold: > > On Mon, Jun 24, 2019 at 10:33:23AM +0200, Oliver Neukum wrote: > > > If you deregister a device you need to wake up all waiters > > >

Re: [PATCH] gpss: core: no waiters left behind on deregister

2019-06-25 Thread Johan Hovold
On Mon, Jun 24, 2019 at 10:33:23AM +0200, Oliver Neukum wrote: > If you deregister a device you need to wake up all waiters > as there will be no further wakeups. > > Signed-off-by: Oliver Neukum > --- > drivers/gnss/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [usb:usb-testing 46/46] drivers/usb//misc/adutux.c:375:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}'

2019-06-20 Thread Johan Hovold
On Thu, Jun 20, 2019 at 08:01:30AM -0700, dmg wrote: > > kbuild test robot writes: > > [...] > > > > All warnings (new ones prefixed by >>): > > > >In file included from include/linux/printk.h:332:0, > > from include/linux/kernel.h:15, > > from drivers

Re: [PATCH] USB: serial: ch341: fix wrong baud rate setting calculation

2019-06-20 Thread Johan Hovold
On Sat, Jun 08, 2019 at 05:13:09PM +1200, jontio wrote: > For some wanted baud rates ch341_set_baudrate_lcr() calculates the "a" > value such that it produces a significantly different baud rate than the > desired one. This means some hardware can't communicate with the CH34x > chip. Particularly o

Re: linux/drivers/usb/serial/ch341.c calculates some baud rates wrong

2019-06-20 Thread Johan Hovold
On Mon, Jun 10, 2019 at 02:32:16PM +1200, Jonathan Olds wrote: > Hi Johan, > > Thanks for the info. I followed > https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patc > h-to-the-linux-kernel-and-responding-to-feedback/ and made a proposal patch > ("[PATCH] USB: serial: ch341

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-19 Thread Johan Hovold
On Wed, Jun 19, 2019 at 09:33:40AM +0300, Felipe Balbi wrote: > Johan Hovold writes: > > Are you sure you actually did register two xhci debug ttys? > > hmm, let me check: ... > Hmm, so it only really registers after writing to sysfs file. Man, this > is an odd d

Re: [PATCH] USB: serial: option: add support for GosunCn ME3630 RNDIS mode

2019-06-19 Thread Johan Hovold
On Wed, Jun 19, 2019 at 12:30:19AM +0200, Jörgen Storvist wrote: > Added USB IDs for GosunCn ME3630 cellular module in RNDIS mode. > > T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=03 Dev#= 18 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=19d2 ProdID=0601 Rev=

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-18 Thread Johan Hovold
On Mon, Jun 17, 2019 at 09:43:19AM +0300, Felipe Balbi wrote: > > Hi, > > Johan Hovold writes: > > On Tue, Jun 11, 2019 at 08:24:16PM +0300, Felipe Balbi wrote: > >> If we happen to have two XHCI controllers with DbC capability, then > >> there's

Re: [PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-14 Thread Johan Hovold
On Tue, Jun 11, 2019 at 08:24:16PM +0300, Felipe Balbi wrote: > If we happen to have two XHCI controllers with DbC capability, then > there's no hope this will ever work as the global pointer will be > overwritten by the controller that probes last. > > Avoid this problem by keeping the tty_driver

Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)

2019-06-12 Thread Johan Hovold
On Wed, Jun 12, 2019 at 09:18:41PM +0800, Charles Yeh wrote: > Prolific has developed a new USB to UART chip: PL2303HXN > PL2303HXN : PL2303GC/PL2303GS/PL2303GT/PL2303GL/PL2303GE/PL2303GB > The Vendor request used by the PL2303HXN (TYPE_HXN) is different from > the existing PL2303 series (TYPE_HX &

[GIT PULL] USB-serial fixes for 5.2-rc5

2019-06-10 Thread Johan Hovold
linux-next with no reported issues. Signed-off-by: Johan Hovold Chris Packham (1): USB: serial: pl2303: add Allied Telesis VT-Kit3 Daniele Palmas (1): USB: serial: option: add Telit 0x1260 and 0x1261 compositions Jörgen

Re: [PATCH] usb: chipidea: Use dev_err() instead of pr_err()

2019-06-03 Thread Johan Hovold
On Mon, Jun 03, 2019 at 11:09:01PM -0300, Fabio Estevam wrote: > dev_err() is more appropriate for printing error messages inside > drivers, so switch to dev_err(). > > Signed-off-by: Fabio Estevam > --- > drivers/usb/chipidea/core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >

  1   2   3   4   5   6   7   8   9   10   >