Re: [PATCH] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-16 Thread Greg KH
On Wed, Oct 16, 2019 at 01:38:25PM +0900, GwanYeong Kim wrote: > On Tue, 15 Oct 2019 17:14:32 -0600 > shuah wrote: > > > On 10/15/19 7:14 AM, GwanYeong Kim wrote: > > > cannot be less than 0 - fread() returns 0 on error. > > > > > > Signed-off-by: GwanYeong Kim > > > --- > > > tools/usb/usbip

Re: [PATCH v2] usb: usbfs: Suppress problematic bind and unbind uevents.

2019-10-15 Thread Greg KH
On Fri, Oct 11, 2019 at 01:55:18PM +0200, Ingo Rohloff wrote: > commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound > to a driver") added bind and unbind uevents when a driver is bound or > unbound to a physical device. > > For USB devices which are handled via the generic usbfs l

Re: [PATCH] usb: usbfs: Suppress problematic bind and unbind uevents.

2019-10-10 Thread Greg KH
On Thu, Oct 10, 2019 at 06:48:00PM +0200, Ingo Rohloff wrote: > commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound > to a driver") added bind and unbind uevents when a driver is bound or > unbound to a physical device. > > For USB devices which are handled via the generic usbfs l

Re: [PATCH] USB: usbfs: Suppress emission of uevents for interfaces handled via usbfs

2019-10-10 Thread Greg KH
On Wed, Oct 09, 2019 at 12:38:35PM +0200, Ingo Rohloff wrote: > >From 17d1e75543e26cfe702e7f5b0d4e07e0e45e5250 Mon Sep 17 00:00:00 2001 > From: Ingo Rohloff > Date: Tue, 8 Oct 2019 20:27:57 +0200 > Subject: [PATCH] USB: usbfs: Suppress emission of uevents for interfaces > handled via usbfs. No n

Re: Unknown symbol errors in usb storage driver

2019-10-08 Thread Greg KH
On Tue, Oct 08, 2019 at 09:53:16PM +0200, Heiner Kallweit wrote: > Since a while I see the following. I didn't bisect yet, maybe issue is caused > by > 32bca2df7da2 ("usb-storage: export symbols in USB_STORAGE namespace")? > > DEPMOD 5.4.0-rc2-next-20191008+ > depmod: WARNING: > /lib/modules/

Re: [PATCH] usbfs: Suppress uevents for claiminterface/releaseinterface

2019-10-08 Thread Greg KH
On Tue, Oct 08, 2019 at 09:32:10PM +0200, Ingo Rohloff wrote: > Hello, > > With recent Ubuntu 18/Linux Mint 19.2 etc, lots of user space programs > (in particular systemd/eudev/upowerd) have problems with the "BIND/UNBIND" > events produced since kernel 4.13. > Some problems are described, when

Re: CREAD ignored by almost all USB serial drivers

2019-10-08 Thread Greg KH
On Mon, Oct 07, 2019 at 03:18:52PM +0200, Harald Welte wrote: > Hi Greg, > > On Mon, Oct 07, 2019 at 01:06:33PM +0200, Greg KH wrote: > > On Sat, Sep 28, 2019 at 10:49:55PM +0200, Harald Welte wrote: > > > It seems that a lot of Linux kernel USB serial device drivers are

Re: [PATCH v4] usb: hub: Check device descriptor before resusciation

2019-10-08 Thread Greg KH
On Tue, Oct 08, 2019 at 06:10:22PM +0200, David Heinzelmann wrote: > On Tue, Oct 08, 2019 at 02:55:46PM +0200, Greg KH wrote: > > What happened to Alan's ack? > > > > I'm not sure I'm allowed to add someone else's acked-by tag? If they provide it, and

Re: [PATCH v4] usb: hub: Check device descriptor before resusciation

2019-10-08 Thread Greg KH
On Tue, Oct 08, 2019 at 10:09:01AM +0200, David Heinzelmann wrote: > If a device connected to an xHCI host controller disconnects from the USB bus > and then reconnects, e.g. triggered by a firmware update, then the host > controller automatically activates the connection and the port is enabled. T

Re: [PATCH] Check for changed device descriptors when a connection-change occurs before validating the connection.

2019-10-07 Thread Greg KH
On Mon, Oct 07, 2019 at 10:01:47AM -0400, Alan Stern wrote: > On Mon, 7 Oct 2019, David Heinzelmann wrote: > > > Hi, > > > > I hope it all fits now. > > > > David > > > > > > From 8517ecfac0175aebba03bb0868dde652bc3c36e5 Mon Sep 17 00:00:00 2001 > > From: David Heinzelmann > > Date: Fri, 4 Oc

Re: CREAD ignored by almost all USB serial drivers

2019-10-07 Thread Greg KH
On Sat, Sep 28, 2019 at 10:49:55PM +0200, Harald Welte wrote: > [Copied on requst from https://bugzilla.kernel.org/show_bug.cgi?id=205033] > > It seems that a lot of Linux kernel USB serial device drivers are > ignoring the CREAD setting of termios.c_cflag. > > The man page is quite clear: >

Re: [PATCH] drivers: musb: removed unused status variable

2019-10-04 Thread Greg KH
On Wed, Oct 02, 2019 at 11:09:13PM +0530, aliasgar.surti...@gmail.com wrote: > From: Aliasgar Surti > > Status variable is initialized and returned without updating it's value. > Removed status variable and returned value directly. > > Signed-off-by: Aliasgar Surti > --- > drivers/usb/musb/mus

Re: Driver for something that's neither a device nor an interface driver?

2019-09-28 Thread Greg KH
On Sat, Sep 28, 2019 at 02:37:21PM +0200, Bastien Nocera wrote: > On Sat, 2019-09-28 at 14:18 +0200, Greg KH wrote: > > Again, the power_supply api is for power going the other way in the > > system. That's not an "existing clearly defined API in kernel > > spac

Re: Driver for something that's neither a device nor an interface driver?

2019-09-28 Thread Greg KH
On Sat, Sep 28, 2019 at 12:42:21PM +0200, Bastien Nocera wrote: > On Sat, 2019-09-28 at 09:39 +0200, Greg KH wrote: > > On Fri, Sep 27, 2019 at 10:12:14PM +0200, Bastien Nocera wrote: > > > On Fri, 2019-09-27 at 21:25 +0200, Greg KH wrote: > > > > On Fri, Sep 27, 201

Re: Driver for something that's neither a device nor an interface driver?

2019-09-28 Thread Greg KH
On Fri, Sep 27, 2019 at 10:12:14PM +0200, Bastien Nocera wrote: > On Fri, 2019-09-27 at 21:25 +0200, Greg KH wrote: > > On Fri, Sep 27, 2019 at 08:49:12PM +0200, Bastien Nocera wrote: > > > On Fri, 2019-09-27 at 13:56 -0400, Alan Stern wrote: > > > > > > &g

Re: Driver for something that's neither a device nor an interface driver?

2019-09-27 Thread Greg KH
On Fri, Sep 27, 2019 at 08:49:12PM +0200, Bastien Nocera wrote: > On Fri, 2019-09-27 at 13:56 -0400, Alan Stern wrote: > > > > > Is there any reason this needs to be done in a kernel driver? > > To offer a unified interface all the devices with similar needs. What "other devices with similar ne

Re: Driver for something that's neither a device nor an interface driver?

2019-09-27 Thread Greg KH
On Fri, Sep 27, 2019 at 07:44:08PM +0200, Bastien Nocera wrote: > On Fri, 2019-09-27 at 19:38 +0200, Greg KH wrote: > > What does the usb descriptors for the device look like? Is it only > > the > > "default" control endpoint and no interfaces? What does the outp

Re: Driver for something that's neither a device nor an interface driver?

2019-09-27 Thread Greg KH
On Fri, Sep 27, 2019 at 07:29:52PM +0200, Bastien Nocera wrote: > Hey, > > I'm trying to write a "power supply" class driver for Apple MFi > devices, and struggling a little with the USB drivers. > > To ask many Apple devices to draw more power, we need to make a call to > the device using a vend

Re: [PATCH -next] usb: cdns3: Fix sheduling with locks held.

2019-09-26 Thread Greg KH
On Thu, Sep 26, 2019 at 08:00:30AM +0100, Pawel Laszczak wrote: > Patch fix issue in cdns3_ep0_feature_handle_device function. > > The function usleep_range can't be used there because this function is > called with locks held and IRQs disabled in > cdns3_device_thread_irq_handler(). > > To resol

Re: [PATCH -next] usb: cdns3: Fix sheduling with locks held.

2019-09-25 Thread Greg KH
On Thu, Sep 26, 2019 at 07:19:27AM +0100, Pawel Laszczak wrote: > Patch fix issue in cdns3_ep0_feature_handle_device function. > > The function usleep_range can't be used there because this function is > called with locks held and IRQs disabled in > cdns3_device_thread_irq_handler(). > > To resol

Re: [PATCH 1/1] usb: serial: option: add Telit FN980 compositions

2019-09-23 Thread Greg KH
On Mon, Sep 23, 2019 at 11:51:42AM +0200, Daniele Palmas wrote: > This patch adds the following Telit FN980 compositions: > > 0x1050: tty, adb, rmnet, tty, tty, tty, tty > 0x1051: tty, adb, mbim, tty, tty, tty, tty > 0x1052: rndis, tty, adb, tty, tty, tty, tty > 0x1053: tty, adb, ecm, tty, tty, tt

Re: Failed to connect to 4G modem

2019-09-20 Thread Greg KH
On Sat, Sep 21, 2019 at 08:10:30AM +1000, JH wrote: > Hi Greg, > > On 9/18/19, Greg KH wrote: > > Otherwise, just use 5.3 now and then 5.4 when it comes out in a few > > months. > > My apology for an off topic question. I discussed with my colleague to > use 5.3,

Re: [PATCH] Check for changed device descriptors when a connection-change occurs before validating the connection.

2019-09-20 Thread Greg KH
On Fri, Sep 20, 2019 at 03:17:26PM +0200, David Heinzelmann wrote: > Hi, > > sorry for the wrong patch format. No problem, that's normal. But please do not top-post on linux mailing lists. > I am trying to detect a change. At the moment I think the change could be > ignored if a > port connect

Re: [PATCH] Check for changed device descriptors when a connection-change occurs before validating the connection.

2019-09-20 Thread Greg KH
On Fri, Sep 20, 2019 at 12:36:28PM +0200, David Heinzelmann wrote: > When a port connection-change occurs the hub driver tries to resuscitate an > existing device. > Activated from a firmware download a usb device can re-enumerate with new or > changed device > descriptors. Therefore it will be c

Re: [PATCH] USB: serial: add port statistics

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 01:51:29PM +0200, Yegor Yefremov wrote: > On Wed, Sep 18, 2019 at 1:45 PM Greg KH wrote: > > > > On Wed, Sep 18, 2019 at 01:22:42PM +0200, Yegor Yefremov wrote: > > > On Wed, Sep 18, 2019 at 1:08 PM Greg KH > > > wrote: > > > &g

Re: [PATCH] USB: serial: add port statistics

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 01:22:42PM +0200, Yegor Yefremov wrote: > On Wed, Sep 18, 2019 at 1:08 PM Greg KH wrote: > > > > On Wed, Sep 18, 2019 at 11:14:15AM +0200, yegorsli...@googlemail.com wrote: > > > From: Yegor Yefremov > > > > > > Add additional por

Re: [PATCH] USB: serial: add port statistics

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 11:14:15AM +0200, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Add additional port statistics like received and transmitted bytes > the way /proc/tty/driver/serial does. > > As usbserial driver already provides USB related information and > this line is lo

Re: Failed to connect to 4G modem

2019-09-17 Thread Greg KH
On Wed, Sep 18, 2019 at 07:38:14AM +1000, JH wrote: > Hi Greg, > > On 9/17/19, Greg KH wrote: > > On Tue, Sep 17, 2019 at 09:29:34PM +1000, JH wrote: > >> Hi, > >> > >> I am running kernel LTS 4.19 in an i.MX6 board with a 4G LTE modem, it > >

Re: Failed to connect to 4G modem

2019-09-17 Thread Greg KH
On Tue, Sep 17, 2019 at 09:29:34PM +1000, JH wrote: > Hi, > > I am running kernel LTS 4.19 in an i.MX6 board with a 4G LTE modem, it > continually displayed following messages in a serial port tried and > failed to connect to LTE modem, are there any problems in kernel 4.19 > LTS to support usb qm

Re: patch "usbip: tools: fix GCC8 warning for strncpy" added to usb-next

2019-09-16 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH v3 3/3] net: cdc_ncm: Add ACPI MAC address pass through functionality

2019-09-06 Thread Greg KH
On Thu, Sep 05, 2019 at 08:51:15PM -0500, Charles Hyde wrote: > This change adds support to cdc_ncm for ACPI MAC address pass through > functionality that also exists in the Realtek r8152 driver. This is in > support of Dell's Universal Dock D6000, to give it the same feature > capability as is cu

Re: [PATCH 0/3] Add get/set ethernet address functions and ACPI MAC address pass through functionality to cdc_ncm driver

2019-09-05 Thread Greg KH
On Thu, Sep 05, 2019 at 09:14:05PM +, charles.h...@dellteam.com wrote: > > > -Original Message- > > > From: Hyde, Charles - Dell Team > > > Sent: Thursday, September 5, 2019 4:02 PM > > > To: Oliver Neukum; "Rafael J. Wysocki"; Len Brown > > > Cc: Limonciello, Mario; chip.program...@gma

Re: [PATCH] usb: devio: fix mmap() on non-coherent DMA architectures

2019-09-04 Thread Greg KH
On Mon, Aug 05, 2019 at 05:17:13PM +0200, Greg KH wrote: > On Fri, Aug 02, 2019 at 10:57:00AM -0700, Gavin Li wrote: > > usbfs mmap() looks like it was introduced for 4.6 in commit > > f7d34b445abc, so it should probably be backported to 4.9 and onwards. > > This issue has b

Re: [PATCH] xhci: tegra: Parameterize mailbox register addresses

2019-09-03 Thread Greg KH
On Wed, Sep 04, 2019 at 09:43:08AM +0800, JC Kuo wrote: > On 9/3/19 9:58 PM, Greg KH wrote: > > On Mon, Sep 02, 2019 at 04:21:27PM +0800, JC Kuo wrote: > >> Tegra194 XUSB host controller has rearranged mailbox registers. This > >> commit makes mailbox registers address a

Re: [PATCH] USB: rio500: Fix lockdep violation

2019-09-03 Thread Greg KH
On Thu, Aug 15, 2019 at 10:47:45AM -0400, Alan Stern wrote: > On Thu, 15 Aug 2019, Greg KH wrote: > > > On Thu, Aug 08, 2019 at 02:23:00PM -0400, Alan Stern wrote: > > > On Thu, 8 Aug 2019, Greg KH wrote: > > > > > > > On Thu, Aug 08, 2019 at 01:34:0

Re: [PATCH] xhci: tegra: Parameterize mailbox register addresses

2019-09-03 Thread Greg KH
On Mon, Sep 02, 2019 at 04:21:27PM +0800, JC Kuo wrote: > Tegra194 XUSB host controller has rearranged mailbox registers. This > commit makes mailbox registers address a part of "soc" data so that > xhci-tegra driver can be used for Tegra194. > > Signed-off-by: JC Kuo > --- > drivers/usb/host/xh

Re: [PATCH RESEND] xhci: Prevent deadlock when xhci adapter breaks during init

2019-09-03 Thread Greg KH
On Thu, Aug 29, 2019 at 02:12:15PM -0400, Bill Kuzeja wrote: > The system can hit a deadlock if xhci adapter breaks while initializing. > The deadlock is between two threads: thread 1 is tearing down the > adapter and is stuck in usb_unlocked_disable_lpm waiting to lock the > hcd->handwidth_mute

Re: Adding "UAS" protocol line to usb.ids file?

2019-09-03 Thread Greg KH
On Sat, Aug 17, 2019 at 06:01:45PM -0400, Nathan Stratton Treadway wrote: > I noticed that when I use "lsusb -v" on a UAS-enabled drive enclosure, > the bInterfaceProtocol line for #80/0x50 has a "protocol name" label but the > one for #98/0x62 does not: > > > > # lsusb -v -s2:15 | grep

Re: [PATCH v3 2/2] USB: storage: ums-realtek: Whitelist auto-delink support

2019-08-27 Thread Greg KH
On Tue, Aug 27, 2019 at 02:56:36PM -0400, Alan Stern wrote: > On Wed, 28 Aug 2019, Kai-Heng Feng wrote: > > > Auto-delink requires writing special registers to ums-realtek devices. > > Unconditionally enable auto-delink may break newer devices. > > > > So only enable auto-delink by default for th

Re: [PATCH 2/2] USB: storage: ums-realtek: Enable auto-delink optionally

2019-08-25 Thread Greg KH
On Mon, Aug 26, 2019 at 12:46:30PM +0800, Kai-Heng Feng wrote: > Auto-delink requires writing special registers to ums-realtek device. > Unconditionally enable auto-delink may break newer devices. > > So only enable auto-delink by default for the original three IDs, > 0x0138, 0x0158 and 0x0159. >

Re: [PATCH 1/2] USB: storage: ums-realtek: Rename module parameter auto_delink_en to auto_delink_mode

2019-08-25 Thread Greg KH
On Mon, Aug 26, 2019 at 12:46:29PM +0800, Kai-Heng Feng wrote: > The option named "auto_delink_en" is a bit misleading, as setting it to > false doesn't really disable auto-delink but let auto-delink be firmware > controlled. > > Rename it to reflect the real usage of this parameter. > > Signed-o

Re: [Patch v5] usb: hcd: use managed device resources

2019-08-25 Thread Greg KH
On Fri, Aug 23, 2019 at 02:11:28PM +, Schmid, Carsten wrote: > Using managed device resources in usb_hcd_pci_probe() allows devm usage for > resource subranges, such as the mmio resource for the platform device > created to control host/device mode mux, which is a xhci extended > capability, an

Re: [RFC 2/3] ACPI: move ACPI functionality out of r8152 driver

2019-08-23 Thread Greg KH
On Fri, Aug 23, 2019 at 10:28:24PM +, charles.h...@dellteam.com wrote: > --- /dev/null > +++ b/lib/acpi_mac_passthru.c > @@ -0,0 +1,61 @@ > +/* > + * Copyright (c) 2019 Dell Technology. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or > + * modify

Re: [PATCH v5 1/2] usbip: Skip DMA mapping and unmapping for urb at vhci

2019-08-22 Thread Greg KH
On Fri, Aug 09, 2019 at 12:54:34AM +0900, Suwan Kim wrote: > vhci doesn’t do DMA for remote device. Actually, the real DMA > operation is done by network card driver. vhci just passes virtual > address of the buffer to the network stack, so vhci doesn’t use and > need dma address of the buffer of t

Re: problems with Edgeport/416

2019-08-21 Thread Greg KH
On Wed, Aug 21, 2019 at 03:04:48PM +0200, walter harms wrote: > > > Am 21.08.2019 14:20, schrieb Greg KH: > > On Wed, Aug 21, 2019 at 01:48:46PM +0200, walter harms wrote: > >> > >> > >> Am 21.08.2019 13:20, schrieb Greg KH: > >>> On Wed

Re: [PATCH v3 09/11] usb-storage: remove single-use define for debugging

2019-08-21 Thread Greg KH
On Wed, Aug 21, 2019 at 03:21:22PM +0200, Thomas Gleixner wrote: > On Wed, 21 Aug 2019, Matthias Maennich wrote: > > > USB_STORAGE was defined as "usb-storage: " and used in a single location > > as argument to printk. In order to be able to use the name > > 'USB_STORAGE', drop the definition and

Re: [PATCH v3 10/11] RFC: usb-storage: export symbols in USB_STORAGE namespace

2019-08-21 Thread Greg KH
On Wed, Aug 21, 2019 at 12:49:25PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Define DEFAULT_SYMBOL_NAMES

Re: [PATCH v3 09/11] usb-storage: remove single-use define for debugging

2019-08-21 Thread Greg KH
On Wed, Aug 21, 2019 at 12:49:24PM +0100, Matthias Maennich wrote: > USB_STORAGE was defined as "usb-storage: " and used in a single location > as argument to printk. In order to be able to use the name > 'USB_STORAGE', drop the definition and use the string directly for the > printk call. > > Sig

Re: f_mass_storage vs drivers/target

2019-08-21 Thread Greg KH
On Wed, Aug 21, 2019 at 01:38:49PM +1000, Benjamin Herrenschmidt wrote: > Hi folks ! > > It seems that f_mass_storage duplicates (well maybe predates too..) a > lot of what's in drivers/target. It predates it by a long time. > Anybody working on implementing a new version of f_mass_storage that

Re: [RFC 1/4] Add usb_get_address and usb_set_address support

2019-08-20 Thread Greg KH
On Tue, Aug 20, 2019 at 10:18:42PM +, charles.h...@dellteam.com wrote: > +int usb_get_address(struct usb_device *dev, unsigned char * mac) > +{ > + int ret = -ENOMEM; > + unsigned char *tbuf = kmalloc(256, GFP_NOIO); On a technical level, why are you asking for 256 bytes here, and in t

Re: [RFC 1/4] Add usb_get_address and usb_set_address support

2019-08-20 Thread Greg KH
On Tue, Aug 20, 2019 at 10:18:42PM +, charles.h...@dellteam.com wrote: > The core USB driver message.c is missing get/set address functionality > that stops ifconfig from being able to push MAC addresses out to USB > based ethernet devices. Without this functionality, some USB devices > stop r

Re: [PATCH] usb: usb251xb: drop some unused defines

2019-08-19 Thread Greg KH
On Mon, Aug 19, 2019 at 12:02:11PM +0200, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König > --- > drivers/usb/misc/usb251xb.c | 5 - > 1 file changed, 5 deletions(-) I can't take a patch without any changelog text. And you forgot to cc: the usb maintainer, so there's no way this w

[GIT PULL] USB fixes for 5.3-rc5

2019-08-18 Thread Greg KH
The following changes since commit d45331b00ddb179e291766617259261c112db872: Linux 5.3-rc4 (2019-08-11 13:26:41 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.3-rc5 for you to fetch changes up to 6a5f43d1d8bd3779e428178

Re: kernel 5.2.7 support for usb Apple Superdrive is broken

2019-08-16 Thread Greg KH
On Fri, Aug 16, 2019 at 02:24:18PM -0500, David Walthour wrote: > I am new to this mailing list, so please go easy on me if I'm breaking > etiquete. > > Upgraded my Fedora 30 install from linux kernel 5.2.6 to 5.2.7 (and > 5.2.8) and my apple usb superdrive stopped working. Booting up in 5.2.6 > a

Re: [PATCH v5 0/2] usbip: Implement SG support

2019-08-15 Thread Greg KH
On Wed, Aug 14, 2019 at 06:19:51AM -0700, Christoph Hellwig wrote: > FYI, I think my > >"usb: add a HCD_DMA flag instead of guestimating DMA capabilities" > > is the proper core fix for what your patch 1 works around, as the USB > core should not assume DMA capabilities based on the presence

Re: [PATCH] usb: usbfs: only account once for mmap()'ed usb memory usage

2019-08-15 Thread Greg KH
On Wed, Aug 14, 2019 at 02:29:24PM -0700, gavi...@thegavinli.com wrote: > From: Gavin Li > > Memory usage for USB memory allocated via mmap() is already accounted > for at mmap() time; no need to account for it again at submiturb time. > > Signed-off-by: Gavin Li > --- > drivers/usb/core/devio

Re: [PATCH] USB: rio500: Fix lockdep violation

2019-08-15 Thread Greg KH
On Thu, Aug 08, 2019 at 02:23:00PM -0400, Alan Stern wrote: > On Thu, 8 Aug 2019, Greg KH wrote: > > > On Thu, Aug 08, 2019 at 01:34:08PM -0400, Alan Stern wrote: > > > The syzbot fuzzer found a lockdep violation

Re: USB disconnect due to error from flowcontrol urb

2019-08-15 Thread Greg KH
On Thu, Aug 15, 2019 at 10:41:05AM +0200, Bjoern wrote: > Hi, > > > I'm running on Ubuntu Bionic 4.14.94-155 on an odroid-x4 (armhf). > > > I have a FT230X Basic UART (0403:6015) plugged into the exynos-ohci USB. The > device is linked via a udev rule to a "symbolic/virtual" device so that the

Re: [PATCH] From: cy_huang Subject: usb: add more vendor defined ops in tcpci

2019-08-15 Thread Greg KH
On Thu, Aug 15, 2019 at 12:19:13PM +0800, cy_huang wrote: > diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h > index 303ebde..a6754fb 100644 > --- a/drivers/usb/typec/tcpm/tcpci.h > +++ b/drivers/usb/typec/tcpm/tcpci.h > @@ -130,6 +130,11 @@ struct tcpci_data { >

Re: [PATCH] From: cy_huang Subject: usb: add more vendor defined ops in tcpci

2019-08-15 Thread Greg KH
On Thu, Aug 15, 2019 at 12:19:13PM +0800, cy_huang wrote: > From: cy_huang Your subject line is a bit odd :) Also, we need a "real" name here, and in the signed-off-by line, not an email prefix. Please fix up and resend. thanks, greg k-h

Re: TL-MR3420 with OpenWRT with a huawei E353 usb dongle

2019-08-14 Thread Greg KH
On Wed, Aug 14, 2019 at 11:42:53AM -0300, Francisco Ferreiro wrote: > Hi guys, this is me trying to setup a tp-link TL-MR3420 with OpenWRT > with a huawei E353 usb dongle > > hopefully I will try to setup a multiwan along with this two more > sources to get redundant access to internet > - a ce

Re: [PATCH v2 07/10] modpost: add support for generating namespace dependencies

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:04PM +0100, Matthias Maennich wrote: > This patch adds an option to modpost to generate a .ns_deps file > per module, containing the namespace dependencies for that module. > > E.g. if the linked module my-module.ko would depend on the symbol > myfunc.MY_NS in the nam

Re: [PATCH v2 05/10] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:02PM +0100, Matthias Maennich wrote: > If MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is enabled (default=n), the > requirement for modules to import all namespaces that are used by > the module is relaxed. > > Enabling this option effectively allows (invalid) modules to b

Re: [PATCH v2 06/10] export: allow definition default namespaces in Makefiles or sources

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:03PM +0100, Matthias Maennich wrote: > To avoid excessive usage of EXPORT_SYMBOL_NS(sym, MY_NAMESPACE), where > MY_NAMESPACE will always be the namespace we are exporting to, allow > exporting all definitions of EXPORT_SYMBOL() and friends by defining > DEFAULT_SYMBOL_

Re: [PATCH v2 06/10] export: allow definition default namespaces in Makefiles or sources

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:03PM +0100, Matthias Maennich wrote: > To avoid excessive usage of EXPORT_SYMBOL_NS(sym, MY_NAMESPACE), where > MY_NAMESPACE will always be the namespace we are exporting to, allow > exporting all definitions of EXPORT_SYMBOL() and friends by defining > DEFAULT_SYMBOL_

Re: [PATCH v2 04/10] modpost: add support for symbol namespaces

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:01PM +0100, Matthias Maennich wrote: > Add support for symbols that are exported into namespaces. For that, > extract any namespace suffix from the symbol name. In addition, emit a > warning whenever a module refers to an exported symbol without > explicitly importing

Re: [PATCH v2 03/10] module: add support for symbol namespaces.

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:00PM +0100, Matthias Maennich wrote: > The EXPORT_SYMBOL_NS() and EXPORT_SYMBOL_NS_GPL() macros can be used to > export a symbol to a specific namespace. There are no _GPL_FUTURE and > _UNUSED variants because these are currently unused, and I'm not sure > they are ne

Re: KASAN: use-after-free Read in device_release_driver_internal

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 03:22:15PM +0200, Oliver Neukum wrote: > Am Dienstag, den 13.08.2019, 14:42 +0200 schrieb Andrey Konovalov: > > > > > > [..] > > > On Thu, Aug 8, 2019 at 4:00 PM Alan Stern wrote: > > > Ah, that looks right, thank you. The patch worked correctly -- good > > > work Oliv

Re: [PATCH v2 09/10] usb-storage: remove single-use define for debugging

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 02:42:59PM +0200, Greg KH wrote: > On Tue, Aug 13, 2019 at 01:17:06PM +0100, Matthias Maennich wrote: > > USB_STORAGE was defined as "usb-storage: " and used in a single location > > as argument to printk. In order to be able to use the name &g

Re: [PATCH v2 10/10] RFC: usb-storage: export symbols in USB_STORAGE namespace

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:07PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Define DDEFAULT_SYMBOL_NAME

Re: [PATCH v2 10/10] RFC: usb-storage: export symbols in USB_STORAGE namespace

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:07PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Define DDEFAULT_SYMBOL_NAME

Re: [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies.

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote: > A script that uses the '.ns_deps' file generated by modpost to > automatically add the required symbol namespace dependencies to each > module. > > Usage: > 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define >

Re: [PATCH v2 09/10] usb-storage: remove single-use define for debugging

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:17:06PM +0100, Matthias Maennich wrote: > USB_STORAGE was defined as "usb-storage: " and used in a single location > as argument to printk. In order to be able to use the name > 'USB_STORAGE', drop the definition and use the string directly for the > printk call. > > Sig

Re: [PATCH v2 02/10] export: explicitly align struct kernel_symbol

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:16:59PM +0100, Matthias Maennich wrote: > This change allows growing struct kernel_symbol without wasting bytes to > alignment. It also concretized the alignment of ksymtab entries if > relative references are used for ksymtab entries. > > struct kernel_symbol was alread

Re: [PATCH v2 01/10] module: support reading multiple values per modinfo tag

2019-08-13 Thread Greg KH
On Tue, Aug 13, 2019 at 01:16:58PM +0100, Matthias Maennich wrote: > Similar to modpost's get_next_modinfo(), introduce get_next_modinfo() in > kernel/module.c to acquire any further values associated with the same > modinfo tag name. That is useful for any tags that have multiple > occurrences (su

Re: [PATCH] USB: core: Fix races in character device registration and deregistraion

2019-08-12 Thread Greg KH
On Mon, Aug 12, 2019 at 04:11:07PM -0400, Alan Stern wrote: > The syzbot fuzzer has found two (!) races in the USB character device > registration and deregistration routines. This patch fixes the races. > > The first race results from the fact that usb_deregister_dev() sets > usb_minors[intf->mi

Re: KASAN: use-after-free Read in ld_usb_release

2019-08-12 Thread Greg KH
On Fri, Aug 09, 2019 at 12:51:00PM -0400, Alan Stern wrote: > Greg: > > See below... > > On Fri, 9 Aug 2019, syzbot wrote: > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com

Re: KASAN: use-after-free Read in ld_usb_release

2019-08-12 Thread Greg KH
On Mon, Aug 12, 2019 at 10:21:14AM -0400, Alan Stern wrote: > On Mon, 12 Aug 2019, Andrey Konovalov wrote: > > > Alan, could you submit this patch (if you haven't already)? Looks like > > it fixes this bug (and might fix some others). > > I will. I was waiting to se

Re: [PATCH] xhci: wait CNR when doing xhci resume

2019-08-12 Thread Greg KH
On Mon, Aug 12, 2019 at 03:24:52PM +0800, Rick Tseng wrote: > From: Rick > > NVIDIA 3.1 xHCI card would lose power when moving power state into D3Cold. > Thus we need to wait CNR bit to clear when xhci resmue as xhci init. > > Signed-off-by: Rick We need a "full" name on the from and signed-of

[GIT PULL] USB fixes for 5.3-rc4

2019-08-10 Thread Greg KH
The following changes since commit 609488bc979f99f805f34e9a32c1e3b71179d10b: Linux 5.3-rc2 (2019-07-28 12:47:02 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.3-rc4 for you to fetch changes up to 27709ae4e2fe6cf7da2ae45

Re: AW: AW: KASAN: use-after-free Read in usbhid_power

2019-08-09 Thread Greg KH
On Fri, Aug 09, 2019 at 01:00:25PM +, Schmid, Carsten wrote: > >> > >> @Greg: > >> I am still confident that my patch in __release_region should be taken in. > > > > Ok, submit it in a "real" way and we can consider it :) > > > > thanks, > > > > greg k-h > > Already done, linux-ker...@vger.ker

Re: AW: AW: KASAN: use-after-free Read in usbhid_power

2019-08-09 Thread Greg KH
On Fri, Aug 09, 2019 at 12:38:35PM +, Schmid, Carsten wrote: > Hi again, > > >> > >> Hey, i did not want to trigger an eartquake in the basement of the kernel > >> ;-) > >> My intention was to prevent some crashes, and help developers to find > >> their bugs. > >> I think my patch exactly do

Re: BUG: bad usercopy in ld_usb_read

2019-08-09 Thread Greg KH
On Thu, Aug 08, 2019 at 04:06:32PM -0700, Kees Cook wrote: > On Thu, Aug 08, 2019 at 02:46:54PM +0200, Greg KH wrote: > > On Thu, Aug 08, 2019 at 05:38:06AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > &g

Re: KASAN: use-after-free Read in usbhid_power

2019-08-09 Thread Greg KH
On Fri, Aug 09, 2019 at 07:35:32AM +, Schmid, Carsten wrote: > Hi all having use-after-free issues in USB shutdowns: > I hunted for a similar case in the intel_xhci_usb_sw driver. > What i have found and proposed is (from yesterday): > --- > [PATCH] kernel/resource.c: invalidate parent when fre

Re: [PATCH] USB: rio500: Fix lockdep violation

2019-08-08 Thread Greg KH
On Thu, Aug 08, 2019 at 01:34:08PM -0400, Alan Stern wrote: > The syzbot fuzzer found a lockdep violation in the rio500 driver: > > == > WARNING: possible circular locking dependency detected > 5.3.0-rc2+ #23 Not tainted >

Re: [PATCH v2] usbfs: Add ioctls for runtime power management

2019-08-08 Thread Greg KH
On Wed, Aug 07, 2019 at 10:29:50AM -0400, Alan Stern wrote: > It has been requested that usbfs should implement runtime power > management, instead of forcing the device to remain at full power as > long as the device file is open. This patch introduces that new > feature. > > It does so by addin

Re: usb zero copy dma handling

2019-08-08 Thread Greg KH
On Thu, Aug 08, 2019 at 12:07:26PM +0200, Greg KH wrote: > On Thu, Aug 08, 2019 at 10:46:24AM +0100, Robin Murphy wrote: > > On 2019-08-08 9:58 am, Greg KH wrote: > > > On Thu, Aug 08, 2019 at 10:46:36AM +0200, yvahkhfo.1df7f...@hashmail.org > > > wrote: > >

Re: BUG: bad usercopy in ld_usb_read

2019-08-08 Thread Greg KH
On Thu, Aug 08, 2019 at 05:38:06AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:e96407b4 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.t

Re: usb zero copy dma handling

2019-08-08 Thread Greg KH
On Thu, Aug 08, 2019 at 10:46:24AM +0100, Robin Murphy wrote: > On 2019-08-08 9:58 am, Greg KH wrote: > > On Thu, Aug 08, 2019 at 10:46:36AM +0200, yvahkhfo.1df7f...@hashmail.org > > wrote: > > > Hello linux-usb and linux-arm. > > > > > > Ccing securit

Re: usb zero copy dma handling

2019-08-08 Thread Greg KH
On Thu, Aug 08, 2019 at 10:46:36AM +0200, yvahkhfo.1df7f...@hashmail.org wrote: > Hello linux-usb and linux-arm. > > Ccing security@ because "the kernel dma code is mapping randomish > kernel/user mem to a user process" seems to have security implications > even though i didnt research that aspect

Re: [PATCH] usb: devio: fix mmap() on non-coherent DMA architectures

2019-08-05 Thread Greg KH
On Fri, Aug 02, 2019 at 10:57:00AM -0700, Gavin Li wrote: > usbfs mmap() looks like it was introduced for 4.6 in commit > f7d34b445abc, so it should probably be backported to 4.9 and onwards. > This issue has been present since the introduction of the feature. > > One sidenote: this patch will cau

Re: [PATCH v2] USB: Disable USB2 LPM at shutdown

2019-08-05 Thread Greg KH
On Mon, Aug 05, 2019 at 08:58:33PM +0800, Kai-Heng Feng wrote: > Hi Greg, > > at 17:22, Kai-Heng Feng wrote: > > > at 22:17, Alan Stern wrote: > > > > > > I agree with Kai-Heng, this seems like a fairly light-weight solution > > > to a reasonable problem. > > > > Thanks for your review. > >

Re: [PATCH] usb: devio: fix mmap() on non-coherent DMA architectures

2019-08-02 Thread Greg KH
On Thu, Aug 01, 2019 at 03:04:36PM -0700, gavi...@thegavinli.com wrote: > From: Gavin Li > > On architectures that are not (or are optionally) DMA coherent, > dma_alloc_coherent() returns an address into the vmalloc space, > and calling virt_to_phys() on this address returns an unusable > physica

Re: [PATCH] HID: usbhid: Use GFP_KERNEL instead of GFP_ATOMIC when applicable

2019-08-01 Thread Greg KH
On Thu, Aug 01, 2019 at 12:06:03PM +0200, walter harms wrote: > > > Am 01.08.2019 09:47, schrieb Christophe JAILLET: > > There is no need to use GFP_ATOMIC when calling 'usb_alloc_coherent()' > > here. These calls are done from probe functions and using GFP_KERNEL should > > be safe. > > The memo

Re: [PATCH 4.19.y 0/3] usb: dwc3: Prevent requests from being queued twice

2019-07-29 Thread Greg KH
On Mon, Jul 29, 2019 at 07:13:36PM +0530, Saranya Gopal wrote: > With recent changes in AOSP, adb is now using asynchronous I/O. > While adb works good for the most part, there have been issues with > adb root/unroot commands which cause adb hang. The issue is caused > by a request being queued twi

Re: [PATCH 4.19.y 2/3] usb: dwc3: gadget: prevent dwc3_request from being queued twice

2019-07-29 Thread Greg KH
On Mon, Jul 29, 2019 at 05:06:13PM +, Gopal, Saranya wrote: > > On Mon, Jul 29, 2019 at 07:13:38PM +0530, Saranya Gopal wrote: > > > From: Felipe Balbi > > > > > > [Upstream commit b2b6d601365a1acb90b87c85197d79] > > > > > > Queueing the same request twice can introduce hard-to-debug > > > pro

Re: [PATCH 4.19.y 2/3] usb: dwc3: gadget: prevent dwc3_request from being queued twice

2019-07-29 Thread Greg KH
On Mon, Jul 29, 2019 at 07:13:38PM +0530, Saranya Gopal wrote: > From: Felipe Balbi > > [Upstream commit b2b6d601365a1acb90b87c85197d79] > > Queueing the same request twice can introduce hard-to-debug > problems. At least one function driver - Android's f_mtp.c - is known > to cause this problem

Re: [PATCH 4.19.y 3/3] usb: dwc3: gadget: remove req->started flag

2019-07-29 Thread Greg KH
On Mon, Jul 29, 2019 at 07:13:39PM +0530, Saranya Gopal wrote: > From: Felipe Balbi > > [Upstream commit 7c3d7dc89e57a1d43acea935882dd8713c9e639f] > > Now that we have req->status, we don't need this extra flag > anymore. It's safe to remove it. > > Signed-off-by: Felipe Balbi > Signed-off-by:

[GIT PULL] USB fixes for 5.3-rc2

2019-07-28 Thread Greg KH
The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.3-rc2 for you to fetch changes up to d39b5bad8658d6d94cb2d98

Re: Oops in xhci_endpoint_reset

2019-07-27 Thread Greg KH
On Fri, Jul 26, 2019 at 11:15:46PM -0400, Bob Gleitsmann wrote: > Hello, > > > I have seen kernel oopses on waking from suspend to memory. I got this > twice, one dmesg with backtrace attached. The other one had the failure > in the same place in the code. > > > This is kernel 5.3.0-rc1, patche

  1   2   3   4   5   6   7   8   9   10   >