Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-15 Thread Daniel Drake
On Wed, Oct 16, 2019 at 1:52 AM Rafael J. Wysocki wrote: > On Tue, Oct 15, 2019 at 7:31 AM Daniel Drake wrote: > > It's actually coming out of D3cold here, however what happens right > > before this is that __pci_start_power_transition() calls > > pci_platform_power_transition(D0) to leave D3cold

Re: [PATCH] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-15 Thread GwanYeong Kim
On Tue, 15 Oct 2019 17:14:32 -0600 shuah wrote: > On 10/15/19 7:14 AM, GwanYeong Kim wrote: > > cannot be less than 0 - fread() returns 0 on error. > > > > Signed-off-by: GwanYeong Kim > > --- > > tools/usb/usbip/libsrc/usbip_device_driver.c | 2 +- > > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-15 Thread shuah
On 10/15/19 7:14 AM, GwanYeong Kim wrote: cannot be less than 0 - fread() returns 0 on error. Signed-off-by: GwanYeong Kim --- tools/usb/usbip/libsrc/usbip_device_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/usb/usbip/libsrc/usbip_device_driver.c b/tool

Re: USB-C dock ethernet port issue

2019-10-15 Thread Marc Fauvain
with extract from dmesg : usb 4-2-port3: Cannot enable. Maybe the USB cable is bad? usb 4-2-port3: Cannot enable. Maybe the USB cable is bad? usb 1-8.3: new high-speed USB device number 26 using xhci_hcd usb 4-2-port3: Cannot enable. Maybe the USB cable is bad? usb 4-2-port3: Cannot enable. Maybe

USB-C dock ethernet port issue

2019-10-15 Thread Marc Fauvain
Not specific to a kernel version as I've been seeing the bug since kernel 4.8. When connecting a macbookpro 14,1 to a USB dock (from Pluggable) with Ethernet, USB and Audio via provided (Pluggable) USB-C cable, Ethernet port is not always recognized with provided dmesg. Strange because when connec

Re: [PATCH v2 3/6] USB: Implement usb_device_match_id()

2019-10-15 Thread Alan Stern
On Tue, 15 Oct 2019, Bastien Nocera wrote: > Match a usb_device with a table of IDs. > > Signed-off-by: Bastien Nocera > --- > drivers/usb/core/driver.c | 15 +++ > include/linux/usb.h | 2 ++ > 2 files changed, 17 insertions(+) > > diff --git a/drivers/usb/core/driver.c b/d

Re: [PATCH v2] usb: usbfs: Suppress problematic bind and unbind uevents.

2019-10-15 Thread Greg KH
On Fri, Oct 11, 2019 at 01:55:18PM +0200, Ingo Rohloff wrote: > commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound > to a driver") added bind and unbind uevents when a driver is bound or > unbound to a physical device. > > For USB devices which are handled via the generic usbfs l

Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-15 Thread Rafael J. Wysocki
On Tue, Oct 15, 2019 at 7:31 AM Daniel Drake wrote: > > On Mon, Oct 14, 2019 at 11:43 PM Bjorn Helgaas wrote: > > Can you tell if this is because the Ryzen7 XHCI controller is out of > > spec, or is the Linux PCI core missing some delay? If the latter, > > fixing the core might fix other devices

RE: how to test g_webcam

2019-10-15 Thread Gopal, Saranya
Hi Quadros, > I used the a different uvc-gadget application from this location [1] and it > seems > to > work quite fine with builtin video pattern and jpg image but not with V4L2 > capture source. > > So something is broken in uvc-gadget at [2] > > [1] https://github.com/wlhe/uvc-gadget > [2]

[PATCH v2 6/6] USB: Add driver to control USB fast charge for iOS devices

2019-10-15 Thread Bastien Nocera
iOS devices will not draw more than 500mA unless instructed to do so. Setting the charge type power supply property to "fast" tells the device to start drawing more power, using the same procedure that official "MFi" chargers would. Signed-off-by: Bastien Nocera --- MAINTAINERS

[PATCH v2 4/6] USB: Select better matching USB drivers when available

2019-10-15 Thread Bastien Nocera
Now that USB device drivers can reuse code from the generic USB device driver, we need to make sure that they get selected rather than the generic driver. Add an id_table and match vfunc to the usb_device_driver struct, which will get used to select a better matching driver at ->probe time. This i

[PATCH v2 3/6] USB: Implement usb_device_match_id()

2019-10-15 Thread Bastien Nocera
Match a usb_device with a table of IDs. Signed-off-by: Bastien Nocera --- drivers/usb/core/driver.c | 15 +++ include/linux/usb.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index d3787d084937..cc3ca62111b4 1006

[PATCH v2 5/6] USB: Fallback to generic driver when specific driver fails

2019-10-15 Thread Bastien Nocera
If ->probe fails for a device specific driver, ask the driver core to reprobe us, after having flagged the device for the generic driver to be forced. Signed-off-by: Bastien Nocera --- drivers/usb/core/driver.c | 5 - drivers/usb/core/generic.c | 3 +++ include/linux/usb.h| 1 + 3 f

[PATCH v2 1/6] USB: Export generic USB device driver functions

2019-10-15 Thread Bastien Nocera
This will make it possible to implement device drivers which extend the generic driver without needing to reimplement it. Signed-off-by: Bastien Nocera --- drivers/usb/core/generic.c | 16 drivers/usb/core/usb.h | 6 ++ 2 files changed, 14 insertions(+), 8 deletions(-)

[PATCH v2 2/6] USB: Make it possible to "subclass" usb_device_driver

2019-10-15 Thread Bastien Nocera
The kernel currenly has only 2 usb_device_drivers, one generic one, one that completely replaces the generic one to make USB devices usable over a network. Use the newly exported generic driver functions when a driver declares to want them run, in addition to its own code. This makes it possible t

[PATCH v2 0/6] Add Apple MFi fastcharge USB device driver

2019-10-15 Thread Bastien Nocera
This is version 2 of the patch set. - checkpatch.pl is now quiet - fallback to the generic driver when driver ->probe() fails Bastien Nocera (6): USB: Export generic USB device driver functions USB: Make it possible to "subclass" usb_device_driver USB: Implement usb_device_match_id() USB:

Re: [PATCH v2 0/6] Add Apple MFi fastcharge USB device driver

2019-10-15 Thread Bastien Nocera
On Tue, 2019-10-15 at 16:27 +0200, Bastien Nocera wrote: > This is version 2 of the patch set. > > - checkpatch.pl is now quiet > - fallback to the generic driver when driver ->probe() fails And I'll send a v3 because all the patches got mangled by my mail client.

[PATCH v2 6/6] USB: Add driver to control USB fast charge for iOS devices

2019-10-15 Thread Bastien Nocera
iOS devices will not draw more than 500mA unless instructed to do so. Setting the charge type power supply property to "fast" tells the device to start drawing more power, using the same procedure that official "MFi" chargers would. Signed-off-by: Bastien Nocera --- MAINTAINERS

[PATCH v2 2/6] USB: Make it possible to "subclass" usb_device_driver

2019-10-15 Thread Bastien Nocera
The kernel currenly has only 2 usb_device_drivers, one generic one, one that completely replaces the generic one to make USB devices usable over a network. Use the newly exported generic driver functions when a driver declares to want them run, in addition to its own code. This makes it possible t

[PATCH v2 4/6] USB: Select better matching USB drivers when available

2019-10-15 Thread Bastien Nocera
Now that USB device drivers can reuse code from the generic USB device driver, we need to make sure that they get selected rather than the generic driver. Add an id_table and match vfunc to the usb_device_driver struct, which will get used to select a better matching driver at ->probe time. This i

[PATCH v2 3/6] USB: Implement usb_device_match_id()

2019-10-15 Thread Bastien Nocera
Match a usb_device with a table of IDs. Signed-off-by: Bastien Nocera --- drivers/usb/core/driver.c | 15 +++ include/linux/usb.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index d3787d084937..cc3ca62111b4 1006

[PATCH v2 5/6] USB: Fallback to generic driver when specific driver fails

2019-10-15 Thread Bastien Nocera
If ->probe fails for a device specific driver, ask the driver core to reprobe us, after having flagged the device for the generic driver to be forced. Signed-off-by: Bastien Nocera --- drivers/usb/core/driver.c | 5 - drivers/usb/core/generic.c | 3 +++ include/linux/usb.h| 1 + 3 f

[PATCH v2 1/6] USB: Export generic USB device driver functions

2019-10-15 Thread Bastien Nocera
This will make it possible to implement device drivers which extend the generic driver without needing to reimplement it. Signed-off-by: Bastien Nocera --- drivers/usb/core/generic.c | 16 drivers/usb/core/usb.h | 6 ++ 2 files changed, 14 insertions(+), 8 deletions(-)

[PATCH v2 0/6] Add Apple MFi fastcharge USB device driver

2019-10-15 Thread Bastien Nocera
This is version 2 of the patch set. - checkpatch.pl is now quiet - fallback to the generic driver when driver ->probe() fails Bastien Nocera (6): USB: Export generic USB device driver functions USB: Make it possible to "subclass" usb_device_driver USB: Implement usb_device_match_id() USB:

[PATCH] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-15 Thread GwanYeong Kim
cannot be less than 0 - fread() returns 0 on error. Signed-off-by: GwanYeong Kim --- tools/usb/usbip/libsrc/usbip_device_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/usb/usbip/libsrc/usbip_device_driver.c b/tools/usb/usbip/libsrc/usbip_device_driver.c index

Re: how to test g_webcam

2019-10-15 Thread Roger Quadros
Hi, On 14/10/2019 17:22, Felipe Balbi wrote: Hi, Roger Quadros writes: Hmm, Link Change is disabled by default upstream, unless you're running on anything older than 2.50a. I don't remember the version you're using, though :-p 2.02a Thanks :-) irq/170-dwc3-270 [000] d... 173