Hi,
Roger Quadros writes:
> On 21/07/2019 21:32, Pawel Laszczak wrote:
>> This patch introduce new Cadence USBSS DRD driver to Linux kernel.
>>
>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
>> H
Hi,
Vicente Bergas writes:
> On Wednesday, August 14, 2019 3:12:26 PM CEST, Robin Murphy wrote:
>> On 14/08/2019 13:53, Vicente Bergas wrote:
>>> On Monday, July 22, 2019 4:31:27 PM CEST, Vicente Bergas wrote: ...
>>
>> This particular change looks like it's implicitly specific to
>> RK3399,
Hi,
Vicente Bergas writes:
>> Vicente Bergas writes:
>>> On Monday, July 22, 2019 4:31:27 PM CEST, Vicente Bergas wrote:
Hi, i have been running linux on rk3399 booted with kexec fine until 5.2
From 5.2 onwards, there are memory corruption issues as reported here:
http://lkml.iu
Hi,
Yinbo Zhu writes:
>> Yinbo Zhu writes:
>> >> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>> >> > index
>> >> > 98bce85c29d0..a133d8490322 100644
>> >> > --- a/drivers/usb/dwc3/core.c
>> >> > +++ b/drivers/usb/dwc3/core.c
>> >> > @@ -300,8 +300,7 @@ static void dwc3_fra
From: cy_huang
In real case, not all TCPCs support the tcpc PP control command.
Sometimes, charger/OTG/CurrentLimit functions will need to externally
control via power_supply/regulator/BC1.2(extcon). This patch add the ops
set_vbus/get_current_limit/set_current_limit for vendors.
Signed-off-by:
> -Original Message-
> From: Felipe Balbi [mailto:ba...@kernel.org]
> Sent: 2019年8月12日 13:27
> To: Yinbo Zhu ; Greg Kroah-Hartman
> ; linux-usb@vger.kernel.org; open list
>
> Cc: Xiaobo Xie ; Jiafei Pan ; Ran
> Wang
> Subject: RE: [EXT] Re: [PATCH v1] usb: dwc3: remove the call trace of
On Wednesday, August 14, 2019 3:12:26 PM CEST, Robin Murphy wrote:
On 14/08/2019 13:53, Vicente Bergas wrote:
On Monday, July 22, 2019 4:31:27 PM CEST, Vicente Bergas wrote: ...
This particular change looks like it's implicitly specific to
RK3399, which wouldn't be ideal. Presumably if the co
Adding Duncan Laurie who I think has some more intimate knowledge
of how this is implemented in HW. Duncan, could you correct or elaborate
on my answers below as you see fit? Also, sorry if I make some beginner
mistakes here, I'm just getting familiar with the USB subsystem, and thanks for
your pat
ATTN DEAR PARCEL BENEFICIARY.
I AM CATHY JONES,DIPLOMATIC AGENT ASIGNED ON THE DELIVERY OF YOUR ATM
CARD THROUGH MS. MARYANNA B. THOMASON, DHL MANAGEMENT DIRECTOR NEW
YORK.
TODAY, Wed, Aug 14, 2019 I AM READY FOR COMING TO YOUR ADDRESS WITH
THIS ATM CARD, So before i deliver I want you to send me.
On Wed, Aug 14, 2019 at 12:41:33PM -0500, Wenwen Wang wrote:
> In usbnet_start_xmit(), 'urb->sg' is allocated through kmalloc_array() by
> invoking build_dma_sg(). Later on, if 'CONFIG_PM' is defined and the if
> branch is taken, the execution will go to the label 'deferred'. However,
> 'urb->sg' i
From: Gavin Li
Memory usage for USB memory allocated via mmap() is already accounted
for at mmap() time; no need to account for it again at submiturb time.
Signed-off-by: Gavin Li
---
drivers/usb/core/devio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/cor
On Wed, Aug 14, 2019 at 02:12:07PM -0600, Nick Crews wrote:
> Thanks for the fast response!
>
> On Tue, Aug 13, 2019 at 12:02 AM Greg Kroah-Hartman
> wrote:
> >
> > On Mon, Aug 12, 2019 at 06:08:43PM -0600, Nick Crews wrote:
> > > Hi Greg!
> >
> > Hi!
> >
> > First off, please fix your email clie
Thanks for the fast response!
On Tue, Aug 13, 2019 at 12:02 AM Greg Kroah-Hartman
wrote:
>
> On Mon, Aug 12, 2019 at 06:08:43PM -0600, Nick Crews wrote:
> > Hi Greg!
>
> Hi!
>
> First off, please fix your email client to not send html so that vger
> does not reject your messages :)
Thanks, shoul
On Wed, Aug 14, 2019 at 11:42:53AM -0300, Francisco Ferreiro wrote:
> Hi guys, this is me trying to setup a tp-link TL-MR3420 with OpenWRT
> with a huawei E353 usb dongle
>
> hopefully I will try to setup a multiwan along with this two more
> sources to get redundant access to internet
> - a ce
In kalmia_init_and_get_ethernet_addr(), 'usb_buf' is allocated through
kmalloc(). In the following execution, if the 'status' returned by
kalmia_send_init_packet() is not 0, 'usb_buf' is not deallocated, leading
to memory leaks. To fix this issue, add the 'out' label to free 'usb_buf'.
Signed-off-
In cx82310_bind(), 'dev->partial_data' is allocated through kmalloc().
Then, the execution waits for the firmware to become ready. If the firmware
is not ready in time, the execution is terminated. However, the allocated
'dev->partial_data' is not deallocated on this path, leading to a memory
leak
In usbnet_start_xmit(), 'urb->sg' is allocated through kmalloc_array() by
invoking build_dma_sg(). Later on, if 'CONFIG_PM' is defined and the if
branch is taken, the execution will go to the label 'deferred'. However,
'urb->sg' is not deallocated on this execution path, leading to a memory
leak bu
On Wed, Aug 14, 2019 at 5:54 AM 'Matthias Maennich' via kernel-team
wrote:
>
> On Tue, Aug 13, 2019 at 01:15:44PM -0700, Saravana Kannan wrote:
> >On Tue, Aug 13, 2019 at 5:19 AM 'Matthias Maennich' via kernel-team
> > wrote:
> >>
> >> If MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is enabled (default=
In lan78xx_probe(), a new urb is allocated through usb_alloc_urb() and
saved to 'dev->urb_intr'. However, in the following execution, if an error
occurs, 'dev->urb_intr' is not deallocated, leading to memory leaks. To fix
this issue, invoke usb_free_urb() to free the allocated urb before
returning
As reported by one of our users here:
https://github.com/raspberrypi/linux/issues/3148
There is a bug when the dwc2 core receives USB data packets that are
between 1 and 4 bytes in length - 4 bytes are always written to memory
where the non-packet bytes are garbage.
This is easily reproducible by
On 11/08/2019 09:05, Christoph Hellwig wrote:
We still treat devices without a DMA mask as defaulting to 32-bits for
both mask, but a few releases ago we've started warning about such
cases, as they require special cases to work around this sloppyness.
Add a dma_mask field to struct platform_obje
On Wed, Aug 14, 2019 at 03:42:46PM +0200, Hans de Goede wrote:
> Hi,
>
> On 14-08-19 15:24, Heikki Krogerus wrote:
> > Hi,
> >
> > This series removes the deprecated fusb302 specific properties, and
> > stops using struct tcpc_config in the driver.
>
> Series looks good to me:
>
> Reviewed-by:
On Wed, 14 Aug 2019, Dan Carpenter wrote:
> I was looking at this code again today and I'm still convinced this
> patch is correct. Should I resend?
>
> regards,
> dan carpenter
>
> On Fri, Feb 23, 2018 at 03:33:00PM +0300, Dan Carpenter wrote:
> > The code is supposed to clear the RH_A_NPS and
Hi guys, this is me trying to setup a tp-link TL-MR3420 with OpenWRT
with a huawei E353 usb dongle
hopefully I will try to setup a multiwan along with this two more
sources to get redundant access to internet
- a cell phone (either tethering or if possible via USB (*))
- a fiber based dsl ser
On driver removal, the platform_device_unregister call
attached through devm_add_action_or_reset was executed
after usb_hcd_pci_remove.
This lead to a use-after-free for the iomem resorce of
the xhci-ext-caps driver in the platform removal
because the parent of the resource was freed earlier.
Fix
Hi Roger,
>
>On 21/07/2019 21:32, Pawel Laszczak wrote:
>> This patch introduce new Cadence USBSS DRD driver to Linux kernel.
>>
>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
>> Host Only (XHCI)confi
Hi Dmitry/Kalle,
> >>
> >> Hi Dmitry,
> >>
> >> We have a patch to fix this:
> >> https://patchwork.kernel.org/patch/10990275/
> >
> > Hi Ganapathi,
> >
> > Has this patch been accepted anywhere? This bug is still open on syzbot.
>
> The patch is in "Changes Requested" state which means that the
Hi Oliver,
Thanks for the fix. You need to set an invalid return code, too.
Regards,
Guido
-Original Message-
From: Andrey Konovalov
Sent: Wednesday, August 14, 2019 3:52 PM
To: syzbot
Cc: Greg Kroah-Hartman ; Kiener Guido 1DS1
; USB list ; Oliver
Neukum ; steve_bayl...@keysight.co
I was looking at this code again today and I'm still convinced this
patch is correct. Should I resend?
regards,
dan carpenter
On Fri, Feb 23, 2018 at 03:33:00PM +0300, Dan Carpenter wrote:
> The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
> a no-op because of the & vs | ty
On 11.8.2019 11.22, Ikjoon Jang wrote:
Xhci re-enables a slot on transaction error in set_address using
xhci_disable_slot() + xhci_alloc_dev().
But in this case, xhci_alloc_dev() creates debugfs entries upon an
existing device without cleaning up old entries, thus memory leaks.
So this patch si
On Wed, Aug 14, 2019 at 3:38 PM syzbot
wrote:
>
> Hello,
>
> syzbot has tested the proposed patch but the reproducer still triggered
> crash:
> KASAN: use-after-free Read in usbtmc_disconnect
Looks like a different bug in the same driver that gets triggered by
the same reproducer =)
You fix look
Hi,
On 14-08-19 15:24, Heikki Krogerus wrote:
Hi,
This series removes the deprecated fusb302 specific properties, and
stops using struct tcpc_config in the driver.
Series looks good to me:
Reviewed-by: Hans de Goede
This has a small conflict with my
"[PATCH] usb: typec: fusb302: Call fusb3
On 21/07/2019 21:32, Pawel Laszczak wrote:
> This patch introduce new Cadence USBSS DRD driver to Linux kernel.
>
> The Cadence USBSS DRD Controller is a highly configurable IP Core which
> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
> Host Only (XHCI)configurations.
>
>
Hello,
syzbot has tested the proposed patch but the reproducer still triggered
crash:
KASAN: use-after-free Read in usbtmc_disconnect
usb 5-1: USB disconnect, device number 2
==
BUG: KASAN: use-after-free in __mutex_lock_common
On Wed, Aug 14, 2019 at 04:24:19PM +0300, Heikki Krogerus wrote:
> By registering a software fwnode for the port when the
> firmware does not supply one, we can always provide tcpm the
> connector capabilities by using the common USB connector
> device properties instead of using tcpc_config platfo
On Wed, Aug 14, 2019 at 04:24:18PM +0300, Heikki Krogerus wrote:
> There are no platforms using them anymore.
>
> Signed-off-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
> ---
> Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --g
On Wed, Aug 14, 2019 at 04:24:17PM +0300, Heikki Krogerus wrote:
> Removing the deprecated fusb302 specific properties. There
> are no more platforms using them.
>
> Signed-off-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
> ---
> drivers/usb/typec/tcpm/fusb302.c | 31 +++
Hi,
On 14-08-19 15:32, Schmid, Carsten wrote:
On driver removal, the platform_device_unregister call
attached through devm_add_action_or_reset was executed
after usb_hcd_pci_remove.
This lead to a use-after-free for the iomem resorce of
the xhci-ext-caps driver in the platform removal
because th
> > On driver removal, the platform_device_unregister call
> > attached through devm_add_action_or_reset was executed
> > after usb_hcd_pci_remove.
> > This lead to a use-after-free for the iomem resorce of
> > the xhci-ext-caps driver in the platform removal
> > because the parent of the resource
On 21/07/2019 21:32, Pawel Laszczak wrote:
> This patch introduce new Cadence USBSS DRD driver to Linux kernel.
>
> The Cadence USBSS DRD Controller is a highly configurable IP Core which
> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
> Host Only (XHCI)configurations.
>
>
On 13.8.2019 9.50, Kai-Heng Feng wrote:
Hi Mathias,
at 21:24, Kai-Heng Feng wrote:
at 22:45, Mathias Nyman wrote:
[snipped]
Yes, disabling runtime PM can workaround this issue.
What’s next step here? Is it a firmware bug?
Can't say.
From xhci driver point of view the 39:00.0 xHC con
Am Mittwoch, den 14.08.2019, 04:38 -0700 schrieb syzbot:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:d0847550 usb-fuzzer: main usb gadget fuzzer driver
> git tree: https://github.com/google/kasan.git usb-fuzzer
> console output: https://syzkaller.appspot.com/x/log.
Removing the deprecated fusb302 specific properties. There
are no more platforms using them.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm/fusb302.c | 31 +++
1 file changed, 3 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/typec/tcpm/fusb302.c b
There are no platforms using them anymore.
Signed-off-by: Heikki Krogerus
---
Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 7 ---
1 file changed, 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
b/Documentation/devicetree/bindings/usb/fcs,fusb302
Hi,
This series removes the deprecated fusb302 specific properties, and
stops using struct tcpc_config in the driver.
thanks,
Heikki Krogerus (3):
usb: typec: fusb302: Remove unused properties
dt-bindings: usb: fusb302: Remove deprecated properties
usb: typec: fusb302: Always provide fwnod
By registering a software fwnode for the port when the
firmware does not supply one, we can always provide tcpm the
connector capabilities by using the common USB connector
device properties instead of using tcpc_config platform data.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm/fus
FYI, I think my
"usb: add a HCD_DMA flag instead of guestimating DMA capabilities"
is the proper core fix for what your patch 1 works around, as the USB
core should not assume DMA capabilities based on the presence of a DMA
mask.
On Wednesday, August 14, 2019 3:06:04 PM CEST, Felipe Balbi wrote:
Hi,
Vicente Bergas writes:
On Monday, July 22, 2019 4:31:27 PM CEST, Vicente Bergas wrote:
Hi, i have been running linux on rk3399 booted with kexec fine until 5.2
From 5.2 onwards, there are memory corruption issues as report
On 14/08/2019 13:53, Vicente Bergas wrote:
On Monday, July 22, 2019 4:31:27 PM CEST, Vicente Bergas wrote:
Hi, i have been running linux on rk3399 booted with kexec fine until 5.2
From 5.2 onwards, there are memory corruption issues as reported here:
http://lkml.iu.edu/hypermail/linux/kernel/190
Am Mittwoch, den 14.08.2019, 08:56 + schrieb Schmid, Carsten :
> > This is on a lower layer than ax88179. This comes from xhci_hcd.
> > Is this a regression?
> >
>
> I don't think its a regression.
It would be better to know than to assume.
> Is there something i can do to force an error
Hi,
Vicente Bergas writes:
> On Monday, July 22, 2019 4:31:27 PM CEST, Vicente Bergas wrote:
>> Hi, i have been running linux on rk3399 booted with kexec fine until 5.2
>> From 5.2 onwards, there are memory corruption issues as reported here:
>> http://lkml.iu.edu/hypermail/linux/kernel/1906.2/0
On Tue, Aug 13, 2019 at 01:15:44PM -0700, Saravana Kannan wrote:
On Tue, Aug 13, 2019 at 5:19 AM 'Matthias Maennich' via kernel-team
wrote:
If MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is enabled (default=n), the
requirement for modules to import all namespaces that are used by
the module is rela
On Monday, July 22, 2019 4:31:27 PM CEST, Vicente Bergas wrote:
Hi, i have been running linux on rk3399 booted with kexec fine until 5.2
From 5.2 onwards, there are memory corruption issues as reported here:
http://lkml.iu.edu/hypermail/linux/kernel/1906.2/07211.html
kexec has been identified as
Hi,
On 14-08-19 13:39, Schmid, Carsten wrote:
On driver removal, the platform_device_unregister call
attached through devm_add_action_or_reset was executed
after usb_hcd_pci_remove.
This lead to a use-after-free for the iomem resorce of
the xhci-ext-caps driver in the platform removal
because th
+# This script requires at least spatch
+# version 1.0.4.
How do you think about to avoid the duplicate specification of this
identification?
Regards,
Markus
On driver removal, the platform_device_unregister call
attached through devm_add_action_or_reset was executed
after usb_hcd_pci_remove.
This lead to a use-after-free for the iomem resorce of
the xhci-ext-caps driver in the platform removal
because the parent of the resource was freed earlier.
Fix
From: Li Jun
USB role is fully controlled by usb role switch consumer(e.g. typec),
usb port can be at host mode(USB_ROLE_HOST), device mode connected to
host(USB_ROLE_DEVICE), or not connecting any partner(USB_ROLE_NONE).
Signed-off-by: Li Jun
---
Changes for v3:
- Remove the patch usb: chipid
Hello,
syzbot found the following crash on:
HEAD commit:d0847550 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=16295d4a60
kernel config: https://syzkaller.appspot.com/x/.
On Tue, Aug 13, 2019 at 10:51 PM Sean Young wrote:
>
> On Tue, Aug 13, 2019 at 03:22:49PM +0200, Andrey Konovalov wrote:
> > On Wed, Jul 17, 2019 at 2:29 PM syzbot
> > wrote:
> > >
> > > Hello,
> > >
> > > syzbot has tested the proposed patch and the reproducer did not trigger
> > > crash:
> > >
>>> Plugging them into the same port (!) on my device one of them is
>>> recognized as SuperSpeed, the other as high speed ???
>>> (working on 4.14.129 LTS)
>>>
>>> From dmesg, the "faulty" one:
>>> [ 530.585871] usb 1-2: new high-speed USB device number 4 using
>>> xhci_hcd < HUH
>
Am Dienstag, den 13.08.2019, 17:08 +0200 schrieb Andrey Konovalov:
> On Tue, Aug 13, 2019 at 2:43 PM Oliver Neukum wrote:
> >
> >
> > Hi,
> >
> > this looks like a false positive to me.
> > The offending code is likely this:
> >
> > if (size) {
> > buf = kmalloc(size, G
>> Plugging them into the same port (!) on my device one of them is
>> recognized as SuperSpeed, the other as high speed ???
>> (working on 4.14.129 LTS)
>>
>> From dmesg, the "faulty" one:
>> [ 530.585871] usb 1-2: new high-speed USB device number 4 using
>> xhci_hcd < HUH
>>
> XH
Am Mittwoch, den 14.08.2019, 08:17 + schrieb Schmid, Carsten :
> [Resend - had mailer errors ]
>
> Hi Florian,
>
> today i have seen a strange behaviour of two D-Link DUB-1312 adapters (same
> Revision A1).
> Plugging them into the same port (!) on my device one of them is recognized
> as
[Resend - had mailer errors ]
Hi Florian,
today i have seen a strange behaviour of two D-Link DUB-1312 adapters (same
Revision A1).
Plugging them into the same port (!) on my device one of them is recognized as
SuperSpeed, the other as high speed ???
(working on 4.14.129 LTS)
>From dmesg, the
Could you please confirm if your recieved our purchase order last week.
If no please confirm let me resend it to you.
NARESH KUMAR
Executive Purchase Saiapextrading Ltd
Dubai, KSA.
(T/F): +96-2667-264 777 / 778
(Mo): +96 94284 02803
Website - http://www.saiapexgeneraltrading.com
On Wed, Aug 14, 2019 at 12:06:11PM +0530, Himanshu Jha wrote:
On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote:
A script that uses the '.ns_deps' file generated by modpost to
automatically add the required symbol namespace dependencies to each
module.
Usage:
1) Move some symbol
On Wed, Aug 14, 2019 at 10:17:14AM +0800, Chunfeng Yun wrote:
> On Tue, 2019-08-13 at 13:52 +0300, Heikki Krogerus wrote:
> > Hi Hans,
> >
> > On Tue, Aug 13, 2019 at 12:15:24PM +0200, Hans de Goede wrote:
> > > tcpm_register_port() will call some of the fusb302 code's callbacks
> > > wich in turn
67 matches
Mail list logo
