Re: [PATCH 4.19.y 8/9] Revert "usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup"

2019-06-27 Thread Jack Pham
Hi John, On Thu, Jun 27, 2019 at 08:52:39PM +, John Stultz wrote: > This reverts commit 25ad17d692ad54c3c33b2a31e5ce2a82e38de14e, > as with other patches backported to -stable, we can now apply > the actual upstream commit that matches this. > > Cc: Fei Yang > Cc: Sam Protsenko > Cc: Felipe

[RFC] usb: typec: ucsi: add support for separate DP altmode devices

2019-06-27 Thread Ajay Gupta
CCGx controller used on NVIDIA GPU card has two separate display altmode for two DP pin assignments. UCSI specification doesn't prohibits using separate display altmode. Current UCSI Type-C framework expects only one display altmode for all DP pin assignment. This patch squashes two separate displ

Re: No carrier lost information with gadget RNDIS/ECM

2019-06-27 Thread Peter Chen
> Felipe Balbi writes: > > Kai Ruhnau writes: > >>> Which peripheral controller is this board using? Is it chipidea? dwc2? > >>> dwc3? High Speed or Super Speed? > >> > >> According to the device tree it's 'fsl,imx6sx-usb' driven by > >> chipidea/ci_hdrc_imx.c > >> When connecting to Windows, the

[PATCH 4.19.y 8/9] Revert "usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup"

2019-06-27 Thread John Stultz
This reverts commit 25ad17d692ad54c3c33b2a31e5ce2a82e38de14e, as with other patches backported to -stable, we can now apply the actual upstream commit that matches this. Cc: Fei Yang Cc: Sam Protsenko Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org Cc: sta...@vger.kernel.org # 4.19.y Signed-off-

[PATCH 4.19.y 7/9] usb: dwc3: gadget: remove wait_end_transfer

2019-06-27 Thread John Stultz
From: Felipe Balbi commit fec9095bdef4e7c988adb603d0d4f92ee735d4a1 upstream Now that we have a list of cancelled requests, we can skip over TRBs when END_TRANSFER command completes. Cc: Fei Yang Cc: Sam Protsenko Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org Cc: sta...@vger.kernel.org # 4.1

[PATCH 4.19.y 2/9] usb: dwc3: gadget: track number of TRBs per request

2019-06-27 Thread John Stultz
From: Felipe Balbi commit 09fe1f8d7e2f461275b1cdd832f2cfa5e9be346d upstream This will help us remove the wait_event() from our ->dequeue(). Cc: Fei Yang Cc: Sam Protsenko Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org Cc: sta...@vger.kernel.org # 4.19.y Signed-off-by: Felipe Balbi (cherry p

[PATCH 4.19.y 1/9] usb: dwc3: gadget: combine unaligned and zero flags

2019-06-27 Thread John Stultz
From: Felipe Balbi commit 1a22ec643580626f439c8583edafdcc73798f2fb upstream Both flags are used for the same purpose in dwc3: appending an extra TRB at the end to deal with controller requirements. By combining both flags into one, we make it clear that the situation is the same and that they sh

[PATCH 4.19.y 3/9] usb: dwc3: gadget: use num_trbs when skipping TRBs on ->dequeue()

2019-06-27 Thread John Stultz
From: Felipe Balbi commit c3acd59014148470dc58519870fbc779785b4bf7 upstream Now that we track how many TRBs a request uses, it's easier to skip over them in case of a call to usb_ep_dequeue(). Let's do so and simplify the code a bit. Cc: Fei Yang Cc: Sam Protsenko Cc: Felipe Balbi Cc: linux-

[PATCH 4.19.y 6/9] usb: dwc3: gadget: move requests to cancelled_list

2019-06-27 Thread John Stultz
From: Felipe Balbi commit d4f1afe5e896c18ae01099a85dab5e1a198bd2a8 upstream Whenever we have a request in flight, we can move it to the cancelled list and later simply iterate over that list and skip over any TRBs we find. Cc: Fei Yang Cc: Sam Protsenko Cc: Felipe Balbi Cc: linux-usb@vger.ke

[PATCH 4.19.y 9/9] usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup

2019-06-27 Thread John Stultz
From: Jack Pham commit bd6742249b9ca918565e4e3abaa06665e587f4b5 upstream OUT endpoint requests may somtimes have this flag set when preparing to be submitted to HW indicating that there is an additional TRB chained to the request for alignment purposes. If that request is removed before the cont

[PATCH 4.19.y 4/9] usb: dwc3: gadget: extract dwc3_gadget_ep_skip_trbs()

2019-06-27 Thread John Stultz
From: Felipe Balbi commit 7746a8dfb3f9c91b3a0b63a1d5c2664410e6498d upstream Extract the logic for skipping over TRBs to its own function. This makes the code slightly more readable and makes it easier to move this call to its final resting place as a following patch. Cc: Fei Yang Cc: Sam Prots

[PATCH 4.19.y 0/9] Fix scheduling while atomic in dwc3_gadget_ep_dequeue

2019-06-27 Thread John Stultz
With recent changes in AOSP, adb is using asynchronous io, which causes the following crash usually on a reboot: [ 184.278302] BUG: scheduling while atomic: ksoftirqd/0/9/0x0104 [ 184.284617] Modules linked in: wl18xx wlcore snd_soc_hdmi_codec wlcore_sdio tcpci_rt1711h tcpci tcpm typec adv7

[PATCH 4.19.y 5/9] usb: dwc3: gadget: introduce cancelled_list

2019-06-27 Thread John Stultz
From: Felipe Balbi commit d5443bbf5fc8f8389cce146b1fc2987cdd229d12 upstream This list will host cancelled requests who still have TRBs being processed. Cc: Fei Yang Cc: Sam Protsenko Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org Cc: sta...@vger.kernel.org # 4.19.y Signed-off-by: Felipe Balb

Re: USB bug

2019-06-27 Thread Harutyun Khachatryan
Dear Mathias Nyman, the commands has actually helped. But it is strange that the system behavior has changed, without that command no more usb devices can be connected to the machine. Even Seagate HDD after disconnecting was not able to be connected again. So only with that commands you had wr

HDD's attached via USB3 ports not automatically seen by kernel

2019-06-27 Thread Bauke Jan Douma
Kernel: Linux 4.15.0-52-generic #56~16.04.1-Ubuntu SMP Thu Jun 6 12:03:31 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux I have two additional ('DeLock') USB docks in my pc. One with two USB3 ports+2USB2 ports, the other with two USB3 ports. I have several external HDD's, some that I hook up through

Re: [PATCH v2] carl9170: fix misuse of device driver API

2019-06-27 Thread Kalle Valo
Christian Lamparter wrote: > This patch follows Alan Stern's recent patch: > "p54: Fix race between disconnect and firmware loading" > > that overhauled carl9170 buggy firmware loading and driver > unbinding procedures. > > Since the carl9170 code was adapted from p54 it uses the > same functio

RE: No carrier lost information with gadget RNDIS/ECM

2019-06-27 Thread Kai Ruhnau
Hi, Felipe Balbi writes: > Kai Ruhnau writes: >>> Which peripheral controller is this board using? Is it chipidea? dwc2? >>> dwc3? High Speed or Super Speed? >> >> According to the device tree it's 'fsl,imx6sx-usb' driven by >> chipidea/ci_hdrc_imx.c >> When connecting to Windows, the dmesg show

Re: [PATCH] usb: core: devio: add ioctls for suspend and resume

2019-06-27 Thread Alan Stern
On Thu, 27 Jun 2019, Mayuresh Kulkarni wrote: > Thanks for all the comments and clarifications, Alan. > > I will check the 3-ioctl approach on the platform I have using the test > program I had used to send my original patch. > > Just for my understanding, the below sequence should also work - >

[BUG] net: dm9600: false link status

2019-06-27 Thread Corentin Labbe
Hello I own an USB dongle which is a "Davicom DM96xx USB 10/100 Ethernet". According to the CHIP_ID, it is a DM9620. Since I needed for bringing network to uboot for a board, I have started to create its uboot's driver. My uboot driver is based on the dm9600 Linux driver. The dongle was working

Re: [PATCH] usb: core: devio: add ioctls for suspend and resume

2019-06-27 Thread Mayuresh Kulkarni
On Wed, 2019-06-26 at 11:07 -0400, Alan Stern wrote: > On Wed, 26 Jun 2019, Mayuresh Kulkarni wrote: > > > > > On Tue, 2019-06-25 at 10:08 -0400, Alan Stern wrote: > > > > > > > > > > > > > Based on discussion so far and my understanding, how about below > > > > approach - > > > > > > > > 1.

Re: [Patch V4 1/8] phy: tegra: xusb: t210: add XUSB dual mode support

2019-06-27 Thread Thierry Reding
On Mon, Jun 10, 2019 at 03:49:02PM +0530, Nagarjuna Kristam wrote: > Configure the port capabilities based on usb_dr_mode settings. > > Based on work by JC Kuo . > > Signed-off-by: Nagarjuna Kristam > Reviewed-by: JC Kuo > Acked-by: Thierry Reding > --- > drivers/phy/tegra/xusb-tegra210.c | 2

Re: [Patch V4 2/8] phy: tegra: xusb: t210: add usb3 port fake support

2019-06-27 Thread Thierry Reding
On Mon, Jun 10, 2019 at 03:49:03PM +0530, Nagarjuna Kristam wrote: > On Tegra210, usb2 only otg/peripheral ports dont work in device mode. > They need an assosciated usb3 port to work in device mode. Identify > an unused usb3 port and assign it as a fake USB3 port to USB2 only > port whose mode is

[GIT PULL] USB: changes for v5.3 merge window

2019-06-27 Thread Felipe Balbi
Hi Greg, Here's my pull request for v5.3 merge window. Relevant patches have been tested on platforms I have available. Let me know if you want anything to be changed cheers The following changes since commit a954e5fb4bc2d401b8fc3b4c7cd316497ff80225: Merge 5.2-rc5 into usb-next (2019-06-17