Re: USB bug

2019-06-21 Thread Alan Stern
On Sat, 22 Jun 2019, Harutyun Khachatryan wrote: > Dear Alan Stern, > > I thought that I should wait Mathias's response. I am terribly sorry for > that. I am sending dmesg log and trace content as you asked. I tried the > procedure on kernel 5.1.12-050112-generic since it's most recent now and

Re: [PATCH] usb: core: devio: add ioctls for suspend and resume

2019-06-21 Thread Alan Stern
On Fri, 21 Jun 2019, Mayuresh Kulkarni wrote: > Hi Alan, > > With the suggested modification (of having suspend/resume of usbfs at > device level instead of interface level), looks like I am seeing a > deadlock described as below - > > Pre-condition: USB device is connected but suspended before

Re: [PATCH] usb: core: devio: add ioctls for suspend and resume

2019-06-21 Thread Mayuresh Kulkarni
On Thu, 2019-06-20 at 11:49 -0400, Alan Stern wrote: > On Thu, 20 Jun 2019, Mayuresh Kulkarni wrote: > > > > > On Wed, 2019-06-19 at 10:40 -0400, Alan Stern wrote: > > > > > > > > The only solution I can think of is for the userspace program to > > > first > > > set the device's autosuspend del

Re: [PATCH v3] usb: clean up some of the computations in adu_read

2019-06-21 Thread dmg
d...@turingmachine.org writes: > From: Daniel M German > Sorry, I put a spurious line in the body of the email. I am resending. --dmg

[PATCH v3] usb: clean up some of the computations in adu_read

2019-06-21 Thread dmg
From: Daniel M German Replace ?: with min to calculate the number of bytes in the secondary buffer, including changing the data type of data_in_secondary to size_t to be type-consistent. data_in_secondary can never be negative. Remove some spurious calculations (copy_to_user returns zero on succ

Re: [PATCH] usb: clean up some of the computations in adu_read

2019-06-21 Thread Greg KH
On Thu, Jun 20, 2019 at 11:59:21PM -0700, d...@turingmachine.org wrote: > From: Daniel M German > > Replace ?: with min to calculate the number of bytes in the secondary buffer, > including changing the data type of data_in_secondary to size_t to be > type-consistent. data_in_secondary can never