[PATCH] usb: xhci: dbc: get rid of global pointer

2019-06-11 Thread Felipe Balbi
If we happen to have two XHCI controllers with DbC capability, then there's no hope this will ever work as the global pointer will be overwritten by the controller that probes last. Avoid this problem by keeping the tty_driver struct pointer inside struct xhci_dbc. Fixes: dfba2174dc42 usb: xhci:

Re: [PATCH 4/5] usb: xhci: dbc: Add a dbc raw driver to provide a raw interface on DbC

2019-06-11 Thread Greg KH
On Tue, Jun 11, 2019 at 12:17:40PM +, Regupathy, Rajaram wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, June 11, 2019 3:23 PM > > To: Regupathy, Rajaram > > Cc: Mathias Nyman ; Pandey, Prabhat Chand > > ; linux-usb@vger.kern

RE: [PATCH 4/5] usb: xhci: dbc: Add a dbc raw driver to provide a raw interface on DbC

2019-06-11 Thread Regupathy, Rajaram
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, June 11, 2019 3:23 PM > To: Regupathy, Rajaram > Cc: Mathias Nyman ; Pandey, Prabhat Chand > ; linux-usb@vger.kernel.org; Nyman, > Mathias ; K V, Abhilash ; > Balaji, M > Subject: Re: [PATCH 4/5]

Re: [PATCH 4/5] usb: xhci: dbc: Add a dbc raw driver to provide a raw interface on DbC

2019-06-11 Thread Greg KH
On Tue, Jun 11, 2019 at 09:29:23AM +, Regupathy, Rajaram wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Monday, June 10, 2019 7:46 PM > > To: Mathias Nyman > > Cc: Pandey, Prabhat Chand ; linux- > > u...@vger.kernel.org; Nyman, Mathi

RE: [PATCH 4/5] usb: xhci: dbc: Add a dbc raw driver to provide a raw interface on DbC

2019-06-11 Thread Regupathy, Rajaram
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, June 10, 2019 7:46 PM > To: Mathias Nyman > Cc: Pandey, Prabhat Chand ; linux- > u...@vger.kernel.org; Nyman, Mathias ; > Regupathy, Rajaram ; K V, Abhilash > ; Balaji, M > Subject: Re: [PATCH 4/5]

Re: [PATCH] usb/hcd: Fix a NULL vs IS_ERR() bug in usb_hcd_setup_local_mem()

2019-06-11 Thread Sebastian Andrzej Siewior
On 2019-06-07 16:57:09 [+0300], Dan Carpenter wrote: > The devm_memremap() function doesn't return NULL, it returns error > pointers. > > Fixes: b0310c2f09bb ("USB: use genalloc for USB HCs with local memory") > Signed-off-by: Dan Carpenter Acked-by: Sebastian Andrzej Siewior Sebastian

Re: kernel NULL pointer dereference, ucsi bug

2019-06-11 Thread Heikki Krogerus
Hi Vladimir, On Sun, Jun 02, 2019 at 09:24:43PM +1000, Vladimir Yerilov wrote: > Good day, > > There's a problem with ucsi starting from 5.2-rc1 (maybe earlier > versions of 5.2 are affected too). > Recently I've tried these versions of rc3 (commits), all have this issue: > 3ab4436f688c2d2f221793

Re: [Patch V4 4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding

2019-06-11 Thread Chunfeng Yun
On Mon, 2019-06-10 at 15:49 +0530, Nagarjuna Kristam wrote: > Add device-tree binding documentation for the XUSB device mode controller > present on Tegra210 SoC. This controller supports the USB 3.0 > specification. > > Signed-off-by: Nagarjuna Kristam > Reviewed-by: JC Kuo > --- > .../devicet

Re: kernel NULL pointer dereference, ucsi bug

2019-06-11 Thread Heikki Krogerus
On Mon, Jun 10, 2019 at 04:32:47PM +0200, Greg KH wrote: > On Fri, Jun 07, 2019 at 02:58:51AM +1000, Vladimir Yerilov wrote: > > Finally I can name the first bad commit: > > > > git bisect good > > ad74b8649beaf1a22cf8641324e3321fa0269d16 is the first bad commit > > commit ad74b8649beaf1a22cf86413