[PATCH 5/5] usb: xhci: dbc: Document describe about dbc raw interface

2019-06-06 Thread Prabhat Chand Pandey
This patch have explaination about the new DBC interface called dbc raw interface. This cover the capability, target setup and use case info. Signed-off-by: Prabhat Chand Pandey --- Documentation/usb/dbc_raw.rst | 136 ++ Documentation/usb/index.rst | 16

[PATCH 2/5] usb: xhci: dbc: DbC TTY driver to use new interface

2019-06-06 Thread Prabhat Chand Pandey
Change DbC TTY driver to use the new modular interface exposed by the DbC core. This will allow other function drivers with a different interface also to use DbC. [no need to add running number to tty driver name, remove it. -Mathias] Signed-off-by: Rajaram Regupathy Signed-off-by: Abhilash K V

[PATCH 3/5] usb: xhci: dbc: Provide sysfs option to configure dbc descriptors

2019-06-06 Thread Prabhat Chand Pandey
From: "K V, Abhilash" Show the active dbc function and dbc descriptors, allowing user space to dynamically modify the descriptors The DBC specific sysfs attributes are separated into two groups, in the first group there are dbc & dbc_function sysfs attributes and in second group all other DBC de

[PATCH 1/5] usb: xhci: dbc: make DbC modular, introducing dbc_function structure

2019-06-06 Thread Prabhat Chand Pandey
This patch introduces the dbc_function structure as a first step in making DbC modular and capable in exposing different user interfaces using different "functions", which may implement the callbacks exposed here according to the driver's need. Only one "function" can be registered at a time. The

[PATCH 4/5] usb: xhci: dbc: Add a dbc raw driver to provide a raw interface on DbC

2019-06-06 Thread Prabhat Chand Pandey
From: Abhilash K V This patch provides a raw device interface on xhci Debug capability. This abstracts dbc functionality to user space inorder to facilitate various frameworks to utilize xhci debug capability. It helps to render the target as an usb debug class device on host and establish an us

[PATCH 0/5] usb: xhci: dbc: make modular and add RAW interface

2019-06-06 Thread Prabhat Chand Pandey
This patch-set adds the following features to dbc driver: - show the active dbc function and dbc descriptors, allowing user space to dynamically modify the descriptors. - modularize dbc core to enable it to expose different function interfaces, till now only TTY interface was exposed. - use

[GIT PULL] USB: fixes for v5.2-rc4

2019-06-06 Thread Felipe Balbi
Hi Greg, Here's my first set of fixes for this -rc cycle. Looks like most of what I have in my inbox these days are new features. Very little fixes. I guess folks are writing perfect code now :-p Let me know if you want anything to be changed. Cheers _ < That'

Re: kernel NULL pointer dereference, ucsi bug

2019-06-06 Thread Vladimir Yerilov
Finally I can name the first bad commit: git bisect good ad74b8649beaf1a22cf8641324e3321fa0269d16 is the first bad commit commit ad74b8649beaf1a22cf8641324e3321fa0269d16 Author: Heikki Krogerus Date: Tue Apr 23 17:21:48 2019 +0300 usb: typec: ucsi: Preliminary support for alternate modes

Re: USB reset problem

2019-06-06 Thread Greg KH
On Thu, Jun 06, 2019 at 03:19:14PM +, Bollinger, Seth wrote: > > On Jun 6, 2019, at 10:03 AM, Alan Stern wrote: > > > > EPERM means that the file descriptor was not opened with write access. > > It has nothing to do with reset failures. > > Yes, I was confused by that as well so spent some

Re: USB reset problem

2019-06-06 Thread Bollinger, Seth
> On Jun 6, 2019, at 10:03 AM, Alan Stern wrote: > > EPERM means that the file descriptor was not opened with write access. > It has nothing to do with reset failures. Yes, I was confused by that as well so spent some time instrumenting the kernel. It definitely is open for writing, and get’

Re: USB reset problem

2019-06-06 Thread Alan Stern
On Thu, 6 Jun 2019, Bollinger, Seth wrote: > > On Jun 6, 2019, at 9:36 AM, Greg KH wrote: > > > > If the descriptor changes between resets, that means that something > > changed and we need to start over with it. What is the problem that > > this is causing > > We have code doing a USBDEVFS_RES

Re: USB reset problem

2019-06-06 Thread Bollinger, Seth
> On Jun 6, 2019, at 9:37 AM, Alan Stern > mailto:st...@rowland.harvard.edu>> wrote: > > If this is really a problem we can change the code so that the > iManufacturer, iProduct, iSerialNumber, iConfiguration, and iInterface > descriptor values are exempt from the change check. It would be a > li

Re: USB reset problem

2019-06-06 Thread Bollinger, Seth
> On Jun 6, 2019, at 9:36 AM, Greg KH wrote: > > If the descriptor changes between resets, that means that something > changed and we need to start over with it. What is the problem that > this is causing We have code doing a USBDEVFS_RESET that fails when the ioctl returns EPERM. I think the

Re: Slow I/O on USB media

2019-06-06 Thread Greg KH
On Thu, Jun 06, 2019 at 04:00:52PM +0200, Andrea Vai wrote: > Il giorno mer, 05/06/2019 alle 19.39 +0200, Greg KH ha scritto: > > On Wed, Jun 05, 2019 at 06:23:58PM +0200, Andrea Vai wrote: > > [...] > > > > > Anyway, I know that I can do all of this in a better way, and will > > let > > > you kno

Re: USB reset problem

2019-06-06 Thread Alan Stern
On Thu, 6 Jun 2019, Bollinger, Seth wrote: > Hello All, > > Recently we saw a problem where the device reset will fail due to a > configuration descriptor check in hub.c:5600. > > if (memcmp(buf, udev->rawdescriptors[index], old_length) > != 0) { > dev_dbg(&ud

Re: USB reset problem

2019-06-06 Thread Greg KH
On Thu, Jun 06, 2019 at 01:55:37PM +, Bollinger, Seth wrote: > Hello All, > > Recently we saw a problem where the device reset will fail due to a > configuration descriptor check in hub.c:5600. > > if (memcmp(buf, udev->rawdescriptors[index], old_length) > != 0) { >

Re: Slow I/O on USB media

2019-06-06 Thread Alan Stern
On Thu, 6 Jun 2019, Andrea Vai wrote: > Here I am with another question. > What I have done so far: > > - booted with the last kernel I know to be working (4.20.13- > 200.fc29.x86_64, installed from Fedora repos), checked that test runs > fine (2min to copy) > - marked "git bisect good v4.20.13"

Re: [PATCH usbutils] usb-devices.1: don't mention bash

2019-06-06 Thread Greg Kroah-Hartman
On Tue, May 28, 2019 at 02:37:04PM +0300, Baruch Siach wrote: > Since commit 508d1acf42e ("usb-devices: use /bin/sh hashbang") > usb-devices does not require bash. > > Signed-off-by: Baruch Siach > --- > usb-devices.1.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/u

Re: Slow I/O on USB media

2019-06-06 Thread Andrea Vai
Il giorno mer, 05/06/2019 alle 19.39 +0200, Greg KH ha scritto: > On Wed, Jun 05, 2019 at 06:23:58PM +0200, Andrea Vai wrote: > [...] > > > Anyway, I know that I can do all of this in a better way, and will > let > > you know. > > Yes, please do so, your steps above do not show much. Here I am w

USB reset problem

2019-06-06 Thread Bollinger, Seth
Hello All, Recently we saw a problem where the device reset will fail due to a configuration descriptor check in hub.c:5600. if (memcmp(buf, udev->rawdescriptors[index], old_length) != 0) { dev_dbg(&udev->dev, "config index %d changed (#%d)\n",

Re: [PATCH v2] usb: dwc2: Use generic PHY width in params setup

2019-06-06 Thread Marek Szyprowski
Hi All, On 2019-05-31 14:44, Minas Harutyunyan wrote: > On 5/9/2019 1:16 PM, Jules Maselbas wrote: >> Setting params.phy_utmi_width in dwc2_lowlevel_hw_init() is pointless >> since >> it's value will be overwritten by dwc2_init_params(). >> >> This change make sure to take in account the generic

Re: kernel NULL pointer dereference, ucsi bug

2019-06-06 Thread Vladimir Yerilov
Thanks a lot! Now I understand how to work with bisect in general. However, its log is unlikely to be of help because I use my distro tools to make a kernel package. So I dropped down into the merge commit and for now I am here: index : kernel/git/davem/net-next.git commit - time&date - works or n

Re: Slow I/O on USB media

2019-06-06 Thread Andrea Vai
Il giorno mer, 05/06/2019 alle 19.39 +0200, Greg KH ha scritto: > On Wed, Jun 05, 2019 at 06:23:58PM +0200, Andrea Vai wrote: > > Hi, > > Il giorno mer, 05/06/2019 alle 16.55 +0200, Greg KH ha scritto: > > > On Wed, Jun 05, 2019 at 09:36:04AM +0200, Andrea Vai wrote: > > > > Hi, > > > > Il giorno m

Re: Slow I/O on USB media

2019-06-06 Thread Andrea Vai
Il giorno mer, 05/06/2019 alle 19.39 +0200, Greg KH ha scritto: > On Wed, Jun 05, 2019 at 06:23:58PM +0200, Andrea Vai wrote: > [...] > In ssh I manually mount the media, > then > > run > > > > touch begin > > date > > > > date > > touch end > > That tests nothing other than the size of the memo