Re: [PATCH] usb: core: devio: add ioctls for suspend and resume

2019-06-05 Thread Alan Stern
On Wed, 5 Jun 2019, Greg KH wrote: > On Fri, May 10, 2019 at 11:01:09AM +0100, Mayuresh Kulkarni wrote: > > - The current driver increments the PM ref-count in its .open > > API and decrements it in its .close API. > > - Due to this, it is not possible for the usb_device to go into > > suspend (L2

Re: Slow I/O on USB media

2019-06-05 Thread Greg KH
On Wed, Jun 05, 2019 at 06:23:58PM +0200, Andrea Vai wrote: > Hi, > Il giorno mer, 05/06/2019 alle 16.55 +0200, Greg KH ha scritto: > > On Wed, Jun 05, 2019 at 09:36:04AM +0200, Andrea Vai wrote: > > > Hi, > > > Il giorno mar, 04/06/2019 alle 07.43 +0200, Greg KH ha scritto: > > > > On Mon, Jun 03,

[PATCH 1/2] usb: chipidea: imx: Use devm_platform_ioremap_resource()

2019-06-05 Thread Fabio Estevam
Use devm_platform_ioremap_resource() to simplify the code a bit. Signed-off-by: Fabio Estevam --- drivers/usb/chipidea/usbmisc_imx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index d8b67e150b12.

[PATCH 2/2] usb: chipidea: msm: Use devm_platform_ioremap_resource()

2019-06-05 Thread Fabio Estevam
Use devm_platform_ioremap_resource() to simplify the code a bit. Signed-off-by: Fabio Estevam --- drivers/usb/chipidea/ci_hdrc_msm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index b8b3caad889c.

Re: kernel NULL pointer dereference, ucsi bug

2019-06-05 Thread Greg KH
On Wed, Jun 05, 2019 at 04:36:23PM +1000, Vladimir Yerilov wrote: > Good day Mr. Kroah-Hartman, > > I've found the culprit commit. It took a while though but now I'm sure: > > commit - brief decription - time - works (y) or not (n) > 670784fb4ebe54434e263837390e358405031d9e - rc1 2019-05-20 > e26

Re: Slow I/O on USB media

2019-06-05 Thread Andrea Vai
Hi, Il giorno mer, 05/06/2019 alle 16.55 +0200, Greg KH ha scritto: > On Wed, Jun 05, 2019 at 09:36:04AM +0200, Andrea Vai wrote: > > Hi, > > Il giorno mar, 04/06/2019 alle 07.43 +0200, Greg KH ha scritto: > > > On Mon, Jun 03, 2019 at 01:13:48PM +0200, Andrea Vai wrote: > > > > Il giorno gio, 30/0

Re: Slow I/O on USB media

2019-06-05 Thread Alan Stern
On Wed, 5 Jun 2019, Andrea Vai wrote: > Hi, > Il giorno mer, 05/06/2019 alle 10.26 -0400, Alan Stern ha scritto: > > On Wed, 5 Jun 2019, Andrea Vai wrote: > > > > > Hi, > > > Il giorno mar, 04/06/2019 alle 07.43 +0200, Greg KH ha scritto: > > > > On Mon, Jun 03, 2019 at 01:13:48PM +0200, Andrea V

[PATCH v3] usb: chipidea: Use dev_err() instead of pr_err()

2019-06-05 Thread Fabio Estevam
dev_err() is more appropriate for printing error messages inside drivers, so switch to dev_err(). While at it also add the missing newlines. Signed-off-by: Fabio Estevam --- Changes since v2: - Keep the orginal string drivers/usb/chipidea/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 de

Re: Slow I/O on USB media

2019-06-05 Thread Andrea Vai
Hi, Il giorno mer, 05/06/2019 alle 10.26 -0400, Alan Stern ha scritto: > On Wed, 5 Jun 2019, Andrea Vai wrote: > > > Hi, > > Il giorno mar, 04/06/2019 alle 07.43 +0200, Greg KH ha scritto: > > > On Mon, Jun 03, 2019 at 01:13:48PM +0200, Andrea Vai wrote: > > > > Il giorno gio, 30/05/2019 alle 06.2

Re: [PATCH v2] usb: chipidea: Use dev_err() instead of pr_err()

2019-06-05 Thread Greg KH
On Wed, Jun 05, 2019 at 11:47:59AM -0300, Fabio Estevam wrote: > Hi Greg, > > On Wed, Jun 5, 2019 at 11:21 AM Greg KH wrote: > > > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > > > index 27749ace2d93..92132b35b7fd 100644 > > > --- a/drivers/usb/chipidea/core.c > > >

Re: Slow I/O on USB media

2019-06-05 Thread Greg KH
On Wed, Jun 05, 2019 at 09:36:04AM +0200, Andrea Vai wrote: > Hi, > Il giorno mar, 04/06/2019 alle 07.43 +0200, Greg KH ha scritto: > > On Mon, Jun 03, 2019 at 01:13:48PM +0200, Andrea Vai wrote: > > > Il giorno gio, 30/05/2019 alle 06.25 -0700, Greg KH ha scritto: > > > > [...] > > > Hi, > > > >

Re: Question: Device not recognized when connected without a hub. Why?

2019-06-05 Thread Alan Stern
On Wed, 5 Jun 2019, Chris Osicki wrote: > > Hi > > I stumbled over a behaviour when connecting a USB device which I couldn't > find any explanation for. > So, I'm trying here. > Why connecting a USB device (USB-TTL converter) direct and via an USB hub > makes a difference? > When I connect it

Re: [PATCH v2] usb: chipidea: Use dev_err() instead of pr_err()

2019-06-05 Thread Fabio Estevam
Hi Greg, On Wed, Jun 5, 2019 at 11:21 AM Greg KH wrote: > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > > index 27749ace2d93..92132b35b7fd 100644 > > --- a/drivers/usb/chipidea/core.c > > +++ b/drivers/usb/chipidea/core.c > > @@ -523,8 +523,9 @@ int hw_device_reset(s

Re: Slow I/O on USB media

2019-06-05 Thread Alan Stern
On Wed, 5 Jun 2019, Andrea Vai wrote: > Hi, > Il giorno mar, 04/06/2019 alle 07.43 +0200, Greg KH ha scritto: > > On Mon, Jun 03, 2019 at 01:13:48PM +0200, Andrea Vai wrote: > > > Il giorno gio, 30/05/2019 alle 06.25 -0700, Greg KH ha scritto: > > > > [...] > > > Hi, > > > > > > > Any chance you

Re: [PATCH] usb: hso: correct debug message

2019-06-05 Thread Greg KH
On Wed, Jun 05, 2019 at 02:59:42PM +0200, Oliver Neukum wrote: > If you do not find the OUT endpoint, you should say so, > rather than copy the error message for the IN endpoint. > Presumably a copy and paste error. > > Signed-off-by: Oliver Neukum > --- > drivers/net/usb/hso.c | 2 +- > 1 file

Re: [PATCH v2] usb: chipidea: Use dev_err() instead of pr_err()

2019-06-05 Thread Greg KH
On Wed, Jun 05, 2019 at 10:07:23AM -0300, Fabio Estevam wrote: > dev_err() is more appropriate for printing error messages inside > drivers, so switch to dev_err(). > > While at it also add the missing newlines and remove 'device' > string as the ci_role(ci)->name string will tell if it is host >

[PATCH v2] usb: chipidea: Use dev_err() instead of pr_err()

2019-06-05 Thread Fabio Estevam
dev_err() is more appropriate for printing error messages inside drivers, so switch to dev_err(). While at it also add the missing newlines and remove 'device' string as the ci_role(ci)->name string will tell if it is host or gadget. Signed-off-by: Fabio Estevam --- Changes since v1: - Add missi

[PATCH] usb: hso: correct debug message

2019-06-05 Thread Oliver Neukum
If you do not find the OUT endpoint, you should say so, rather than copy the error message for the IN endpoint. Presumably a copy and paste error. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/hso.c b/dr

[PATCH] usb: hso: correct debug message

2019-06-05 Thread Oliver Neukum
If you do not find the OUT endpoint, you should say so, rather than copy the error message for the IN endpoint. Presumably a copy and paste error. Signed-off-by: Oliver Neukum --- drivers/net/usb/hso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/hso.c b/dr

Re: [PATCH v2] USB: move usb debugfs directory creation to the usb common core

2019-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2019 at 01:44:26PM +0200, Marc Gonzalez wrote: > On 05/06/2019 11:28, Greg Kroah-Hartman wrote: > > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initialized > > and removed as needed. > >

Re: [PATCH v2] USB: move usb debugfs directory creation to the usb common core

2019-06-05 Thread Marc Gonzalez
On 05/06/2019 11:28, Greg Kroah-Hartman wrote: > The USB gadget subsystem wants to use the USB debugfs root directory, so > move it to the common "core" USB code so that it is properly initialized > and removed as needed. > > In order to properly do this, we need to load the common code before th

Re: [PATCH] usb: core: devio: add ioctls for suspend and resume

2019-06-05 Thread Greg KH
On Fri, May 10, 2019 at 11:01:09AM +0100, Mayuresh Kulkarni wrote: > - The current driver increments the PM ref-count in its .open > API and decrements it in its .close API. > - Due to this, it is not possible for the usb_device to go into > suspend (L2) even if all of its interfaces report idle to

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

2019-06-05 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2019 at 11:14:37AM +0200, Oliver Neukum wrote: > Am Montag, den 03.06.2019, 19:55 +0200 schrieb Marco Zatta: > > On Mon, Jun 03, 2019 at 11:58:10AM +0200, Oliver Neukum wrote: > > > Are you sure only the C270 is affected? > > > > > > Regards > > > Oliver > > > > Hello

Re: Slow I/O on USB media

2019-06-05 Thread Andrea Vai
Hi, Il giorno mar, 04/06/2019 alle 07.43 +0200, Greg KH ha scritto: > On Mon, Jun 03, 2019 at 01:13:48PM +0200, Andrea Vai wrote: > > Il giorno gio, 30/05/2019 alle 06.25 -0700, Greg KH ha scritto: > > > [...] > > Hi, > > > > > Any chance you can use 'git bisect' to find the offending > commit? >

RE: [PATCH v3 6/8] ARM: dts: imx7ulp: add imx7ulp USBOTG1 support

2019-06-05 Thread Peter Chen
> > Signed-off-by: Peter Chen > > --- > > arch/arm/boot/dts/imx7ulp.dtsi | 31 +++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi > > b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50f37c8..37b058119505 > > 100644 > > --- a/arch