Re: Raven Ridge xhci_hcd not working: "Refused to change power state, currently in D3"

2019-05-21 Thread Greg KH
On Tue, May 21, 2019 at 04:49:14PM -0500, Adam Gausmann wrote: > On my ThinkPad E585, with a Ryzen 5 2500U, my XHCI driver crashes when > plugging in a device after switching power states, or during switching itself. > > Steps to Reproduce: > > - Unplug the AC power, or start the computer with

Raven Ridge xhci_hcd not working: "Refused to change power state, currently in D3"

2019-05-21 Thread Adam Gausmann
On my ThinkPad E585, with a Ryzen 5 2500U, my XHCI driver crashes when plugging in a device after switching power states, or during switching itself. Steps to Reproduce: - Unplug the AC power, or start the computer with AC unplugged. If the computer has AC power at boot, it will work properly,

Re: [PATCH v3] usbnet: fix kernel crash after disconnect

2019-05-21 Thread David Miller
From: Kloetzke Jan Date: Tue, 21 May 2019 13:18:40 + > When disconnecting cdc_ncm the kernel sporadically crashes shortly > after the disconnect: ... > The crash happens roughly 125..130ms after the disconnect. This > correlates with the 'delay' timer that is started on certain USB tx/rx > e

RE: [PATCH v2 3/5] usb: typec: ucsi: ccg: enable runtime pm support

2019-05-21 Thread Ajay Gupta
Hi Heikki > > +static int ucsi_ccg_resume(struct device *dev) { > > + struct i2c_client *client = to_i2c_client(dev); > > + struct ucsi_ccg *uc = i2c_get_clientdata(client); > > + struct ucsi *ucsi = uc->ucsi; > > + struct ucsi_control c; > > + int ret; > > + > > + /* restore UCSI noti

[PATCH] media: usb: siano: Fix false-positive "uninitialized variable" warning

2019-05-21 Thread Alan Stern
GCC complains about an apparently uninitialized variable recently added to smsusb_init_device(). It's a false positive, but to silence the warning this patch adds a trivial initialization. Signed-off-by: Alan Stern Reported-by: kbuild test robot CC: --- drivers/media/usb/siano/smsusb.c |

Re: [usb:usb-linus 3/10] drivers/media//usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used uninitialized in this function

2019-05-21 Thread Greg Kroah-Hartman
On Tue, May 21, 2019 at 09:49:36AM -0400, Alan Stern wrote: > On Tue, 21 May 2019, Greg Kroah-Hartman wrote: > > > On Tue, May 21, 2019 at 04:48:47PM +0800, kbuild test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > > usb-linus > > > head: 53c7b63f

[PATCH v5 4/5] usb: host: ohci-tmio: init genalloc for local memory

2019-05-21 Thread laurentiu . tudor
From: Laurentiu Tudor In preparation for dropping the existing "coherent" dma mem declaration APIs, replace the current dma_declare_coherent_memory() based mechanism with the creation of a genalloc pool that will be used in the OHCI subsystem as replacement for the DMA APIs. For context, see thr

[PATCH v5 1/5] lib/genalloc.c: Add gen_pool_dma_zalloc() for zeroed DMA allocations

2019-05-21 Thread laurentiu . tudor
From: Fredrik Noring gen_pool_dma_zalloc() is a zeroed memory variant of gen_pool_dma_alloc(). Document return values of both, and indicate NULL as a "%NULL" constant. Signed-off-by: Fredrik Noring --- include/linux/genalloc.h | 1 + lib/genalloc.c | 29 -

[PATCH v5 0/5] prerequisites for device reserved local mem rework

2019-05-21 Thread laurentiu . tudor
From: Laurentiu Tudor For HCs that have local memory, replace the current DMA API usage with a genalloc generic allocator to manage the mappings for these devices. This is in preparation for dropping the existing "coherent" dma mem declaration APIs. Current implementation was relying on a short c

Re: [usb:usb-linus 3/10] drivers/media//usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used uninitialized in this function

2019-05-21 Thread Alan Stern
On Tue, 21 May 2019, Greg Kroah-Hartman wrote: > On Tue, May 21, 2019 at 04:48:47PM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > usb-linus > > head: 53c7b63f797c96a30c21dd3b781fafaae096a12b > > commit: 31e0456de5be379b10fea0fa94a

Re: [PATCH v2 3/5] usb: typec: ucsi: ccg: enable runtime pm support

2019-05-21 Thread Heikki Krogerus
On Tue, May 21, 2019 at 04:37:27PM +0300, Heikki Krogerus wrote: > Hi, > > On Mon, May 20, 2019 at 11:37:48AM -0700, Ajay Gupta wrote: > > +static int ucsi_ccg_resume(struct device *dev) > > +{ > > + struct i2c_client *client = to_i2c_client(dev); > > + struct ucsi_ccg *uc = i2c_get_clientdata

Re: [PATCH v2 3/5] usb: typec: ucsi: ccg: enable runtime pm support

2019-05-21 Thread Heikki Krogerus
Hi, On Mon, May 20, 2019 at 11:37:48AM -0700, Ajay Gupta wrote: > +static int ucsi_ccg_resume(struct device *dev) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + struct ucsi_ccg *uc = i2c_get_clientdata(client); > + struct ucsi *ucsi = uc->ucsi; > + struct ucsi_control

[PATCH v3] usbnet: fix kernel crash after disconnect

2019-05-21 Thread Kloetzke Jan
When disconnecting cdc_ncm the kernel sporadically crashes shortly after the disconnect: [ 57.868812] Unable to handle kernel NULL pointer dereference at virtual address ... [ 58.006653] PC is at 0x0 [ 58.009202] LR is at call_timer_fn+0xec/0x1b4 [ 58.013567] pc : [<000

Re: [usb:usb-linus 3/10] drivers/media//usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used uninitialized in this function

2019-05-21 Thread Greg Kroah-Hartman
On Tue, May 21, 2019 at 04:48:47PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > usb-linus > head: 53c7b63f797c96a30c21dd3b781fafaae096a12b > commit: 31e0456de5be379b10fea0fa94a681057114a96e [3/10] media: usb: siano: > Fix general pro

Re: JMicron JMS578 USB-to-SATA HDD enclosure not working

2019-05-21 Thread Oliver Neukum
On So, 2019-05-19 at 19:35 +0200, Guido Trentalancia wrote: > Thanks to the new firmware and its more meaningful Sense Key, I finally > realized that the hard-drive was simply "locked" as in the BIOS Hard- > Disk Password Lock feature. > > Therefore this is not a bug, the UAS driver is working fin

Re: [PATCH v2] usbnet: fix kernel crash after disconnect

2019-05-21 Thread Oliver Neukum
On Di, 2019-05-21 at 10:12 +, Kloetzke Jan wrote: > > Why not just take v1 of the patch? > > https://lore.kernel.org/netdev/20190417091849.7475-1-jan.kloet...@preh.de/ > > The original version was exactly the same, just without the WARN_ON(). > Or is it required to send a v3 in this case?

Re: [PATCH v2] usbnet: fix kernel crash after disconnect

2019-05-21 Thread Kloetzke Jan
Hi, Am Dienstag, den 21.05.2019, 11:48 +0200 schrieb Oliver Neukum: > On Do, 2019-05-16 at 07:10 +, Kloetzke Jan wrote: > > Am Montag, den 06.05.2019, 10:17 +0200 schrieb Oliver Neukum: > > > On So, 2019-05-05 at 00:45 -0700, David Miller wrote: > > > > From: Kloetzke Jan > > > > Date: Tue, 3

Re: [PATCH v2] usbnet: fix kernel crash after disconnect

2019-05-21 Thread Oliver Neukum
On Do, 2019-05-16 at 07:10 +, Kloetzke Jan wrote: > Am Montag, den 06.05.2019, 10:17 +0200 schrieb Oliver Neukum: > > On So, 2019-05-05 at 00:45 -0700, David Miller wrote: > > > From: Kloetzke Jan > > > Date: Tue, 30 Apr 2019 14:15:07 + > > > > > > > @@ -1431,6 +1432,11 @@ netdev_tx_t usb

Re: [PATCH 1/1] USB: serial: option: add Telit 0x1260 and 0x1261 compositions

2019-05-21 Thread Johan Hovold
On Wed, May 15, 2019 at 05:27:49PM +0200, Daniele Palmas wrote: > Added support for Telit LE910Cx 0x1260 and 0x1261 compositions. > > Signed-off-by: Daniele Palmas Applied, thanks. Johan

Re: [PATCH] USB: serial: option: add support for Simcom SIM7500/SIM7600 RNDIS mode

2019-05-21 Thread Johan Hovold
On Mon, May 13, 2019 at 06:37:52PM +0200, Jörgen Storvist wrote: > Added IDs for Simcom SIM7500/SIM7600 series cellular module in RNDIS > mode. Reserved the interface for ADB. > Signed-off-by: Jörgen Storvist Applied, thanks. Johan

[usb:usb-linus 3/10] drivers/media//usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used uninitialized in this function

2019-05-21 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus head: 53c7b63f797c96a30c21dd3b781fafaae096a12b commit: 31e0456de5be379b10fea0fa94a681057114a96e [3/10] media: usb: siano: Fix general protection fault in smsusb config: mips-allmodconfig (attached as .config) compil

RE: [PATCH v2 6/8] ARM: dts: imx7ulp: add imx7ulp USBOTG1 support

2019-05-21 Thread Peter Chen
> > 1 file changed, 31 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi > > b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50f37c8..60c9ea116d0a > > 100644 > > --- a/arch/arm/boot/dts/imx7ulp.dtsi > > +++ b/arch/arm/boot/dts/imx7ulp.dtsi > > @@ -30,6 +30,7 @@ > > serial

Re: TODO advice for octeon-usb?

2019-05-21 Thread Greg Kroah-Hartman
On Tue, May 21, 2019 at 02:05:32AM +0300, Aaro Koskinen wrote: > Hi, > > I'm looking for input what should be done next to get > drivers/staging/octeon-usb out of staging. > > Thousands of checkpatch errors/warnings have been fixed (starting point > was