Re: WARNING in usb_submit_urb (4)

2019-04-18 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+7634edaea4d0b341c...@syzkaller.appspotmail.com Tested on: commit: e12e00e3 Merge tag 'kbuild-fixes-v4.20' of git://git.kerne.. git tree: git://git.kernel.o

Re: WARNING in usb_submit_urb (4)

2019-04-18 Thread Alan Stern
On Thu, 18 Apr 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger > crash: > > Reported-and-tested-by: > syzbot+7634edaea4d0b341c...@syzkaller.appspotmail.com > > Tested on: > > commit: e12e00e3 Merge tag 'kbuild-fixes-v4.20' of

Re: WARNING in usb_submit_urb (4)

2019-04-18 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+7634edaea4d0b341c...@syzkaller.appspotmail.com Tested on: commit: e12e00e3 Merge tag 'kbuild-fixes-v4.20' of git://git.kerne.. git tree: git://git.kernel.o

Re: WARNING in usb_submit_urb (4)

2019-04-18 Thread Alan Stern
On Thu, 18 Apr 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > WARNING in usb_submit_urb > > hub 3-0:1.0: b89ba4aa hub_resume > hub 3-0:1.0: b89ba4aa hub_activate type 1 discon 0 > hub 3-0:1.0: b89ba4aa

Re: WARNING in usb_submit_urb (4)

2019-04-18 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: WARNING in usb_submit_urb hub 3-0:1.0: b89ba4aa hub_resume hub 3-0:1.0: b89ba4aa hub_activate type 1 discon 0 hub 3-0:1.0: b89ba4aa hub_activate type 4 discon 0 [ cut here

[PATCH] USB: dummy-hcd: Fix failure to give back unlinked URBs

2019-04-18 Thread Alan Stern
The syzkaller USB fuzzer identified a failure mode in which dummy-hcd would never give back an unlinked URB. This causes usb_kill_urb() to hang, leading to WARNINGs and unkillable threads. In dummy-hcd, all URBs are given back by the dummy_timer() routine as it scans through the list of pending U

Re: WARNING in usb_submit_urb (4)

2019-04-18 Thread Alan Stern
On Thu, 18 Apr 2019, Alan Stern wrote: > On Wed, 17 Apr 2019, Alan Stern wrote: > > > I'm still having trouble understanding this. Here's some more > > debugging. > > Let's try this again. The patch format was wrong. One more try, this time with the syz command line. Incidentally, the conso

[PATCH 2/2] USB: serial: digi_acceleport: clean up set_termios

2019-04-18 Thread Johan Hovold
Clean up set_termios() by adding missing white space around operators and making a couple of continuation lines more readable. Also drop a couple of redundant braces. Signed-off-by: Johan Hovold --- drivers/usb/serial/digi_acceleport.c | 33 ++-- 1 file changed, 16 inser

[PATCH 1/2] USB: serial: digi_acceleport: clean up modem-control handling

2019-04-18 Thread Johan Hovold
Clean up modem-control handling somewhat by adding missing whitespace around operators and splitting a long statement in two. Signed-off-by: Johan Hovold --- drivers/usb/serial/digi_acceleport.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/digi_a

[PATCH] USB: serial: pl2303: fix xon/xoff flow control

2019-04-18 Thread Johan Hovold
Fix the XON/XOFF flow-control implementation by reporting back the attributes actually supported while ignoring the rest. Note that only outgoing XON/XOFF flow control (IXON) is currently supported for PL2303HX, and only using the default start and stop chars. Fixes: 68270dab9710 ("USB: serial: p

Re: WARNING in usb_submit_urb (4)

2019-04-18 Thread Alan Stern
On Wed, 17 Apr 2019, Alan Stern wrote: > I'm still having trouble understanding this. Here's some more > debugging. Let's try this again. The patch format was wrong. Alan Stern --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1016,6 +1016,9 @@ static void hub_activate(struct usb

[PATCH v3] usb: host: use usb_endpoint_maxp instead of usb_maxpacket

2019-04-18 Thread zhuyan
From: Yan Zhu fhci_queue_urb() shouldn't use urb->pipe to compute the maxpacket size anyway.It should use usb_endpoint_maxp(&urb->ep->desc). Signed-off-by: Yan Zhu --- drivers/usb/host/fhci-sched.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/

[PATCH] usb: dwc2: gadget: Reject LPM token during Control transfers

2019-04-18 Thread Minas Harutyunyan
Avoiding switch to L1 state in any stage of control transfers. Send NYET handshake to LPM token. Renamed GLPMCFG_LPM_ACCEPT_CTRL_ISOC to GLPMCFG_LPM_REJECT_CTRL_CONTROL because by setting this bit core reject LPM token. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 1 + drive