[BUG] ASIX AX88179 USB-Ethernet NICs not sending/receiving frames

2019-03-02 Thread Bradley Chapman
All, I am trying to get an ASIX AX88179 USB 3.0 dual Ethernet NIC dongle to work on an SFF system running Linux 4.20.13. The NICs are properly detected and named eth3 and eth4 by udev and I can configure and administer them like any other NIC, but neither interface is able to fully establish

Re: [PATCH v2 2/2] usb: typec: add typec switch via GPIO control

2019-03-02 Thread Andy Shevchenko
On Fri, Mar 1, 2019 at 3:25 AM Jun Li wrote: > > This patch adds a simple typec switch driver which only needs > a GPIO to switch the super speed active channel according to > typec orientation. FWIW, Reviewed-by: Andy Shevchenko One minor below. > > Signed-off-by: Li Jun > --- > > Changes fo

Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-02 Thread Andy Shevchenko
On Sat, Mar 2, 2019 at 11:05 AM Yu Chen wrote: > > This driver handles usb hub power on and typeC port event of HiKey960 board: > 1)DP&DM switching between usb hub and typeC port base on typeC port > state > 2)Control power of usb hub on Hikey960 > 3)Control vbus of typeC port > +config HISI_HIKE

Re: [PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon

2019-03-02 Thread Andy Shevchenko
On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: > > This driver handles usb phy power on and shutdown for hi3660 Soc of > Hisilicon. Few comments below. After fixing them, FWIW Reviewed-by: Andy Shevchenko > +#define HI3660_USB_DEFAULT_PHY_PARAM 0x1c466e3 A bit of description would be

Re: [PATCH v3 06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2019-03-02 Thread Andy Shevchenko
On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: > > It needs more time for the device controller to clear the CmdAct of > DEPCMD on Hisilicon Kirin Soc. > 5x times more? Can you provide more specific details on that? > Cc: Andy Shevchenko > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: John

Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-02 Thread Greg Kroah-Hartman
On Sat, Mar 02, 2019 at 02:51:41PM +0100, Oliver Neukum wrote: > On Sa, 2019-03-02 at 09:00 +0100, Greg Kroah-Hartman wrote: > > On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote: > > > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > > > > By moving one field around in 'st

Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-02 Thread Oliver Neukum
On Sa, 2019-03-02 at 09:00 +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote: > > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > > > By moving one field around in 'struct urb' we reduce the size of the > > > structure by 8 bytes. > > >

[PATCH] USB: serial: option: Add support for Quectel EM12

2019-03-02 Thread Kristian Evensen
The Quectel EM12 is a Cat. 12 LTE modem. It behaves in the exactly the same way as the EP06 (including the dynamic configuration behavior), so the same checkes on reserved interfaces, etc. are needed. Signed-off-by: Kristian Evensen --- drivers/usb/serial/option.c | 4 1 file changed, 4 ins

Re: [PATCH 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue

2019-03-02 Thread Martin Blumenstingl
Hi Neil, > > +static int dwc3_meson_g12a_debugfs_init(struct dwc3_meson_g12a *priv) > > +{ > > + priv->root = debugfs_create_dir("dwc3-meson-g12a", NULL); > > + if (IS_ERR(priv->root)) > > + return PTR_ERR(priv->root); > > + > > + debugfs_create_file("mode_force", 0

[PATCH v3 03/12] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform

2019-03-02 Thread Yu Chen
This patch adds support for the poweron and shutdown of dwc3 core on Hisilicon Soc Platform. --- drivers/usb/dwc3/dwc3-of-simple.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index 4c2771c5e727..0ed09

[PATCH v3 04/12] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2019-03-02 Thread Yu Chen
SPLIT_BOUNDARY_DISABLE should be set for DesignWare USB3 DRD Core of Hisilicon Kirin Soc when dwc3 core act as host. Cc: Andy Shevchenko Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- drivers/usb/dwc3/core.c | 24

[PATCH v3 06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2019-03-02 Thread Yu Chen
It needs more time for the device controller to clear the CmdAct of DEPCMD on Hisilicon Kirin Soc. Cc: Andy Shevchenko Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH v3 01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-03-02 Thread Yu Chen
This patch adds binding documentation for supporting the hi3660 usb phy on boards like the HiKey960. Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v1: * Fix some format error as suggested by Rob. v2: * Change hi3660 usb PHY to hi3660 USB PHY v3:

[PATCH v3 09/12] usb: dwc3: Registering a role switch in the DRD code.

2019-03-02 Thread Yu Chen
The Type-C drivers use USB role switch API to inform the system about the negotiated data role, so registering a role switch in the DRD code in order to support platforms with USB Type-C connectors. Cc: Jun Li Cc: Valentin Schneider Cc: John Stultz Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc:

[PATCH v3 05/12] usb: dwc3: Execute GCTL Core Soft Reset while switch mdoe for Hisilicon Kirin Soc

2019-03-02 Thread Yu Chen
A GCTL soft reset should be executed when switch mode for dwc3 core of Hisilicon Kirin Soc. Cc: Andy Shevchenko Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- drivers/usb/dwc3/core.c | 19 +++ drivers/usb/dwc3/core.h | 1

[PATCH v3 02/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2019-03-02 Thread Yu Chen
This patch adds binding documentation to support usb hub and usb data role switch of Hisilicon HiKey960 Board. Cc: Sergei Shtylyov Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v1: * Fix some format errors as suggested by Sergei. * Modify gpio d

[PATCH v3 08/12] usb: roles: Add usb role switch notifier.

2019-03-02 Thread Yu Chen
This patch adds notifier for drivers want to be informed of the usb role switch. Cc: Greg Kroah-Hartman Cc: Heikki Krogerus Cc: Hans de Goede Cc: Andy Shevchenko Cc: John Stultz Suggested-by: Heikki Krogerus Signed-off-by: Yu Chen --- drivers/usb/roles/class.c | 20 +++- in

[PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon

2019-03-02 Thread Yu Chen
This driver handles usb phy power on and shutdown for hi3660 Soc of Hisilicon. Cc: Andy Shevchenko Cc: Kishon Vijay Abraham I Cc: "David S. Miller" Cc: Greg Kroah-Hartman Cc: Mauro Carvalho Chehab Cc: Andrew Morton Cc: Arnd Bergmann Cc: Shawn Guo Cc: Pengcheng Li Cc: Jianguo Sun Cc: Masa

[PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

2019-03-02 Thread Yu Chen
This driver handles usb hub power on and typeC port event of HiKey960 board: 1)DP&DM switching between usb hub and typeC port base on typeC port state 2)Control power of usb hub on Hikey960 3)Control vbus of typeC port Cc: Chunfeng Yun Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Greg Kroah-Hartma

[PATCH v3 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only

2019-03-02 Thread Yu Chen
Currently the "match_existing_only" of usb_gadget_driver in configfs is set to one which is not flexible. Dwc3 udc will be removed when usb core switch to host mode. This causes failure of writing name of dwc3 udc to configfs's UDC attribuite. To fix this we need to add a way to change the config o

[PATCH v3 12/12] dts: hi3660: Add support for usb on Hikey960

2019-03-02 Thread Yu Chen
This patch adds support for usb on Hikey960. Cc: Chunfeng Yun Cc: Wei Xu Cc: Rob Herring Cc: Mark Rutland Cc: linux-arm-ker...@lists.infradead.org Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- v2: * Remove device_type property. * Add property "usb-role-switch". v3: * Make node

[PATCH v3 00/12] Add support for usb on Hikey960

2019-03-02 Thread Yu Chen
The patchset adds support for usb functionality of Hikey960, includes: - dwc3 driver for Hisilicon Kirin Soc hi3660 - usb driver for HiKey960 board - some adjustment in dwc3, usb gadget and typec driver - dts for support usb of HiKey960 This patchset based on patchset https://lkml.org/lkml/2019/1/

Re: [PATCH] USB: usb.h: tweak struct urb to remove wasted space

2019-03-02 Thread Greg Kroah-Hartman
On Fri, Mar 01, 2019 at 08:44:13PM +0100, Oliver Neukum wrote: > On Fr, 2019-03-01 at 18:22 +0100, Greg Kroah-Hartman wrote: > > By moving one field around in 'struct urb' we reduce the size of the > > structure by 8 bytes. > > If you are going for this I have to ask why unlink and status > are fu