RE: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate modes

2019-02-15 Thread Michael Hsu
Hi Heikki, > -Original Message- > From: Heikki Krogerus > Sent: Tuesday, February 12, 2019 7:22 AM > To: Michael Hsu > Cc: Greg Kroah-Hartman ; Ajay Gupta > ; linux-usb@vger.kernel.org > Subject: Re: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate > modes > > Hi, > > On

patch "usb: f_fs: Avoid crash due to out-of-scope stack ptr access" added to usb-next

2019-02-15 Thread gregkh
This is a note to let you know that I've just added the patch titled usb: f_fs: Avoid crash due to out-of-scope stack ptr access to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-next branch. The patch will show up in the n

Re: [usb:usb-testing 63/64] drivers/usb/typec/mux.c:167 typec_mux_match() warn: unsigned 'nval' is never less than zero.

2019-02-15 Thread Andy Shevchenko
On Fri, Feb 15, 2019 at 4:40 PM Heikki Krogerus wrote: > > On Fri, Feb 15, 2019 at 11:19:47AM +0200, Andy Shevchenko wrote: > > On Fri, Feb 15, 2019 at 11:01 AM Heikki Krogerus > > wrote: > > > > > > On Fri, Feb 15, 2019 at 01:33:24PM +0800, kbuild test robot wrote: > > > > tree: https://git.ke

[PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-15 Thread Paul Kocialkowski
According to the chipidea driver bindings, the USB PHY is specified via the "phys" phandle node. However, this only takes effect for USB PHYs that use the common PHY framework. For legacy USB PHYs, a simple lookup based on the USB PHY type is done instead. This does not play out well when more tha

Re: USB microphone does not get the required bandwidth

2019-02-15 Thread Michael Häckel
Thank you for the reply. Ok, I will read the specification about isochronous transfers and check, whether I can do something or not. The specification is indeed quite long. A long time ago I was quite active in open source development, but I didn't expect that I will ever dive so deep into the k

Re: [usb:usb-testing 63/64] drivers/usb/typec/mux.c:167 typec_mux_match() warn: unsigned 'nval' is never less than zero.

2019-02-15 Thread Heikki Krogerus
On Fri, Feb 15, 2019 at 11:19:47AM +0200, Andy Shevchenko wrote: > On Fri, Feb 15, 2019 at 11:01 AM Heikki Krogerus > wrote: > > > > On Fri, Feb 15, 2019 at 01:33:24PM +0800, kbuild test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > > usb-testing >

Re: [PATCH v3 0/9] device connection: Add support for device graphs

2019-02-15 Thread Heikki Krogerus
Hi Greg, On Thu, Feb 14, 2019 at 11:10:44AM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 13, 2019 at 10:45:48AM +0300, Heikki Krogerus wrote: > > Hi, > > > > This is the third version of my proposal to add device graph parsing > > to the device connection API. There was only one problem reporte

Re: [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607

2019-02-15 Thread Bjørn Mork
Beniamino Galvani writes: > The 1199:68C0 USB ID is reused by Sierra WP7607 which requires the DTR > quirk to be detected. Apply QMI_QUIRK_SET_DTR unconditionally as > already done for other IDs shared between different devices. > > Signed-off-by: Beniamino Galvani Thanks. Looks like it's time

[PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607

2019-02-15 Thread Beniamino Galvani
The 1199:68C0 USB ID is reused by Sierra WP7607 which requires the DTR quirk to be detected. Apply QMI_QUIRK_SET_DTR unconditionally as already done for other IDs shared between different devices. Signed-off-by: Beniamino Galvani --- drivers/net/usb/qmi_wwan.c | 4 ++-- 1 file changed, 2 inserti

[PATCH v2 -next] usb: host: oxu210hp-hcd: remove set but not used variables 'uframes, transfer_buffer_length'

2019-02-15 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/host/oxu210hp-hcd.c: In function 'scan_periodic': drivers/usb/host/oxu210hp-hcd.c:2256:13: warning: variable 'uframes' set but not used [-Wunused-but-set-variable] drivers/usb/host/oxu210hp-hcd.c: In function 'oxu_urb_enqueue': drivers/u

Re: [PATCH -next] usb: host: oxu210hp-hcd: remove set but not used variables 'uframes, transfer_buffer_length'

2019-02-15 Thread YueHaibing
On 2019/2/15 16:11, Sergei Shtylyov wrote: > Hello! > > On 15.02.2019 6:17, YueHaibing wrote: > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/usb/host/oxu210hp-hcd.c: In function 'scan_periodic': >> drivers/usb/host/oxu210hp-hcd.c:2256:13: warning: >> variable 'uframes' set

Re: [PATCH v4 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-02-15 Thread Chunfeng Yun
hi, On Thu, 2019-02-14 at 19:45 +, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to linux kernel. > > The Cadence USBSS DRD Driver is a highly configurable IP Core whichi > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configur

Re: [usb:usb-testing 63/64] drivers/usb/typec/mux.c:167 typec_mux_match() warn: unsigned 'nval' is never less than zero.

2019-02-15 Thread Andy Shevchenko
On Fri, Feb 15, 2019 at 11:01 AM Heikki Krogerus wrote: > > On Fri, Feb 15, 2019 at 01:33:24PM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > usb-testing > > head: 09aa11cfda9d8186046bcd1adcd6498b688114f4 > > commit: 96a6d031ca9930

Re: [PATCH] usb: typec: tps6598x: Check mode of operation

2019-02-15 Thread Heikki Krogerus
On Thu, Feb 14, 2019 at 06:29:43PM +0300, Sergei Shtylyov wrote: > On 02/14/2019 06:28 PM, Heikki Krogerus wrote: > > > +static int tps6598x_check_mode(struct tps6598x *tps) > > +{ > > + char mode[5] = { }; > > + int ret; > > + > > + ret = tps6598x_read32(

Re: [usb:usb-testing 63/64] drivers/usb/typec/mux.c:167 typec_mux_match() warn: unsigned 'nval' is never less than zero.

2019-02-15 Thread Heikki Krogerus
On Fri, Feb 15, 2019 at 01:33:24PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > usb-testing > head: 09aa11cfda9d8186046bcd1adcd6498b688114f4 > commit: 96a6d031ca9930938bd66d0052fc7ed2b56e3583 [63/64] usb: typec: mux: > Find the muxes

RE: patch "usb: misc: usbtest: add super-speed isoc support" added to usb-testing

2019-02-15 Thread Felipe Balbi
Hi, Peter Chen writes: > >> This is a note to let you know that I've just added the patch titled >> >> usb: misc: usbtest: add super-speed isoc support >> >> to my usb git tree which can be found at >> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >> in the usb-testing

RE: patch "usb: misc: usbtest: add super-speed isoc support" added to usb-testing

2019-02-15 Thread Peter Chen
> This is a note to let you know that I've just added the patch titled > > usb: misc: usbtest: add super-speed isoc support > > to my usb git tree which can be found at > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > in the usb-testing branch. > > The patch will show u

RE: [PATCH 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot

2019-02-15 Thread Ran Wang
Hi Felipe, Sorry for the late response, I didn't receive your mail. Felipe Balbi wrotes: >Hi, > >Ran Wang writes: >> +static void dwc3_power_off_all_roothub_ports(struct dwc3 *dwc) >> +{ >> +int i, port_num; >> +u32 reg, op_regs_base, offset; >> +void __iomem*xhci_re

Re: [GIT PULL] USB changes for v5.1

2019-02-15 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: >> Here's my pull request for v5.1. Changes have been sitting in next for a >> while now. No shenanigans were reported. >> >> Surprisingly, we have only 40 commits thihs time. Even less than the >> previous time. Seems like I could train a deep neural network to

Re: [PATCH] USB: serial: ftdi_sio: add ID for Hjelmslund Electronics USB485

2019-02-15 Thread Johan Hovold
On Thu, Feb 14, 2019 at 07:45:33PM +, Mans Rullgard wrote: > This adds the USB ID of the Hjelmslund Electronics USB485 Iso stick. > > Signed-off-by: Mans Rullgard Applied, thanks. Johan

patch "usb: f_fs: Avoid crash due to out-of-scope stack ptr access" added to usb-testing

2019-02-15 Thread gregkh
This is a note to let you know that I've just added the patch titled usb: f_fs: Avoid crash due to out-of-scope stack ptr access to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-testing branch. The patch will show up in th

Re: [GIT PULL] USB changes for v5.1

2019-02-15 Thread Greg Kroah-Hartman
On Fri, Feb 15, 2019 at 08:44:36AM +0200, Felipe Balbi wrote: > > Hi Greg, > > Here's my pull request for v5.1. Changes have been sitting in next for a > while now. No shenanigans were reported. > > Surprisingly, we have only 40 commits thihs time. Even less than the > previous time. Seems like

Re: [PATCH -next] usb: host: oxu210hp-hcd: remove set but not used variables 'uframes, transfer_buffer_length'

2019-02-15 Thread Sergei Shtylyov
Hello! On 15.02.2019 6:17, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/host/oxu210hp-hcd.c: In function 'scan_periodic': drivers/usb/host/oxu210hp-hcd.c:2256:13: warning: variable 'uframes' set but not used [-Wunused-but-set-variable] drivers/usb/host/oxu210