[PATCH 1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property

2019-02-04 Thread Srinath Mannam
Add usb-phy-port-reset optional property to set quirk in xhci platform driver which forces USB port PHY reset on port disconnect event. Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/D

[PATCH 2/2] drivers: xhci: Add quirk to reset xHCI port PHY

2019-02-04 Thread Srinath Mannam
Add a quirk to reset xHCI port PHY on port disconnect event. Stingray USB HS PHY has an issue, that USB High Speed device detected at Full Speed after the same port has connected to Full speed device. This problem can be resolved with that port PHY reset on disconnect. Signed-off-by: Srinath Manna

[PATCH 0/2] Reset xHCI port PHY on disconnect

2019-02-04 Thread Srinath Mannam
This patch set adds a quirk in xHCI driver to reset PHY of xHCI port on its disconnect event. This patch set is based on Linux-5.0-rc2. Srinath Mannam (2): dt-bindings: usb-xhci: Add usb-phy-port-reset property drivers: xhci: Add quirk to reset xHCI port PHY Documentation/devicetree/binding

RE: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate modes

2019-02-04 Thread Michael Hsu
Hi Heikki, > -Original Message- > From: Heikki Krogerus > Sent: Monday, February 4, 2019 4:10 AM > To: Michael Hsu > Cc: Greg Kroah-Hartman ; Ajay Gupta > ; linux-usb@vger.kernel.org > Subject: Re: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate > modes > > Hi, > > On F

RE: [PATCH 5/5] usb: typec: ucsi: Support for DisplayPort alt mode

2019-02-04 Thread Ajay Gupta
Hi Heikki, > -Original Message- > From: linux-usb-ow...@vger.kernel.org On > Behalf Of Heikki Krogerus > Sent: Friday, February 1, 2019 2:48 AM > To: Greg Kroah-Hartman ; Ajay Gupta > ; Michael Hsu > Cc: linux-usb@vger.kernel.org > Subject: [PATCH 5/5] usb: typec: ucsi: Support for Displ

RE: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate modes

2019-02-04 Thread Ajay Gupta
Hi Heikki > -Original Message- > From: linux-usb-ow...@vger.kernel.org On > Behalf Of Heikki Krogerus > Sent: Friday, February 1, 2019 2:48 AM > To: Greg Kroah-Hartman ; Ajay Gupta > ; Michael Hsu > Cc: linux-usb@vger.kernel.org > Subject: [PATCH 4/5] usb: typec: ucsi: Preliminary suppor

Re: Frequent dwc3 crashes on suspend or reboot since 5.0-rc1

2019-02-04 Thread John Stultz
On Sat, Feb 2, 2019 at 9:00 AM Alan Stern wrote: > > On Fri, 1 Feb 2019, John Stultz wrote: > > > Hey all, > > Since the 5.0 merge window opened, I've been tripping on frequent > > dwc3 crashes on reboot and suspend, which I've added an example to the > > bottom of this mail. > > > > I've dug in

Re: [PATCH v2 2/2] PCI: Override Synopsys USB 3.x HAPS device class

2019-02-04 Thread Trent Piepho
On Mon, 2019-02-04 at 23:18 +, Thinh Nguyen wrote: > Trent Piepho wrote: > > On Mon, 2018-12-10 at 14:08 -0800, Thinh Nguyen wrote: > > > Synopsys USB 3.x host HAPS platform has a class code of > > > PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these > > > devices should us

Re: [PATCH v2 2/2] PCI: Override Synopsys USB 3.x HAPS device class

2019-02-04 Thread Thinh Nguyen
Hi Trent, Trent Piepho wrote: > On Mon, 2018-12-10 at 14:08 -0800, Thinh Nguyen wrote: >> Synopsys USB 3.x host HAPS platform has a class code of >> PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these >> devices should use dwc3-haps driver. Change these devices' class code to >

Re: [PATCH v2 2/2] PCI: Override Synopsys USB 3.x HAPS device class

2019-02-04 Thread Trent Piepho
On Mon, 2018-12-10 at 14:08 -0800, Thinh Nguyen wrote: > Synopsys USB 3.x host HAPS platform has a class code of > PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these > devices should use dwc3-haps driver. Change these devices' class code to > PCI_CLASS_SERIAL_USB_DEVICE to prev

Re: [PATCH 3/3] udc: net2280: Fix typo

2019-02-04 Thread Alan Stern
On Mon, 4 Feb 2019, Guido Kiener wrote: > From: Guido Kiener > > Fix spelling of automatically. > > Signed-off-by: Guido Kiener > --- > drivers/usb/gadget/udc/net2280.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/net2280.c > b/drivers/usb/

Re: [PATCH 2/3] udc: net2280: Fix overrun of OUT messages

2019-02-04 Thread Alan Stern
On Mon, 4 Feb 2019, Guido Kiener wrote: > From: Guido Kiener > > The OUT endpoint normally blocks (NAK) subsequent packets when a > short packet is received and returns an incomplete queue entry to > the gadget driver. Thereby the gadget driver can detect > a short packet when reading queue entr

Re: [PATCH 1/3] udc: net2280: Fix net2280_disable

2019-02-04 Thread Alan Stern
On Mon, 4 Feb 2019, Guido Kiener wrote: > From: Guido Kiener > > A reset e.g. calling ep_reset_338x() can happen while endpoints > are enabled. How can this happen? That routine is called from only two places. One is in net2280_disable(), so after the endpoint has already been disabled. The

[PATCH 1/3] udc: net2280: Fix net2280_disable

2019-02-04 Thread Guido Kiener
From: Guido Kiener A reset e.g. calling ep_reset_338x() can happen while endpoints are enabled. The ep_reset_338x() sets ep->desc = NULL to mark endpoint being invalid. A subsequent call of net2280_disable will fail and return -EINVAL to parent function usb_ep_disable(), which will fail, too, and

[PATCH 2/3] udc: net2280: Fix overrun of OUT messages

2019-02-04 Thread Guido Kiener
From: Guido Kiener The OUT endpoint normally blocks (NAK) subsequent packets when a short packet is received and returns an incomplete queue entry to the gadget driver. Thereby the gadget driver can detect a short packet when reading queue entries with a length that is not equal to a multiple of

[PATCH 3/3] udc: net2280: Fix typo

2019-02-04 Thread Guido Kiener
From: Guido Kiener Fix spelling of automatically. Signed-off-by: Guido Kiener --- drivers/usb/gadget/udc/net2280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c index 1cb58fd5d1c6..430d582d8b6e 100644 ---

Re: [PATCH] USB: serial: cp210x: add GPIO support for CP2104

2019-02-04 Thread Johan Hovold
On Mon, Jan 28, 2019 at 01:57:17PM +0800, Icenowy Zheng wrote: > The CP2104 chips feature 4 controllable GPIO pins, which are similar to > the ones on CP2102N chip (output-only when push-pull, output or > simulated input mode when open-drain). > > Add support for the GPIO pins for cp210x driver. T

Re: [PATCH] USB: serial: cp210x: Fix GPIO in autosuspend

2019-02-04 Thread Johan Hovold
On Tue, Jan 15, 2019 at 11:29:42AM +0100, Johan Hovold wrote: > On Tue, Jan 15, 2019 at 10:26:07AM +0100, Johan Hovold wrote: > > On Tue, Jan 15, 2019 at 09:17:58AM +, Karoly Pados wrote: > > > > I think it's better to add the autopm call to gpio210x_gpio_get/set > > > > only. This will allow f

Re: [PATCH] USB: serial: cp210x: add minimun baud rate for CP2105 SCI

2019-02-04 Thread Johan Hovold
On Mon, Feb 04, 2019 at 04:57:00PM +0100, Johan Hovold wrote: > On Mon, Feb 04, 2019 at 12:21:30PM +0100, Johanna Abrahamsson wrote: > > From: Johanna Abrahamsson > > > > This patch adds a minimum baud rate of 2400 for CP2105 SCI > > > > According to the datasheet for CP2105, the SCI supports 24

Re: [PATCH] USB: serial: cp210x: add minimun baud rate for CP2105 SCI

2019-02-04 Thread Johan Hovold
On Mon, Feb 04, 2019 at 12:21:30PM +0100, Johanna Abrahamsson wrote: > From: Johanna Abrahamsson > > This patch adds a minimum baud rate of 2400 for CP2105 SCI > > According to the datasheet for CP2105, the SCI supports 2400 as the > lowest baud rate. As this is not heeded in the current code, a

Re: [regression] USB power management failure to suspend / high CPU usage

2019-02-04 Thread Mathias Nyman
On 04.02.2019 17:27, Alan Stern wrote: On Mon, 4 Feb 2019, Mathias Nyman wrote: Hi Mathias, I see this behavior even in 4.20.6. With the above commit reverted, my laptop suspends and resumes properly again and I don't see the high CPU usage of the mentioned kernel threads. When I suspend with

Re: [regression] USB power management failure to suspend / high CPU usage

2019-02-04 Thread Alan Stern
On Mon, 4 Feb 2019, Mathias Nyman wrote: > >> Hi Mathias, > >> > >> I see this behavior even in 4.20.6. With the above commit reverted, my > >> laptop suspends and resumes properly again and I don't see the high > >> CPU usage of the mentioned kernel threads. > >> > >> When I suspend with the dyna

Re: [regression] USB power management failure to suspend / high CPU usage

2019-02-04 Thread Mathias Nyman
On 04.02.2019 15:17, Eric Blau wrote: On Mon, Feb 4, 2019 at 8:12 AM Eric Blau wrote: On Mon, Feb 4, 2019 at 4:31 AM Mathias Nyman wrote: On 03.02.2019 04:08, Eric Blau wrote: I finally was able to complete the bisect on this issue. It seems that this commit introduced the regression on m

Re: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-04 Thread Greg KH
On Mon, Feb 04, 2019 at 04:17:00PM +0200, Felipe Balbi wrote: > > Hi, > > Greg KH writes: > > On Thu, Jan 31, 2019 at 11:52:29AM +, Pawel Laszczak wrote: > >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > >> to driver/usb/common/debug.c file. These moved functions

Re: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-04 Thread Felipe Balbi
Hi, Greg KH writes: > On Thu, Jan 31, 2019 at 11:52:29AM +, Pawel Laszczak wrote: >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver >> to driver/usb/common/debug.c file. These moved functions include: >> dwc3_decode_get_status >> dwc3_decode_set_clear_feature

Re: [PATCH 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-02-04 Thread Thierry Reding
On Thu, Jan 03, 2019 at 03:34:58PM +0530, Nagarjuna Kristam wrote: > This patch adds UDC driver for tegra XUSB 3.0 device mode controller. > XUSB device mode controller support SS, HS and FS modes > > Based on work by: > Mark Kuo > Andrew Bresticker > > Signed-off-by: Nagarjuna Kristam > -

Re: [regression] USB power management failure to suspend / high CPU usage

2019-02-04 Thread Eric Blau
On Mon, Feb 4, 2019 at 8:12 AM Eric Blau wrote: > > On Mon, Feb 4, 2019 at 4:31 AM Mathias Nyman > wrote: > > > > On 03.02.2019 04:08, Eric Blau wrote: > > > > > > I finally was able to complete the bisect on this issue. It seems that > > > this commit introduced the regression on my MacBook Pro:

Re: [regression] USB power management failure to suspend / high CPU usage

2019-02-04 Thread Eric Blau
On Mon, Feb 4, 2019 at 4:31 AM Mathias Nyman wrote: > > On 03.02.2019 04:08, Eric Blau wrote: > > > > I finally was able to complete the bisect on this issue. It seems that > > this commit introduced the regression on my MacBook Pro: > > > > cc8b329fef53c74a4abf98b0755b3832d572d6ce is the first ba

Re: [PATCH 4/8] arm64: tegra: Add xudc node for Tegra210

2019-02-04 Thread Thierry Reding
On Thu, Jan 03, 2019 at 03:34:55PM +0530, Nagarjuna Kristam wrote: > Tegra210 has one XUSB device mode controller, which can be operated > HS and SS modes. Add DT support for XUSB device mode controller. > > Signed-off-by: Nagarjuna Kristam > --- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 17 +

Re: [PATCH 5/8] arm64: tegra: Enable xudc on Jetson TX1

2019-02-04 Thread Thierry Reding
On Thu, Jan 03, 2019 at 03:34:56PM +0530, Nagarjuna Kristam wrote: > Enable XUSB device mode driver for USB0 slot on Jetson TX1. > > Signed-off-by: Nagarjuna Kristam > --- > arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/

Re: [PATCH 6/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding

2019-02-04 Thread Thierry Reding
On Thu, Jan 03, 2019 at 03:34:57PM +0530, Nagarjuna Kristam wrote: > Add device-tree binding documentation for the XUSB device mode controller > present on tegra210 SoC. This controller supports USB 3.0 specification > > Based on work by Andrew Bresticker . > > Signed-off-by: Nagarjuna Kristam >

Re: [PATCH 1/8] phy: tegra: xusb: t210: add XUSB device mode support

2019-02-04 Thread Thierry Reding
On Thu, Jan 03, 2019 at 03:34:52PM +0530, Nagarjuna Kristam wrote: > Add support for XUSB device mode controller on Tegra210. > Update PADCTL driver to set port cap based on DT config. > Add code to handle property "nvidia,usb3-port-fake" > Provide API's to control vbus override and utmi pad power

Re: [PATCH 4/5] usb: typec: ucsi: Preliminary support for alternate modes

2019-02-04 Thread Heikki Krogerus
Hi, On Fri, Feb 01, 2019 at 10:02:19PM +, Michael Hsu wrote: > Hi Heikki, the use of "con->port_altmode[cur]->mode" (which is a 1-based > index, not a 32-bit mode VDO) can cause incorrect matches if the > GET_ALTERNATE_MODES returns different ordering for recipient=connector and > recipient=so

Re: [PATCH v3 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-02-04 Thread Greg KH
On Thu, Jan 31, 2019 at 11:52:32AM +, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver > to linux kernel. > > The Cadence USBSS DRD Driver is a highly > configurable IP Core which can be > instantiated as Dual-Role Device (DRD), > Peripheral Only and Host Only (XHCI) >

Re: [PATCH 3/8] dt-bindings: phy: tegra-xusb-padctl: Add nvidia,usb3-port-fake entry

2019-02-04 Thread Thierry Reding
On Thu, Jan 03, 2019 at 03:34:54PM +0530, Nagarjuna Kristam wrote: > Add binding details regarding nvidia,usb3-port-fake > > Signed-off-by: Nagarjuna Kristam > --- > Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH v3 4/6] usb:common Simplify usb_decode_get_set_descriptor function.

2019-02-04 Thread Greg KH
On Thu, Jan 31, 2019 at 11:52:31AM +, Pawel Laszczak wrote: > Patch moves switch responsible for decoding descriptor type > outside snprintf. It's little improves code readability. Should that last sentence read: "It improves code readability a little"? thanks, greg k-h

Re: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-04 Thread Greg KH
On Thu, Jan 31, 2019 at 11:52:29AM +, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_addres

Re: [PATCH 0/8] Tegra XUSB gadget driver support

2019-02-04 Thread Thierry Reding
On Thu, Jan 03, 2019 at 03:34:51PM +0530, Nagarjuna Kristam wrote: > Add driver for XUSB device mode controller available on Tegra > Soc > > Patches 1-3 are phy driver changes to add support for device > mode Patches 4-7 are changes related to XUSB device mode > controller driver Patch 8 is to ena

Re: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-04 Thread Greg KH
On Thu, Jan 31, 2019 at 11:52:29AM +, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_addres

[PATCH] USB: serial: cp210x: add minimun baud rate for CP2105 SCI

2019-02-04 Thread Johanna Abrahamsson
From: Johanna Abrahamsson This patch adds a minimum baud rate of 2400 for CP2105 SCI According to the datasheet for CP2105, the SCI supports 2400 as the lowest baud rate. As this is not heeded in the current code, an error message 'failed set req 0x1e size 4 status: -32' when trying to set a low

Re: [PATCH] usb: dwc2: Reset device address on EnumDone

2019-02-04 Thread Minas Harutyunyan
Hi Felipe, On 1/21/2019 11:13 AM, Minas Harutyunyan wrote: > Hi Felipe, > > On 12/12/2018 3:43 PM, Minas Harutyunyan wrote: >> Initially resetting device address was done in USB RESET interrupt >> handler. In case, when power saving mode enabled (hibernation) USB >> RESET interrupt handled in dwc

Re: [regression] USB power management failure to suspend / high CPU usage

2019-02-04 Thread Mathias Nyman
On 03.02.2019 04:08, Eric Blau wrote: I finally was able to complete the bisect on this issue. It seems that this commit introduced the regression on my MacBook Pro: cc8b329fef53c74a4abf98b0755b3832d572d6ce is the first bad commit commit cc8b329fef53c74a4abf98b0755b3832d572d6ce Author: Mathias