Re: Fwd: composite device fails to reset "suspended" flag

2018-12-23 Thread Minas Harutyunyan
Hi Frank, On 12/21/2018 6:24 PM, Frank Mori Hess wrote: >> >> According data book Disconnect Interrupt asserted only in Host mode. >> Programming guide says for device initialization unmask follow device >> specific interrupts: USB reset, Enum Done, Early suspend, Suspend and SOF. >> And on device

Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-12-23 Thread Minas Harutyunyan
Hi John, On 12/21/2018 8:05 PM, John Keeping wrote: > Hi Minas, > > On Wed, 19 Dec 2018 14:09:01 + > Minas Harutyunyan wrote: > >> On 12/18/2018 6:35 PM, John Keeping wrote: >>> Hi Minas, >>> >>> On Fri, 14 Dec 2018 09:00:08 + >>> Minas Harutyunyan wrote: First of all, sorry for d

[PATCH] usb: gadget: function: sync f_uac1 ac header baInterfaceNr

2018-12-23 Thread liangshengjun
f_uac1 audio control header descriptor default set baInterfaceNr[]={1,2}, but usb gadget make a configuration descriptor with more interfaces combination, it can not confirm f_uac1 function linked first. So always keep baInterfaceNr[]={1,2} is correct, and it is necessary to sync baInterfaceNr[]

[PATCH] usb: gadget: function: f_uac1 add interface assoc desc

2018-12-23 Thread liangshengjun
Add f_uac1 interface association descriptor, make f_uac1 link other function(like f_uvc) is possible. Signed-off-by: Liang Shengjun --- drivers/usb/gadget/function/f_uac1.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gad

[PATCH 1/1] usb: chipidea: fix static checker warning for NULL pointer

2018-12-23 Thread Peter Chen
During the static checker, "data->usbmisc_data" may be NULL. Fix it by this pointer judgement before using. Reported-by: Dan Carpenter Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_h

Re: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-23 Thread kbuild test robot
-ci/linux/commits/Pawel-Laszczak/Introduced-new-Cadence-USBSS-DRD-Driver/20181223-231813 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached

Re: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-23 Thread Randy Dunlap
Hi, Here are a few Kconfig text corrections. On 12/23/18 7:13 AM, Pawel Laszczak wrote: > diff --git a/drivers/usb/cdns3/Kconfig b/drivers/usb/cdns3/Kconfig > new file mode 100644 > index ..4adfd87811e8 > --- /dev/null > +++ b/drivers/usb/cdns3/Kconfig > @@ -0,0 +1,44 @@ > +config US

[PATCH v2 0/5] Introduced new Cadence USBSS DRD Driver.

2018-12-23 Thread Pawel Laszczak
This patch set introduce new Cadence USBSS DRD driver to linux kernel. The Cadence USBSS DRD Driver s a highly configurable IP Core which can be instantiated as Dual-Role Device (DRD), Peripheral Only and Host Only (XHCI) configurations. The current driver has been validated with FPGA burned. We

[PATCH v2 3/5] usb:common Patch simplify usb_decode_set_clear_feature function.

2018-12-23 Thread Pawel Laszczak
Patch adds usb_decode_test_mode and usb_decode_device_feature functions, which allow to make more readable and simplify the usb_decode_set_clear_feature function. Signed-off-by: Pawel Laszczak --- drivers/usb/common/debug.c | 83 ++ 1 file changed, 40 insertio

[PATCH v2 2/5] usb:common Separated decoding functions from dwc3 driver.

2018-12-23 Thread Pawel Laszczak
Patch moves some decoding functions from driver/usb/dwc3/debug.h driver to driver/usb/common/debug.c file. These moved functions include: dwc3_decode_get_status dwc3_decode_set_clear_feature dwc3_decode_set_address dwc3_decode_get_set_descriptor dwc3_decode_get_configuration

[PATCH v2 4/5] usb:common Simplify usb_decode_get_set_descriptor function.

2018-12-23 Thread Pawel Laszczak
Patch moves switch responsible for decoding descriptor type outside snprintf. It's little improves code readability. Signed-off-by: Pawel Laszczak --- drivers/usb/common/debug.c | 111 +++-- 1 file changed, 57 insertions(+), 54 deletions(-) diff --git a/drivers/u

[PATCH v2 1/5] dt-bindings: add binding for USBSS-DRD controller.

2018-12-23 Thread Pawel Laszczak
This patch aim at documenting USB related dt-bindings for the Cadence USBSS-DRD controller. Signed-off-by: Pawel Laszczak --- .../devicetree/bindings/usb/cdns3-usb.txt | 30 +++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/cdns3-u

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Marek Vasut
On 12/23/18 11:56 AM, Andrew Lunn wrote: > On Sun, Dec 23, 2018 at 11:43:05AM +0100, Marek Vasut wrote: >> On 12/23/18 11:23 AM, Andrew Lunn wrote: > +static int smsc95xx_phy_address(struct usbnet *dev) > +{ > + u32 read_buf; > + int ret, id1, id2, phyad; > + > + ret = smsc9

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Andrew Lunn
On Sun, Dec 23, 2018 at 11:43:05AM +0100, Marek Vasut wrote: > On 12/23/18 11:23 AM, Andrew Lunn wrote: > >>> +static int smsc95xx_phy_address(struct usbnet *dev) > >>> +{ > >>> + u32 read_buf; > >>> + int ret, id1, id2, phyad; > >>> + > >>> + ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf); > >>>

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Marek Vasut
On 12/23/18 11:23 AM, Andrew Lunn wrote: >>> +static int smsc95xx_phy_address(struct usbnet *dev) >>> +{ >>> + u32 read_buf; >>> + int ret, id1, id2, phyad; >>> + >>> + ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf); >>> + if (ret < 0) >>> + return ret; >>> + >>> + /* Check if

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Andrew Lunn
> > +static int smsc95xx_phy_address(struct usbnet *dev) > > +{ > > + u32 read_buf; > > + int ret, id1, id2, phyad; > > + > > + ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf); > > + if (ret < 0) > > + return ret; > > + > > + /* Check if using external PHY, if not, use internal

Re: [PATCH] smsc95xx: Add support for automated PHY address detection

2018-12-23 Thread Marek Vasut
On 9/11/18 12:12 PM, Marek Vasut wrote: > The SMSC95xx chip can use either the internal PHY or an external one. > Currently, the driver hard-codes support for the internal PHY only. > > This patch reads out the HW_CFG register to determine whether external > PHY is attached or not. If an external