RE: [RFC PATCH v2 03/15] dt-bindings: add binding for USBSS-DRD controller.

2018-11-24 Thread Pawel Laszczak
Hi Roger >On 18/11/18 12:08, Pawel Laszczak wrote: >> Thsi patch aim at documenting USB related dt-bindings for the > >s/Thsi/This > >> Cadence USBSS-DRD controller. >> >> Signed-off-by: Pawel Laszczak >> --- >> .../devicetree/bindings/usb/cdns3-usb.txt | 17 + >> 1 file ch

[PATCH v2 0/5] omap_udc bug fixes

2018-11-24 Thread Aaro Koskinen
Hello, Some fixes for omap_udc making the driver usable again on Palm TE & 770. v2: Patch #2 rewritten, now usb_add_gadget_udc_release() should be properly used. Patch #5 added. v1: https://marc.info/?l=linux-usb&m=154258778216930&w=2 https://m

[PATCH v2 3/5] USB: omap_udc: fix omap_udc_start() on 15xx machines

2018-11-24 Thread Aaro Koskinen
On OMAP 15xx machines there are no transceivers, and omap_udc_start() always fails as it forgot to adjust the default return value. Signed-off-by: Aaro Koskinen --- drivers/usb/gadget/udc/omap_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/omap

[PATCH v2 2/5] USB: omap_udc: fix crashes on probe error and module removal

2018-11-24 Thread Aaro Koskinen
We currently crash if usb_add_gadget_udc_release() fails, since the udc->done is not initialized until in the remove function. Furthermore, on module removal the udc data is accessed although the release function is already triggered by usb_del_gadget_udc() early in the function. Fix by rewriting

[PATCH v2 1/5] USB: omap_udc: use devm_request_irq()

2018-11-24 Thread Aaro Koskinen
The current code fails to release the third irq on the error path (observed by reading the code), and we get also multiple WARNs with failing gadget drivers due to duplicate IRQ releases. Fix by using devm_request_irq(). Signed-off-by: Aaro Koskinen --- drivers/usb/gadget/udc/omap_udc.c | 37 +++

[PATCH v2 5/5] USB: omap_udc: fix rejection of out transfers when DMA is used

2018-11-24 Thread Aaro Koskinen
Commit 387f869d2579 ("usb: gadget: u_ether: conditionally align transfer size") started aligning transfer size only if requested, breaking omap_udc DMA mode. Set quirk_ep_out_aligned_size to restore the old behaviour. Fixes: 387f869d2579 ("usb: gadget: u_ether: conditionally align transfer size")

[PATCH v2 4/5] USB: omap_udc: fix USB gadget functionality on Palm Tungsten E

2018-11-24 Thread Aaro Koskinen
On Palm TE nothing happens when you try to use gadget drivers and plug the USB cable. Fix by adding the board to the vbus sense quirk list. Signed-off-by: Aaro Koskinen --- drivers/usb/gadget/udc/omap_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/omap_udc.c b/

Re: pl2303 regression after v4.17. Bisected to 7041d9c3f01b

2018-11-24 Thread Florian Zumbiehl
Hi, > Requested baud setting looks odd to me. Maybe related to this > --keep-baud flag in "/sbin/agetty -o -p -- \u --keep-baud > 115200,38400,9600 ttyUSB0 vt220"? Well, what is the baud rate of the other side? It seems a bit strange that ... > 1. serial-getty@ttyUSB0.service disabled > > speed

Re: [PATCH] dma: cppi41: delete channel from pending list when stop channel

2018-11-24 Thread Vinod Koul
On 12-11-18, 09:43, Bin Liu wrote: > The driver defines three states for a cppi channel. > - idle: .chan_busy == 0 && not in .pending list > - pending: .chan_busy == 0 && in .pending list > - busy: .chan_busy == 1 && not in .pending list > > There are cases in which the cppi channel could be in th