Re: [PATCH v2] usbnet: smsc95xx: disable carrier check while suspending

2018-11-02 Thread David Miller
From: Frieder Schrempf Date: Wed, 31 Oct 2018 22:52:19 +0100 > We need to make sure, that the carrier check polling is disabled > while suspending. Otherwise we can end up with usbnet_read_cmd() > being issued when only usbnet_read_cmd_nopm() is allowed. If this > happens, read operations lock up

Re: [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs

2018-11-02 Thread Greg KH
On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote: > Move Synopsys HAPS platform device IDs to pci_ids.h. Why? pci_ids.h, at the top of the file, says to not add new entries to the file. thanks, greg k-h

[PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs

2018-11-02 Thread Thinh Nguyen
Move Synopsys HAPS platform device IDs to pci_ids.h. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/dwc3-haps.c | 4 include/linux/pci_ids.h | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-haps.c b/drivers/usb/dwc3/dwc3-haps.c index c9cc3

[PATCH] usb: dwc3: Set default mode for DWC_usb3 v3.30a and higher

2018-11-02 Thread Thinh Nguyen
DWC_usb31 and DWC_usb3 v3.30a and higher do not support OTG mode. If the controller supports DRD but the dr_mode is not specified or set to OTG, then set the mode to peripheral. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/core.c | 9 + drivers/usb/dwc3/core.h | 1 + 2 files changed,

[PATCH] usb: dwc3: debugfs: Dump internal states

2018-11-02 Thread Thinh Nguyen
To dump internal LSP and endpoint state debug registers, we must write to GDBGLSPMUX register. This patch correctly dump internal BMU, LSP, and endpoint states from the debug registers. If the controller is in device mode, all LSP and endpoint state registers will be dumped. In host mode, the user

[PATCH 3/3] usb: dwc3: Enable low power management using refclk

2018-11-02 Thread Thinh Nguyen
DWC_usb31 peripheral controller v1.80a introduced a new feature to enhance low power scheduling for ADC devices. Set "snps,enable-refclk-lpm" to enable this feature. It enables low power scheduling of isochronous transfers by running SOF/ITP counters using the reference clock. Both "snps,dis_u2_sus

[PATCH 1/3] usb: dwc3: Add reference clock properties

2018-11-02 Thread Thinh Nguyen
Add two new device properties to program the reference clock period and to enable low power management using the reference clock. This allows a higher demand to go in low power for Audio Device Class devices. This feature is currently only valid for DWC_usb31 peripheral controller v1.80a and higher

[PATCH 2/3] usb: dwc3: Set reference clock period

2018-11-02 Thread Thinh Nguyen
Get the reference clock period from the device property and reprogram it during core power-on initialization. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/core.c | 22 ++ drivers/usb/dwc3/core.h | 10 ++ 2 files changed, 32 insertions(+) diff --git a/drivers/usb/

[PATCH 0/3] usb: dwc3: Introduce refclk lpm

2018-11-02 Thread Thinh Nguyen
This patch series introduce a new feature in DWC_usb31 with more aggressive low power management using reference clock. Thinh Nguyen (3): usb: dwc3: Add reference clock properties usb: dwc3: Set reference clock period usb: dwc3: Enable low power management using refclk Documentation/devic

Re: [PATCH 12/14] dt-bindings: ehci-mv: add bindings

2018-11-02 Thread Pavel Machek
Hi! > Signed-off-by: Lubomir Rintel > --- > .../devicetree/bindings/usb/ehci-mv.txt | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/usb/ehci-mv.txt I see this is pending in -next, but I don't see Rob's Ack anywhere. Is

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-02 Thread Alan Stern
On Fri, 2 Nov 2018, Laurent Pinchart wrote: > Hi Alan, Hi, Laurent. > The composite layer only handles USB_GADGET_DELAYED_STATUS for > USB_REQ_SET_CONFIGURATION (in set_config()) and for USB_REQ_SET_INTERFACE (in > composite_setup()). It increments cdev->delayed_status immediately. Then, in >

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-02 Thread Laurent Pinchart
Hi Alan, On Friday, 2 November 2018 18:18:45 EET Alan Stern wrote: > On Fri, 2 Nov 2018, Laurent Pinchart wrote: > > On Friday, 2 November 2018 15:17:20 EET Felipe Balbi wrote: > >> Laurent Pinchart writes: > >>> +void usb_ep_delay_status(struct usb_ep *ep) > >>> > >>> +{ > >>> +

Bug: USB bluetooth disconnect on boot, only visible again after resume from suspend (Lenovo A485)

2018-11-02 Thread Samantha McVey
I have tried both the original Realtek 8822BE and Intel's 9260 wifi cards. Both of these show the same issue: the bluetooth usb which is part of the wifi card disconnects during boot. This happens whether or not the PCIe wireless loads firmware or if the wifi's kernel module is blacklisted (so firm

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-02 Thread Alan Stern
On Fri, 2 Nov 2018, Laurent Pinchart wrote: > Hi Felipe, > > On Friday, 2 November 2018 15:17:20 EET Felipe Balbi wrote: > > Laurent Pinchart writes: > > > +void usb_ep_delay_status(struct usb_ep *ep) > > > > > > +{ > > > + ep->delayed_status = true; > > > +} > > > +E

[PATCH v1 2/2] usb: dwc2: gadget: Accept LPM token when TxFIFO is not empty

2018-11-02 Thread Artur Petrosyan
Set GLPMCFG_LPM_ACCEPT_CTRL_ISOC bit in GLPMCFG register to accept LPM token during ISOC transfers when TxFIFO is not empty. - Added two definitions. #define GLPMCFG_LPM_ACCEPT_CTRL_CONTROLBIT(21) #define GLPMCFG_LPM_ACCEPT_CTRL_ISOC BIT(22) This patch uses GLPMCFG_LPM_

[PATCH v1 1/2] usb: dwc2: gadget: Fix WkupAlert interrupt handler.

2018-11-02 Thread Artur Petrosyan
According to the databook DCTL_RMTWKUPSIG bit is defined in DCTL register not in DCFG. Updated setting DCTL_RMTWKUPSIG bit to DCTL register. Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt") Signed-off-by: Artur Petrosyan Signed-off-by: Minas Harutyunyan --- drive

[PATCH v1 0/2] usb: dwc2: gadget: Fix Service Interval support.

2018-11-02 Thread Artur Petrosyan
1. This patch set fixes WkupAlert interrupt handler. 2. Adds support to accept LPM token when TxFIFO is not empty. NOTE: Request to add this patch set on "tag: usb-for-v4.20" Changes from V0: - Add Fixes: tag in "56f25126ae1f usb: dwc2: gadget: Fix WkupAlert interrupt handler." - Modify pat

Re: [PATCH] usb: host: remove unnecessary condition check

2018-11-02 Thread Alan Stern
On Fri, 2 Nov 2018, Chengguang Xu wrote: > dma_pool_destroy() can handle NULL pointer correctly, so there is > no need to check NULL pointer before calling dma_pool_destroy(). > > Signed-off-by: Chengguang Xu > --- > drivers/usb/host/ohci-mem.c | 12 > 1 file changed, 4 insertions(

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-02 Thread Laurent Pinchart
Hi Felipe, On Friday, 2 November 2018 15:17:20 EET Felipe Balbi wrote: > Laurent Pinchart writes: > > +void usb_ep_delay_status(struct usb_ep *ep) > > > > +{ > > + ep->delayed_status = true; > > +} > > +EXPORT_SYMBOL_GPL(usb_ep_delay_status); > > Is usb_ep

[PATCH] usb: host: remove unnecessary condition check

2018-11-02 Thread Chengguang Xu
dma_pool_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling dma_pool_destroy(). Signed-off-by: Chengguang Xu --- drivers/usb/host/ohci-mem.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/ohci-m

Re: [PATCH v3 1/3] dt-bindings: connector: Add self-powered property

2018-11-02 Thread Rob Herring
On Fri, Nov 2, 2018 at 8:28 AM Heikki Krogerus wrote: > > On Mon, Oct 01, 2018 at 12:44:59PM -0700, Badhri Jagan Sridharan wrote: > > >From USB_PD_R3_0 > > 7.1.5 Response to Hard Resets > > Device operation during and after a Hard Reset is defined as follows: > > Self-powered devices Should Not di

Re: [PATCH v15 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-11-02 Thread Heikki Krogerus
On Fri, Oct 26, 2018 at 09:36:59AM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller > over I2C interface. > > This UCSI I2C driver uses I2C bus driver interface for communicating > with Type-C controller. > > Signed-off-by: Ajay Gupta Acked-by: Heikki Kro

Re: [PATCH v3 3/3] usb: typec: tcpm: charge current handling for sink during hard reset

2018-11-02 Thread Heikki Krogerus
On Mon, Oct 01, 2018 at 12:45:01PM -0700, Badhri Jagan Sridharan wrote: > During the initial connect to a non-pd port, sink would hard reset > twice before deeming that the port partner is non-pd. TCPM sets the > the charge path to false during the hard reset. This causes unnecessary > connects/dis

Re: [PATCH v3 2/3] usb: typec: tcpm: Do not disconnect link for self powered devices

2018-11-02 Thread Heikki Krogerus
On Mon, Oct 01, 2018 at 12:45:00PM -0700, Badhri Jagan Sridharan wrote: > During HARD_RESET the data link is disconnected. > For self powered device, the spec is advising against doing that. > > >From USB_PD_R3_0 > 7.1.5 Response to Hard Resets > Device operation during and after a Hard Reset is d

Re: [PATCH v3 1/3] dt-bindings: connector: Add self-powered property

2018-11-02 Thread Heikki Krogerus
On Mon, Oct 01, 2018 at 12:44:59PM -0700, Badhri Jagan Sridharan wrote: > >From USB_PD_R3_0 > 7.1.5 Response to Hard Resets > Device operation during and after a Hard Reset is defined as follows: > Self-powered devices Should Not disconnect from USB during a Hard Reset > (see Section 9.1.2). > Bus

[PATCH v2] usb: xhci: fix small typo

2018-11-02 Thread Yangtao Li
Fix a typo of a misspelled "Calculates". Signed-off-by: Yangtao Li --- Change in v2: -add changelog --- drivers/usb/host/xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 0420eefa647a..d4446dc46fd1 100644 --- a/driv

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-02 Thread Laurent Pinchart
Hello, On Friday, 2 November 2018 01:40:59 EET Paul Elder wrote: > On Thu, Oct 18, 2018 at 10:07:36AM -0400, Alan Stern wrote: > > On Thu, 18 Oct 2018, Laurent Pinchart wrote: > >> On Thursday, 11 October 2018 19:10:21 EEST Bin Liu wrote: > >>> On Tue, Oct 09, 2018 at 10:49:01PM -0400, Paul Elder

Re: usb: dwc3: dwc3 errors while video streaming with uvc-gadget

2018-11-02 Thread Laurent Pinchart
Hello, On Friday, 2 November 2018 11:50:47 EET Roger Quadros wrote: > On 15/10/18 19:34, Terence Neill wrote: > > Hi Felipe, > > > > I am having some issues when attempting to stream 1280x720 uncompressed > > video @ 10fps over a USB 2.0 High-Speed link. > > > > The system setup is: > > > > Web

Re: usb: dwc3: dwc3 errors while video streaming with uvc-gadget

2018-11-02 Thread Roger Quadros
Hi Terry, On 15/10/18 19:34, Terence Neill wrote: Hi Felipe, I am having some issues when attempting to stream 1280x720 uncompressed video @ 10fps over a USB 2.0 High-Speed link. The system setup is: WebCam --- USB 2.0 link ---> x86 Linux Machine running uvc-gadget USB 2.0 link ---> x