Re: [PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-10-10 Thread Heikki Krogerus
On Sat, Sep 29, 2018 at 10:26:20PM +0800, Yu Wang wrote: > The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI > controller state. The role can't be switched if related states haven't > satisfied. That is why we need to poll the DUAL_ROLE_CFG1 to check if > the role switched suc

[PATCH] usbip: vhci_hcd: Check rhport everywhere in vhci_hub_control()

2018-10-10 Thread Ben Hutchings
Commit 5b22f676118f "usbip: vhci_hcd: check rhport before using in vhci_hub_control()" added some validation of rhport, but left several problems: - If VHCI_HC_PORTS < 256, we can get rhport >= VHCI_HC_PORTS which is also out of range. To keep things simple, set rhport to -1 if this would hap

Re: KASAN: slab-out-of-bounds Read in vhci_hub_control

2018-10-10 Thread Shuah Khan
On 10/10/2018 01:42 PM, Dmitry Vyukov wrote: > On Tue, Oct 2, 2018 at 6:04 PM, Shuah Khan wrote: >> On 09/04/2018 12:52 PM, syzbot wrote: >>> Hello, >>> >>> syzbot found the following crash on: >>> >>> HEAD commit:420f51f4ab6b Merge tag 'arm64-fixes' of git://git.kernel.o.. >>> git tree:

Re: KASAN: slab-out-of-bounds Read in vhci_hub_control

2018-10-10 Thread Dmitry Vyukov
On Tue, Oct 2, 2018 at 6:04 PM, Shuah Khan wrote: > On 09/04/2018 12:52 PM, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:420f51f4ab6b Merge tag 'arm64-fixes' of git://git.kernel.o.. >> git tree: upstream >> console output: https://syzkaller.appspot

Re: It can not be formatted with 'gnome-disk-utility' the pendrive

2018-10-10 Thread Greg KH
On Wed, Oct 10, 2018 at 03:39:01PM -0300, Cristian wrote: > Hello, > > Open bug in launchpad.net > https://bugs.launchpad.net/bugs/1797190 > > "I am trying to format a pendrive of 2TB(Purchased in China for ebay). > What I do is the following: > > 1) I start the notebook with Linux 4.18.0-9 > 2)

Re: KASAN: slab-out-of-bounds Read in vhci_hub_control

2018-10-10 Thread Dmitry Vyukov
On Wed, Oct 10, 2018 at 8:41 PM, Dmitry Vyukov wrote: > On Wed, Oct 3, 2018 at 1:21 AM, Shuah Khan wrote: >> On 10/02/2018 10:42 AM, Dmitry Vyukov wrote: >>> On Tue, Oct 2, 2018 at 6:04 PM, Shuah Khan wrote: On 09/04/2018 12:52 PM, syzbot wrote: > Hello, > > syzbot found the fol

Re: KASAN: slab-out-of-bounds Read in vhci_hub_control

2018-10-10 Thread Dmitry Vyukov
On Wed, Oct 3, 2018 at 1:21 AM, Shuah Khan wrote: > On 10/02/2018 10:42 AM, Dmitry Vyukov wrote: >> On Tue, Oct 2, 2018 at 6:04 PM, Shuah Khan wrote: >>> On 09/04/2018 12:52 PM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:420f51f4ab6b Merge t

It can not be formatted with 'gnome-disk-utility' the pendrive

2018-10-10 Thread Cristian
Hello, Open bug in launchpad.net https://bugs.launchpad.net/bugs/1797190 "I am trying to format a pendrive of 2TB(Purchased in China for ebay). What I do is the following: 1) I start the notebook with Linux 4.18.0-9 2) I start with my GNOME session 3) I connect the pendrive 4) I open Nautilus 5)

Re: USB mass storage device inaccessible, freezes lsusb

2018-10-10 Thread Alan Stern
On Tue, 9 Oct 2018, Christoph Groth wrote: > On Tue, 9 Oct 2018, Alan Stern wrote: > > > On Mon, 8 Oct 2018, Christoph Groth wrote: > > > > > On Sun, 7 Oct 2018, Alan Stern wrote: > > > > > > > On Fri, 5 Oct 2018, Christoph Groth wrote: > > > > > > > > > I would be grateful for hints on how solv

Re: [PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-10-10 Thread Hans de Goede
Hi All, On 29-09-18 16:26, Yu Wang wrote: The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI controller state. The role can't be switched if related states haven't satisfied. That is why we need to poll the DUAL_ROLE_CFG1 to check if the role switched successful or not. So

Re: [PATCH 1/6] usb: uvc: include videodev2.h in g_uvc.h

2018-10-10 Thread Laurent Pinchart
Hi Paul, Thank you for the patch. On Wednesday, 10 October 2018 05:48:58 EEST Paul Elder wrote: > V4L2_EVENT_PRIVATE_START is used in g_uvc.h but is defined in > videodev2.h, which is not included and causes a compiler warning: > > linux/usb/g_uvc.h:15:28: error: ‘V4L2_EVENT_PRIVATE_START’ undec

Re: [PATCH 0/6] usb: gadget: add mechanism to asynchronously validate data stage of ctrl out request

2018-10-10 Thread Laurent Pinchart
Hi Paul, Thank you for the patches. On Wednesday, 10 October 2018 05:48:57 EEST Paul Elder wrote: > This patch series adds a mechanism to allow asynchronously validating > the data stage of a control out request, and for stalling or suceeding > the request accordingly. This mechanism is implement

Re: [RFC] usb: chipidea: Add minimal support for HSIC interface on i.MX6QDL

2018-10-10 Thread Frieder Schrempf
Hi Peter, On 09.10.2018 03:24, Peter Chen wrote: The topic has been discussed before: [1] And there is some implementation in the vendor kernel: [2] It seems like two things need to be done: 1. Switch the pinmux of the strobe signal to use a pullup after the core has been initialized.

Re: xHCI enable slot command if there are several ports connected

2018-10-10 Thread Dmitry Malkin
Thank you very much. I really was confused by "Enable Slot" name. On 10/10/2018 12:31 PM, Mathias Nyman wrote: On 09.10.2018 21:57, Alan Stern wrote: On Tue, 9 Oct 2018, Dmitry Malkin wrote: Hi guys, Could someone can give me a hint to this question: if there are multiple connected USB dev

Re: [PATCH net-next 04/19] net: usb: aqc111: Various callbacks implementation

2018-10-10 Thread Oliver Neukum
On Di, 2018-10-09 at 15:27 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > > On Fr, 2018-10-05 at 10:24 +, Igor Russkikh wrote: > > > From: Dmitry Bezrukov > > > > > > Reset, stop callbacks, driver unbind callback. > > > More register defines required for these callbacks. > > > > > >

Re: [PATCH] usb: roles: intel_xhci: Fix Unbalanced pm_runtime_enable

2018-10-10 Thread Hans de Goede
Hi, On 09-10-18 06:52, wan.ahmad.zainie.wan.moha...@intel.com wrote: From: Wan Ahmad Zainie Add missing pm_runtime_disable() to remove(), in order to avoid an Unbalanced pm_runtime_enable when the module is removed and re-probed. Error log: root@intel-corei7-64:~# modprobe -r intel_xhci_usb_r

Re: xHCI enable slot command if there are several ports connected

2018-10-10 Thread Mathias Nyman
On 09.10.2018 21:57, Alan Stern wrote: On Tue, 9 Oct 2018, Dmitry Malkin wrote: Hi guys, Could someone can give me a hint to this question: if there are multiple connected USB devices (multiple ports with set PORTSC.CCS bit) to xHCI and I issue the very first enable slot command which port wi

Re: [PATCH 0/2] USB: serial: gpio line-name fix and FT232R CBUS gpio support

2018-10-10 Thread Linus Walleij
On Fri, Oct 5, 2018 at 3:40 PM Johan Hovold wrote: > On Mon, Oct 01, 2018 at 11:43:55AM +0200, Linus Walleij wrote: > > The idea is to make it possible for userspace to look up a GPIO > > on a chip by name, so if the gpiochip has a unique name, > > and the line name is unique on that chip it shou

Re: [BUG REPORT] usb: dwc3: Failed to link at superspeed in device mode

2018-10-10 Thread Felipe Balbi
Hi, Thomas JOURDAN writes: >> > From your trace.txt, I don't see the early enumeration phase, so I can't >> > comment one what happened during that time. Care to rerun this so that >> > we have early enumeration? I need to see a Reset Event on the trace as >> > that's the first event when you fi

Re: [BUG REPORT] usb: dwc3: Failed to link at superspeed in device mode

2018-10-10 Thread Thomas JOURDAN
Hi Le mer. 10 oct. 2018 à 09:41, Felipe Balbi a écrit : > > first of all, thanks for following the documentation when reporting a > bug, much appreciated. That's the least I can do. Thanks for take into account my issue. > Thomas JOURDAN writes: > > On the UP2 board, it is not possible in devi

Re: [PATCH net-next 05/19] net: usb: aqc111: Introduce PHY access

2018-10-10 Thread Igor Russkikh
On 10.10.2018 03:58, Andrew Lunn wrote: > > I just discovered driver_priv. > > https://elixir.bootlin.com/linux/v4.19-rc7/source/include/linux/usb/usbnet.h#L33 > > It would be good to use that, to avoid the casts. Looks good to me, thanks. Regards, Igor

Re: [BUG REPORT] usb: dwc3: Failed to link at superspeed in device mode

2018-10-10 Thread Felipe Balbi
Hi Thomas, first of all, thanks for following the documentation when reporting a bug, much appreciated. Thomas JOURDAN writes: > On the UP2 board, it is not possible in device mode to get the USB3.0 > OTG port working at superspeed. It is unclear yet if it is a bug in > the Linux DWC3 driver or