Re: [PATCH net v2 0/7] net: usb: Check for Wake-on-LAN modes

2018-09-29 Thread David Miller
From: Florian Fainelli Date: Fri, 28 Sep 2018 16:18:49 -0700 > Most of our USB Ethernet drivers don't seem to be checking properly > whether the user is supplying a correct Wake-on-LAN mode to enter, so > the experience as an user could be confusing, since it would generally > lead to either no w

[PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-09-29 Thread Yu Wang
The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI controller state. The role can't be switched if related states haven't satisfied. That is why we need to poll the DUAL_ROLE_CFG1 to check if the role switched successful or not. So the SW_IDPIN and SW_VBUS_VALID bits can't det

Re: [PATCH v3 -next] usb: typec: remove set but not used variables 'snk_ma, min_mv'

2018-09-29 Thread Guenter Roeck
On 09/29/2018 02:53 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_pd_select_pps_apdo': drivers/usb/typec/tcpm/tcpm.c:2212:39: warning: variable 'snk_ma' set but not used [-Wunused-but-set-variable] drivers/usb/typec/tcpm/

[PATCH] usb: gadget: fix spelling mistakeis "[En]queing" -> "[En]queuing"

2018-09-29 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistakes in debug warning messages Signed-off-by: Colin Ian King --- drivers/usb/gadget/udc/aspeed-vhub/epn.c | 2 +- drivers/usb/gadget/udc/udc-xilinx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/

Re: [PATCH] usbip: fix vhci_hcd controller counting

2018-09-29 Thread Jonathan Dieter
For whatever it's worth, I've tested this on 4.18.9 and can verify that there are no regressions there. Tested-by: Jonathan Dieter

[PATCH -next] USB: cypress_m8: remove set but not used variables 'actual_size, iflag'

2018-09-29 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/serial/cypress_m8.c: In function 'cypress_send': drivers/usb/serial/cypress_m8.c:689:33: warning: variable 'actual_size' set but not used [-Wunused-but-set-variable] drivers/usb/serial/cypress_m8.c: In function 'cypress_set_termios': dri

[PATCH v3 -next] usb: typec: remove set but not used variables 'snk_ma, min_mv'

2018-09-29 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_pd_select_pps_apdo': drivers/usb/typec/tcpm/tcpm.c:2212:39: warning: variable 'snk_ma' set but not used [-Wunused-but-set-variable] drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_pd_build_pps_reques

Re: [PATCH v2 -next] usb: typec: remove set but not used variables 'snk_ma, flags'

2018-09-29 Thread YueHaibing
On 2018/9/29 16:56, Sergei Shtylyov wrote: > Hello! > > On 9/29/2018 9:58 AM, YueHaibing wrote: > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_pd_select_pps_apdo': >> drivers/usb/typec/tcpm/tcpm.c:2212:39: warning: >> variable 'snk_m

Re: [PATCH v2 -next] usb: typec: remove set but not used variables 'snk_ma, flags'

2018-09-29 Thread Sergei Shtylyov
Hello! On 9/29/2018 9:58 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_pd_select_pps_apdo': drivers/usb/typec/tcpm/tcpm.c:2212:39: warning: variable 'snk_ma' set but not used [-Wunused-but-set-variable] drivers/usb/type

Re: [PATCH] usbip: fix vhci_hcd controller counting

2018-09-29 Thread Maciej Żenczykowski
I'm not entirely sure who I should be CC'ing on this... but it's such an obvious fix... Thanks, - Maciej