RE: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree

2018-09-13 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: 2018年9月14日 1:35 > To: Angus Ainslie > Cc: Peter Chen ; Heikki Krogerus > ; Greg Kroah-Hartman > ; linux-usb@vger.kernel.org; lkml > ; Peter Chen ; Jun Li > > Subject: Re: [PATCH v3] usb: typec: get the vbus

RE: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree

2018-09-13 Thread Jun Li
Hi > -Original Message- > From: Angus Ainslie > Sent: 2018年9月13日 19:10 > To: Peter Chen > Cc: li...@roeck-us.net; Heikki Krogerus ; > Greg > Kroah-Hartman ; linux-usb@vger.kernel.org; lkml > ; Peter Chen ; Jun Li > ; Guenter Roeck > Subject: Re: [PATCH v3] usb: typec: get the vbus sourc

Re: [PATCH 2/2] typec: tcpm: Add option to maintain current limit at Vsafe5V

2018-09-13 Thread Badhri Jagan Sridharan
On Thu, Sep 13, 2018 at 10:07 AM Jack Pham wrote: > > On Thu, Sep 13, 2018 at 6:43 AM Badhri Jagan Sridharan > wrote: > > > > On Wed, Sep 12, 2018 at 11:39 PM Jack Pham wrote: > > > > > > Hello Badhri, > > > > > > On Wed, Sep 12, 2018 at 07:11:13PM -0700, Badhri Jagan Sridharan wrote: > > > > Du

RE: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-13 Thread Ajay Gupta
Hi Heikki and Peter, > > > Can we get the working set in while the issues is being debugged? > > > > I'm not the one making the decision, and I don't even know if this is > > going through the i2c or the usb tree? If it's going through the i2c > > tree you need a tag from the usb people (Greg?) on

Re: [PATCH 1/2] typec: tcpm: Do not disconnect link for self powered devices

2018-09-13 Thread Badhri Jagan Sridharan
On Thu, Sep 13, 2018 at 10:51 AM Guenter Roeck wrote: > > On Thu, Sep 13, 2018 at 04:24:08PM +0300, Heikki Krogerus wrote: > > +Guenter > > > > On Wed, Sep 12, 2018 at 07:11:12PM -0700, Badhri Jagan Sridharan wrote: > > > During HARD_RESET the data link is disconnected. > > > For self powered devi

Inaccessible dual-role port on CherryTrail

2018-09-13 Thread Rob Weber
Hi linux-usb, I'm currently bringing up a custom board that uses a CherryTrail processor and I'm having quite a bit of trouble accessing the dual-role port from Linux. Our system includes two USB 3.0-capable ports with Type-C connectors. One port is designed to be a host-only port (downstream-fac

Re: [PATCH v4 4/8] usb: dwc3: implement stream transfer timeout

2018-09-13 Thread Thinh Nguyen
Hi Anurag, On 9/8/2018 8:03 AM, Anurag Kumar Vulisha wrote: > According to dwc3 databook when streams are used, it may be possible > for the host and device become out of sync, where device may wait for > host to issue prime transcation and host may wait for device to issue > erdy. To avoid such d

Re: [PATCH 1/2] typec: tcpm: Do not disconnect link for self powered devices

2018-09-13 Thread Guenter Roeck
On Thu, Sep 13, 2018 at 04:24:08PM +0300, Heikki Krogerus wrote: > +Guenter > > On Wed, Sep 12, 2018 at 07:11:12PM -0700, Badhri Jagan Sridharan wrote: > > During HARD_RESET the data link is disconnected. > > For self powered device, the spec is advising against doing that. > > > > >From USB_PD_R

Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree

2018-09-13 Thread Guenter Roeck
On Thu, Sep 13, 2018 at 05:10:09AM -0600, Angus Ainslie wrote: > > > >staging: typec: don't do vbus source disable for dead battery > > > >In PTN5110 design, DisableSourceVBUS command also disables the sink > >enable signal because the EN_SNK can be used to source higher voltage, > >and, there is o

Re: [PATCH 2/2] typec: tcpm: Add option to maintain current limit at Vsafe5V

2018-09-13 Thread Jack Pham
On Thu, Sep 13, 2018 at 6:43 AM Badhri Jagan Sridharan wrote: > > On Wed, Sep 12, 2018 at 11:39 PM Jack Pham wrote: > > > > Hello Badhri, > > > > On Wed, Sep 12, 2018 at 07:11:13PM -0700, Badhri Jagan Sridharan wrote: > > > During hard reset, TCPM turns off the charging path. > > > The spec provi

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-13 Thread Kristian Evensen
Hello again, On Thu, Sep 13, 2018 at 11:17 AM Johan Hovold wrote: > Kristian would you mind giving it a try? I just finished backporting + testing your patch with our 4.14-kernel (mine is already there) and it works great. The driver correctly handles different EP06-configurations. Thanks a lot

Re: [PATCH 1/5] misc: rtsx_usb: Use USB remote wakeup signaling for card insertion detection

2018-09-13 Thread Alan Stern
On Thu, 13 Sep 2018, Kai-Heng Feng wrote: > I am working on the next version of this series, and the last missing > puzzle is to differentiate system-wide resume from runtime resume in > usb_driver's resume() and reset_resume() callback. > > The parent device, rtsx_usb, has two child devices,

Re: [PATCH 2/2] typec: tcpm: Add option to maintain current limit at Vsafe5V

2018-09-13 Thread Badhri Jagan Sridharan
On Wed, Sep 12, 2018 at 11:39 PM Jack Pham wrote: > > Hello Badhri, > > On Wed, Sep 12, 2018 at 07:11:13PM -0700, Badhri Jagan Sridharan wrote: > > During hard reset, TCPM turns off the charging path. > > The spec provides an option for Sink to either drop to vSafe5V or vSafe0V. > > This doesn't m

Re: [PATCH 2/2] typec: tcpm: Add option to maintain current limit at Vsafe5V

2018-09-13 Thread Badhri Jagan Sridharan
+ Guenter On Thu, Sep 13, 2018 at 6:43 AM Badhri Jagan Sridharan wrote: > > On Wed, Sep 12, 2018 at 11:39 PM Jack Pham wrote: > > > > Hello Badhri, > > > > On Wed, Sep 12, 2018 at 07:11:13PM -0700, Badhri Jagan Sridharan wrote: > > > During hard reset, TCPM turns off the charging path. > > > The

Re: [PATCH 1/2] typec: tcpm: Do not disconnect link for self powered devices

2018-09-13 Thread Heikki Krogerus
+Guenter On Wed, Sep 12, 2018 at 07:11:12PM -0700, Badhri Jagan Sridharan wrote: > During HARD_RESET the data link is disconnected. > For self powered device, the spec is advising against doing that. > > >From USB_PD_R3_0 > 7.1.5 Response to Hard Resets > Device operation during and after a Hard

[PATCH 04/10] usb: xhci-mtk: improve bandwidth scheduling

2018-09-13 Thread Mathias Nyman
From: Chunfeng Yun Mainly improve SuperSpeed ISOC bandwidth in last microframe, and LowSpeed/FullSpeed IN INT/ISOC bandwidth in split and idle microframes by introduing a bandwidth budget table; Signed-off-by: Chunfeng Yun Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-mtk-sch.c | 162

[PATCH 06/10] usb: xhci-mtk: supports SSP without external USB3 gen2 hub

2018-09-13 Thread Mathias Nyman
From: Chunfeng Yun Supports SSP scheduling only for SSP device directly connected to root hub but not through external USB3 gen2 hub which need use a new scheduling way. Signed-off-by: Chunfeng Yun Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-mtk-sch.c | 17 +++-- 1 file

[PATCH 10/10] xhci-pci: allow host runtime PM as default for Intel Alpine and Titan Ridge

2018-09-13 Thread Mathias Nyman
The xhci controller on Alpine and Titan Ridge keeps the whole thunderbolt awake if the host controller is not allowed tp sleep. This is the case even if no USB devices are connected to the host. Because of this bigger impact, allow runtime pm as default for these xhci controllers in the driver. S

[PATCH 08/10] usb: host: xhci-plat: add platform TPL support

2018-09-13 Thread Mathias Nyman
From: Peter Chen The TPL support is used to identify targeted devices during EH2.0 and EH3.0 certification test, the user can add "tpl-support" at dts to enable this feature. Signed-off-by: Peter Chen Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-plat.c | 3 +++ 1 file changed, 3 ins

[PATCH 09/10] xhci: Use soft retry to recover faster from transaction errors

2018-09-13 Thread Mathias Nyman
Use soft retry to recover from a USB Transaction Errors that are caused by temporary error conditions. The USB device is not aware that the xHC has halted the endpoint, and will be waiting for another retry A Soft Retry perform additional retries and recover from an error which has caused the xHC

[PATCH 07/10] usb: typec: pci: Enable Intel USB role mux on Apollo Lake platforms

2018-09-13 Thread Mathias Nyman
From: Heikki Krogerus Intel Apollo Lake has the same internal USB role mux as Intel Cherry Trail. Signed-off-by: Heikki Krogerus Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-pci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-pci.c b

[PATCH 05/10] usb: xhci-mtk: supports bandwidth scheduling with multi-TT

2018-09-13 Thread Mathias Nyman
From: Chunfeng Yun Supports LowSpeed and FullSpeed INT/ISOC bandwidth scheduling with USB multi-TT Signed-off-by: Chunfeng Yun Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-mtk-sch.c | 247 ++-- drivers/usb/host/xhci-mtk.h | 21 2 files c

[PATCH 02/10] usb: xhci-mtk: use maximum ESIT payload of endpiont context

2018-09-13 Thread Mathias Nyman
From: Chunfeng Yun Make use of maximum ESIT payload of endpoint context to calculate the number of packets to send in each ESIT Signed-off-by: Chunfeng Yun Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-mtk-sch.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) d

[PATCH 00/10] xhci features for usb-next

2018-09-13 Thread Mathias Nyman
Hi Greg A few new features for xhci, better transaction error handling, default runtime PM allowing for Intel Alpine and Tiran Ridge xhci controllers, and Mediatek related xhci improvements. -Mathias Chunfeng Yun (6): usb: xhci-mtk: resume USB3 roothub first usb: xhci-mtk: use maximum ESIT p

[PATCH 01/10] usb: xhci-mtk: resume USB3 roothub first

2018-09-13 Thread Mathias Nyman
From: Chunfeng Yun Give USB3 devices a better chance to enumerate at USB3 speeds if they are connected to a suspended host. Porting from "671ffdff5b13 xhci: resume USB 3 roothub first" Signed-off-by: Chunfeng Yun Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-mtk.c | 4 ++-- 1 file ch

[PATCH 03/10] usb: xhci-mtk: fix ISOC error when interval is zero

2018-09-13 Thread Mathias Nyman
From: Chunfeng Yun If the interval equal zero, needn't round up to power of two for the number of packets in each ESIT, so fix it. Signed-off-by: Chunfeng Yun Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-mtk-sch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-13 Thread Heikki Krogerus
Hi, On Thu, Sep 13, 2018 at 09:36:58AM +0200, Peter Rosin wrote: > On 2018-09-13 00:22, Ajay Gupta wrote: > > Hi Peter, > > Can we get the working set in while the issues is being debugged? > > I'm not the one making the decision, and I don't even know if this > is going through the i2c or the us

Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree

2018-09-13 Thread Angus Ainslie
On 2018-09-13 01:27, Peter Chen wrote: On Thu, Sep 13, 2018 at 12:35 AM Guenter Roeck wrote: On Wed, Sep 12, 2018 at 10:08:58AM -0600, Angus Ainslie wrote: > On 2018-09-11 09:33, Guenter Roeck wrote: > >I cant put my finger on it but this seems wrong. As i said both src > >and sink should neve

Re: [PATCH] usbcore: Select UAC3 configuration for audio if present

2018-09-13 Thread Oliver Neukum
On Di, 2018-09-11 at 23:36 +0530, saranya.go...@intel.com wrote: > @@ -121,6 +132,23 @@ int usb_choose_configuration(struct usb_device *udev) > #endif > } > > + /* > +* Select first configuration as default for audio so that > +* devi

Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers

2018-09-13 Thread Felipe Balbi
Arnd Bergmann writes: > A handful of drivers all have a trivial wrapper around their ioctl > handler, but don't call the compat_ptr() conversion function at the > moment. In practice this does not matter, since none of them are used > on the s390 architecture and for all other architectures, comp

Re: [PATCH 1/5] misc: rtsx_usb: Use USB remote wakeup signaling for card insertion detection

2018-09-13 Thread Kai-Heng Feng
Hi Alan, Ulf, at 14:17, Kai-Heng Feng wrote: Although rtsx_usb doesn't support card removal detection, card insertion will resume rtsx_usb by USB remote wakeup signaling. When rtsx_usb gets resumed, also resumes its child devices, rtsx_usb_sdmmc and rtsx_usb_ms, to notify them there's a card

Re: [PATCH 1/1] usb: host: xhci-plat: add platform TPL support

2018-09-13 Thread Mathias Nyman
On 13.09.2018 09:54, Peter Chen wrote: On Wed, Jul 18, 2018 at 2:45 PM Peter Chen wrote: The TPL support is used to identify targeted devices during EH2.0 and EH3.0 certification test, the user can add "tpl-support" at dts to enable this feature. Signed-off-by: Peter Chen --- drivers/usb/h

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-13 Thread Kristian Evensen
Hi Johan, On Thu, Sep 13, 2018 at 11:17 AM Johan Hovold wrote: > Kristian would you mind giving it a try? Yes, thank you very much. I will give the patches a go during the day today and report back. > Oh, also note that I dropped the RSVD(5) for the ADB interface in your > patch since it uses a

[PATCH] usb: dwc3: add EXTCON dependency for qcom

2018-09-13 Thread Arnd Bergmann
Like the omap back-end, we get a link error with CONFIG_EXTCON=m when building the qcom back-end into the kernel: drivers/usb/dwc3/dwc3-qcom.o: In function `dwc3_qcom_probe': dwc3-qcom.c:(.text+0x13dc): undefined reference to `extcon_get_edev_by_phandle' dwc3-qcom.c:(.text+0x1b18): undefined refer

[PATCH 2/2] USB: serial: option: add two-endpoints device-id flag

2018-09-13 Thread Johan Hovold
Allow matching on interfaces having two endpoints by adding a new device-id flag. This allows for the handling of devices whose interface numbers can change (e.g. Quectel EP06) to be contained in the device-id table. Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/option.c | 17 +

[PATCH 1/2] USB: serial: option: improve Quectel EP06 detection

2018-09-13 Thread Johan Hovold
From: Kristian Evensen The Quectel EP06 (and EM06/EG06) LTE modem supports updating the USB configuration, without the VID/PID or configuration number changing. When the configuration is updated and interfaces are added/removed, the interface numbers are updated. This causes our current code for

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-13 Thread Johan Hovold
On Wed, Sep 12, 2018 at 10:34:43PM +0200, Bjørn Mork wrote: > Dan Williams writes: > > > The fact that the firmware implementation has the ability to change the > > endpoints is unrelated to Kristian's case, and that alone is > > justification for this to be quirked in the driver. People other t

Re: [PATCH v12 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-13 Thread Peter Rosin
On 2018-09-13 00:22, Ajay Gupta wrote: > Hi Peter, > Can we get the working set in while the issues is being debugged? I'm not the one making the decision, and I don't even know if this is going through the i2c or the usb tree? If it's going through the i2c tree you need a tag from the usb people

Re: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree

2018-09-13 Thread Peter Chen
On Thu, Sep 13, 2018 at 12:35 AM Guenter Roeck wrote: > > On Wed, Sep 12, 2018 at 10:08:58AM -0600, Angus Ainslie wrote: > > On 2018-09-11 09:33, Guenter Roeck wrote: > > >I cant put my finger on it but this seems wrong. As i said both src > > >and sink should never be true at the same time. I als