Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-08 Thread Mats Karrman
Hi, On 05/08/2018 04:25 PM, Heikki Krogerus wrote: > Hi, > > On Mon, May 07, 2018 at 11:19:40PM +0200, Mats Karrman wrote: Even so, when the mux driver "set" function is called, it will just get the mode argument but since the mode (TYPEC_STATE_...) is overlapping for different >>

Re: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM

2018-05-08 Thread James Bottomley
On Tue, 2018-05-08 at 10:29 -0500, David R. Bild wrote: > On Tue, May 8, 2018 at 10:25 AM, James Bottomley > wrote: > > > > > On Fri, May 04, 2018 at 02:56:25PM -0500, David R. Bild wrote: > > > > [...] > > > > In particular, it sets the credentials for the platform > > > > hierarchy. > > > > Th

Re: linux-next: Tree for May 8 (usb: typec...)

2018-05-08 Thread Randy Dunlap
On 05/07/2018 10:22 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180507: > on x86_64: WARNING: unmet direct dependencies detected for TYPEC_TCPCI Depends on [n]: STAGING [=y] && TYPEC_TCPM [=y] && I2C [=n] Selected by [y]: - TYPEC_RT1711H [=y] && STAGING [=y] && TYPEC_TCPM [=

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-08 Thread Doug Anderson
Hi, On Tue, May 8, 2018 at 12:43 AM, wlf wrote: > Dear Doug, > > 在 2018年05月08日 13:11, Doug Anderson 写道: >> >> Hi, >> >> On Mon, May 7, 2018 at 8:07 PM, William Wu >> wrote: >>> >>> +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, >>> +

Re: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM

2018-05-08 Thread David R. Bild
On Tue, May 8, 2018 at 10:25 AM, James Bottomley wrote: > > > On Fri, May 04, 2018 at 02:56:25PM -0500, David R. Bild wrote: > [...] > > > In particular, it sets the credentials for the platform hierarchy. > > > The platform hierarchy is essentially the "root" account of the > > > TPM, so it's cri

Re: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM

2018-05-08 Thread James Bottomley
On Tue, 2018-05-08 at 13:55 +0300, Jarkko Sakkinen wrote: > On Fri, May 04, 2018 at 02:56:25PM -0500, David R. Bild wrote: [...] > > In particular, it sets the credentials for the platform hierarchy. > > The platform hierarchy is essentially the "root" account of the > > TPM, so it's critical that

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-08 Thread Heikki Krogerus
Hi, On Mon, May 07, 2018 at 11:19:40PM +0200, Mats Karrman wrote: > >> Even so, when the mux driver "set" function is called, it will just get the > >> mode argument but since the mode (TYPEC_STATE_...) is overlapping for > >> different > >> AMs if I understand your proposal correctly, the mux al

Re: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM

2018-05-08 Thread Jarkko Sakkinen
On Fri, May 04, 2018 at 02:56:25PM -0500, David R. Bild wrote: > On Fri, May 4, 2018 at 2:06 PM, Jason Gunthorpe wrote: > > > > On Fri, May 04, 2018 at 08:00:22AM -0500, David R. Bild wrote: > > > Normally the system platform (i.e., BIOS/UEFI for x86) is responsible > > > for performing initializa

Re: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM

2018-05-08 Thread Jarkko Sakkinen
On Fri, May 04, 2018 at 08:00:22AM -0500, David R. Bild wrote: > Normally the system platform (i.e., BIOS/UEFI for x86) is responsible > for performing initialization of the TPM. For these modules, the host > kernel is the platform, so we perform the initialization in the driver > before registeri

Re: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-08 Thread Oliver Neukum
Am Freitag, den 04.05.2018, 08:59 + schrieb Jun Li: > > > > > Can one implement a device that can operate as either DFP or UFP, > > > > but not implements the dynamic role switch that a DRP must support? > > > > > > You mean a port with DRD on data but not DRP on power? > > > > > > The data-

Re: [PATCH v3 1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card

2018-05-08 Thread Oliver Neukum
Am Montag, den 07.05.2018, 08:31 -0500 schrieb David R. Bild : > > > + spi_master->flags = 0; > > > + spi_master->setup = xapea00x_spi_setup; > > > + spi_master->transfer_one_message = > > > xapea00x_spi_transfer_one_message; > > > + > > > + retval = spi_register_master(spi_master

Re: [usb-storage] [PATCH] usb: storage: Fix a possible data race in uas_queuecommand_lck

2018-05-08 Thread Jia-Ju Bai
On 2018/5/8 16:27, Oliver Neukum wrote: Am Dienstag, den 08.05.2018, 15:47 +0800 schrieb Jia-Ju Bai: The write operations to "cmnd->result" and "cmnd->scsi_done" are protected by the lock on line 642-643, but the write operations to these data on line 634-635 are not protected by the lock. Thu

Re: [usb-storage] [PATCH] usb: storage: Fix a possible data race in uas_queuecommand_lck

2018-05-08 Thread Oliver Neukum
Am Dienstag, den 08.05.2018, 15:47 +0800 schrieb Jia-Ju Bai: > The write operations to "cmnd->result" and "cmnd->scsi_done" > are protected by the lock on line 642-643, but the write operations > to these data on line 634-635 are not protected by the lock. > Thus, there may exist a data race for

Re: [PATCH 4/5] arm64: allwinner: h6: add USB3 device nodes

2018-05-08 Thread Sergei Shtylyov
Hello! On 5/7/2018 6:18 PM, Icenowy Zheng wrote: Allwinner H6 SoC features USB3 functionality, with a DWC3 controller and a custom PHY. Add device tree nodes for them. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38 1 file changed,

[PATCH] usb: storage: Fix a possible data race in uas_queuecommand_lck

2018-05-08 Thread Jia-Ju Bai
The write operations to "cmnd->result" and "cmnd->scsi_done" are protected by the lock on line 642-643, but the write operations to these data on line 634-635 are not protected by the lock. Thus, there may exist a data race for "cmnd->result" and "cmnd->scsi_done". To fix this data race, the wr

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-08 Thread wlf
Dear Doug, 在 2018年05月08日 13:11, Doug Anderson 写道: Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, + struct dwc2_qh *qh, + struct dwc

Re: [PATCH v3 2/2] usb: dwc2: fix isoc split in transfer with no data

2018-05-08 Thread wlf
Dear Doug, 在 2018年05月08日 13:13, Doug Anderson 写道: Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: If isoc split in transfer with no data (the length of DATA0 packet is zero), we can't simply return immediately. Because the DATA0 can be the first transaction or the second transaction for