[PATCH] usb: max3421: unlock on error in max3421_hub_control()

2017-10-26 Thread Dan Carpenter
We can't return directly in max3421_hub_control(), we have to unlock first. Fixes: 721fdc83b31b ("usb: max3421: Add devicetree support") Signed-off-by: Dan Carpenter diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c index 928a5aabee02..46a86a7f3360 100644 --- a/drivers

Re: [RFC 1/3] USB: Add document for usb of Hikey960

2017-10-26 Thread Rob Herring
On Tue, Oct 24, 2017 at 02:06:08PM +0800, Yu Chen wrote: > DT bindings for usb of Hikey960. > > Signed-off-by: Yu Chen > Signed-off-by: Ning Fan > Signed-off-by: Di Yang > Signed-off-by: Rui Li > > --- > .../devicetree/bindings/usb/hisilicon-usb.txt | 38 > ++ > 1 f

Re: [PATCH v7 usb-next 4/4] dt-bindings: usb: xhci: include the roothub and a device in the example

2017-10-26 Thread Rob Herring
On Mon, Oct 23, 2017 at 11:57:18PM +0200, Martin Blumenstingl wrote: > This extends the existing example from the USB xHCI binding > documentation so it includes the roothub and an actual device. > The goal of this is to show that the roothub is specified alongside the > actual devices on the USB b

Re: [PATCH 01/10 v3] usb: usb251xb: Update usb251xb bindings

2017-10-26 Thread Rob Herring
On Sun, Oct 22, 2017 at 11:38:03PM +0300, Serge Semin wrote: > Since hub usb2517 is going to be supported by the usb251xb driver, > the bindings need to be properly updated. Particularly: > - add "microchip,usb2517" and "microchip,usb2517i" compatible strings. > - add "boolean" description to all t

RE: [PATCH resend 00/12] staging: typec: tcpci: move out of staging

2017-10-26 Thread Jun Li
Hi Guenter, > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: Friday, October 27, 2017 8:43 AM > To: Jun Li ; gre...@linuxfoundation.org; robh...@kernel.org; > mark.rutl...@arm.com; heikki.kroge...@linux.intel.com > Cc: yue...@google.c

Re: [PATCH resend 00/12] staging: typec: tcpci: move out of staging

2017-10-26 Thread Guenter Roeck
What happened with this series ? Did we all drop the ball ? Guenter On 09/25/2017 09:05 PM, Li Jun wrote: This patch set attempts to move the tcpci driver out of staging by fix some tcpci driver issues and verified on NXP PTN5110, which is a standard tcpci typec port controller device with powe

[PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-26 Thread Douglas Anderson
On rk3288-veyron devices on Chrome OS it was found that plugging in an Arduino-based USB device could cause the system to lockup, especially if the CPU Frequency was at one of the slower operating points (like 100 MHz / 200 MHz). Upon tracing, I found that the following was happening: * The USB de

Re: [PATCH v2 1/3] usb: host: remove ehci-msm.c

2017-10-26 Thread Alan Stern
On Thu, 26 Oct 2017, Alex Elder wrote: > No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it. What about old Qualcomm SoCs? What should they use instead? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@

Re: [RFC/PATCH 0/4] usb: core: Add Support for getting PTM_STATUS

2017-10-26 Thread Alan Stern
On Thu, 26 Oct 2017, Felipe Balbi wrote: > Felipe Balbi writes: > > > Hi, > > > > Alan Stern writes: > >> On Wed, 25 Oct 2017, Felipe Balbi wrote: > >> > >>> Hi, > >>> > >>> The following series was compile-tested only (so far, at least). I > >>> wanted to get some comments from folks to see w

[PATCH v2 0/3] usb: remove some unused code

2017-10-26 Thread Alex Elder
This series deletes some Qualcomm USB code is no longer needed by any Qualcomm hardware. This version properly deletes the sections of Kconfig files that control whether the deleted code gets built. (This time I'm also sending to linux-arm-msm and linux-arm-kernel.)

[PATCH v2 3/3] usb: phy: remove phy-qcom-8x16-usb.c

2017-10-26 Thread Alex Elder
No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver support any more, so remove the code. Suggested-by: Stephen Boyd Signed-off-by: Alex Elder Acked-by: Bjorn Andersson Acked-by: Andy Gross --- v2: Update the Kconfig file so it no longer offers to build this code, as suggeste

[PATCH v2 1/3] usb: host: remove ehci-msm.c

2017-10-26 Thread Alex Elder
No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it. Suggested-by: Stephen Boyd Signed-off-by: Alex Elder Acked-by: Bjorn Andersson Acked-by: Andy Gross --- v2: Update the Kconfig file so it no longer offers to build this code, as suggested by Manu Gautam. drivers/usb/

[PATCH v2 2/3] usb: phy: remove phy-msm-usb.c

2017-10-26 Thread Alex Elder
No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support any more, so remove the code. Suggested-by: Stephen Boyd Signed-off-by: Alex Elder Acked-by: Bjorn Andersson Acked-by: Andy Gross --- v2: Update the Kconfig file so it no longer offers to build this code, as suggested by M

Re: [PATCH 1/3] usb: host: remove ehci-msm.c

2017-10-26 Thread Alex Elder
On 10/26/2017 12:10 AM, Manu Gautam wrote: > Hi, I'll re-send with the kconfig updates pointed out by you and Felipe Balbi. Sorry about that. -Alex > > On 10/26/2017 3:31 AM, Alex Elder wrote: >> No Qualcomm SoC requires the "ehci-msm.c" code any more.

[PATCH 1/3] phy: phy-mtk-tphy: use auto instead of force to bypass utmi signals

2017-10-26 Thread Chunfeng Yun
When system is running, if usb2 phy is forced to bypass utmi signals, all PLL will be turned off, and it can't detect device connection anymore, so replace force mode with auto mode which can bypass utmi signals automatically if no device attached for normal flow. But keep the force mode to fix RX

[PATCH 2/3] phy: phy-mtk-tphy: use of_device_get_match_data()

2017-10-26 Thread Chunfeng Yun
reduce the boilerplate code to get the specific data Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-tphy.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c index 54cc44b..cdd

[PATCH 3/3] phy: phy-mtk-tphy: fix alignment warning

2017-10-26 Thread Chunfeng Yun
Fix alignment warning by checkpatch.pl with --strict Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/Kconfig|8 drivers/phy/mediatek/phy-mtk-tphy.c | 24 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/phy/mediatek/Kco

Re: [PATCH 1/4] usb: xhci: remove unused variable last_freed_endpoint

2017-10-26 Thread LABBE Corentin
On Thu, Oct 26, 2017 at 12:01:54PM +, Corentin Labbe wrote: > This patch fix the following build warnings: > drivers/usb/host/xhci.c:3378:6: warning: variable 'last_freed_endpoint' set > but not used [-Wunused-but-set-variable] > > Signed-off-by: Corentin Labbe > --- > drivers/usb/host/xhci

[PATCH 4/4] usb: xhci: remove unused variable ep_ring

2017-10-26 Thread Corentin Labbe
This patch fix the following build warnings: drivers/usb/host/xhci-ring.c:2011:20: warning: variable 'ep_ring' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe --- drivers/usb/host/xhci-ring.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/xhci-r

[PATCH 2/4] usb: xhci: remove unused variable ep

2017-10-26 Thread Corentin Labbe
This patch fix the following build warning: drivers/usb/host/xhci.c:2853:23: warning: variable 'ep' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe --- drivers/usb/host/xhci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/h

[PATCH 3/4] usb: xhci: remove unused variable urb_priv

2017-10-26 Thread Corentin Labbe
This patch fix the following build warning: drivers/usb/host/xhci-ring.c:1895:19: warning: variable 'urb_priv' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe --- drivers/usb/host/xhci-ring.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/xhci-r

[PATCH 1/4] usb: xhci: remove unused variable last_freed_endpoint

2017-10-26 Thread Corentin Labbe
This patch fix the following build warnings: drivers/usb/host/xhci.c:3378:6: warning: variable 'last_freed_endpoint' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe --- drivers/usb/host/xhci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/host/xhci

[PATCH v2 0/4] usb: xhci: fix build warnings

2017-10-26 Thread Corentin Labbe
Hello This patchset fix some build warnings on usb/xhci. Regards Changes since v1: - Changed subject of patch Corentin Labbe (4): usb: xhci: remove unused variable last_freed_endpoint usb: xhci: remove unused variable ep usb: xhci: remove unused variable urb_priv usb: xhci: remove unuse

[PATCH v2 3/4] usb: xhci: remove unused variable urb_priv

2017-10-26 Thread Corentin Labbe
From: Corentin Labbe This patch fix the following build warning: drivers/usb/host/xhci-ring.c:1895:19: warning: variable 'urb_priv' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe --- drivers/usb/host/xhci-ring.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/

[PATCH v2 4/4] usb: xhci: remove unused variable ep_ring

2017-10-26 Thread Corentin Labbe
From: Corentin Labbe This patch fix the following build warnings: drivers/usb/host/xhci-ring.c:2011:20: warning: variable 'ep_ring' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe --- drivers/usb/host/xhci-ring.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/

[PATCH v2 1/4] usb: xhci: remove unused variable last_freed_endpoint

2017-10-26 Thread Corentin Labbe
From: Corentin Labbe This patch fix the following build warnings: drivers/usb/host/xhci.c:3378:6: warning: variable 'last_freed_endpoint' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe --- drivers/usb/host/xhci.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH v2 2/4] usb: xhci: remove unused variable ep

2017-10-26 Thread Corentin Labbe
From: Corentin Labbe This patch fix the following build warning: drivers/usb/host/xhci.c:2853:23: warning: variable 'ep' set but not used [-Wunused-but-set-variable] Signed-off-by: Corentin Labbe --- drivers/usb/host/xhci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host

Re: [PATCH] usb: gadget: composite: mark expected switch fall-throughs

2017-10-26 Thread Gustavo A. R. Silva
Hi Felipe, Quoting Felipe Balbi : "Gustavo A. R. Silva" writes: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva Acked-by: Felipe Balbi Thank you for the ACKs. -- Gustavo A. R. Silva

Re: [RFC/PATCH 0/4] usb: core: Add Support for getting PTM_STATUS

2017-10-26 Thread Felipe Balbi
Felipe Balbi writes: > Hi, > > Alan Stern writes: >> On Wed, 25 Oct 2017, Felipe Balbi wrote: >> >>> Hi, >>> >>> The following series was compile-tested only (so far, at least). I >>> wanted to get some comments from folks to see what you guys think >>> about this before running tests. >>> >>>

Re: [RFC/PATCH 0/4] usb: core: Add Support for getting PTM_STATUS

2017-10-26 Thread Felipe Balbi
Hi, Alan Stern writes: > On Wed, 25 Oct 2017, Felipe Balbi wrote: > >> Hi, >> >> The following series was compile-tested only (so far, at least). I >> wanted to get some comments from folks to see what you guys think >> about this before running tests. >> >> I don't have any device available w

Re: [PATCH] usb: gadget: composite: mark expected switch fall-throughs

2017-10-26 Thread Felipe Balbi
"Gustavo A. R. Silva" writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: gadget: udc: dummy_hcd: mark expected switch fall-throughs

2017-10-26 Thread Felipe Balbi
"Gustavo A. R. Silva" writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 3/3] usb: phy: remove phy-qcom-8x16-usb.c

2017-10-26 Thread Felipe Balbi
Alex Elder writes: > No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver > support any more, so remove the code. > > Suggested-by: Stephen Boyd > Signed-off-by: Alex Elder > Acked-by: Bjorn Andersson > Acked-by: Andy Gross Kconfig? -- balbi signature.asc Description: PGP si