Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

2017-10-18 Thread Andrzej Hajda
Hi Laurent, Thank you for the review. On 18.10.2017 17:11, Laurent Pinchart wrote: > Hi Andrzej, > > Thank you for the patch. > > On Thursday, 28 September 2017 16:07:27 EEST Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >> and it should be possible

Re: dwc2 - ChHltd set, but reason is unknown

2017-10-18 Thread Minas Harutyunyan
On 10/16/2017 7:16 PM, Anders Montonen wrote: > On Mon, 16 Oct 2017, Minas Harutyunyan wrote: >> On 10/16/2017 12:12 PM, Anders Montonen wrote: >>> On Mon, 16 Oct 2017, Minas Harutyunyan wrote: On 10/10/2017 4:35 PM, Anders Montonen wrote: > On Mon, 9 Oct 2017, Minas Harutyunyan wrote: >>>

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-10-18 Thread Minas Harutyunyan
On 10/17/2017 12:41 PM, Minas Harutyunyan wrote: > On 10/17/2017 1:34 AM, John Stultz wrote: >> On Mon, Oct 16, 2017 at 1:36 AM, Minas Harutyunyan >> wrote: >>> On b-plug disconnect should asserted GOTGINT.SesEndDet interrupt. >>> According previously sent by you register dump (GHWCFG2 = 0x23affc7

Re: [iMX6Q][CI] EHCI Low-speed device problem

2017-10-18 Thread Peter Chen
On Thu, Oct 19, 2017 at 07:47:01AM +0200, Lukasz Majewski wrote: > > > I'm wondering if it is feasible to manually check the XactErr bit > > > and then for example order the soft USB reset (from the root hub)? > > > > > > Or is there any other acceptable in upstream solution? > > > > > > > > > >

Re: [iMX6Q][CI] EHCI Low-speed device problem

2017-10-18 Thread Lukasz Majewski
Hi Peter, > On Thu, Oct 19, 2017 at 01:38:45AM +0200, Lukasz Majewski wrote: > > Hi Alan, > > > > Thank you for you reply. > > > > > On Wed, 18 Oct 2017, Lukasz Majewski wrote: > > > > > > > Dear All, > > > > > > > > I'm using iMX6q for my application. It uses the touchscreen IC > > > > connec

Re: [iMX6Q][CI] EHCI Low-speed device problem

2017-10-18 Thread Peter Chen
On Thu, Oct 19, 2017 at 01:38:45AM +0200, Lukasz Majewski wrote: > Hi Alan, > > Thank you for you reply. > > > On Wed, 18 Oct 2017, Lukasz Majewski wrote: > > > > > Dear All, > > > > > > I'm using iMX6q for my application. It uses the touchscreen IC > > > connected via USB port (Host port 1). T

Oakley Sunglass Warehouse

2017-10-18 Thread Oakley Sunglass Warehouse
From: Oakley Sunglass Warehouse Email: linux-usb@vger.kernel.org -- Good day It's our birthday and we are celebrating two years of our shop. We sell the latest original Oakley Sunglasses just $19.95. If interested, please check out our out

Re: [iMX6Q][CI] EHCI Low-speed device problem

2017-10-18 Thread Alan Stern
On Wed, 18 Oct 2017, Lukasz Majewski wrote: > Dear All, > > I'm using iMX6q for my application. It uses the touchscreen IC > connected via USB port (Host port 1). The touchscreen operates with > low-speed. I don't know anything about the iMX6q specifically... > Board: Wandboard rev1b / some cu

[PATCH 2/2] typec: tcpm: Only request matching pdos

2017-10-18 Thread Badhri Jagan Sridharan
At present, TCPM code assumes that local device supports variable/batt pdos and always selects the pdo with highest possible power within the board limit. This assumption might not hold good for all devices. To overcome this, this patch makes TCPM only accept a source_pdo when there is a matching s

[PATCH 1/2 v3] typec: tcpm: Validate source and sink caps

2017-10-18 Thread Badhri Jagan Sridharan
The source and sink caps should follow the following rules. This patch validates whether the src_caps/snk_caps adheres to it. 6.4.1 Capabilities Message A Capabilities message (Source Capabilities message or Sink Capabilities message) shall have at least one Power Data Object for vSafe5V. The Capa

[iMX6Q][CI] EHCI Low-speed device problem

2017-10-18 Thread Lukasz Majewski
Dear All, I'm using iMX6q for my application. It uses the touchscreen IC connected via USB port (Host port 1). The touchscreen operates with low-speed. Board: Wandboard rev1b / some custom board SW: Mainline Linux 4.13 Problem: I do observe that the USB transfers are truncated - for example

[PATCH] USB: core: fix out-of-bounds access bug in usb_get_bos_descriptor()

2017-10-18 Thread Alan Stern
Andrey used the syzkaller fuzzer to find an out-of-bounds memory access in usb_get_bos_descriptor(). The code wasn't checking that the next usb_dev_cap_header structure could fit into the remaining buffer space. This patch fixes the error and also reduces the bNumDeviceCaps field in the header to

Re: usb/core: slab-out-of-bounds in usb_get_bos_descriptor

2017-10-18 Thread Andrey Konovalov
On Wed, Oct 18, 2017 at 5:25 PM, Alan Stern wrote: > On Wed, 18 Oct 2017, Andrey Konovalov wrote: > >> Hi! >> >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit 3e0cc09a3a2c40ec1ffb6b4e12da86e98feccb11 (4.14-rc5+). >> >> Looks like usb_get_bos_descriptor() do

Re: linux-next: manual merge of the usb-gadget tree with the usb tree

2017-10-18 Thread Mark Brown
On Wed, Oct 18, 2017 at 08:40:04AM -0700, Kees Cook wrote: > On Wed, Oct 18, 2017 at 7:49 AM, Mark Brown wrote: > > I fixed it up with the USB version and can carry the fix as necessary. This > > is now fixed as far as linux-next is concerned, but any non trivial > > conflicts should be mentioned

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

2017-10-18 Thread Laurent Pinchart
Hi Bhumika, Thank you for the patch. On Monday, 16 October 2017 18:18:41 EEST Bhumika Goyal wrote: > Make these structures const as they are only passed to the const > argument of the functions config_{group/item}_init_type_name. > > Signed-off-by: Bhumika Goyal > --- > * Changes in v2- Combine

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

2017-10-18 Thread Laurent Pinchart
Hi Andrzej, On Wednesday, 18 October 2017 18:11:25 EEST Laurent Pinchart wrote: > On Thursday, 28 September 2017 16:07:27 EEST Andrzej Hajda wrote: > > These bindings allows to describe most known standard USB connectors > > and it should be possible to extend it if necessary. > > USB connectors,

Re: linux-next: manual merge of the usb-gadget tree with the usb tree

2017-10-18 Thread Kees Cook
On Wed, Oct 18, 2017 at 7:42 AM, Mark Brown wrote: > Hi Felipe, > > Today's linux-next merge of the usb-gadget tree got a conflict in: > > drivers/usb/gadget/udc/snps_udc_core.c > > between commit: > > 29bce57723351f63d ("usb/gadget/snps_udc_core: Convert timers to use > timer_setup()") > > f

Re: linux-next: manual merge of the usb-gadget tree with the usb tree

2017-10-18 Thread Kees Cook
On Wed, Oct 18, 2017 at 7:49 AM, Mark Brown wrote: > Hi Felipe, > > Today's linux-next merge of the usb-gadget tree got a conflict in: > > drivers/usb/phy/phy-isp1301-omap.c > > between commit: > > 4c13fec1ba55595 ("usb: isp1301-omap: Convert timers to use timer_setup()") > > from the usb tree

Re: usb/core: slab-out-of-bounds in usb_get_bos_descriptor

2017-10-18 Thread Alan Stern
On Wed, 18 Oct 2017, Andrey Konovalov wrote: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. > > On commit 3e0cc09a3a2c40ec1ffb6b4e12da86e98feccb11 (4.14-rc5+). > > Looks like usb_get_bos_descriptor() doesn't check that buffer has > enough space for usb_dev_cap_

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

2017-10-18 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Thursday, 28 September 2017 16:07:27 EEST Andrzej Hajda wrote: > These bindings allows to describe most known standard USB connectors > and it should be possible to extend it if necessary. > USB connectors, beside USB can be used to route other protocols, >

Re: [PATCH v3] USB: Force disconnect Huawei 4G modem during suspend

2017-10-18 Thread Alan Stern
On Wed, 18 Oct 2017, Daniel Drake wrote: > When going into S3 suspend, the Acer TravelMate P648-M and P648-G3 > laptops immediately wake up 3-4 seconds later for no obvious reason. > > Unbinding the integrated Huawei 4G LTE modem before suspend avoids > the issue, even though we are not using the

Re: [PATCH] usb: "USB Host halt failed, -110" error when rebooting system

2017-10-18 Thread Alan Stern
On Tue, 17 Oct 2017 wenxi...@linux.vnet.ibm.com wrote: > From: Wen Xiong > > > We saw "Host halt failed, -110" error when rebooting system/ > shutdowning system/kexec constantly. > > This patch called usb_disconnect() before calling xhci_halt(). > usb_disconnect()disconnect the parent and al

linux-next: manual merge of the usb-gadget tree with the usb tree

2017-10-18 Thread Mark Brown
Hi Felipe, Today's linux-next merge of the usb-gadget tree got a conflict in: drivers/usb/phy/phy-isp1301-omap.c between commit: 4c13fec1ba55595 ("usb: isp1301-omap: Convert timers to use timer_setup()") from the usb tree and commit: 687f272c6b0e89d ("usb: phy: omap: use setup_timer() h

linux-next: manual merge of the usb-gadget tree with the usb tree

2017-10-18 Thread Mark Brown
Hi Felipe, Today's linux-next merge of the usb-gadget tree got a conflict in: drivers/usb/gadget/udc/snps_udc_core.c between commit: 29bce57723351f63d ("usb/gadget/snps_udc_core: Convert timers to use timer_setup()") from the usb tree and commit: 46b614affda8667f9 ("usb: gadget: udc: s

Re: [PATCH usb-next v6 3/3] usb: core: hcd: integrate the PHY roothub wrapper

2017-10-18 Thread Alan Stern
On Tue, 17 Oct 2017, Martin Blumenstingl wrote: > This integrates the PHY roothub wrapper into the core hcd > infrastructure. Multiple PHYs which are part of the roothub devicetree > node (which is a sub-node of the sysdev's node) are now managed > (= powered on/off when needed), by the new usb_ph

Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const

2017-10-18 Thread Doug Ledford
On Mon, 2017-10-16 at 17:18 +0200, Bhumika Goyal wrote: > Make these structures const as they are either passed to the > functions > having the argument as const or stored as a reference in the > "ci_type" > const field of a config_item structure. > > Signed-off-by: Bhumika Goyal Acked-by: Doug

Re: dwc2: usb: Unable to clear channel error

2017-10-18 Thread Dinh Nguyen
On 10/18/2017 09:07 AM, Marek Vasut wrote: > On 10/18/2017 04:05 PM, Dinh Nguyen wrote: >> Hi, >> >> I'm trying to bringup the DWC2 USB IP version 330A on a new Stratix10 >> SoC and have encountered this error in both Linux and U-Boot: >> >> U-Boot(version v2017.09) >> >> # usb start >> starting

Re: dwc2: usb: Unable to clear channel error

2017-10-18 Thread Marek Vasut
On 10/18/2017 04:05 PM, Dinh Nguyen wrote: > Hi, > > I'm trying to bringup the DWC2 USB IP version 330A on a new Stratix10 > SoC and have encountered this error in both Linux and U-Boot: > > U-Boot(version v2017.09) > > # usb start > starting USB... > USB0: Core Release: 3.30a > dwc_otg_core_h

dwc2: usb: Unable to clear channel error

2017-10-18 Thread Dinh Nguyen
Hi, I'm trying to bringup the DWC2 USB IP version 330A on a new Stratix10 SoC and have encountered this error in both Linux and U-Boot: U-Boot(version v2017.09) # usb start starting USB... USB0: Core Release: 3.30a dwc_otg_core_host_init: Timeout! dwc_otg_core_host_init: Timeout! Linux(kernel

Re: [PATCHv4 0/2] dwc3 on XU3

2017-10-18 Thread Kishon Vijay Abraham I
On Monday 09 October 2017 05:30 PM, Andrzej Pietrasiewicz wrote: > Hi all, > > This is the fourth version of patches in this thread. > > The series fixes problems with enumerating of SuperSpeed devices > on an Odroid XU3. There was a patch series from Vivek Gautam in > circulation, but it got l

usb/core: slab-out-of-bounds in usb_get_bos_descriptor

2017-10-18 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 3e0cc09a3a2c40ec1ffb6b4e12da86e98feccb11 (4.14-rc5+). Looks like usb_get_bos_descriptor() doesn't check that buffer has enough space for usb_dev_cap_header, which causes out-of-bounds accesses.

Re: [PATCH v3 10/14] extcon: intel-int3496: Add support for controlling the USB-role mux

2017-10-18 Thread Chanwoo Choi
On 2017년 10월 18일 18:14, Hans de Goede wrote: > Hi, > > On 18-10-17 04:33, Chanwoo Choi wrote: >> Hi Hans, >> >> On 2017년 09월 23일 03:37, Hans de Goede wrote: >>> Cherry Trail SoCs have a built-in USB-role mux for switching between >>> the host and device controllers, rather then using an external m

Re: [PATCH v3] USB: Force disconnect Huawei 4G modem during suspend

2017-10-18 Thread Oliver Neukum
Am Mittwoch, den 18.10.2017, 15:15 +0800 schrieb Daniel Drake: > Notes: >     v2: >     - Handle quirk later in suspend, to avoid interfering with other parts >   of the suspend routine. >     - Don't do the disconnect on runtime suspend, only for S3 suspend Hi, well, can we effectively runti

Re: [PATCH v3 10/14] extcon: intel-int3496: Add support for controlling the USB-role mux

2017-10-18 Thread Hans de Goede
Hi, On 18-10-17 04:33, Chanwoo Choi wrote: Hi Hans, On 2017년 09월 23일 03:37, Hans de Goede wrote: Cherry Trail SoCs have a built-in USB-role mux for switching between the host and device controllers, rather then using an external mux controller by a GPIO. There is a driver using the mux-subsys

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

2017-10-18 Thread Arnd Bergmann
On Tue, Oct 17, 2017 at 11:19 PM, Martin Blumenstingl wrote: >> Ok, very good! >> >>> is there anything else you want me to test? >> >> What about the same dtb when run on a kernel without your >> patch series? Does that work as well, or are your patches >> required to make it work? > > this is th

[PATCH v3] USB: Force disconnect Huawei 4G modem during suspend

2017-10-18 Thread Daniel Drake
When going into S3 suspend, the Acer TravelMate P648-M and P648-G3 laptops immediately wake up 3-4 seconds later for no obvious reason. Unbinding the integrated Huawei 4G LTE modem before suspend avoids the issue, even though we are not using the modem at all (checked from rescue.target/runlevel1)