On Fri, Apr 07 2017, Thinh Nguyen wrote:
> f_mass_storage has a memorry barrier issue with the sleep and wake
> functions that can cause a deadlock. This results in intermittent hangs
> during MSC file transfer. The host will reset the device after receiving
> no response to resume the transfer. Th
The dwc3 driver can overwite its previous events if its top half IRQ
handler gets invoked again before processing the events in the cache. We
see this as a hang in the file transfer and the host will attempt to
reset the device. This shouldn't be possible in the dwc3 implementation
if the HW and th
This patch fixes a commit that causes a hang from device waiting for
data with the wrong sequence number. The commit ffb80fc672c3 ("usb:
dwc3: gadget: skip Set/Clear Halt when invalid") adds a check to return
early depending on DWC3_EP_STALL is set or not, prevent sending the ep
halt command to HW
f_mass_storage has a memorry barrier issue with the sleep and wake
functions that can cause a deadlock. This results in intermittent hangs
during MSC file transfer. The host will reset the device after receiving
no response to resume the transfer. This issue is seen when dwc3 is
processing 2 transf
On 04/07/2017 06:15 PM, Alexandre Bailon wrote:
On 04/07/2017 04:36 PM, Sekhar Nori wrote:
On Wednesday 05 April 2017 10:47 PM, Alexandre Bailon wrote:
The CPPI 4.1 DMA is sharing its clock with the USB OTG,
and most of the time, the clock will be enabled by USB.
But during the init of the
On 04/07/2017 04:36 PM, Sekhar Nori wrote:
On Wednesday 05 April 2017 10:47 PM, Alexandre Bailon wrote:
The CPPI 4.1 DMA is sharing its clock with the USB OTG,
and most of the time, the clock will be enabled by USB.
But during the init of the DMA, USB is not enabled (waiting for DMA),
and then
From: Cristian Birsan
Update Kconfig help for fifo_mode = 0 to explain the behavior better.
Signed-off-by: Cristian Birsan
Acked-by: Nicolas Ferre
---
drivers/usb/gadget/udc/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/Kconfig b/drive
From: Cristian Birsan
Use dev_err() to display EP configuration error to avoid silent failure.
Signed-off-by: Cristian Birsan
Acked-by: Nicolas Ferre
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/
From: Cristian Birsan
This patch series provides fixes, based on the feedback received on the mailing
list, for
the following:
- fifo table parameters validation against device tree values
- coding style
- message display for EP configuration error
- Kconfig comme
Hi,
The patch 2 does not apply because it's already on testing/next.
I'll send a new patch series version that will apply clean on top of testing
branch.
Regards,
Cristi
On 05.04.2017 15:33, Felipe Balbi wrote:
>
> Hi,
>
> cristian.bir...@microchip.com writes:
>> From: Cristian Birsan
>>
>>
From: Joel Stanley
We can't halt the host controller immediately when first HCD is removed as
it will cause problems if we have devices attached to the second (primary)
HCD, like a keyboard.
We've been carrying this in our Linux-as-a-bootloader environment for a
little while now. The machines al
From: Guoqing Zhang
Change the visability of xhci_start() so that it
can be used when enabling test mode.
Signed-off-by: Guoqing Zhang
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 2 +-
drivers/usb/host/xhci.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/
Hi Greg
Among other small changes this series adds usb2 port test mode for xhci,
reworks how we handle unresponsive (hotplug removed) hosts,
and shifts debugging more towards tracing.
v2:
- cc stable for patch 24/24: bInterval quirk for TI TUSB73x0
- set port state to netral before writing por
From: Lu Baolu
Omit extra messages for memory allocation failure.
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-hub.c | 4 +---
drivers/usb/host/xhci-mem.c | 1 -
drivers/usb/host/xhci-ring.c | 10 --
drivers/usb/host/xhci.c | 13 +++--
From: Felipe Balbi
By extracting and exposing xhci_slot_state_string() in a header file, we
can re-use it to print Slot Context State from our tracepoints, which
can aid in tracking down problems related to command execution.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
driver
From: Zhengjun Xing
There's one annoyance in how xhci prints debug messages, we often
get logs with messages but it's hard to say from which device and
endpoint the message originates. Add slot_id, ep_index messages
in handle_tx_event.
Signed-off-by: Zhengjun Xing
Signed-off-by: Mathias Nyman
From: Felipe Balbi
With these, we can track what's happening with the HW while executing
each and every command. It will give us visibility into how the
different contexts are being modified by xHC which can bring insight
into problems while debugging.
Signed-off-by: Felipe Balbi
Signed-off-by:
From: Guoqing Zhang
For usb2 ports, the port test mode Test_J_State, Test_K_State,
Test_Packet, Test_SE0_NAK and Test_Force_En can be enabled
as described in usb2 spec.
USB2 test mode is a required hardware feature for system integrators
validating their hardware according to USB spec, regarding
From: Roger Quadros
As per [1] issue #4,
"The periodic EP scheduler always tries to schedule the EPs
that have large intervals (interval equal to or greater than
128 microframes) into different microframes. So it maintains
an internal counter and increments for each large interval
EP added. When
From: Lu Baolu
Replace 'TRB_FIELD_TO_TYPE(field3)' with 'type' to simplify
code.
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.h | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/host/xhc
From: Lu Baolu
Every XHCI TRB has already been traced by the trb trace events.
It is unnecessary to put the same message in kernel log. This
patch removes xhci_debug_trb().
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-dbg.c | 57 -
From: Lu Baolu
XHCI context changes have already been traced by the trace
events. It's unnecessary to put the same message in kernel
log. This patch removes the use of xhci_dbg_ctx().
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-dbg.c | 143 --
From: Lu Baolu
xhci_decode_trb() treats a link trb in the same way as that for
an event trb. This patch fixes this by decoding the link trb
according to the spec.
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.h | 12 +---
1 file changed, 5 insertions(+
From: Lu Baolu
This patch creates a new event class called xhci_log_ring, and
defines the events used for tracing the change of all kinds of
rings used by an xhci host. An xHCI ring is basically a memory
block shared between software and hardware. By tracing changes
of rings, it makes the life ea
From: Lu Baolu
XHCI ring changes have already been traced by the ring trace
events. It's unnecessary to put the same messages in kernel
log. This patch removes the debugging code for a ring.
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-dbg.c | 62 ---
From: Felipe Balbi
Format for each TRB in each control transfer stage differs. Let's make
sure we correctly pretty print these fields to avoid confusion.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.h | 59 +++--
From: Lu Baolu
enq_updates and deq_updates were introduced in the first place
to check whether an xhci hardware is able to respond to trbs
enqueued in the ring. We now have trb tracers to trace every
single enqueue/dequeue trb. It's time to remove them and the
associated debugging code.
Signed-o
From: Lu Baolu
xhci_dbg_ep_rings() isn't used in xhci driver anymore. Remove
it to reduce the module binary size.
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-dbg.c | 24
drivers/usb/host/xhci.h | 3 ---
2 files changed, 27 delet
From: Lu Baolu
Several functions have a single user in the same file where it
is defined. There's no need to expose it anywhere else.
Signed-off-by: Lu Baolu
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 59 +
drivers/usb/host/xhci.
Introduce a new xhci_hc_died() function that takes care of handling
pending commands and URBs if a host controller becomes unresponsive.
This addresses issues on hotpluggable xhci controllers that disappear
from the bus suddenly, often while the bus (PCI) remove function is
still being processed.
From: Guoqing Zhang
Refactoring slot disable related code into a helper
function xhci_disable_slot() which can be used when
enabling test mode.
Signed-off-by: Guoqing Zhang
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 49 +++--
drivers
From: Felipe Balbi
This will help us figuring out which device $this URB belongs to while
debugging.
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-trace.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci-tra
From: Guoqing Zhang
Refactoring port power on/off related code into
a helper function xhci_set_power_on() which can
be reused when enabling test mode.
[set port state to neutral before writing port power -Mathias]
Signed-off-by: Guoqing Zhang
Signed-off-by: Mathias Nyman
---
drivers/usb/host/
From: Andrew Bresticker
USB host controllers can take a significant amount of time to suspend
and resume, adding several hundred miliseconds to the kernel resume
time. Since the XHCI controller has no outside dependencies (other than
clocks, which are suspended late/resumed early), allow it to su
From: Lu Baolu
EINT(Event Interrupt) is a write-1-to-clear type of bit in xhci
status register. It should be cleared by writing a 1. Writing 0
to this bit has no effect.
Xhci driver tries to clear this bit by writing 0 to it. This is
not the right way to go. This patch corrects this by reading t
On Wednesday 05 April 2017 10:47 PM, Alexandre Bailon wrote:
> The CPPI 4.1 DMA is sharing its clock with the USB OTG,
> and most of the time, the clock will be enabled by USB.
> But during the init of the DMA, USB is not enabled (waiting for DMA),
> and then we must enable the clock before doing a
Commit d8e5f0eca1e8 ("usb: musb: Fix hardirq-safe hardirq-unsafe
lock order error") caused a regression where musb keeps trying to
enable host mode with no cable connected. This seems to be caused
by the fact that now phy is enabled earlier, and we are wrongly
trying to force USB host mode on an OT
On Fri, Apr 07, 2017 at 06:52:53AM -0700, Tony Lindgren wrote:
> * Bin Liu [170406 12:09]:
> > On Wed, Apr 05, 2017 at 08:29:55AM -0700, Tony Lindgren wrote:
> > > If the the port is configured as OTG, we should not need to
> > > try to force any states during init. The change below will stop
> >
On 04.04.2017 15:54, Mathias Nyman wrote:
From: Guoqing Zhang
Refactoring port power on/off related code into
a helper function xhci_set_power_on() which can
be reused when enabling test mode.
Signed-off-by: Guoqing Zhang
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-hub.c | 65 ++
On 04.04.2017 15:54, Mathias Nyman wrote:
Hi Greg
Among other small changes this series adds usb2 port test mode for xhci,
reworks how we handle unresponsive (hotplug removed) hosts,
and shifts debugging more towards tracing.
Found an issue in patch 3/24 this series while doing some xhci bind/
From: Mauro Carvalho Chehab
> Sent: 05 April 2017 14:53
> Several host controllers, commonly found on ARM, like dwc2,
> require buffers that are CPU-word aligned for they to work.
>
> Failing to do that will cause buffer overflows at the caller
> drivers, with could cause data corruption.
>
> Suc
* Peter Ujfalusi [170406 10:07]:
> Tony,
>
> On 04/05/2017 06:29 PM, Tony Lindgren wrote:
> > * Tony Lindgren [170405 06:53]:
> > > * Peter Ujfalusi [170405 00:15]:
> > > > To be precise this is what I have tried:
> > > > - boot w/o cable connected
> > > > - boot w/ board connected to PC (devic
* Bin Liu [170406 12:09]:
> On Wed, Apr 05, 2017 at 08:29:55AM -0700, Tony Lindgren wrote:
> > If the the port is configured as OTG, we should not need to
> > try to force any states during init. The change below will stop
>
> True, but the code has been there for a very long time, any idea what
On 04/06/2017 12:03 AM, Yuyang Du wrote:
A new field ncontrollers is added to the vhci_driver structure.
And this field is stored by scanning the vhci_hcd* dirs in the
platform udev.
Suggested-by: Krzysztof Opasiak
Signed-off-by: Yuyang Du
---
tools/usb/usbip/libsrc/vhci_driver.c | 36 +
On 04/06/2017 12:03 AM, Yuyang Du wrote:
If we get nonpositive number of ports, there is no sense to
continue, then fail gracefully.
In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension:
modifications to vhci driver") introduced configurable numbers of
controllers and ports, but w
Hi,
On 4/7/2017 12:18 PM, Felipe Balbi wrote:
>
> Hi,
>
> John Stultz writes:
> mailto:minas.harutyun...@synopsys.com>>
> wrote:
>> On 4/4/2017 11:03 PM, John Stultz wrote:
>>>
>>> I did notice when cating the regdump file, I saw:
>>> dwc2 f72c.usb: Mode Mismatch Inter
Instead of constantly recomputing how dwc and epnum relate to dep,
just pass dep as argument.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/ep0.c | 52 +-
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/usb/dwc3/ep0.c b/d
Just like we did for all other endpoint types, let's rely on a chained
TRB pointing to ep0_bounce_addr in order to align transfer size. This
will make the code simpler.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.h | 6 +
drivers/usb/dwc3/ep0.c| 65 +-
If we pass TRB's own address on bpl/bph fields, we can get our SETUP
packet as immediate data on the TRB itself, without having to allocate
extra memory for it.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.h | 4
drivers/usb/dwc3/ep0.c| 11 ++-
drivers/usb/dwc3/gadge
hi,
Bryan O'Donoghue writes:
>>> - DWC_USB3_NUM indicates the number of Device mode single directional
>>> endpoints, including OUT and IN endpoint 0.
>>>
>>> - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN
>>> endpoints active at any time, including control endpoint 0.
Hi,
John Stultz writes:
mailto:minas.harutyun...@synopsys.com>>
wrote:
> On 4/4/2017 11:03 PM, John Stultz wrote:
>>
>> I did notice when cating the regdump file, I saw:
>> dwc2 f72c.usb: Mode Mismatch Interrupt: currently in Host mode
>> twice. (You'll see it 4
Instead of using a private copy of struct net_device_stats in struct
kaweth_device, use stats from struct net_device. Also remove the now
unnecessary .ndo_get_stats function.
Cc: linux-usb@vger.kernel.org
Signed-off-by: Tobias Klauser
---
drivers/net/usb/kaweth.c | 32 ++-
Instead of using a private copy of struct net_device_stats in struct
pegasus, use stats from struct net_device. Also remove the now
unnecessary .ndo_get_stats function.
Cc: Petko Manolov
Cc: linux-usb@vger.kernel.org
Signed-off-by: Tobias Klauser
---
drivers/net/usb/pegasus.c | 36 +
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
Acked-by: Doug Ledford
Tested-by: Doug Ledford
---
drivers/infiniband/hw/mt
The current PCI pool API are simple macro functions direct expanded to
the appropriate dma pool functions. The prototypes are almost the same
and semantically, they are very similar. I propose to use the DMA pool
API directly and get rid of the old API.
This set of patches, replaces the old API by
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Acked-by: Jeff Kirsher
Tested-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/e100.c | 12 ++
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Reviewed-by: Peter Senna Tschudin
Acked-by: Doug Ledford
Tested-by: Doug Ledford
---
drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 11 +++
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
---
drivers/block/DAC960.c | 38 ++
drive
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
Reviewed-by: Leon Romanovsky
Acked-by: Doug Ledford
Tested-by: Doug Ledford
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API. It also updates
the name of some variables and the content of comments, accordingly.
Signed-off-by: Romain Perier
Reviewed-by: Peter Senna Tschudin
---
drivers/scsi/csios
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API. It also updates
some comments, accordingly.
Signed-off-by: Romain Perier
Reviewed-by: Peter Senna Tschudin
---
drivers/scsi/lpfc/lpfc.h | 14 +++---
drivers/scsi/l
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
---
drivers/scsi/be2iscsi/be_iscsi.c | 6 +++---
drivers/scsi/be2iscsi/be_mai
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Reviewed-by: Peter Senna Tschudin
---
drivers/scsi/mvsas/mv_init.c | 6 +++---
drivers/scsi/mvsas/mv_sas.c | 6 +++---
2 files changed, 6 in
Now that all the drivers use dma pool API, we can remove the macro
functions for PCI pool.
Signed-off-by: Romain Perier
Reviewed-by: Peter Senna Tschudin
---
include/linux/pci.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 2dbd6d2..
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Reviewed-by: Peter Senna Tschudin
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 73 +
1 file changed, 34 inse
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Reviewed-by: Peter Senna Tschudin
Acked-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_mbox.c | 33 +++
drivers/scsi/
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
---
drivers/scsi/pmcraid.c | 10 +-
drivers/scsi/pmcraid.h | 2 +-
2
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
---
drivers/dma/pch_dma.c | 12 ++--
1 file changed, 6 insertions(+),
The PCI pool API is deprecated. This commit replaces the PCI pool old
API by the appropriate function with the DMA pool API.
Signed-off-by: Romain Perier
Reviewed-by: Peter Senna Tschudin
---
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 13 +++--
1 file changed, 7 insertions(+), 6 del
69 matches
Mail list logo
