Re: [PATCH v10 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

2017-03-03 Thread ayaka
What is wrong with this patch? I have not seen it is merged in next-20170303. On 12/11/2016 11:36 PM, Randy Li wrote: On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full s

[PATCH 1/3] USB: misc: ldusb: fixed decimal permission coding issue

2017-03-03 Thread Milian Reichardt
Fixed ERROR: Use 4 digit octal (0777) not decimal permissions to fulfill the current coding-style. Signed-of-by: Milian Reichardt --- drivers/usb/misc/ldusb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index 3bc

[PATCH 0/3] fixed errors from checkpatch.pl

2017-03-03 Thread Milian Reichardt
Changed multiple errors output from checkpatch.pl to enhance readability Milian Reichardt (3): USB: misc: ldusb: fixed decimal permission coding issue USB: misc: ldusb: changed '*' location to fit coding Style USB: misc: ldusb: Added Space after ',' to fit the coding style drivers/usb/misc

[PATCH 2/3] USB: misc: ldusb: changed '*' location to fit coding Style

2017-03-03 Thread Milian Reichardt
Changed the location of '*' to fit the current coding style and easy readability. Signed-of-by: Milian Reichardt --- drivers/usb/misc/ldusb.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index e965e

[PATCH 3/3] USB: misc: ldusb: Added Space after ',' to fit the coding style

2017-03-03 Thread Milian Reichardt
Added a Space after ',' to get rid of an error message in checkpatch.pl and improve readability Signed-of-by: Milian Reichardt --- drivers/usb/misc/ldusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index 2c68e5153539..

Re: Panic in quirk_usb_early_handoff

2017-03-03 Thread Mason
On 03/03/2017 20:02, Robin Murphy wrote: > On 03/03/17 17:15, Mason wrote: > >> [1.261813] Unable to handle kernel paging request at virtual address >> d08611e4 >> [1.269167] pgd = c0004000 >> [1.271979] [d08611e4] *pgd=8f804811, *pte=, *ppte= >> [1.278394] Intern

Re: Panic in quirk_usb_early_handoff

2017-03-03 Thread Mason
On 03/03/2017 20:02, Robin Murphy wrote: > On 03/03/17 17:15, Mason wrote: > >> [1.264893] Unable to handle kernel paging request at virtual address >> d08664f4 > > Note that that's a reasonable approximation of a vmalloc address... > > ...and that specifically it's r0 + r3... > > ...and

Re: Cannot dump USB report descriptors, not even after unbinding the device

2017-03-03 Thread Krzysztof Opasiak
Hi, >Hi Krzysztof, and thank you for the help! > >> Oh now I see. I missed this when I was reading this email for the first >> time. >> >> root@spark ~ # echo -n 2-10.3 > /sys/bus/usb/drivers/usb/unbind >> >> >> You are trying to unbind here wrong driver I think. Try to unbound driver >> for inter

Re: Cannot dump USB report descriptors, not even after unbinding the device

2017-03-03 Thread Alan Stern
On Fri, 3 Mar 2017, László Monda wrote: > Hi Krzysztof, and thank you for the help! > > > Oh now I see. I missed this when I was reading this email for the first > > time. > > > >> root@spark ~ # echo -n 2-10.3 > /sys/bus/usb/drivers/usb/unbind > > > > > > You are trying to unbind here wrong driv

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Guenter Roeck
On 03/03/2017 04:59 AM, Heikki Krogerus wrote: Hi, On Fri, Mar 03, 2017 at 08:29:18AM +0100, Mats Karrman wrote: On 2017-03-03 04:13, Guenter Roeck wrote: On 03/02/2017 07:22 AM, Mats Karrman wrote: Looking forward, one thing I have run into is how to connect the typec driver with a dr

Re: Cannot dump USB report descriptors, not even after unbinding the device

2017-03-03 Thread László Monda
Hi Krzysztof, and thank you for the help! > Oh now I see. I missed this when I was reading this email for the first > time. > >> root@spark ~ # echo -n 2-10.3 > /sys/bus/usb/drivers/usb/unbind > > > You are trying to unbind here wrong driver I think. Try to unbound driver > for interface instead o

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Mats Karrman
On 2017-03-03 13:59, Heikki Krogerus wrote: On Fri, Mar 03, 2017 at 08:29:18AM +0100, Mats Karrman wrote: How would something like that sound to you guys? Complicated... Need to marinate on that for a while ;) My system is a bit different. It's an i.MX6 SoC with the typec phy and DP

Re: Panic in quirk_usb_early_handoff

2017-03-03 Thread Robin Murphy
On 03/03/17 17:15, Mason wrote: [...] >>> [1.264893] Unable to handle kernel paging request at virtual address >>> d08664f4 Note that that's a reasonable approximation of a vmalloc address... >>> [1.272248] pgd = c0004000 >>> [1.275060] [d08664f4] *pgd=8f804811, *pte=, *ppte=

Re: [PATCH 00/21] USB: serial: refactor endpoint sanity checks

2017-03-03 Thread Oliver Neukum
Am Donnerstag, den 02.03.2017, 12:51 +0100 schrieb Johan Hovold: > This series refactors the endpoint sanity checks by allowing > subdrivers > to specify a minimum number of endpoints required per type and > letting > core verify this during probe. Hi, this is very good, but is it at the right pl

Re: [PATCH 03/21] USB: serial: refactor and clean up endpoint handling

2017-03-03 Thread kbuild test robot
Hi Johan, [auto build test WARNING on usb/usb-testing] [also build test WARNING on v4.10 next-20170303] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Johan-Hovold/USB-serial-refactor-endpoint

Re: Cannot dump USB report descriptors, not even after unbinding the device

2017-03-03 Thread Krzysztof Opasiak
On 03/03/2017 04:59 PM, László Monda wrote: Dear List, About 2 years ago, I used to be able to dump the USB report descriptors of my input devices after unlinking them, but for some reason, not anymore. root@spark ~ # dmesg | tail [239486.804224] logitech-hidpp-device 0003:046D:404D.02B3: inp

Re: Cannot dump USB report descriptors, not even after unbinding the device

2017-03-03 Thread Krzysztof Opasiak
On 03/03/2017 04:59 PM, László Monda wrote: Dear List, About 2 years ago, I used to be able to dump the USB report descriptors of my input devices after unlinking them, but for some reason, not anymore. root@spark ~ # dmesg | tail [239486.804224] logitech-hidpp-device 0003:046D:404D.02B3: inp

Re: Panic in quirk_usb_early_handoff

2017-03-03 Thread Mason
On 03/03/2017 18:10, Mason wrote: > On 03/03/2017 17:18, Mason wrote: >> Hello, >> >> I'm seeing this panic randomly at boot-time, so I want to throw >> it out there in case someone recognizes the issue off the top of >> their head. >> >> I'm on Linux 4.9, using a USB3 PCIe card. I'm actively worki

Re: Panic in quirk_usb_early_handoff

2017-03-03 Thread Mason
On 03/03/2017 17:18, Mason wrote: > Hello, > > I'm seeing this panic randomly at boot-time, so I want to throw > it out there in case someone recognizes the issue off the top of > their head. > > I'm on Linux 4.9, using a USB3 PCIe card. I'm actively working on > the PCIe support, so I may be res

Re: FW: FW: RE: Re: FW: RE: Re: Subject: [PATCH v3] USB:Core: BugFix: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously

2017-03-03 Thread Alan Stern
On Fri, 3 Mar 2017, Ajay Kaher wrote: > > usb_class->kref is not accessible outside the file.c > > as usb_class is _static_ inside the file.c and > > pointer of usb_class->kref is not passed anywhere. > >  > > Hence as you wanted, there are no references of usb_class->kref > > other than taken by 

Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

2017-03-03 Thread kbuild test robot
Hi Jaejoong, [auto build test ERROR on hid/for-next] [also build test ERROR on v4.10 next-20170303] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jaejoong-Kim/HID-hiddev-move-hiddev-s-minor

Cannot dump USB report descriptors, not even after unbinding the device

2017-03-03 Thread László Monda
Dear List, About 2 years ago, I used to be able to dump the USB report descriptors of my input devices after unlinking them, but for some reason, not anymore. root@spark ~ # dmesg | tail [239486.804224] logitech-hidpp-device 0003:046D:404D.02B3: input,hidraw5: USB HID v1.11 Keyboard [Logitech K40

Panic in quirk_usb_early_handoff

2017-03-03 Thread Mason
Hello, I'm seeing this panic randomly at boot-time, so I want to throw it out there in case someone recognizes the issue off the top of their head. I'm on Linux 4.9, using a USB3 PCIe card. I'm actively working on the PCIe support, so I may be responsible for the crash by virtue of something I di

Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

2017-03-03 Thread kbuild test robot
Hi Jaejoong, [auto build test ERROR on hid/for-next] [also build test ERROR on v4.10 next-20170303] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jaejoong-Kim/HID-hiddev-move-hiddev-s-minor

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-03-03 Thread Stefan Wahren
Hi Baruch, Am 01.03.2017 um 11:54 schrieb Baruch Siach: > Hi Stefan, > > On Tue, Feb 28, 2017 at 07:32:09PM +0100, Stefan Wahren wrote: >>> Baruch Siach hat am 28. Februar 2017 um 19:07 >>> geschrieben: >>> On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wahren wrote: Am 28.02.2017 um 13:

FW: FW: RE: Re: FW: RE: Re: Subject: [PATCH v3] USB:Core: BugFix: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously

2017-03-03 Thread Ajay Kaher
> On Thr, 2 Mar 2017, Ajay Kaher wrote: >> On Wed, 1 Mar 2017, Alan Stern wrote: >>> On Wed, 1 Mar 2017, Ajay Kaher wrote:  On Mon, 22 Feb 2017, Ajay Kaher wrote:   >  >> Alan, as per my understanding I have shifted the lock from >> release_usb_class() to destroy_usb_class() in

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Guenter Roeck
On 03/02/2017 11:29 PM, Mats Karrman wrote: On 2017-03-03 04:13, Guenter Roeck wrote: On 03/02/2017 07:22 AM, Mats Karrman wrote: Looking forward, one thing I have run into is how to connect the typec driver with a driver for an alternate mode. E.g. the DisplayPort Alternate Mode specifi

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Heikki Krogerus
Hi Peter, On Fri, Mar 03, 2017 at 11:35:29AM +0800, Peter Chen wrote: > On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: > > +/* --- */ > > +/* Driver callbacks to report role updates */ > > + > > +/** > > + * typec_set_data_role - Report data ro

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Guenter Roeck
On 03/02/2017 08:52 PM, Peter Chen wrote: On Thu, Mar 02, 2017 at 08:29:07PM -0800, Guenter Roeck wrote: On 03/02/2017 07:35 PM, Peter Chen wrote: On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: +/* --- */ +/* Driver callbacks to report role

[PATCH] USB: misc: ldusb: Fixed coding style issues

2017-03-03 Thread Milian Reichardt
Fixed multiple coding style issues. Signed-off-by: Milian Reichardt --- drivers/usb/misc/ldusb.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index 3bc5356832db..77b76b468307 100644 --- a/

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Heikki Krogerus
Hi, On Fri, Mar 03, 2017 at 08:29:18AM +0100, Mats Karrman wrote: > On 2017-03-03 04:13, Guenter Roeck wrote: > > > On 03/02/2017 07:22 AM, Mats Karrman wrote: > > > > > > Looking forward, one thing I have run into is how to connect the typec > > > driver with a > > > driver for an alternat

Re: [PATCH v4 08/19] scsi: be2iscsi: Replace PCI pool old API

2017-03-03 Thread Sergei Shtylyov
On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. Appropriate perhaps? Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna

[PATCH] uvc-gadget: Fix Set Interface (alternate setting) response behaviour

2017-03-03 Thread Roger Quadros
<<< No Message Collected >>> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 09/19] scsi: csiostor: Replace PCI pool old API

2017-03-03 Thread Sergei Shtylyov
Hello! On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. It also updates Appropriate perhaps? the name of some variables and the content of comments, acco

Re: [PATCH] USB: misc: ldusb: Fixed coding style issues

2017-03-03 Thread Milian Reichardt
Am Freitag, den 03.03.2017, 07:24 +0100 schrieb Greg KH: > Please be specific as to exactly what issues you are fixing up.  And > don't do multiple things in the same patch, each different thing > needs > to be broken up into an individual patch. Thanks for the feedback. I'll brake things up in di

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Enric Balletbo Serra
2017-03-03 8:29 GMT+01:00 Mats Karrman : > On 2017-03-03 04:13, Guenter Roeck wrote: > >> On 03/02/2017 07:22 AM, Mats Karrman wrote: >>> >>> >>> Looking forward, one thing I have run into is how to connect the typec >>> driver with a >>> driver for an alternate mode. E.g. the DisplayPort Alte

[PATCH v2 0/2] HID: hiddev: move hiddev's minor number and refactoring

2017-03-03 Thread Jaejoong Kim
Hi all, I found hiddev's minor number is always zero in struct hid_device. So, store the minor number asked from usb core in struct hid_device. This is my first approach. But after reviewed from Bendjamin, he suggested that it would make sense to store a minor number in struct hid

Re: [PATCH] usb: dwc2: Make sure we disconnect the gadget state

2017-03-03 Thread Sergei Shtylyov
Hello! On 3/3/2017 2:36 AM, John Stultz wrote: I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would Plugged. Perhaps could be fixed while applying... prope

Re: [PATCH v7 0/5] usb: early: add support for early printk through USB3 debug port

2017-03-03 Thread Lu Baolu
Hi Ingo, On 03/02/2017 02:40 PM, Ingo Molnar wrote: > * Lu Baolu wrote: > >> Hi Ingo, >> >> How about this version? Any further comments? > So I have re-read the review feedback I gave on Jan 19 and found at least one > thing I pointed out that you didn't address in the latest patches ... Do yo

[PATCH v2 1/2] HID: cp2112: use proper hidraw name with minor number

2017-03-03 Thread Jaejoong Kim
The cp2112 driver is working on hidraw not hiddev. So we need to use proper hidraw name with hidraw's minor number. Reviewed-by: Benjamin Tissoires Signed-off-by: Jaejoong Kim --- Changes in v2: - tie in a series --- drivers/hid/hid-cp2112.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[PATCH v2 2/2] HID: hiddev: reallocate hiddev's minor number

2017-03-03 Thread Jaejoong Kim
We need to store the minor number each drivers. In case of hidraw, the minor number is stored stores in struct hidraw. But hiddev's minor is located in struct hid_device. The hid-core driver announces a kernel message which driver is loaded when HID device connected, but hiddev's minor number is a