Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread Baolin Wang
On 22 December 2016 at 07:47, NeilBrown wrote: > On Wed, Dec 21 2016, Baolin Wang wrote: > >> On 21 December 2016 at 11:48, NeilBrown wrote: >>> On Wed, Dec 21 2016, Baolin Wang wrote: >>> Hi, On 21 December 2016 at 06:07, NeilBrown wrote: > On Tue, Dec 20 2016, Baolin Wang wr

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

2016-12-21 Thread Vivek Gautam
On Thu, Nov 17, 2016 at 5:13 PM, Sriram Dash wrote: > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. > > The idea here is that you pass in the parent of_node along > with the child device pointer, so it would behave exactly > l

Re: USB 3.1 controller does weird magic: appears after Windows 10,

2016-12-21 Thread Nazar Mokrynskyi
22.12.16 07:37, Oliver Neukum пише: > On Thu, 2016-12-22 at 04:14 +0200, Nazar Mokrynskyi wrote: >> Hi, >> >> I have motherboard GA-Z170X-UD5 TH with 2 USB Type-C (USB 3.1 Gen >> 2/Thunderbolt 3) ports, BIOS version F20b (latest as of today). >> >> Both ports are "sleeping" on cold start - I can't

USB 3.1 controller does weird magic: appears after Windows 10, disappears otherwise

2016-12-21 Thread Nazar Mokrynskyi
Hi, I have motherboard GA-Z170X-UD5 TH with 2 USB Type-C (USB 3.1 Gen 2/Thunderbolt 3) ports, BIOS version F20b (latest as of today). Both ports are "sleeping" on cold start - I can't boot from USB device plugged into any and both of these 2 USB Type-C ports, Linux kernel 4.9 doesn't see anyth

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread George Cherian
Hi Oliver, I will try it out and update you!! Regards, -George On Wednesday 21 December 2016 08:09 PM, Oliver Neukum wrote: On Wed, 2016-12-21 at 18:17 +0530, George Cherian wrote: [ 843.149653] scsi host5: uas_post_reset: alloc streams error -19 after reset That would mean the endpoints

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Lu Baolu
Hi, On 12/21/2016 11:18 PM, OGAWA Hirofumi wrote: > Mathias Nyman writes: > >>> We set CMD_RING_STATE_ABORTED state under locking. I'm not checking what >>> is for taking lock for register though, I guess it should be enough just >>> lock around of read=>write of ->cmd_ring if need lock. >> After

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Lu Baolu
Hi, On 12/21/2016 08:48 PM, Mathias Nyman wrote: > On 21.12.2016 08:17, Lu Baolu wrote: >> Hi Mathias, >> >> I have some comments for the implementation of xhci_abort_cmd_ring() below. >> >> On 12/20/2016 11:13 PM, Mathias Nyman wrote: >>> On 20.12.2016 09:30, Baolin Wang wrote: >>> ... >>> >>> Al

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Lu Baolu
Hi, On 12/21/2016 08:57 PM, Mathias Nyman wrote: > On 21.12.2016 08:57, Lu Baolu wrote: >> Hi Mathias, >> >> I have some comments for the implementation of >> xhci_handle_command_timeout() as well. >> >> On 12/20/2016 11:13 PM, Mathias Nyman wrote: >>> On 20.12.2016 09:30, Baolin Wang wrote: >>> .

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread NeilBrown
On Wed, Dec 21 2016, Baolin Wang wrote: > On 21 December 2016 at 11:48, NeilBrown wrote: >> On Wed, Dec 21 2016, Baolin Wang wrote: >> >>> Hi, >>> >>> On 21 December 2016 at 06:07, NeilBrown wrote: On Tue, Dec 20 2016, Baolin Wang wrote: > Hi Neil, > > On 3 November 2016 at

Using multiple USB3380 PCIe cards on a single Linux system

2016-12-21 Thread Karthik Ramana Sankar
Hi Linux-USB members, I currently have a Intel Xeon based Dell poweredge T320 server setup running Ubuntu server 14.04. I would like to add multiple USB3 devices (peripheral mode) to the system using multiple PLX based USB3380 PCIe cards. I would like to associate USB mass storage gadget with a

[PATCH v3 1/1] Increase USB transfer limit

2016-12-21 Thread Mateusz Berezecki
Promote a variable keeping track of USB transfer memory usage to a wider data type and allow for higher bandwidth transfers from a large number of USB devices connected to a single host. Signed-off-by: Mateusz Berezecki --- drivers/usb/core/devio.c | 43 --

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-21 Thread Greg KH
On Wed, Dec 21, 2016 at 08:44:30AM -0800, Mateusz Berezecki wrote: > Hi Greg, > > On 15 Dec 2016, at 11:07, Greg KH wrote: > > [..] > > > > > > > Sorry, I wasn't quite sure how handle this. > > > > Documentation/SubmittingPatches should describe how to do this. Please > > do so on your next s

Re: [PATCH v2 1/1] Increase USB transfer limit

2016-12-21 Thread Mateusz Berezecki
Hi Greg, On 15 Dec 2016, at 11:07, Greg KH wrote: [..] Sorry, I wasn't quite sure how handle this. Documentation/SubmittingPatches should describe how to do this. Please do so on your next submission so I know what patch to apply. Ok, thanks for clarification. I’ll follow this next ti

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Sudip Mukherjee
vudc_dev.c > >> > @@ -388,10 +388,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct > >> > usb_request *_req) > >> > unsigned long flags; > >> > int ret = 0; > >> > > >> > - ep = to_vep(_ep); > >> > i

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread OGAWA Hirofumi
Mathias Nyman writes: >> We set CMD_RING_STATE_ABORTED state under locking. I'm not checking what >> is for taking lock for register though, I guess it should be enough just >> lock around of read=>write of ->cmd_ring if need lock. > > After your patch it should be enough to have the lock only wh

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Mathias Nyman
On 21.12.2016 16:10, OGAWA Hirofumi wrote: Mathias Nyman writes: Below is the latest code. I put my comments in line. 322 static int xhci_abort_cmd_ring(struct xhci_hcd *xhci) 323 { 324 u64 temp_64; 325 int ret; 326 327 xhci_dbg(xhci, "Abort command r

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Krzysztof Opasiak
,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct >>>> usb_request *_req) >>>> unsigned long flags; >>>> int ret = 0; >>>> >>>> - ep = to_vep(_ep); >>>> if (!_ep) >>>> return -EINV

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 18:17 +0530, George Cherian wrote: > [ 843.149653] scsi host5: uas_post_reset: alloc streams error -19 > after > reset That would mean the endpoints are gone. Which is odd. > [ 843.157268] sd 5:0:0:0: [sdb] Synchronizing SCSI cache Could you try the attached patch and do

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread George Cherian
On 12/21/2016 05:12 PM, Oliver Neukum wrote: On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. Thanks. Do you want to submit it

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Shuah Khan
long flags; >> > int ret = 0; >> > >> > - ep = to_vep(_ep); >> > if (!_ep) >> > return -EINVAL; >> >> Hmm. Linus's latest checks _ep and _req. Are you sure you are working >> with the latest tree? > > I ch

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread OGAWA Hirofumi
Mathias Nyman writes: >> Below is the latest code. I put my comments in line. >> >> 322 static int xhci_abort_cmd_ring(struct xhci_hcd *xhci) >> 323 { >> 324 u64 temp_64; >> 325 int ret; >> 326 >> 327 xhci_dbg(xhci, "Abort command ring\n"); >> 328 >> 329

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Sudip Mukherjee
-EINVAL; > > Hmm. Linus's latest checks _ep and _req. Are you sure you are working > with the latest tree? I checked with next-20161221 and its still there. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Mathias Nyman
On 21.12.2016 04:22, Baolin Wang wrote: Hi Mathias, On 20 December 2016 at 23:13, Mathias Nyman wrote: On 20.12.2016 09:30, Baolin Wang wrote: ... Alright, I gathered all current work related to xhci races and timeouts and put them into a branch: git://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Mathias Nyman
On 21.12.2016 08:57, Lu Baolu wrote: Hi Mathias, I have some comments for the implementation of xhci_handle_command_timeout() as well. On 12/20/2016 11:13 PM, Mathias Nyman wrote: On 20.12.2016 09:30, Baolin Wang wrote: ... Alright, I gathered all current work related to xhci races and timeou

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread George Cherian
On 12/21/2016 05:50 PM, Hans de Goede wrote: Hi, On 21-12-16 13:07, George Cherian wrote: On 12/21/2016 05:12 PM, Oliver Neukum wrote: On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the foll

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Mathias Nyman
On 21.12.2016 08:17, Lu Baolu wrote: Hi Mathias, I have some comments for the implementation of xhci_abort_cmd_ring() below. On 12/20/2016 11:13 PM, Mathias Nyman wrote: On 20.12.2016 09:30, Baolin Wang wrote: ... Alright, I gathered all current work related to xhci races and timeouts and put

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Hans de Goede
Hi, On 21-12-16 13:07, George Cherian wrote: On 12/21/2016 05:12 PM, Oliver Neukum wrote: On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the followi

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 17:37 +0530, George Cherian wrote: > > On 12/21/2016 05:12 PM, Oliver Neukum wrote: > > On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > >> Hi Oliver, > >> > >> I was working with this JMicron device and using the uas driver. > >> I am seeing the following 2 issues.

JMS56x not working reliably with uas driver

2016-12-21 Thread George Cherian
Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. xhci_hcd :00:11.0: ERROR Transfer event for disabled endpoint or incorrect stream ring This was eliminated using the following scisso

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 12:54 +0100, Hans de Goede wrote: > Hi, > > On 21-12-16 12:42, Oliver Neukum wrote: > > On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > >> Hi Oliver, > >> > >> I was working with this JMicron device and using the uas driver. > >> I am seeing the following 2 issues.

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Hans de Goede
Hi, On 21-12-16 12:42, Oliver Neukum wrote: On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. Thanks. Do you want to submit it t

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Hans de Goede
Hi, On 21-12-16 12:39, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. xhci_hcd :00:11.0: ERROR Transfer event for disabled endpoint or incorrect stream ring

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > Hi Oliver, > > I was working with this JMicron device and using the uas driver. > I am seeing the following 2 issues. > > 1) On connect I see the following messages. Thanks. Do you want to submit it to Greg? The patch is fine. > 2) On d

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread Baolin Wang
On 21 December 2016 at 11:48, NeilBrown wrote: > On Wed, Dec 21 2016, Baolin Wang wrote: > >> Hi, >> >> On 21 December 2016 at 06:07, NeilBrown wrote: >>> On Tue, Dec 20 2016, Baolin Wang wrote: >>> Hi Neil, On 3 November 2016 at 09:25, NeilBrown wrote: > On Tue, Nov 01 2016,

[PATCH v2 1/2] usb: gadget: ether: Add \n to each attribute of ethernet functions

2016-12-21 Thread Krzysztof Opasiak
Generally in SysFS and ConfigFS files are new line terminated. Also most of USB functions adds a trailing newline to each attribute. Let's follow this convention also in ethernet functions. Signed-off-by: Krzysztof Opasiak --- drivers/usb/gadget/function/u_ether.c | 24 +

[PATCH v2 2/2] usb: gadget: printer: Remove pnp_string static buffer

2016-12-21 Thread Krzysztof Opasiak
pnp string is usually much shorter than 1k so let's stop wasting 1k of memory for its buffer and make it dynamically alocated. This also removes 1k len limitation for pnp_string and adds a new line after string content if required. Signed-off-by: Krzysztof Opasiak --- Changes since v1: - assignt