RE: [PATCH 2/3] usb: dwc3: host: Do not use dma_set_coherent_mask

2016-10-26 Thread Sriram Dash
>From: Arnd Bergmann [mailto:a...@arndb.de] >On Tuesday, October 25, 2016 4:26:27 PM CEST Sriram Dash wrote: >> Do not require dma_set_coherent_mask for hcd >> >> Signed-off-by: Arnd Bergmann > >Aside from the comments I had for patch 3, you are doing two different things >here: > >> diff --git a/

Re: [PATCH] Staging: wilc1000: Remove unused structure

2016-10-26 Thread Greg KH
On Wed, Oct 26, 2016 at 11:00:07PM +0300, Muraru Mihaela wrote: > On Tue, Oct 25, 2016 at 08:37:50AM +0200, Greg KH wrote: > > On Mon, Oct 24, 2016 at 10:56:45PM +0300, Mihaela Muraru wrote: > > > This is a parch to the emxx_udc.c file that remove the > > > 'usb_device_descriptor' structure because

Re: [PATCH v2 2/4] usb: musb: core: added helper function for parsing DT

2016-10-26 Thread David Lechner
On 10/26/2016 10:03 AM, Alexandre Bailon wrote: From: Petr Kulhavy This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Alexandre Bailon --- drivers/usb/musb/musb_core.c | 19 +++ driver

Re: [PATCH v2 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-10-26 Thread David Lechner
On 10/26/2016 10:03 AM, Alexandre Bailon wrote: From: Petr Kulhavy This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 47 +++ 1 file chang

Re: [PATCH] USB: OHCI: make ohci-da8xx a separate driver

2016-10-26 Thread David Lechner
On 10/26/2016 04:08 PM, ahas...@baylibre.com wrote: From: Manjunath Goudar Separate the Davinci OHCI host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM Signed-off-by: Manjunath Goudar

Re: [PATCH] USB: OHCI: make ohci-da8xx a separate driver

2016-10-26 Thread David Lechner
On 10/26/2016 04:08 PM, ahas...@baylibre.com wrote: +module_exit(ohci_da8xx_exit); +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:ohci"); The "ohci" in MODULE_ALIAS() should also be replaced with hcd_name. -- To unsubscribe from this list: send the line "un

Re: [PATCH 13/15] Documentation: devicetree: dwc2: Add host DMA binding

2016-10-26 Thread Rob Herring
On Wed, Oct 19, 2016 at 06:22:52PM -0700, John Youn wrote: > Add the host-dma property to devicetree. This controls whether to use > DMA in host mode. > > Signed-off-by: John Youn > --- > Documentation/devicetree/bindings/usb/dwc2.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Doc

[PATCH] USB: OHCI: make ohci-da8xx a separate driver

2016-10-26 Thread ahaslam
From: Manjunath Goudar Separate the Davinci OHCI host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM Signed-off-by: Manjunath Goudar [Axel: adapted and rebased, fixed minor comments] Sign

Re: [PATCH] phy: Add reset callback for not generic phy

2016-10-26 Thread Kishon Vijay Abraham I
On Wednesday 26 October 2016 02:17 AM, John Youn wrote: > On 10/25/2016 7:15 AM, Randy Li wrote: >> I forget to add a dummy function in case the CONFIG_GENERIC_PHY >> is disabled. >> >> Signed-off-by: Randy Li > > Fixes: cac18ecb6f44 ("phy: Add reset callback") > Tested-by: John Youn > > Hi K

Re: [PATCH] Staging: wilc1000: Remove unused structure

2016-10-26 Thread Muraru Mihaela
On Tue, Oct 25, 2016 at 08:37:50AM +0200, Greg KH wrote: > On Mon, Oct 24, 2016 at 10:56:45PM +0300, Mihaela Muraru wrote: > > This is a parch to the emxx_udc.c file that remove the > > 'usb_device_descriptor' structure because it is not used in the current > > file or in other one. > > > > Signed

Re: [PATCH 2/4] USB: ch341: reinitialize chip on reconfiguration

2016-10-26 Thread Aidan Thornton
On Mon, Oct 24, 2016 at 4:24 PM, Johan Hovold wrote: > On Sat, Oct 22, 2016 at 10:14:21PM +0100, Aidan Thornton wrote: >> Sent, but please pay close attention to the new note in patch 2 about >> higher baud rates. It turns out the timings for baud rates above 500kbaud >> are out of spec. This isn'

[PATCH v4] usb: musb: remove duplicated actions

2016-10-26 Thread Kirill Esipov
Removing unnecessary duplicated actions that we've got while merging: 19915e623458 ("Merge 4.1-rc7 into usb-next") Signed-off-by: Kirill Esipov --- drivers/usb/musb/musb_core.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c ind

Re: [PATCH v2 2/3] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround

2016-10-26 Thread Alexandre Bailon
On 10/26/2016 05:40 PM, David Lechner wrote: > On 10/26/2016 05:58 AM, Alexandre Bailon wrote: >> If we configure the da8xx OTG phy in OTG mode, neither device or host >> mode will work. That is because the PHY is not able to detect and notify >> the driver that value of ID pin changed. >> To work

Re: [PATCH v2 2/3] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround

2016-10-26 Thread David Lechner
On 10/26/2016 05:58 AM, Alexandre Bailon wrote: If we configure the da8xx OTG phy in OTG mode, neither device or host mode will work. That is because the PHY is not able to detect and notify the driver that value of ID pin changed. To work despite this hardware limitation, the da8xx glue implemen

Re: [PATCH v3] usb: musb: remove duplicated actions

2016-10-26 Thread Bin Liu
Hi, On Wed, Oct 26, 2016 at 05:24:27PM +0300, Kirill Esipov wrote: > Removing unnecessary duplicated actions that we've got while merging: > 19915e623458 ("Merge 4.1-rc7 into usb-next") > > Signed-off-by: Kirill Esipov > --- > drivers/usb/musb/musb_core.c | 6 -- > 1 file changed, 6 deletio

[PATCH v2 1/4] dt/bindings: Add binding for the DA8xx MUSB driver

2016-10-26 Thread Alexandre Bailon
From: Petr Kulhavy DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon --- .../devicetree/bindings/usb/da8xx-usb.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644 Documentation

[PATCH v2 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-10-26 Thread Alexandre Bailon
From: Petr Kulhavy This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/drivers/usb/mus

[PATCH v2 4/4] ARM: dts: da850: Add the usb otg device node

2016-10-26 Thread Alexandre Bailon
This adds the device tree node for the usb otg controller present in the da850 family of SoC's. This also enables the otg usb controller for the lcdk board. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850-lcdk.dts | 8 arch/arm/boot/dts/da850.dtsi | 15 +++

[PATCH v2 2/4] usb: musb: core: added helper function for parsing DT

2016-10-26 Thread Alexandre Bailon
From: Petr Kulhavy This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Alexandre Bailon --- drivers/usb/musb/musb_core.c | 19 +++ drivers/usb/musb/musb_core.h | 5 + 2 files changed

[PATCH v2 0/4] Add DT support for DA8xx

2016-10-26 Thread Alexandre Bailon
The purpose of this series is to add DT support to the da8xx USB OTG. This series should apply and build without any issues but it has some dependencies on "Add DT support for ohci-da8xx" series. Without it, the phy init will fail and then the da8xx driver will also fail. Changes in v2: * Remove u

RE: [PATCH v2] usb: xhci: Don't drive port 2.0 reset while resuming

2016-10-26 Thread Alan Stern
On Wed, 26 Oct 2016, Sriram Dash wrote: > >From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] > >I don't think usb core tries to drive reset while port is still resuming > > > > I am skeptical about it and hope somebody may help us on this. You can see for yourself. In drivers/usb/core

Re: musb RPM sleep-while-atomic in 4.9-rc1

2016-10-26 Thread Tony Lindgren
* Johan Hovold [161026 07:21]: > On Tue, Oct 25, 2016 at 08:11:10AM -0700, Tony Lindgren wrote: > > * Johan Hovold [161025 01:33]: > > > On Mon, Oct 24, 2016 at 10:35:38AM -0700, Tony Lindgren wrote: > > > > > > > From: Tony Lindgren > > > > Date: Mon, 24 Oct 2016 09:18:02 -0700 > > > > Subject

[PATCH v3] usb: musb: remove duplicated actions

2016-10-26 Thread Kirill Esipov
Removing unnecessary duplicated actions that we've got while merging: 19915e623458 ("Merge 4.1-rc7 into usb-next") Signed-off-by: Kirill Esipov --- drivers/usb/musb/musb_core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c in

Re: musb RPM sleep-while-atomic in 4.9-rc1

2016-10-26 Thread Johan Hovold
On Tue, Oct 25, 2016 at 08:11:10AM -0700, Tony Lindgren wrote: > * Johan Hovold [161025 01:33]: > > On Mon, Oct 24, 2016 at 10:35:38AM -0700, Tony Lindgren wrote: > > > > > From: Tony Lindgren > > > Date: Mon, 24 Oct 2016 09:18:02 -0700 > > > Subject: [PATCH] usb: musb: Fix sleeping function cal

Re: link state problem with dwc3 in supper-speed device mode

2016-10-26 Thread Bin Liu
On Wed, Oct 26, 2016 at 04:35:29PM +0300, Felipe Balbi wrote: > > Hi, > > Bin Liu writes: > > On Wed, Oct 26, 2016 at 04:13:11PM +0300, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Bin Liu writes: > >> >> >> >> > There is no VBUS detection on this device and board. Is the VBUS > >> >> >> >> >

Re: link state problem with dwc3 in supper-speed device mode

2016-10-26 Thread Felipe Balbi
Hi, Bin Liu writes: > On Wed, Oct 26, 2016 at 04:13:11PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu writes: >> >> >> >> > There is no VBUS detection on this device and board. Is the VBUS >> >> >> >> > detection needed for dwc3 to work in device mode? >> >> >> >> >> >> >> >> In the c

Re: link state problem with dwc3 in supper-speed device mode

2016-10-26 Thread Bin Liu
On Wed, Oct 26, 2016 at 04:13:11PM +0300, Felipe Balbi wrote: > > Hi, > > Bin Liu writes: > >> >> >> > There is no VBUS detection on this device and board. Is the VBUS > >> >> >> > detection needed for dwc3 to work in device mode? > >> >> >> > >> >> >> In the case of DRA7x, you don't *really*

Re: [PATCH v2] usb: musb: remove duplicated actions

2016-10-26 Thread Sergei Shtylyov
On 10/26/2016 03:01 PM, Kirill Esipov wrote: Removing unnecessary duplicated actions that we've got while merging: "Merge 4.1-rc7 into usb-next" 19915e623458 See Documentation/SubmittingPatches, it should be: 19915e623458 ("Merge 4.1-rc7 into usb-next"). Perhaps the MUSB maintainer can fix

Re: link state problem with dwc3 in supper-speed device mode

2016-10-26 Thread Felipe Balbi
Hi, Bin Liu writes: >> >> >> > There is no VBUS detection on this device and board. Is the VBUS >> >> >> > detection needed for dwc3 to work in device mode? >> >> >> >> >> >> In the case of DRA7x, you don't *really* need detection. All you need >> >> >> to >> >> >> do is correctly update UTMI

RE: [PATCH v2] usb: xhci: Don't drive port 2.0 reset while resuming

2016-10-26 Thread Sriram Dash
>From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] >On 25.10.2016 13:45, Sriram Dash wrote: >> For the USB3.0 controller, USB 2.0 reset not driven while port is in >> Resume state. So, do not program the USB 2.0 reset >> (PORTSC[PR]=1) while in Resume state. >> >> Signed-off-by: Rajat Sriv

Re: link state problem with dwc3 in supper-speed device mode

2016-10-26 Thread Bin Liu
On Wed, Oct 26, 2016 at 10:20:11AM +0300, Roger Quadros wrote: > Hi, > > On 25/10/16 23:55, Bin Liu wrote: > > Felipe, > > > > On Tue, Oct 25, 2016 at 08:57:26AM -0500, Bin Liu wrote: > >> On Tue, Oct 25, 2016 at 04:44:13PM +0300, Felipe Balbi wrote: > >> > >> [snip] > >> > Just reviewed thi

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-26 Thread Johan Hovold
On Wed, Oct 26, 2016 at 01:50:14PM +0200, Linus Walleij wrote: > On Wed, Oct 26, 2016 at 11:09 AM, Johan Hovold wrote: > > On Tue, Oct 25, 2016 at 11:34:40AM +0200, Linus Walleij wrote: > > >> I was thinking on either reusing the .names field of the > >> struct gpiochip to name the lines for the

Re: link state problem with dwc3 in supper-speed device mode

2016-10-26 Thread Bin Liu
On Wed, Oct 26, 2016 at 11:35:47AM +0300, Felipe Balbi wrote: > > Hi, > > Bin Liu writes: > >> >> > There is no VBUS detection on this device and board. Is the VBUS > >> >> > detection needed for dwc3 to work in device mode? > >> >> > >> >> In the case of DRA7x, you don't *really* need detecti

[PATCH v2] usb: musb: remove duplicated actions

2016-10-26 Thread Kirill Esipov
Removing unnecessary duplicated actions that we've got while merging: "Merge 4.1-rc7 into usb-next" 19915e623458 Signed-off-by: Kirill Esipov --- drivers/usb/musb/musb_core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c inde

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-26 Thread Linus Walleij
On Wed, Oct 26, 2016 at 11:09 AM, Johan Hovold wrote: > On Tue, Oct 25, 2016 at 11:34:40AM +0200, Linus Walleij wrote: >> I was thinking on either reusing the .names field of the >> struct gpiochip to name the lines for the userspace >> chardev. With the sideeffect of the names getting reflected

Re: [PATCH] usb: musb: remove duplicated actions

2016-10-26 Thread Sergei Shtylyov
Hello. On 10/26/2016 2:12 PM, Kirill Esipov wrote: Remove unnecessary duplicate actions (that we've got here: 19915e623458004547c1c2490b09bb923fe69337) You should also specify the commit's summary line in (""). And it's enough to specify 12 digits of SHA1 ID. Signed-off-by: Kirill Esip

[PATCH] usb: musb: remove duplicated actions

2016-10-26 Thread Kirill Esipov
Remove unnecessary duplicate actions (that we've got here: 19915e623458004547c1c2490b09bb923fe69337) Signed-off-by: Kirill Esipov --- drivers/usb/musb/musb_core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 27dadc0..2

[PATCH v2 0/3] usb: musb: da8xx: Fix few issues

2016-10-26 Thread Alexandre Bailon
Currently, the USB OTG of the da8xx doesn't work. This series intend to fix them. Change in v2: * Fix the error path da8xx_musb_init() Alexandre Bailon (3): usb: musb: da8xx: Call earlier clk_prepare_enable() phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround usb: musb: da8xx: Onl

[PATCH v2 3/3] usb: musb: da8xx: Only execute the OTG workaround when phy in OTG mode

2016-10-26 Thread Alexandre Bailon
When the phy is forced in host mode, only the first hot plug and hot remove works. That is actually because the driver execute the OTG workaround, whereas it is not applicable in host or device mode. Indeed, to work correctly, the VBUS sense and session end comparator must be enabled, what is only

[PATCH v2 1/3] usb: musb: da8xx: Call earlier clk_prepare_enable()

2016-10-26 Thread Alexandre Bailon
The first attempt to read a register may fail because the clock may not be enabled, and then the probe of musb driver will fail. Call clk_prepare_enable() before the first register read. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 17 - 1 file changed, 8 insert

[PATCH v2 2/3] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround

2016-10-26 Thread Alexandre Bailon
If we configure the da8xx OTG phy in OTG mode, neither device or host mode will work. That is because the PHY is not able to detect and notify the driver that value of ID pin changed. To work despite this hardware limitation, the da8xx glue implement a workaround. But to work, the workaround requir

Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation

2016-10-26 Thread Mark Rutland
On Tue, Oct 25, 2016 at 12:42:46PM -0700, John Youn wrote: > Add interrupt moderation interval binding for dwc3. > > Signed-off-by: John Youn > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc

Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation

2016-10-26 Thread Sergei Shtylyov
Hello. On 10/25/2016 10:42 PM, John Youn wrote: Add interrupt moderation interval binding for dwc3. Signed-off-by: John Youn --- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/

Re: Identifying Synopsys USB3 Controller on Baytrail Device

2016-10-26 Thread Felipe Balbi
Hi, Joseph Kogut writes: > Hi David, > > I know this is a pretty old thread. I tried searching for the LKML > etiquette on something like this and came up empty. If I should start > a new thread, let me know. > > After what I learned from the last thread, I dropped the idea of using > the device

Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable

2016-10-26 Thread Sekhar Nori
On Tuesday 25 October 2016 09:35 PM, David Lechner wrote: > On 10/25/2016 05:12 AM, Sekhar Nori wrote: >> On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: >>> diff --git a/arch/arm/mach-davinci/usb-da8xx.c >>> b/arch/arm/mach-davinci/usb-da8xx.c >>> index 9e41a7f..982e105 100644 >>>

Re: [PATCH 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-10-26 Thread Alexandre Bailon
On 10/25/2016 07:38 PM, Sergei Shtylyov wrote: > Hello. > > On 10/25/2016 05:39 PM, Alexandre Bailon wrote: > >> From: Petr Kulhavy >> >> This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver >> >> Signed-off-by: Petr Kulhavy >> Signed-off-by: Alexandre Bailon >> --- >> drivers

Re: [PATCH 2/3] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround

2016-10-26 Thread Alexandre Bailon
On 10/25/2016 09:16 PM, David Lechner wrote: > On 10/25/2016 08:52 AM, Alexandre Bailon wrote: >> If we configure the da8xx OTG phy in OTG mode, neither device or host >> mode will work. That is because the PHY is not able to detect and notify >> the driver that value of ID pin changed. >> To work

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-26 Thread Johan Hovold
On Tue, Oct 25, 2016 at 11:34:40AM +0200, Linus Walleij wrote: > Good work on this patch, nice that it got merged. > > I was just thinking that as an add-on, you may want to name > the gpio lines so they have meaningful names in userspace > when you use this with the chardev (I have reasons to bel

[PATCH 1/1] usb: gadget: f_uac2: fix error handling at afunc_bind

2016-10-26 Thread Peter Chen
The current error handling flow uses incorrect goto label, fix it Cc: Fixes: d12a8727171c ("usb: gadget: function: Remove redundant usb_free_all_descriptors") Signed-off-by: Peter Chen --- drivers/usb/gadget/function/f_uac2.c | 20 +++- 1 file changed, 11 insertions(+),

Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

2016-10-26 Thread Sekhar Nori
On Tuesday 25 October 2016 09:23 PM, David Lechner wrote: > Hi Sekhar, > > On 10/25/2016 05:17 AM, Sekhar Nori wrote: >> On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote: >>> Hi Sekar, >>> >>> On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori wrote: On Monday 24 October 2016 10:16 PM, ahas

Re: link state problem with dwc3 in supper-speed device mode

2016-10-26 Thread Felipe Balbi
Hi, Bin Liu writes: >> >> > There is no VBUS detection on this device and board. Is the VBUS >> >> > detection needed for dwc3 to work in device mode? >> >> >> >> In the case of DRA7x, you don't *really* need detection. All you need to >> >> do is correctly update UTMI mailbox. >> > >> > But t

Re: link state problem with dwc3 in supper-speed device mode

2016-10-26 Thread Roger Quadros
Hi, On 25/10/16 23:55, Bin Liu wrote: > Felipe, > > On Tue, Oct 25, 2016 at 08:57:26AM -0500, Bin Liu wrote: >> On Tue, Oct 25, 2016 at 04:44:13PM +0300, Felipe Balbi wrote: >> >> [snip] >> Just reviewed this patch, it seems to be the regression. But SS should not generate ID pin event

Re: [GIT PULL] usb: chipidea: fixes for v4.9

2016-10-26 Thread Greg KH
On Wed, Oct 26, 2016 at 11:03:20AM +0800, Peter Chen wrote: > The following changes since commit b76032396d7958f006bccf5fb2535beb5526837c: > > usb: renesas_usbhs: add wait after initialization for R-Car Gen3 > (2016-10-24 14:35:46 +0200) > > are available in the git repository at: > > git:/