Re: [PATCH] extcon: usb-gpio: Add VBUS detection support

2016-09-26 Thread Peter Chen
On Tue, Sep 20, 2016 at 05:53:55PM +0300, Roger Quadros wrote: > Driver can now work with both ID and VBUS pins or either one of > them. > > There can be the following 3 cases > > 1) Both ID and VBUS GPIOs are available: > > ID = LOW -> USB_HOST active, USB inactive > ID = HIGH -> USB_HOST inact

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-26 Thread Peter Chen
On Mon, Sep 26, 2016 at 11:44:50AM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-25 20:29:27) > > On Thu, Sep 22, 2016 at 11:51:02AM -0700, Stephen Boyd wrote: > > > Quoting Peter Chen (2016-09-16 18:16:05) > > > > On Wed, Sep 14, 2016 at 01:55:02AM -0700, Stephen Boyd wrote: > > > > > Q

Re: [PATCH v6 0/2] Add USB configuration for imx53

2016-09-26 Thread Peter Chen
On Mon, Sep 26, 2016 at 01:14:18PM +0200, Fabien Lahoudere wrote: > Changes in V2: > - Patches sent to early with bad contents > Changes in V3: > - Change subject > - Split "configure imx for ULPI phy" for disable-oc code > Changes in V4: > - Fix "Change switch order" commit

Re: Strange behavior of CHN bit with dwc3

2016-09-26 Thread mgautam
On 2016-09-22 18:46, yfw wrote: Hi list, I tried to enable the high speed, high bandwidth transfer in device mode for iso type on dwc3 based soc. The platform only supports usb device 2.0. I set the MaxPacketSize to 0x1400 so the host could allocate 3072 bytes for uframe. But when I chain three

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-26 Thread Pierre de Villemereuil
Hi guys, Any news on this front? Anything I can do to help find the issue? Cheers, Pierre. Le mardi 20 septembre 2016, 11:05:13 NZDT Oliver Neukum a écrit : > On Tue, 2016-09-20 at 20:58 +1200, Pierre de Villemereuil wrote: > > Hi Oliver! > > > > Here you are. > > > > dmesg signals when pluggi

[PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-26 Thread Allan Chou
From: Chris Roth Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610). Patch verified on x64 linux kernel 4.7.4 system with the Kensington SD4600P USB-C Universal Dock with Power, which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge C

Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-26 Thread Chris Roth
I'm not sure what I'm doing wrong: I'm trying to get the from statement to read original author (Allan Chou) first, and then me (Chris Roth) second. I've used the following two commands: git format-patch -o /tmp/ --subject-prefix="PATCH v2" --from="Allan Chou " HEAD^ and git send-email --to lin

Re: [PATCH v8 2/3] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-09-26 Thread John Youn
On 9/24/2016 11:51 AM, Randy Li wrote: > On the rk3288 USB host-only port (the one that's not the OTG-enabled > port) the PHY can get into a bad state when a wakeup is asserted (not > just a wakeup from full system suspend but also a wakeup from > autosuspend). > > We can get the PHY out of its ba

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-26 Thread Malcolm Priestley
On 26/09/16 19:23, Oliver Neukum wrote: On Mon, 2016-09-26 at 18:57 +0100, Malcolm Priestley wrote: On 26/09/16 09:48, Oliver Neukum wrote: On Sat, 2016-09-24 at 01:21 +0100, Malcolm Priestley wrote: On 22/09/16 20:50, Malcolm Priestley wrote: On 22/09/16 15:25, Oliver Neukum wrote: On

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-26 Thread Oliver Neukum
On Mon, 2016-09-26 at 18:57 +0100, Malcolm Priestley wrote: > > On 26/09/16 09:48, Oliver Neukum wrote: > > On Sat, 2016-09-24 at 01:21 +0100, Malcolm Priestley wrote: > >> > >> On 22/09/16 20:50, Malcolm Priestley wrote: > >>> > >>> > >>> On 22/09/16 15:25, Oliver Neukum wrote: > On Thu, 201

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-26 Thread Malcolm Priestley
On 26/09/16 09:48, Oliver Neukum wrote: On Sat, 2016-09-24 at 01:21 +0100, Malcolm Priestley wrote: On 22/09/16 20:50, Malcolm Priestley wrote: On 22/09/16 15:25, Oliver Neukum wrote: On Thu, 2016-09-22 at 14:46 +0300, Binyamin Sharet wrote: -- Binyamin I compiled the kernel without B

Re: g_webcam Isoch high bandwidth transfer

2016-09-26 Thread Laurent Pinchart
Hi Felipe, On Friday 23 Sep 2016 11:27:26 Felipe Balbi wrote: > yfw writes: > >> Here's one that actually compiles, sorry about that. > > > > No worries, I was sleeping ;-) > > > > I will test it out early next week. Thanks. > > meanwhile, how about some instructi

Re: g_webcam Isoch high bandwidth transfer

2016-09-26 Thread Laurent Pinchart
Hi Felipe, On Friday 23 Sep 2016 10:49:57 Felipe Balbi wrote: > Bin Liu writes: > > +Fengwei Yin per his request. > > > > On Thu, Sep 22, 2016 at 10:48:40PM +0300, Felipe Balbi wrote: > >> Bin Liu writes: > >> > >> [...] > >> > Here's one that actually compiles, sorry about that. > >>>

Re: [PATCH 1/2] usb: add helper to extract bits 12:11 of wMaxPacketSize

2016-09-26 Thread Bin Liu
On Mon, Sep 26, 2016 at 01:15:57PM +0300, Felipe Balbi wrote: > > Hi, > > yfw writes: > > Hi Felipe, > > > > On 2016/9/26 16:12, Felipe Balbi wrote: > >> According to USB Specification 2.0 table 9-4, > >> wMaxPacketSize is a bitfield. Endpoint's maxpacket > >> is laid out in bits 10:0. For high-

Re: g_webcam Isoch high bandwidth transfer

2016-09-26 Thread Bin Liu
On Fri, Sep 23, 2016 at 10:49:57AM +0300, Felipe Balbi wrote: > > Hi, > > Bin Liu writes: > > +Fengwei Yin per his request. > > > > On Thu, Sep 22, 2016 at 10:48:40PM +0300, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Bin Liu writes: > >> > >> [...] > >> > >> >> Here's one that actually com

[PATCH 6/8] usb: dwc3: gadget: remove redundant trace prints

2016-09-26 Thread Felipe Balbi
Removing some trace prints which were made redundant when we started decoding events and TRBs completely within their respective trace points. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/ep0.c| 17 + drivers/usb/dwc3/gadget.c | 43 +---

[PATCH 8/8] usb: dwc3: trace: print out ep0state also from XferComplete

2016-09-26 Thread Felipe Balbi
With this extra piece of information, it will be easier to find mismatches between driver and HW. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debug.h | 11 --- drivers/usb/dwc3/ep0.c| 4 drivers/usb/dwc3/gadget.c | 2 +- drivers/usb/dwc3/trace.h | 12 +++- 4 fil

[PATCH 4/8] usb: dwc3: gadget: conditionally disable Link State change events

2016-09-26 Thread Felipe Balbi
Link State Change events are only needed for debugging and to apply certain workarounds on known errata. Let's save a few cycles by disabling these events completely on working revisions of the core. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 4 +++- 1 file changed, 3 insertions

[PATCH 7/8] usb: dwc3: debug: move dwc3_ep0_state_string() to debug.h

2016-09-26 Thread Felipe Balbi
We will be using dwc3_ep0_state_string() from within our tracepoints, so we need to move that helper to debug.h in order for it to be accessible. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debug.h | 16 drivers/usb/dwc3/ep0.c | 16 2 files changed, 16 in

[PATCH 5/8] usb: dwc3: debug: decode control endpoint phase too

2016-09-26 Thread Felipe Balbi
DWC3 can tell us which phase of a setup transfer we're getting into. Let's decode it from the event to make it easier to debug. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.h | 1 + drivers/usb/dwc3/debug.h | 13 + 2 files changed, 14 insertions(+) diff --git a/drivers/us

[PATCH 3/8] usb: dwc3: gadget: giveback request if we can't kick it

2016-09-26 Thread Felipe Balbi
There might be situations where a Start Transfer command might fail, if that ever happens, instead of simply removing the request from our list, we should give the request back to the gadget driver, otherwise we might eventually starve it from requests. Signed-off-by: Felipe Balbi --- drivers/us

[PATCH 1/8] usb: dwc3: gadget: properly check ep cmd

2016-09-26 Thread Felipe Balbi
The cmd argument we pass to dwc3_send_gadget_ep_cmd() could contain extra arguments embedded. When checking for StartTransfer command, we need to make sure to match only lower 4 bits which contain the actual command and ignore the rest. Reported-by: Janusz Dziedzic Signed-off-by: Felipe Balbi --

[PATCH 2/8] usb: dwc3: gadget: make use of No Response Update Transfer

2016-09-26 Thread Felipe Balbi
No Response Update Transfer is a special type of Update Transfer command which can be used whenever we're not relying on XferNotReady to prepare transfers. With this, we don't need to wait for CMDACT to be cleared and issue further commands to the endpoint straight away. Let's start using this ver

Re: [umap2] status of issues

2016-09-26 Thread Oliver Neukum
On Fri, 2016-09-02 at 12:41 +, Binyamin Sharet (bsharet) wrote: > Hi, > Here are the sources of the issues that were reproduced: so it seems to me that the current state is: > [02/11][10cf:5500] drivers/staging/comedi/drivers/vmk80xx.c open > [04/11][0557:2002] drivers/net/usb/kaweth.c fi

[PATCH v6 0/2] Add USB configuration for imx53

2016-09-26 Thread Fabien Lahoudere
Changes in V2: - Patches sent to early with bad contents Changes in V3: - Change subject - Split "configure imx for ULPI phy" for disable-oc code Changes in V4: - Fix "Change switch order" commit message - Indent switch/case (set case on the same column as sw

[PATCH v6 1/2] usb: chipidea: imx: configure imx for ULPI phy

2016-09-26 Thread Fabien Lahoudere
In order to use ULPI phy with usb host 2 and 3, we need to configure controller register to enable ULPI features. Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index switch and then test for features i

[PATCH v6 2/2] usb: chipidea: imx: Disable internal 60Mhz clock with ULPI PHY

2016-09-26 Thread Fabien Lahoudere
The internal 60Mhz clock for host2 and host3 are useless in ULPI phy mode, so we disable it when configuring ULPI PHY node for those host. Signed-off-by: Fabien Lahoudere --- drivers/usb/chipidea/usbmisc_imx.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/chipidea/

Re: [PATCH] usb: gadget: udc: atmel: fix endpoint name

2016-09-26 Thread Richard Genoud
2016-09-26 9:18 GMT+02:00 Felipe Balbi : > > Hi, > > Greg Kroah-Hartman writes: >> On Fri, Sep 23, 2016 at 04:20:45PM +0200, Nicolas Ferre wrote: >>> Le 16/09/2016 à 10:36, Nicolas Ferre a écrit : >>> > Le 15/09/2016 à 17:07, Alexandre Belloni a écrit : >>> >> Since commit c32b5bcfa3c4 ("ARM: dts:

Re: [PATCH 1/2] usb: add helper to extract bits 12:11 of wMaxPacketSize

2016-09-26 Thread Felipe Balbi
Hi, yfw writes: > Hi Felipe, > > On 2016/9/26 16:12, Felipe Balbi wrote: >> According to USB Specification 2.0 table 9-4, >> wMaxPacketSize is a bitfield. Endpoint's maxpacket >> is laid out in bits 10:0. For high-speed, >> high-bandwidth isochronous endpoints, bits 12:11 >> contain a multiplier

Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static

2016-09-26 Thread Mathias Nyman
On 23.09.2016 16:46, Baoyou Xie wrote: We get 1 warning when building kernel with W=1: drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't ne

Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-26 Thread Fabien Lahoudere
Hi, On 23/09/16 21:47, Rob Herring wrote: On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote: This binding allow to disable the internal 60Mhz clock for USB host2 or host3. Signed-off-by: Fabien Lahoudere --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + driver

Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-26 Thread Fabien Lahoudere
Hi, On 26/09/16 10:18, Sascha Hauer wrote: On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote: This binding allow to disable the internal 60Mhz clock for USB host2 or host3. Signed-off-by: Fabien Lahoudere --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + drive

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-26 Thread Oliver Neukum
On Sat, 2016-09-24 at 01:21 +0100, Malcolm Priestley wrote: > > On 22/09/16 20:50, Malcolm Priestley wrote: > > > > > > On 22/09/16 15:25, Oliver Neukum wrote: > >> On Thu, 2016-09-22 at 14:46 +0300, Binyamin Sharet wrote: > >> > -- Binyamin > >>> > >>> I compiled the kernel without BPF and s

Re: [PATCH 1/2] usb: add helper to extract bits 12:11 of wMaxPacketSize

2016-09-26 Thread yfw
Hi Felipe, On 2016/9/26 16:12, Felipe Balbi wrote: According to USB Specification 2.0 table 9-4, wMaxPacketSize is a bitfield. Endpoint's maxpacket is laid out in bits 10:0. For high-speed, high-bandwidth isochronous endpoints, bits 12:11 contain a multiplier to tell us how many transactions we

Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-26 Thread Sascha Hauer
On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote: > This binding allow to disable the internal 60Mhz clock for USB host2 or > host3. > > Signed-off-by: Fabien Lahoudere > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + > drivers/usb/chipidea/ci_hdrc_imx.c

[PATCH 2/2] usb: dwc3: gadget: set PCM1 field of isochronous-first TRBs

2016-09-26 Thread Felipe Balbi
In case of High-Speed, High-Bandwidth endpoints, we need to tell DWC3 that we have more than one packet per interval. We do that by setting PCM1 field of Isochronous-First TRB. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 14 -- 1 file changed, 12 insertions(+), 2 dele

[PATCH 1/2] usb: add helper to extract bits 12:11 of wMaxPacketSize

2016-09-26 Thread Felipe Balbi
According to USB Specification 2.0 table 9-4, wMaxPacketSize is a bitfield. Endpoint's maxpacket is laid out in bits 10:0. For high-speed, high-bandwidth isochronous endpoints, bits 12:11 contain a multiplier to tell us how many transactions we want to try per uframe. This means that if we want an

Re: [PATCH] usb: gadget: udc: atmel: fix endpoint name

2016-09-26 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > On Fri, Sep 23, 2016 at 04:20:45PM +0200, Nicolas Ferre wrote: >> Le 16/09/2016 à 10:36, Nicolas Ferre a écrit : >> > Le 15/09/2016 à 17:07, Alexandre Belloni a écrit : >> >> Since commit c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes"), >> >> atmel_usba_u