Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Laurent Pinchart
Hi Tony, On Monday 19 Sep 2016 15:41:50 Tony Lindgren wrote: > * Laurent Pinchart [160919 13:35]: > > On Sunday 18 Sep 2016 08:19:02 Tony Lindgren wrote: > >>> [5.711303] [] (_raw_spin_unlock_irqrestore) from > >>> [] > >>> (musb_gadget_queue+0x128/0x4ac) > >>> [5.711303] [] (musb_gadget_

Re: [PATCH] usb: misc: legousbtower: Fix NULL pointer deference

2016-09-19 Thread Greg KH
On Mon, Sep 19, 2016 at 07:09:51PM +0100, James wrote: > This patch fixes a NULL pointer dereference caused by a race codition in the > probe function of the legousbtower driver. It re-structures the probe > function to only register the interface after successfully reading the > board's firmware I

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Andreas Kemnade
On Mon, 19 Sep 2016 09:02:50 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160918 23:00]: > > On Sun, 18 Sep 2016 08:19:02 -0700 > > Tony Lindgren wrote: > > > > > * Laurent Pinchart [160918 > > > 05:13]: > > > > > > > > FYI, while this patch allows me to boot my Panda board with NFS > > >

Re: [PATCH v2 3/6] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-19 Thread Kishon Vijay Abraham I
On Monday 19 September 2016 10:12 PM, Kevin Hilman wrote: > Kishon Vijay Abraham I writes: > >> Hi Kevin, >> >> On Wednesday 14 September 2016 09:36 PM, Kevin Hilman wrote: >>> Kishon, >>> >>> Martin Blumenstingl writes: >>> This is a new driver for the USB PHY found in Meson8b and GXBB S

Re: [PATCH 1/2] phy-sun4i-usb: Add sun4i_usb_phy_force_session_end() function

2016-09-19 Thread Kishon Vijay Abraham I
Hi, On Sunday 18 September 2016 10:20 PM, Hans de Goede wrote: > The sunxi musb has a bug where sometimes it will generate a babble > error on device disconnect instead of a disconnect irq. When this > happens the musb-controller switches from host mode to device mode > (it clears MUSB_DEVCTL_SESS

[PATCH v7 5/8] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

2016-09-19 Thread Peter Chen
From: Peter Chen At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node, we let the core's device node equals glu

[PATCH v7 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line

2016-09-19 Thread Peter Chen
From: Joshua Clayton Previously the onboard hub was made to work by treating its reset gpio as a regulator enable. Get rid of that kludge now that pwseq has added reset gpio support Move pin muxing the hub reset pin into the usbh1 group Signed-off-by: Joshua Clayton Signed-off-by: Peter Chen -

[PATCH v7 6/8] ARM: dts: imx6qdl: Enable usb node children with

2016-09-19 Thread Peter Chen
From: Joshua Clayton Give usb nodes #address and #size attributes, so that a child node representing a permanently connected device such as an onboard hub may be addressed with a attribute Signed-off-by: Joshua Clayton Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl.dtsi | 6 ++

[PATCH v7 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-09-19 Thread Peter Chen
Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/binding

[PATCH v7 2/8] power: add power sequence library

2016-09-19 Thread Peter Chen
We have an well-known problem that the device needs to do some power sequence before it can be recognized by related host, the typical example like hard-wired mmc devices and usb devices. This power sequence is hard to be described at device tree and handled by related host driver, so we have crea

[PATCH v7 4/8] usb: core: add power sequence handling for USB devices

2016-09-19 Thread Peter Chen
Some hard-wired USB devices need to do power sequence to let the device work normally, the typical power sequence like: enable USB PHY clock, toggle reset pin, etc. But current Linux USB driver lacks of such code to do it, it may cause some hard-wired USB devices works abnormal or can't be recogniz

[PATCH v7 7/8] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2016-09-19 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Besides, using gpio pinctrl setting for USB2415's reset pin. Signed-off-by: Peter Chen Signed-off-by: Josh

[PATCH v7 3/8] binding-doc: usb: usb-device: add optional properties for power sequence

2016-09-19 Thread Peter Chen
Add optional properties for power sequence. Signed-off-by: Peter Chen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentatio

[PATCH v7 0/8] power: add power sequence library

2016-09-19 Thread Peter Chen
Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2]. The kinds of power sequence instances will be added at postcore_initcall, the match criteria is compatible string first, if the compatible string is not matched b

Re: UAS and f_tcm -- is anyone using it?

2016-09-19 Thread John Youn
On 8/29/2016 11:26 AM, John Youn wrote: > On 8/29/2016 12:33 AM, Felipe Balbi wrote: >> >> Hi, >> >> John Youn writes: >>> On 8/26/2016 12:48 AM, Felipe Balbi wrote: Hi, John Youn writes: > I was wondering if anyone is using the f_tcm function? Specifically > for UAS i

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-19 Thread Pierre de Villemereuil
Dear Oliver, Sorry about my last message, the bug is actually still going on. I found something interesting though: when AC is plugged, USB is working totally OK, but when on battery, then here comes trouble... Could this be power management? Below is my TLP config (mostly default) if it's an

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Tony Lindgren
* Laurent Pinchart [160919 13:35]: > On Sunday 18 Sep 2016 08:19:02 Tony Lindgren wrote: > > > [5.711303] [] (_raw_spin_unlock_irqrestore) from > > > [] > > > (musb_gadget_queue+0x128/0x4ac) > > > [5.711303] [] (musb_gadget_queue) from [] > > > (usb_ep_queue+0x38/0x1d4) > > > [5.729766

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-19 Thread Pierre de Villemereuil
Dear Oliver, I'm not really sure what happened, but now USB appears to be working perfectly well... In the meantime, since my last checks, I simply updated Tumbleweed and entered the command below as root (I rebooted twice since then: USB still working!). I didn't find anything relevant in the

Re: [RESEND PATCH v7 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup

2016-09-19 Thread Rob Herring
On Sat, Sep 10, 2016 at 02:59:38AM +0800, Randy Li wrote: > It is a hardware bug in RK3288, the only way to solve it is to > reset the phy. > > Signed-off-by: Randy Li > --- > .../devicetree/bindings/phy/rockchip-usb-phy.txt | 3 +++ Acked-by: Rob Herring > drivers/phy/phy-rockchip-usb.c

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-19 Thread Rob Herring
On Fri, Sep 16, 2016 at 7:05 PM, Stephen Boyd wrote: > Quoting Rob Herring (2016-09-16 08:19:51) >> On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: >> > The high-speed phy on qcom SoCs is controlled via the ULPI >> > viewport. >> > [...] >> > +- qcom,init-seq: >> > +Usage: opti

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Laurent Pinchart
Hi Tony, On Sunday 18 Sep 2016 08:19:02 Tony Lindgren wrote: > * Laurent Pinchart [160918 05:13]: > > FYI, while this patch allows me to boot my Panda board with NFS over > > usbnet, it only works with cold boots. A warm reboot results in the > > following warning, and no ethernet traffic going t

[PATCH] usb: misc: legousbtower: Fix NULL pointer deference

2016-09-19 Thread James
This patch fixes a NULL pointer dereference caused by a race codition in the probe function of the legousbtower driver. It re-structures the probe function to only register the interface after successfully reading the board's firmware ID. The probe function does not deregister the usb interfac

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-19 Thread Alan Stern
On Mon, 19 Sep 2016, Ulf Hansson wrote: > On 18 September 2016 at 04:30, Alan Stern wrote: > > On Sat, 17 Sep 2016, Ulf Hansson wrote: > > > >> Each access of the parent device (usb device) needs to be done in runtime > >> resumed state. Currently this isn't case while changing the leds, so let's

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-09-19 Thread Alan Stern
On Mon, 19 Sep 2016, Ulf Hansson wrote: > On 18 September 2016 at 03:42, Alan Stern wrote: > > Well, this is pretty clear: > > > > Sep 17 15:55:52 learner kernel: CPU: 1 PID: 535 Comm: rtsx_usb_ms_1 > > Tainted: G U 4.8.0-rc6ulf1alan1+ #19 > > Sep 17 15:55:52 learner kernel: Hardwa

Re: Memory barrier needed with wake_up_process()?

2016-09-19 Thread Alan Stern
On Mon, 19 Sep 2016, Felipe Balbi wrote: > >> file-storage-3578 [002] 21167.727072: fsg_main_thread: next: bh > >> 880111e69a80 state 1 > >> file-storage-3578 [002] 21167.729458: fsg_main_thread: next: bh > >> 880111e6aac0 state 2 > >> irq/17-dwc3-3579 [003] d..

Re: [PATCH v2 3/6] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-19 Thread Kevin Hilman
Kishon Vijay Abraham I writes: > Hi Kevin, > > On Wednesday 14 September 2016 09:36 PM, Kevin Hilman wrote: >> Kishon, >> >> Martin Blumenstingl writes: >> >>> This is a new driver for the USB PHY found in Meson8b and GXBB SoCs. >>> >>> Signed-off-by: Martin Blumenstingl >>> Signed-off-by: Je

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Tony Lindgren
* Andreas Kemnade [160918 23:00]: > On Sun, 18 Sep 2016 08:19:02 -0700 > Tony Lindgren wrote: > > > * Laurent Pinchart [160918 05:13]: > > > > > > FYI, while this patch allows me to boot my Panda board with NFS > > > over usbnet, it only works with cold boots. A warm reboot results > > > in th

[PATCH v3 2/2] usb: dwc3: Wait for control tranfer completed when stopping gadget

2016-09-19 Thread Baolin Wang
When we change the USB function with configfs dynamically, we possibly met this situation: one core is doing the control transfer, another core is trying to unregister the USB gadget from userspace, we must wait for completing this control tranfer, or it will hang the controller to set the DEVCTRLH

[PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-09-19 Thread Baolin Wang
When system has stpped the gadget, we should avoid queuing any requests which will cause tranfer failed. Thus adding some disconnect checking to avoid this situation. Signed-off-by: Baolin Wang --- Changes since v2: - Move disconnect checking into dwc3_send_gadget_ep_cmd(). - Rename completion

[PATCH v4 1/3] usb: chipidea: imx: Change switch order

2016-09-19 Thread Fabien Lahoudere
Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index switch and then test for features if they exist for this index. This patch also remove useless test of reg and val. Those two values cannot be NULL.

[PATCH v4 2/3] usb: chipidea: imx: configure imx for ULPI phy

2016-09-19 Thread Fabien Lahoudere
In order to use ULPI phy with usb host 2 and 3, we need to configure controller register to enable ULPI features. Signed-off-by: Fabien Lahoudere --- drivers/usb/chipidea/ci_hdrc_imx.c | 5 + drivers/usb/chipidea/ci_hdrc_imx.h | 1 + drivers/usb/chipidea/usbmisc_imx.c | 37

[PATCH v4 3/3] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-19 Thread Fabien Lahoudere
This binding allow to disable the internal 60Mhz clock for USB host2 and host3. Signed-off-by: Fabien Lahoudere --- drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++ drivers/usb/chipidea/ci_hdrc_imx.h | 1 + drivers/usb/chipidea/usbmisc_imx.c | 13 + 3 files changed, 16 insertions(+) dif

[PATCH v4 0/3] usb: chipidea: imx: Add USB configuration for imx53

2016-09-19 Thread Fabien Lahoudere
Changes in V2: - Patches sent to early with bad contents Changes in V3: - Change subject - Split "configure imx for ULPI phy" for disable-oc code Changes in V4: - Fix "Change switch order" commit message - Indent switch/case (set case on the same column as sw

[PATCH 2/2] usb: chipidea: otg: fix reading otgsc register

2016-09-19 Thread Sascha Hauer
When switching from gadget to host the driver waits for VBUS to disappear before doing the actual switch. This waiting is done by letting hw_wait_reg() poll the OTGSC register. This is buggy. hw_wait_reg() directly reads the register, but for reading the OTGSC register hw_read_otgsc() must be used

[PATCH 1/2] usb: chipidea: otg: save indention level

2016-09-19 Thread Sascha Hauer
Return early from ci_handle_id_switch() to save an indention level. Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/otg.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c index 03b6743..91989b

USB: chipidea: Fix VBUS valid polling when extcon is used

2016-09-19 Thread Sascha Hauer
This series fixes a bug when the VBUS detection is done by using extcon. When this is and the driver leaves host mode it will always respond with: ci_hdrc.0: timeout waiting for 0800 in 11 This goes back to reading the OTGSC register with the raw register read function. See 2/2 for more info.

[PATHCv10 1/2] usb: USB Type-C connector class

2016-09-19 Thread Heikki Krogerus
The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and Alt

[PATHCv10 0/2] USB Type-C Connector class

2016-09-19 Thread Heikki Krogerus
The USB Type-C class is meant to provide unified interface to the userspace to present the USB Type-C ports in a system. Changes since v9: - Minor typec_wcove.c cleanup as proposed by Guenter Roeck. No function affect. Changes since v8: - checking sysfs_streq() result correctly in sysfs_strmatc

[PATHCv10 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

2016-09-19 Thread Heikki Krogerus
This adds driver for the USB Type-C PHY on Intel WhiskeyCove PMIC which is available on some of the Intel Broxton SoC based platforms. Reviewed-by: Guenter Roeck Signed-off-by: Heikki Krogerus --- drivers/usb/typec/Kconfig | 14 ++ drivers/usb/typec/Makefile | 1 + drivers/usb/typ

Re: Memory barrier needed with wake_up_process()?

2016-09-19 Thread Felipe Balbi
Hi Alan, Alan Stern writes: > On Fri, 9 Sep 2016, Felipe Balbi wrote: > >> Finally :-) Here's the diff I used: >> >> diff --git a/drivers/usb/gadget/function/f_mass_storage.c >> b/drivers/usb/gadget/function/f_mass_storage.c >> index 8f3659b65f53..0716024f6b65 100644 >> --- a/drivers/usb/gadge

Re: [PATCH v2 2/2] usb: dwc3: Wait for control tranfer completed when stopping gadget

2016-09-19 Thread Baolin Wang
Hi Felipe, On 19 September 2016 at 17:58, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 1a33308..c9026ce 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1441,6 +1441

Re: [PATCH 05/15] usb: chipidea: imx: Change switch order

2016-09-19 Thread Joe Perches
On Mon, 2016-09-19 at 12:18 +0200, Fabien Lahoudere wrote: > Each USB controller have different behaviour, so in order to avoid to have > several "swicth(data->index)" and lock/unlock, we prefer to get the index > and then test for features if they exist for this index. [] > diff --git a/drivers/us

Re: [PATCH v3 1/3] usb: chipidea: imx: Change switch order

2016-09-19 Thread Sergei Shtylyov
Hello. On 9/19/2016 1:22 PM, Fabien Lahoudere wrote: Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index Switch. and then test for features if they exist for this index. Signed-off-by: Fabien

Re: [PATCH 05/15] usb: chipidea: imx: Change switch order

2016-09-19 Thread Fabien Lahoudere
Please forget this submission. On 19/09/16 12:18, Fabien Lahoudere wrote: Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index and then test for features if they exist for this index. Signed-off-by:

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-19 Thread Sergei Shtylyov
Hello. On 9/19/2016 9:35 AM, Joel Stanley wrote: We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the primary HCD, like a keyboard. We've been carrying this in our Linux-as-a-bootloader environment for a little while n

[PATCH v3 1/3] usb: chipidea: imx: Change switch order

2016-09-19 Thread Fabien Lahoudere
Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index and then test for features if they exist for this index. Signed-off-by: Fabien Lahoudere --- drivers/usb/chipidea/usbmisc_imx.c | 44 ++

[PATCH v3 2/3] usb: chipidea: imx: configure imx for ULPI phy

2016-09-19 Thread Fabien Lahoudere
In order to use ULPI phy with usb host 2 and 3, we need to configure controller register to enable ULPI features. Signed-off-by: Fabien Lahoudere --- drivers/usb/chipidea/ci_hdrc_imx.c | 5 + drivers/usb/chipidea/ci_hdrc_imx.h | 1 + drivers/usb/chipidea/usbmisc_imx.c | 37

[PATCH v3 3/3] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-19 Thread Fabien Lahoudere
This binding allow to disable the internal 60Mhz clock for USB host2 and host3. Signed-off-by: Fabien Lahoudere --- drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++ drivers/usb/chipidea/ci_hdrc_imx.h | 1 + drivers/usb/chipidea/usbmisc_imx.c | 17 + 3 files changed, 20 insertions(+)

[PATCH 05/15] usb: chipidea: imx: Change switch order

2016-09-19 Thread Fabien Lahoudere
Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index and then test for features if they exist for this index. Signed-off-by: Fabien Lahoudere --- drivers/usb/chipidea/usbmisc_imx.c | 44 ++

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-09-19 Thread Ulf Hansson
On 18 September 2016 at 03:42, Alan Stern wrote: > On Sat, 17 Sep 2016, Ritesh Raj Sarraf wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> Hello Alan, >> >> >> On Fri, 2016-09-16 at 17:40 -0400, Alan Stern wrote: >> > We're still getting runtime suspends, but now at 2-second in

Re: [PATCH v2 2/2] usb: dwc3: Wait for control tranfer completed when stopping gadget

2016-09-19 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index 1a33308..c9026ce 100644 >>> --- a/drivers/usb/dwc3/gadget.c >>> +++ b/drivers/usb/dwc3/gadget.c >>> @@ -1441,6 +1441,15 @@ static int dwc3_gadget_run_stop(struct dwc3 *dwc, >>> int is_on, in

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-19 Thread Oliver Neukum
On Sun, 2016-09-18 at 19:48 +1200, Pierre de Villemereuil wrote: > Dear kernel devs, > > I'm using openSUSE Tumbleweed (kernel 4.7.2-2-default) on an ASUS Vivobook > Flip TP301UA-C4028T, see here for specs: > https://www.asus.com/Notebooks/ASUS-VivoBook-Flip-TP301UA/specifications/ > > Since my

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-19 Thread Ulf Hansson
On 18 September 2016 at 04:30, Alan Stern wrote: > On Sat, 17 Sep 2016, Ulf Hansson wrote: > >> Each access of the parent device (usb device) needs to be done in runtime >> resumed state. Currently this isn't case while changing the leds, so let's >> add pm_runtime_get_sync() and pm_runtime_put()

Re: Gadget regression with u_ether in Linux next

2016-09-19 Thread Greg Kroah-Hartman
On Mon, Sep 19, 2016 at 11:19:07AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Tony Lindgren writes: > > Hi, > > > > Looks like commit c9ffc78745f8 ("usb: gadget: NCM: Protect dev->port_usb > > using dev->lock") causes hangs for me with Linux next. > > > > Reverting c9ffc78745f8 makes the issues

Re: Gadget regression with u_ether in Linux next

2016-09-19 Thread Felipe Balbi
Hi Greg, Tony Lindgren writes: > Hi, > > Looks like commit c9ffc78745f8 ("usb: gadget: NCM: Protect dev->port_usb > using dev->lock") causes hangs for me with Linux next. > > Reverting c9ffc78745f8 makes the issues go away, some more info below. Can you revert this commit from your tree? Here'

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-19 Thread Joel Stanley
Hi Mathias, On Mon, Sep 19, 2016 at 4:33 PM, Greg KH wrote: > On Mon, Sep 19, 2016 at 04:05:45PM +0930, Joel Stanley wrote: >> We can't halt the secondary HCD, because it's also the primary HCD, >> which will cause problems if we have devices attached to the primary >> HCD, like a keyboard. >> >>

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-19 Thread Vaibhav Hiremath
On Monday 19 September 2016 01:16 PM, Peter Chen wrote: On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote: On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote: [...] We had an agreement that keep mmc's pwrseq framework unchanging. Unless Ulf and rob both agree to change.

[PATCH v2 0/3] Usb gadget ncm code cleanup

2016-09-19 Thread Harish Jenny K N
This patchset consists of some code cleanup in usb gadget ncm code. Note: Testing has only been done on an ARM i.MX6 based platform. --- Change from v1 to v2 Subject line changed on Patch 2. Torsten Polle (3): usb: gadget: NCM: link socket buffers to the device for tx packets usb: gadget: u_

[PATCH v2 3/3] usb: gadget: NCM: differentiate consumed packets from dropped packets

2016-09-19 Thread Harish Jenny K N
From: Torsten Polle dev_kfree_skb_any() is used to free packets that are dropped by the network stack. Therefore the function should not be used for packets that have been successfully processed by the network stack. Instead dev_consume_skb_any() has to be used for such consumed packets. This se

[PATCH v2 2/3] usb: gadget: u_ether: link socket buffers to the device for received packets

2016-09-19 Thread Harish Jenny K N
From: Torsten Polle Socket buffers should be linked to the (network) device that allocated the buffers. __netdev_alloc_skb performs this task. Signed-off-by: Torsten Polle Signed-off-by: Jim Baxter Signed-off-by: Harish Jenny K N --- Change from v1 to v2 Subject line changed drivers/usb/gad

[PATCH v2 1/3] usb: gadget: NCM: link socket buffers to the device for tx packets

2016-09-19 Thread Harish Jenny K N
From: Torsten Polle Socket buffers should be linked to the (network) device that allocated the buffers. Signed-off-by: Torsten Polle Signed-off-by: Harish Jenny K N --- drivers/usb/gadget/function/f_ncm.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/function/f_

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-19 Thread Peter Chen
On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote: > > > On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote: > >[...] > > > >We had an agreement that keep mmc's pwrseq framework unchanging. > >Unless Ulf and rob both agree to change. > Why 2 separate approach for s

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-19 Thread Mathias Nyman
On 19.09.2016 09:35, Joel Stanley wrote: We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the primary HCD, like a keyboard. We've been carrying this in our Linux-as-a-bootloader environment for a little while now. The ma

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-19 Thread Vaibhav Hiremath
On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote: [...] We had an agreement that keep mmc's pwrseq framework unchanging. Unless Ulf and rob both agree to change. Why 2 separate approach for same problem ? And I see this as possible duplication of code/functionality :) How the new ker

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-19 Thread Arnd Bergmann
On Monday, September 19, 2016 10:29:27 AM CEST Kishon Vijay Abraham I wrote: > On Monday 19 September 2016 01:26 AM, Martin Blumenstingl wrote: > > On Fri, Sep 16, 2016 at 10:19 AM, Kishon Vijay Abraham I > > wrote: > >> This way the driver will be probed only once (the reset can be done during

Re: [RFC PATCH] xhci: do not halt the secondary HCD

2016-09-19 Thread Greg KH
On Mon, Sep 19, 2016 at 04:05:45PM +0930, Joel Stanley wrote: > We can't halt the secondary HCD, because it's also the primary HCD, > which will cause problems if we have devices attached to the primary > HCD, like a keyboard. > > We've been carrying this in our Linux-as-a-bootloader environment f