Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller

2016-07-10 Thread Peter Chen
On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > Describes the qoriq usb 2.0 controller driver binding, currently used > for LS1021A and LS1012A platform. > > Signed-off-by: Rajesh Bhagat > --- > Changes in v2: > - Adds DT binding documentation for qoriq usb 2.0 controller > -

Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

2016-07-10 Thread Peter Chen
On Sat, Jul 09, 2016 at 10:00:52AM +0530, Rajesh Bhagat wrote: > Adds qoriq platform driver for chipidea controller, > verfied on LS1021A and LS1012A platforms. > > Signed-off-by: Rajesh Bhagat > --- > Changes in v2: > - Replaced Freescale with QorIQ in comments section > - Added macros to remo

Re: [PATCH 0/3] usb: chipidea: Improvements to UDC

2016-07-10 Thread Peter Chen
On Sat, Jul 09, 2016 at 02:16:37PM +, Stefan Wahren wrote: > This patch series aim to improve the ChipIdea UDC driver in regards to > readability and runtime behavior. > > Changes since RFC: > - drop patch usb: chipidea: udc: Avoid busy wait in reset ISR > > Stefan Wahren (3): > usb: chipid

Re: [PATCH] usb: gadget: fix check in sync read from ep in gadgetfs

2016-07-10 Thread Peter Chen
On Sun, Jul 10, 2016 at 11:25:17AM +0300, Binyamin Sharet wrote: > Hi, > > Could someone please advise whether I should also open a bug in > bugzilla for this thing? or if there anything else I'm missing? > It is not necessary, the related maintainers will comment or accept it. Peter > This is

Re: [PATCH v2 19/22] usb: chipidea: msm: Handle phy power states

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:10PM -0700, Stephen Boyd wrote: > The ULPI phy on qcom platforms needs to be initialized and > powered on after a USB reset and before we toggle the run/stop > bit. Otherwise, the phy locks up and doesn't work properly. Hook > the phy initialization into the RESET even

Re: [PATCH v2 20/22] usb: chipidea: msm: Be silent on probe defer errors

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:11PM -0700, Stephen Boyd wrote: > If something fails in ci_hdrc_add_device() due to probe defer, we > shouldn't print an error message. Be silent in this case as we'll > try probe again later. > > Cc: Peter Chen > Cc: Greg Kroah-Hartman > Signed-off-by: Stephen Boyd

Re: [PATCH v2 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:09PM -0700, Stephen Boyd wrote: > The MSM chipidea wrapper has two bits that are used to reset the > first or second phy. Add support for these bits via the reset > controller framework, so that phy drivers can reset their > hardware at the right time during initializa

Re: [PATCH v2 17/22] usb: chipidea: msm: Make platform data driver local instead of global

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:08PM -0700, Stephen Boyd wrote: > If two devices are probed with this same driver, they'll share > the same platform data structure, while the chipidea core layer > writes and modifies it. This can lead to interesting results > especially if one device is an OTG type c

Re: [PATCH v2 16/22] usb: chipidea: msm: Restore wrapper settings after reset

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:07PM -0700, Stephen Boyd wrote: > When the RESET bit is set in the USBCMD register it resets quite > a few of the wrapper's registers to their reset state. This > includes the GENCONFIG and GENCONFIG2 registers. Currently this > is done by the usb phy and ehci-msm driv

Re: [PATCH v15 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-07-10 Thread Baolin Wang
Hi Felipe, On 1 July 2016 at 14:05, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their kernels > or US

Re: [PATCH v2 15/22] usb: chipidea: msm: Mux over secondary phy at the right time

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:06PM -0700, Stephen Boyd wrote: > We need to pick the correct phy at runtime based on how the SoC > has been wired onto the board. If the secondary phy is used, take > it out of reset and mux over to it by writing into the TCSR > register. Make sure to do this on reset

Re: [PATCH v2 14/22] usb: chipidea: msm: Add proper clk and reset support

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:05PM -0700, Stephen Boyd wrote: > The msm chipidea controller uses two main clks, an AHB clk to > read/write the MMIO registers and a core clk called the system > clk that drives the controller itself. Add support for these clks > as they're required in all designs. >

[PATCH] usb3: Fixed usb3 device is not detected in s0 when hotplug usb3 disk under S3

2016-07-10 Thread Huang, Huki
When end user inserts a usb3 device and put dut to s3. Then hotplug the usb3 disk under s3. The device will be lost upon resuming from s3. There is a corner case that the hub->change_bits for the usb3 port is not set when usb port change event happens. This will cause hub driver ignore the device

Re: [PATCH v2 12/22] usb: chipidea: msm: Rely on core to override AHBBURST

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:03PM -0700, Stephen Boyd wrote: > The core framework already handles setting this parameter with a > platform quirk. Add the appropriate flag so that we always set > AHBBURST to 0. Technically DT should be doing this, but we always > do it for msm chipidea devices so s

Re: [PATCH v2 11/22] usb: chipidea: msm: Mark device as runtime pm active

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:02PM -0700, Stephen Boyd wrote: > We're not properly marking the glue layer/wrapper device as > runtime active, so runtime PM believes that the hardware state is > inactive when we call pm_runtime_enable() in this driver. This > causes a problem when the glue layer has

Re: [PATCH v2 10/22] usb: chipidea: Add support for ULPI PHY bus

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:01PM -0700, Stephen Boyd wrote: > Some phys for the chipidea controller are controlled via the ULPI > viewport. Add support for the ULPI bus so that these sorts of > phys can be probed and read/written automatically without having > to duplicate the viewport logic in e

[PATCH v2] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-10 Thread Baolin Wang
Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size attribute, which means it need to align the request buffer's size to an ep's maxpacketsize. Thus we add usb_ep_align_maybe() function to check if it is need to align the request buffer's size to an ep's maxpacketsize. Sig

Re: [PATCH v2 09/22] usb: chipidea: Kick OTG state machine for AVVIS with vbus extcon

2016-07-10 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:21:00PM -0700, Stephen Boyd wrote: > Force the OTG state machine to go forward when we're using an > extcon for vbus detection. In this case, the controller may never > raise an interrupt for AVVIS, so we need to simulate the event by > toggling the appropriate OTG fsm bi

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-10 Thread Baolin Wang
On 8 July 2016 at 21:04, Michal Nazarewicz wrote: > On Fri, Jul 08 2016, Baolin Wang wrote: >> On 7 July 2016 at 20:51, Michal Nazarewicz wrote: >>> On Thu, Jul 07 2016, Baolin Wang wrote: Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size attribute, which means

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-10 Thread Baolin Wang
On 8 July 2016 at 21:27, Felipe Balbi wrote: > > Hi again, > > Felipe Balbi writes: >> Michal Nazarewicz writes: >>> On Fri, Jul 08 2016, Baolin Wang wrote: On 7 July 2016 at 20:51, Michal Nazarewicz wrote: > On Thu, Jul 07 2016, Baolin Wang wrote: >> Some gadget device (such as dw

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-10 Thread Baolin Wang
On 8 July 2016 at 21:21, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size >> attribute, which means it need to align the request buffer's size to an ep's >> maxpacketsize. >> >> Thus we add usb_ep_align_maybe() func

[PATCH v2 1/1] usb: udc: core: fix error handling

2016-07-10 Thread Peter Chen
The udc device needs to be deleted if error occurs Fixes: 855ed04a3758 ("usb: gadget: udc-core: independent registration of gadgets and gadget drivers") Signed-off-by: Peter Chen --- Changes for v2: - Reformat the "Fixes" description in commit log drivers/usb/gadget/udc/core.c | 5

Re: [PATCH 1/1] usb: udc: core: fix error handling

2016-07-10 Thread Peter Chen
On Fri, Jul 08, 2016 at 01:28:57PM +0300, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > The udc device needs to be deleted if error occurs > > > > Fixes: 855ed04a (usb: gadget: udc-core: independent registration of gadgets > > and gadget drivers) > > it's preferred that the abbreviati

[PATCH v3] cdc-wdm: fix "out-of-sync" due to missing notifications

2016-07-10 Thread Bjørn Mork
The driver enforces a strict one-to-one relationship between the received RESPONSE_AVAILABLE notifications and messages read from the device. At the same time, it will cancel the interrupt URB when there is no client holding the character device open. Many devices do not cope well with this behavi

Re: [PATCH v2] cdc-wdm: fix "out-of-sync" due to missing notifications

2016-07-10 Thread Oliver Neukum
On Sat, 2016-07-09 at 20:31 +0200, Bjørn Mork wrote: > [removed the stable CC since this discussion isn't relevant to stable > anymore] > > Oliver Neukum writes: [..] > How about splitting the behaviour locally in cdc-wdm, keeping the > current behaviour for CDC WDM devices and changing to "dra

Re: [PATCH] usb: gadget: fix check in sync read from ep in gadgetfs

2016-07-10 Thread Binyamin Sharet
Hi, Could someone please advise whether I should also open a bug in bugzilla for this thing? or if there anything else I'm missing? This is the first time that I deal with kernel modification/development, and I'm not sure about the process in general and in the USB develepor community. Thanks, B