Re: xhci usb serial open/close issue

2016-06-14 Thread shishir tiwari
Hi Greg, What kernel version is this? >>>kernel - 3..4.14 ported on ARM custom board. Are there any kernel logs showing any errors? >> no error log showing >> we are just waiting for '#' prompt using chat command and comparing the >> result and printing "OK" in success case and "ERROR" in failu

Re: [PATCH v2] hid: migrate Riso Kagaku LED driver from USB misc to HID

2016-06-14 Thread Heiner Kallweit
Am 14.06.2016 um 23:49 schrieb Benjamin Tissoires: > On Jun 12 2016 or thereabouts, Heiner Kallweit wrote: >> The Riso Kagaku Webmail Notifier (and its clones) is supported as part of >> usb/misc/usbled driver currently. This patch migrates the driver for this >> device to the HID subsystem. >> >>

Re: [PATCH net-next 0/3] r8152: code adjustment for PHY

2016-06-14 Thread David Miller
From: Hayes Wang Date: Mon, 13 Jun 2016 17:49:35 +0800 > These patches are for adjusting the code about PHY and setting speed. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RESENDING] dwc2: Using internal phy (fs mode) for STM32F4x9 platform

2016-06-14 Thread John Youn
On 6/13/2016 8:21 AM, Bruno Herrera wrote: > Hi > > On Mon, Jun 13, 2016 at 9:19 AM, Maxime Coquelin > wrote: >> Hi, >> >> 2016-06-10 8:56 GMT+02:00 Felipe Balbi : >>> >>> Hi, >>> >>> John Youn writes: On 6/9/2016 10:18 AM, Bruno Herrera wrote: > Hello all, > I'm bringing the linux

Re: [PATCH v3 00/13] usb: dwc2: Fix up gadget isochronous support

2016-06-14 Thread John Youn
On 5/25/2016 6:06 PM, John Youn wrote: > The following patch series fixes up isochronous support for the dwc2 > gadget. The existing isochronous support lacked a few features. Most > notably it did not properly sync up with the first packet and it > didn't handle the Incomplete ISO IN/OUT interrupt

[PATCH 1/1] usb: core: of.c: fix defined but not declare warning

2016-06-14 Thread Peter Chen
The helper usb_of_get_child_node is defined at of.c, but missing its declare as a global function. Fix it by adding related header file as well as compile it on conditional of CONFIG_OF. Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: Alan Stern Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Frank Wang
Hi Heiko, On 2016/6/14 21:27, Heiko Stübner wrote: Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required

Add MediaTek USB3 DRD Driver

2016-06-14 Thread Chunfeng Yun
>From 48552e96e4e33f8830cb6a59154fe148425532fd Mon Sep 17 00:00:00 2001 From: Chunfeng Yun Date: Wed, 15 Jun 2016 10:58:10 +0800 Subject: [PATCH v4,0/5] Add MediaTek USB3 DRD Driver These patches introduce the MediaTek USB3 dual-role controller driver. The driver can be configured as Dual-Role D

[PATCH v4,2/5] dt-bindings: mt8173-mtu3: add devicetree bindings

2016-06-14 Thread Chunfeng Yun
add a DT binding doc for MediaTek USB3 DRD driver Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/usb/mt8173-mtu3.txt| 86 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/mt8173-mtu3.txt diff --git a/Documentation

[PATCH v4,5/5] arm64: dts: mediatek: add USB3 DRD driver

2016-06-14 Thread Chunfeng Yun
USB3 DRD driver is added for MT8173-EVB, and xHCI driver becomes its subnode Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 46 +-- arch/arm64/boot/dts/mediatek/mt8173.dtsi| 28 2 files changed, 65 insertions(+), 9 d

[PATCH v4,1/5] dt-bindings: mt8173-xhci: support host side of dual-role mode

2016-06-14 Thread Chunfeng Yun
Some resources, such as IPPC register etc, shared with device driver are moved into common glue layer when xHCI driver is the host side of dual-role mode and they should be changed as optional properties if they are required ones before. For clarity, add a new part of binding to support host side o

[PATCH v4,3/5] usb: xhci-mtk: make IPPC register optional

2016-06-14 Thread Chunfeng Yun
Make IPPC register optional to support host side of dual-role mode, due to it is moved into common glue layer for simplification. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH v4,4/5] usb: Add MediaTek USB3 DRD Driver

2016-06-14 Thread Chunfeng Yun
This patch adds support for the MediaTek USB3 controller integrated into MT8173. It can be configured as Dual-Role Device (DRD), Peripheral Only and Host Only (xHCI) modes. Signed-off-by: Chunfeng Yun --- drivers/usb/Kconfig|2 + drivers/usb/Makefile |1 + d

Re: [PATCH] USB: core: fix missing include

2016-06-14 Thread Peter Chen
On Tue, Jun 14, 2016 at 01:08:08PM +0200, Arnd Bergmann wrote: > On Wednesday, June 8, 2016 3:04:27 AM CEST kbuild test robot wrote: > > >> drivers/usb/core/of.c:32:21: error: redefinition of > > >> 'usb_of_get_child_node' > > struct device_node *usb_of_get_child_node(struct device_node *paren

Re: [PATCH] usb: common: otg-fsm: add license to usb-otg-fsm

2016-06-14 Thread Peter Chen
On Tue, Jun 14, 2016 at 01:26:59PM +0200, Oscar wrote: > El 2016-06-14 08:26, Peter Chen escribió: > >On Mon, Jun 13, 2016 at 06:56:30PM +0200, Oscar wrote: > >>Fix warning about tainted kernel because usb-otg-fsm has no license. > >>WARNING: with this patch usb-otg-fsm module can be loaded > >>but

Re: [PATCH v5 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-06-14 Thread Frank Wang
Hi Heiko, On 2016/6/14 21:28, Heiko Stübner wrote: Am Montag, 13. Juni 2016, 10:38:39 schrieb Heiko Stübner: Am Montag, 13. Juni 2016, 10:10:09 schrieb Frank Wang: Signed-off-by: Frank Wang looks really cool now, thanks for addressing all the review comments Reviewed-by: Heiko Stuebner Yo

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Frank Wang
Hi Heiko & Guenter, On 2016/6/14 22:00, Heiko Stübner wrote: Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck: On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote: Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: The newer SoCs (rk3366, rk3399) take a different usb-phy IP bl

Re: [PATCH v5 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-06-14 Thread Rob Herring
On Mon, Jun 13, 2016 at 10:10:09AM +0800, Frank Wang wrote: > Signed-off-by: Frank Wang > --- > > Changes in v5: > - Added 'reg' property to identify the different phy-blocks. > > Changes in v4: > - Used 'phy-supply' instead of 'vbus_*-supply'. > > Changes in v3: > - Added 'clocks' and 'cloc

RE: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread Mario_Limonciello
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 14, 2016 1:35 PM > To: pali.ro...@gmail.com > Cc: gre...@linuxfoundation.org; and...@lunn.ch; Limonciello, Mario > ; hayesw...@realtek.com; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; l

Re: [PATCH v2] hid: migrate Riso Kagaku LED driver from USB misc to HID

2016-06-14 Thread Benjamin Tissoires
On Jun 12 2016 or thereabouts, Heiner Kallweit wrote: > The Riso Kagaku Webmail Notifier (and its clones) is supported as part of > usb/misc/usbled driver currently. This patch migrates the driver for this > device to the HID subsystem. > > Benefits: > - Avoid using USB low-level calls and use the

[PATCH v2] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Heiner Kallweit
The Dream Cheeky Webmail Notifier and Friends Alert are supported as part of usb/misc/usbled driver currently. This patch migrates the driver for these devices to the HID subsystem. Benefits: - Avoid using USB low-level calls and use the HID subsystem instead (as this device provides a USB HID i

Re: [PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Heiner Kallweit
Am 14.06.2016 um 21:57 schrieb Oliver Neukum: > On Tue, 2016-06-14 at 21:34 +0200, Heiner Kallweit wrote: >> Am 14.06.2016 um 10:05 schrieb Oliver Neukum: >>> On Tue, 2016-06-14 at 07:51 +0200, Heiner Kallweit wrote: >>> + ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); + if (ret) +

Re: usbip/vhci_hcd.c: vhci_get_frame_number

2016-06-14 Thread Greg KH
On Sun, Jun 12, 2016 at 10:40:55PM +0200, Lars Täuber wrote: > Hello kernel hackers, > > please excuse the way I'm writing this. I know I'm for sure braking rules. > I'm trying to use the usbip vhcd_hcd driver to monitor a beehive via an > exported usb mic. Usbip is great, because I can use a ver

[PATCH 2/2] usb: musb: sunxi: Remove bogus "Frees glue" comment

2016-06-14 Thread Bin Liu
From: Hans de Goede The comment is wrong, glue is devm_kzalloc-ed mem attached to the "allwinner,sun4i-a10-musb" compatible platform-dev. Where as glue->musb_pdev is a newly created "musb-hdrc" platform-dev. Signed-off-by: Hans de Goede [b-...@ti.com: revise subject prefix] Signed-off-by: Bin L

[PATCH 0/2] musb-fixes for v4.7-rc4

2016-06-14 Thread Bin Liu
Hi Greg, Here are musb fixes for v4.7-rc4. Only one fix for NULL ptr deref in musb sunxi. Please let me know if any change is needed. Regards, -Bin. Hans de Goede (2): usb: musb: sunxi: Fix NULL ptr deref when gadget is registered before musb usb: musb: sunxi: Remove bogus "Frees glue"

[PATCH 1/2] usb: musb: sunxi: Fix NULL ptr deref when gadget is registered before musb

2016-06-14 Thread Bin Liu
From: Hans de Goede Stop using the return value of platform_device_register_full() to get to the struct musb in sunxi_musb_work(). If a gadget has been registered (insmod-ed) before the musb driver, then musb_start will get called from the musb_core probe function and sunxi_musb_work() may run be

Re: [PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Oliver Neukum
On Tue, 2016-06-14 at 21:34 +0200, Heiner Kallweit wrote: > Am 14.06.2016 um 10:05 schrieb Oliver Neukum: > > On Tue, 2016-06-14 at 07:51 +0200, Heiner Kallweit wrote: > > > >> + ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); > >> + if (ret) > >> + return ret; > >> + > >> + minor = ((st

Re: [PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Heiner Kallweit
Am 14.06.2016 um 10:05 schrieb Oliver Neukum: > On Tue, 2016-06-14 at 07:51 +0200, Heiner Kallweit wrote: > >> +ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); >> +if (ret) >> +return ret; >> + >> +minor = ((struct hidraw *) hdev->hidraw)->minor; >> + >> +ret = dc_init_de

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread David Miller
From: Pali Rohár Date: Tue, 14 Jun 2016 18:47:36 +0200 > You have never seen two ethernet cards with same MAC addresses? Right I > have not seen two USB, but there is non zero chance that could happen. It would be an error scenerio, and something to be avoided. It is a valid and correct assum

RE: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread Mario_Limonciello
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Tuesday, June 14, 2016 12:23 PM > To: Limonciello, Mario > Cc: pali.ro...@gmail.com; gre...@linuxfoundation.org; > da...@davemloft.net; hayesw...@realtek.com; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; l

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread Andrew Lunn
> > It is same, how to handle two network cards which tell us, that they > > have same MAC addresses. > > > > The kernel handles this just fine. In doing this patch I checked to see > what it does in that scenario. Two devices are made. systemd doesn't > rename the second device via the MAC na

RE: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread Mario_Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Tuesday, June 14, 2016 11:48 AM > To: Greg KH > Cc: David Miller ; and...@lunn.ch; Limonciello, > Mario ; hayesw...@realtek.com; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; linux- > u...@vger.kernel.

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread Pali Rohár
On Tuesday 14 June 2016 18:40:17 Greg KH wrote: > On Tue, Jun 14, 2016 at 06:28:10PM +0200, Pali Rohár wrote: > > On Saturday 11 June 2016 19:42:26 David Miller wrote: > > > From: Andrew Lunn > > > Date: Sat, 11 Jun 2016 17:39:21 +0200 > > > > > > > What is still open is do we want to accept it a

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread Greg KH
On Tue, Jun 14, 2016 at 06:28:10PM +0200, Pali Rohár wrote: > On Saturday 11 June 2016 19:42:26 David Miller wrote: > > From: Andrew Lunn > > Date: Sat, 11 Jun 2016 17:39:21 +0200 > > > > > What is still open is do we want to accept it at all? Do we accept > > > the concept of putting the same MA

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread Pali Rohár
On Saturday 11 June 2016 19:42:26 David Miller wrote: > From: Andrew Lunn > Date: Sat, 11 Jun 2016 17:39:21 +0200 > > > What is still open is do we want to accept it at all? Do we accept > > the concept of putting the same MAC address on multiple interfaces > > at hotplug time? Do we trust BIOS v

Re: xhci usb serial open/close issue

2016-06-14 Thread Greg KH
On Tue, Jun 14, 2016 at 08:27:30PM +0530, shishir tiwari wrote: > Hi , > > We are trying to open and close ttyUSB0 port and using 'chat' command > to communicate in while loop using shell script.but after 30-40 times > '#' reply is not coming for 'ls' command. > > shell script:: > while > ( > stt

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Heiko Stübner
Am Dienstag, 14. Juni 2016, 07:52:13 schrieb Guenter Roeck: > On 06/12/2016 07:10 PM, Frank Wang wrote: > > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > > than rk3288 and before, and most of phy-related registers are also > > different from the past, so a new phy driver is re

Re: [PATCH] xhci: Detect out-of-bounds access to usb2_ports

2016-06-14 Thread Christian M . Amsüss
On Tue, Jun 14, 2016 at 06:19:58PM +0300, Mathias Nyman wrote: > If I write a more verbose debugging patch for this specific case could you > try it out? Sure. I wouldn't have known where to start looking, but if you have anything I can apply and boot into, I can give you a full dmesg output or wh

RE: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-14 Thread Mario_Limonciello
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, June 11, 2016 12:42 PM > To: and...@lunn.ch > Cc: Limonciello, Mario ; > hayesw...@realtek.com; linux-ker...@vger.kernel.org; > net...@vger.kernel.org; linux-usb@vger.kernel.org; pali.ro...@gmail.com; >

Re: xhci usb serial open/close issue

2016-06-14 Thread Oliver Neukum
On Tue, 2016-06-14 at 20:27 +0530, shishir tiwari wrote: > Hi , > > We are trying to open and close ttyUSB0 port and using 'chat' command > to communicate in while loop using shell script.but after 30-40 times > '#' reply is not coming for 'ls' command. > > shell script:: > while > ( > stty -F /d

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Guenter Roeck
On 06/12/2016 07:10 PM, Frank Wang wrote: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required necessarily. Signed-off-by: Frank Wang --- [ ... ] + +stat

xhci usb serial open/close issue

2016-06-14 Thread shishir tiwari
Hi , We are trying to open and close ttyUSB0 port and using 'chat' command to communicate in while loop using shell script.but after 30-40 times '#' reply is not coming for 'ls' command. shell script:: while ( stty -F /dev/ttyUSB0 115200 -echo exec > /dev/ttyUSB0 exec < /dev/ttyUSB0 chat '' ls '#

[PATCH] usb: misc: ftdi-elan: Fix off-by-one memory corruptions

2016-06-14 Thread Xiao Han
This patch fixes fives off-by-one bugs in the ftdi-elan driver code. The bug can be triggered by plugging a USB adapter for CardBus 3G cards (model U132 manufactured by Elan Digital Systems, Ltd), causing a kernel panic. The fix was tested on Ubuntu 14.04.4 with 4.7.0-rc14.2.0-27-generic+ and 4.4.0

Re: [PATCH v10 03/14] usb: hcd.h: Add OTG to HCD interface

2016-06-14 Thread Alan Stern
On Tue, 14 Jun 2016, Roger Quadros wrote: > +Alan > > On 10/06/16 16:07, Roger Quadros wrote: > > The OTG core will use struct otg_hcd_ops to interface > > with the HCD (Host Controller Driver). > > > > The main purpose of this interface is to avoid directly > > calling HCD APIs from the OTG cor

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Heiko Stübner
Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck: > On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote: > > Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: > >> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > >> than rk3288 and before, and most of phy-related

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Guenter Roeck
On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote: > Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: >> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block >> than rk3288 and before, and most of phy-related registers are also >> different from the past, so a new phy driver

Re: [PATCH v5 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-06-14 Thread Heiko Stübner
Am Montag, 13. Juni 2016, 10:38:39 schrieb Heiko Stübner: > Am Montag, 13. Juni 2016, 10:10:09 schrieb Frank Wang: > > Signed-off-by: Frank Wang > > looks really cool now, thanks for addressing all the review comments > > Reviewed-by: Heiko Stuebner You've only added the very common "reg" prop

Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-14 Thread Heiko Stübner
Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > than rk3288 and before, and most of phy-related registers are also > different from the past, so a new phy driver is required necessarily. > > Signed-off-by: Frank Wang > -

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-06-14 Thread Oliver Neukum
On Tue, 2016-06-14 at 13:20 +0200, Martin Kepplinger wrote: > * Fix usb_autopm calls to be balanced > * In reset_resume() we need to set the device mode > * In suspend() we must cancel the workqueue's work > > Signed-off-by: Martin Kepplinger Looks good to me. Regards

Re: [PATCH] usb: common: otg-fsm: add license to usb-otg-fsm

2016-06-14 Thread Oscar
El 2016-06-14 08:26, Peter Chen escribió: On Mon, Jun 13, 2016 at 06:56:30PM +0200, Oscar wrote: Fix warning about tainted kernel because usb-otg-fsm has no license. WARNING: with this patch usb-otg-fsm module can be loaded but then the kernel will hang. Tested with a udoo quad board. Signed-of

[PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-06-14 Thread Martin Kepplinger
* Fix usb_autopm calls to be balanced * In reset_resume() we need to set the device mode * In suspend() we must cancel the workqueue's work Signed-off-by: Martin Kepplinger --- Thanks Oliver, I think I got it now. Dmitry, again, do you want to have a new version of the whole driver instead of

Re: [PATCH] USB: core: fix missing include

2016-06-14 Thread Arnd Bergmann
On Wednesday, June 8, 2016 3:04:27 AM CEST kbuild test robot wrote: > >> drivers/usb/core/of.c:32:21: error: redefinition of 'usb_of_get_child_node' > struct device_node *usb_of_get_child_node(struct device_node *parent, > ^ >In file included from

Re: BUG: using smp_processor_id() in preemptible [00000000] code]

2016-06-14 Thread M G Berberich
Hello, Am Montag, den 13. Juni schrieb Adam Morrison: > On Mon, Jun 13, 2016 at 4:06 PM, M G Berberich > wrote: > > > Hello, > > > >> >> With 4.7-rc2, after detecting a USB Mass Storage device > >> >> > >> >> [ 11.589843] usb-storage 4-2:1.0: USB Mass Storage device detected > >> >> > >> >> a

Re: USB broken on Banana Pi in Linux 4.6 [solved]

2016-06-14 Thread Marc Haber
Hi, On Mon, May 30, 2016 at 09:02:54PM +0200, Marc Haber wrote: > on my Bananapis, in kernel 4.6 USB does not work. Kernel configuration > is USB-wise identical to 4.5 (grepped for differences in (hci|usb)), > and in 4.6 there is not even /dev/bus/usb. This turned out to be a configuration issue.

Re: [PATCH v10 01/14] usb: hcd: Initialize hcd->flags to 0

2016-06-14 Thread Roger Quadros
+Alan, On 10/06/16 16:07, Roger Quadros wrote: > When using the OTG/DRD library we can call hcd_add/remove > consecutively without calling usb_put_hcd/usb_create_hcd in between > so hcd->flags can be stale. > > If the HC dies due to whatever reason then without this > patch we get the below error

Re: [PATCH v10 14/14] usb: host: xhci-plat: Add otg device to platform data

2016-06-14 Thread Roger Quadros
Mathias, On 10/06/16 16:07, Roger Quadros wrote: > Host controllers that are part of an OTG/dual-role instance > need to somehow pass the OTG controller device information > to the HCD core. > > We use platform data to pass the OTG controller device. > > Signed-off-by: Roger Quadros > Reviewed-

Re: [PATCH v10 12/14] usb: hcd: Adapt to OTG core

2016-06-14 Thread Roger Quadros
+Alan On 10/06/16 16:07, Roger Quadros wrote: > Introduce usb_otg_add/remove_hcd() for use by host > controllers that are part of OTG/dual-role port. > > Non device tree platforms can use the otg_dev argument > to specify the OTG controller device. If otg_dev is NULL > then the device tree node's

Re: [PATCH v10 03/14] usb: hcd.h: Add OTG to HCD interface

2016-06-14 Thread Roger Quadros
+Alan On 10/06/16 16:07, Roger Quadros wrote: > The OTG core will use struct otg_hcd_ops to interface > with the HCD (Host Controller Driver). > > The main purpose of this interface is to avoid directly > calling HCD APIs from the OTG core as they > wouldn't be defined in the built-in symbol tabl

Re: [PATCH v10 00/14] USB OTG/dual-role framework

2016-06-14 Thread Roger Quadros
+Alan. (Sorry Alan, I forgot to add copy you in this series). Hi, On 14/06/16 05:17, Peter Chen wrote: > On Fri, Jun 10, 2016 at 04:07:09PM +0300, Roger Quadros wrote: >> Hi, >> >> This series centralizes OTG/Dual-role functionality in the kernel. >> As of now I've got Dual-role functionality wor

Re: [PATCH] hid: migrate Dream Cheeky LED driver from USB misc to HID

2016-06-14 Thread Oliver Neukum
On Tue, 2016-06-14 at 07:51 +0200, Heiner Kallweit wrote: > + ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW); > + if (ret) > + return ret; > + > + minor = ((struct hidraw *) hdev->hidraw)->minor; > + > + ret = dc_init_device(dcdev); That is a race condition. You announce

Re: [PATCH] xhci: Detect out-of-bounds access to usb2_ports

2016-06-14 Thread Christian M . Amsüss
Hello USB maintainers, On Wed, Mar 30, 2016 at 10:52:53AM +0200, Christian M. Amsüss wrote: > Out-of-bounds access was triggered on a Thinkpad Yoga during suspend or > by rmmod'ing the xhci-pci module, sometimes leading to a general > protection fault. the problem still exists in 4.7-rc3, and it

Re: uac2: diagnosing uac2 audio gadget problems

2016-06-14 Thread Peter Chen
On Tue, Jun 14, 2016 at 02:00:23PM +0800, Peter Chen wrote: > On Mon, Jun 13, 2016 at 04:49:50PM -0700, Caleb Crome wrote: > > On Mon, Jun 13, 2016 at 4:04 PM, Caleb Crome wrote: > > > On Mon, Jun 13, 2016 at 2:53 AM, Peter Chen wrote: > > >> On Wed, Jun 08, 2016 at 04:11:11PM -0700, Caleb Crome