Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

2016-02-14 Thread Krzysztof Hałasa
Arnd Bergmann writes: >> Anyway, I think readl()/writel() do the right thing: in BE mode they >> swap PCI accesses and don't swap normal registers, in LE mode nothing is >> swapped. > > This seems to be true when CONFIG_IXP4XX_INDIRECT_PCI is set, but > not otherwise. For the indirect variant, wr

RE: [PATCH v7 3/3] usbip: safe completion against usb_kill_urb()

2016-02-14 Thread fx IWATA NOBUO
> Why this one tiny bugfix at the end of this series? Is this something that > could be applied without the huge 1/3 patch here? If so, please send it > on its own. If not, then please fix it in the place where you made this > bug happen. OK. I will send it separately. I will send it as V1 wit

RE: [PATCH v3 0/2] usbip: vhci number of ports extension

2016-02-14 Thread fx IWATA NOBUO
> What limitation? Why change it? What's the problem here... In original code, number of devices to be able to attach is 8. It's came from VHCI_NPORTS, the default is 8. It can be changed with compile option -DVHCI_NPORTS The maximum number is limited to USB_MAXCHILDREN (31). In my use case, se

Re: [PATCH 20/21] usb: support building without CONFIG_HAS_DMA

2016-02-14 Thread Vegard Nossum
On 02/15/2016 02:09 AM, Greg Kroah-Hartman wrote: On Wed, Feb 10, 2016 at 03:29:55PM +0100, Vegard Nossum wrote: Some platforms don't have DMA, but we should still be able to build USB drivers for these platforms. They could still be used through vhci_hcd, usbip_host, or maybe something like USB

Re: [PATCH BACKPORT] xhci:_don't_finish_a_TD_if_we_get_a_short_transfer_event_mid_TD

2016-02-14 Thread Steve Bangert
On Sun, 2016-02-14 at 14:15 -0800, Greg KH wrote: > On Wed, Dec 16, 2015 at 06:22:30AM -0800, Steve Bangert wrote: > > Hi, > > > > This original patch was posted and applied to the 4.3-rcX kernel > > and tagged for > > stable kernels. > > > > http://marc.info/?l=linux-usb&m=144463835322214&w=2 >

RE: [PATCH v7 1/3] usbip: exporting devices

2016-02-14 Thread fx IWATA NOBUO
> I don't see any benifit here at all, please explain it better. > You are saying what your patch does, but not why we would want it. It may not be better than cover letter but I try. My use case is a) a service in internet with VHCI b) distributed small Linux nodes with STUB and IoT devices. I

RE: [PATCH v7 2/3] usbip: readme and manuals about exporting devices

2016-02-14 Thread fx IWATA NOBUO
> > This patch adds function and usage of export to README and manuals. > > > > The wording, 'server' and 'client' are changed. > > That sounds like a mistake, why would you do that? You just reversed > everything? Why? I'd like to add reverse connection. Originally both IMPORT and EXPORT packe

RE: [PATCH v6 00/10] add HNP polling support for usb otg fsm

2016-02-14 Thread Jun Li
Ping... > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Jun Li > Sent: Thursday, January 28, 2016 2:50 PM > To: ba...@ti.com > Cc: linux-usb@vger.kernel.org; Peter Chen ; > hzpeterc...@gmail.com; gre...@linuxfoundation.o

RE: [PATCH v6 00/10] add HNP polling support for usb otg fsm

2016-02-14 Thread Jun Li
Resend with Felipe's new email address > -Original Message- > From: Jun Li > Sent: Monday, February 15, 2016 10:16 AM > To: ba...@ti.com > Cc: linux-usb@vger.kernel.org; Peter Chen ; > hzpeterc...@gmail.com; gre...@linuxfoundation.org; Jun Li > Subject: RE: [PATCH v6 00/10] add HNP pollin

RE: [PATCH v7 1/3] usbip: exporting devices

2016-02-14 Thread fx IWATA NOBUO
> That's too much code to review, especially for something that I have no > idea what it is, or why it is needed at all. > > Please be more descriptive here, and hopefully, break this patch down into > smaller steps. OK. I will divide. Best Regards, n.iwata // -- To unsubscribe from this list:

RE: [PATCH v3 1/2] usbip: vhci number of ports extension

2016-02-14 Thread fx IWATA NOBUO
> > ex) # insmod vhci_hcd.ko num_controllers=4 > > I hate module parameters, please don't do that, create these dynamically > as needed some other way. OK. > > Also, ports per controller is changed from 8 to USB_MAXCHILDREN (31). > > Why? All in one patch? Not good. I will remove the modific

[PATCH v4] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-02-14 Thread Emilio López
From: Reilly Grant The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily relinquish the ability to issue other ioctls that may interfere with other processes and drivers that have claimed an interface on the device. This commit also includes a simple utility to be able to test t

Re: [PATCH v7 0/3] usbip: exporting devices

2016-02-14 Thread Greg KH
On Mon, Feb 15, 2016 at 01:23:20AM +, fx IWATA NOBUO wrote: > > I have no idea what you mean by "exporting devices" :( > > It's at line 86 of original tools/usb/usbip/src/usbip_network.h > // I have no idea what you are talking about here, please be more descriptive in the changelog. And as

RE: [PATCH v7 0/3] usbip: exporting devices

2016-02-14 Thread fx IWATA NOBUO
> I have no idea what you mean by "exporting devices" :( It's at line 86 of original tools/usb/usbip/src/usbip_network.h // -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: [PATCH] usb: storage: make US_DEBUGPX print with LOGLEVEL_DEBUG

2016-02-14 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2016 at 04:13:43PM -0800, Victor Dodon wrote: > The US_DEBUGPX macro uses printk without specifying a kernel log level, so > the default kernel log level is used, which may not match LOGLEVEL_DEBUG > used in usb_stor_dbg. Use printk_emit with LOGLEVEL_DEBUG instead. > > Signed-off-

Re: [PATCH v3 1/2] usbip: vhci number of ports extension

2016-02-14 Thread Greg KH
On Wed, Feb 10, 2016 at 10:55:12AM +0900, Nobuo Iwata wrote: > This patch extends number of ports limitation in application (vhci) > side. > > To do so, vhci driver supports multiple host controllers. The number of > controllers can be specified as a module parameter 'num_controllers'. > The de

Re: [PATCH v3 0/2] usbip: vhci number of ports extension

2016-02-14 Thread Greg KH
On Wed, Feb 10, 2016 at 10:55:11AM +0900, Nobuo Iwata wrote: > This series of patches extends number of ports limitaion in application > (vhci) side. What limitation? Why change it? What's the problem here... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH v7 3/3] usbip: safe completion against usb_kill_urb()

2016-02-14 Thread Greg KH
On Wed, Feb 10, 2016 at 10:45:03AM +0900, Nobuo Iwata wrote: > stub_shutdown_connection() : drivers/usb/usbip/stub_dev.c > stub_device_cleanup_urbs() : drivers/usb/usbip/stub_main.c > requests to kill pending URBs and clears priv lists. > > stub_complete() : drivers/usb/usbip/stub_tx.c might

Re: [PATCH v7 2/3] usbip: readme and manuals about exporting devices

2016-02-14 Thread Greg KH
On Wed, Feb 10, 2016 at 10:45:02AM +0900, Nobuo Iwata wrote: > This patch adds function and usage of export to README and manuals. > > The wording, 'server' and 'client' are changed. That sounds like a mistake, why would you do that? You just reversed everything? Why? > For existing attach com

Re: [PATCH v7 1/3] usbip: exporting devices

2016-02-14 Thread Greg KH
On Wed, Feb 10, 2016 at 10:45:01AM +0900, Nobuo Iwata wrote: > USB/IP supports a function to import USB devices from application-side > machine by attach command. > The usage is as following. > dev:# (Physically attach your USB device.) > dev:# insmod usbip-core.ko and usbip-host.ko > dev:# usbipd

Re: [PATCH v7 0/3] usbip: exporting devices

2016-02-14 Thread Greg KH
On Wed, Feb 10, 2016 at 10:45:00AM +0900, Nobuo Iwata wrote: > Dear all, > > This series of patches introduces exporting devices. I have no idea what you mean by "exporting devices" :( -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@

Re: [PATCH 20/21] usb: support building without CONFIG_HAS_DMA

2016-02-14 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2016 at 03:29:55PM +0100, Vegard Nossum wrote: > Some platforms don't have DMA, but we should still be able to build > USB drivers for these platforms. They could still be used through > vhci_hcd, usbip_host, or maybe something like USB passthrough in UML > from a capable host. > >

Re: [PATCH BACKPORT] xhci:_don't_finish_a_TD_if_we_get_a_short_transfer_event_mid_TD

2016-02-14 Thread Greg KH
On Wed, Dec 16, 2015 at 06:22:30AM -0800, Steve Bangert wrote: > Hi, > > This original patch was posted and applied to the 4.3-rcX kernel and tagged > for > stable kernels. > > http://marc.info/?l=linux-usb&m=144463835322214&w=2 > > > But didn't to make it into the 4.1 and 3.14 kernels as it f

Re: FAILED: patch "[PATCH] USB: fix invalid memory access in hub_activate()" failed to apply to 3.10-stable tree

2016-02-14 Thread Greg KH
On Wed, Jan 27, 2016 at 02:14:54PM -0500, Alan Stern wrote: > On Mon, 25 Jan 2016 gre...@linuxfoundation.org wrote: > > > The patch below does not apply to the 3.10-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then please email the backport, incl

Re: [GIT PULL] USB driver fixes for 4.5-rc4

2016-02-14 Thread Linus Torvalds
On Sun, Feb 14, 2016 at 12:39 PM, Greg KH wrote: > > Ugh, you are right, sorry about that, do you need an updated pull > request, or are you ok with this one? I took it and updates the merge log appropriately. Linus -- To unsubscribe from this list: send the line "unsubscribe l

Re: [GIT PULL] USB driver fixes for 4.5-rc4

2016-02-14 Thread Greg KH
On Sun, Feb 14, 2016 at 12:24:11PM -0800, Linus Torvalds wrote: > On Sun, Feb 14, 2016 at 11:01 AM, Greg KH wrote: > > > > USB and PHY fixes for 4.5-rc4 > > > > Here are a number of USB and PHY driver fixes for 4.5-rc4. > > Actually, only PHY fixes. The USB fixes you already sent me for rc3. > Se

Re: [GIT PULL] USB driver fixes for 4.5-rc4

2016-02-14 Thread Linus Torvalds
On Sun, Feb 14, 2016 at 11:01 AM, Greg KH wrote: > > USB and PHY fixes for 4.5-rc4 > > Here are a number of USB and PHY driver fixes for 4.5-rc4. Actually, only PHY fixes. The USB fixes you already sent me for rc3. See merge commit 46df55ceeaf3. Apparently you haven't updated your upstream tree.

[GIT PULL] USB driver fixes for 4.5-rc4

2016-02-14 Thread Greg KH
The following changes since commit 36f90b0a2ddd60823fe193a85e60ff1906c2a9b3: Linux 4.5-rc2 (2016-01-31 18:12:16 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.5-rc4 for you to fetch changes up to 6b44d1e9bf3b850b433694

Re: [PATCH] ARM: dts: ls2080a: Add quirk for Erratum A009116

2016-02-14 Thread Shawn Guo
On Tue, Feb 09, 2016 at 05:08:07PM -0600, Lijun Pan wrote: > Add "snps,quirk-frame-length-adjustment" property to > USB3 node for erratum A009116. This property provides > value of GFLADJ_30MHZ for post silicon frame length > adjustment. > > Signed-off-by: Lijun Pan > --- > arch/arm64/boot/dts/f