RE: [PATCH] usb: renesas_usbhs: constify usbhs_pkt_handle structures

2016-01-06 Thread Yoshihiro Shimoda
Hi Julia, > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Julia Lawall > Sent: Monday, December 28, 2015 5:50 AM > > The usbhs_pkt_handle structures are never modified, so declare them as > const. > > Done with the help of Coccinelle. > > Signed-

Re: [PATCH v2] Add support for usbfs zerocopy.

2016-01-06 Thread Lingzhu Xiang
On Wed, Nov 25, 2015 at 7:19 PM, Steinar H. Gunderson wrote: > Add a new interface for userspace to preallocate memory that can be > used with usbfs. This gives two primary benefits: I got this when trying to allocate a little bit large buffer (~4MB) using the new userspace libusb_dev_mem_alloc()

Re: [PATCH] cdc_acm: blacklist Samsung Phones in firmware update mode

2016-01-06 Thread Jose Alonso
I will not continue with this patch. The reasons are: 1. The device 04e8:6601 is used by models in update firmware:    GT-i9000 series, Galaxy Tab P1000, I5700, ...    and also used for modems!!!. 2. The device 04e8:68c3 is used by models in update firmware:    Droid Charge series and ?!? 3. The

Re: xHCI driver issue (ASMedia Controller using xhci_hcd)

2016-01-06 Thread Steve Graham
Oliver Neukum writes: > > # echo -1 >/sys/module/usbcore/parameters/autosuspend > > Did you see any other device failing or is it specific > to your scanner? > > Regards > Oliver > All other devices I own have worked as expected: mouse, keyboard, storage (memory card, hard

Re: [PATCH 1/5] [v2] usb: host: ehci-msm: Allow LS devices to work

2016-01-06 Thread Timur Tabi
Timur Tabi wrote: From: Jack Pham Disable the silicon quirk which is normally enabled for HSIC host mode. This would otherwise prevent low speed devices from enumerating properly. Signed-off-by: Jack Pham Signed-off-by: Timur Tabi Felipe, any change that these five patches can make it into

Re: xHCI driver issue (ASMedia Controller using xhci_hcd)

2016-01-06 Thread Oliver Neukum
On Wed, 2016-01-06 at 17:52 +, Steve Graham wrote: > In my case, my scanner problem has been fixed (so far) by tuning off > autosuspend: > > # echo -1 >/sys/module/usbcore/parameters/autosuspend Did you see any other device failing or is it specific to your scanner? Regards

Re: [PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix error path

2016-01-06 Thread Sergei Shtylyov
Hello. On 1/5/2016 7:54 PM, Peter Senna Tschudin wrote: From: Peter Senna Tschudin This patch remove four calls to dev_err() from sisusb_probe() as reporting memory allocation failures is redundant: - Remove a call to dev_err() that was reporting unsuccesful call to kzalloc(). - Rem

Re: xHCI driver issue (ASMedia Controller using xhci_hcd)

2016-01-06 Thread Steve Graham
In my case, my scanner problem has been fixed (so far) by tuning off autosuspend: # echo -1 >/sys/module/usbcore/parameters/autosuspend -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: xHCI driver issue (ASMedia Controller using xhci_hcd)

2016-01-06 Thread Steve Graham
I've been trying to get my scanner working on my newer laptop (entire Linux installation, apart from the kernel (4.2.5) cloned from the old one) and I seem to be seeing the same issue, although I have no problem with USB storage or HID devices on the USB 3 port. Here's a clip from the debug with S

Re: [PATCH 0/5] usb-misc: cleanup sisusbvga

2016-01-06 Thread Joe Perches
On Wed, 2016-01-06 at 16:30 +0100, Peter Senna Tschudin wrote: > is it ok to fix horizontal issues caused by vertical changes in the > vertical changes patch? Yes. > Is it reasonable to respin if other issues are > reported for this series? Your choice. I think it'd be better to respin in any ca

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-06 Thread Alan Stern
On Wed, 6 Jan 2016, Peter Stuge wrote: > Steinar H. Gunderson wrote: > > > Our interface for zero copy reads/writes is O_DIRECT, and that requires > > > not special memory allocation, just proper alignment. > > > > But that assumes you are using I/O using read()/write(). There's no way you > > ca

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-06 Thread Steinar H. Gunderson
On Wed, Jan 06, 2016 at 04:22:12PM +0100, Peter Stuge wrote: >>> Our interface for zero copy reads/writes is O_DIRECT, and that requires >>> not special memory allocation, just proper alignment. >> But that assumes you are using I/O using read()/write(). There's no way you >> can shoehorn USB isoch

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-06 Thread Alan Stern
On Wed, 6 Jan 2016, Steinar H. Gunderson wrote: > On Tue, Jan 05, 2016 at 10:49:49PM -0800, Christoph Hellwig wrote: > > This is a completely broken usage of the mmap interface. if you use > > mmap on a device file you must use the actual mmap for the data > > transfer. > > Really? V4L does exac

Re: [PATCH 0/5] usb-misc: cleanup sisusbvga

2016-01-06 Thread Peter Senna Tschudin
On Tue, Jan 05, 2016 at 10:53:24AM -0800, Joe Perches wrote: > On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote: > [] > > Patch 1 is the biggest and fix only whitespace, tab and newline issues. I > > used > > > > $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-06 Thread Peter Stuge
Steinar H. Gunderson wrote: > > Our interface for zero copy reads/writes is O_DIRECT, and that requires > > not special memory allocation, just proper alignment. > > But that assumes you are using I/O using read()/write(). There's no way you > can shoehorn USB isochronous reads into the read() int

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-06 Thread Steinar H. Gunderson
On Tue, Jan 05, 2016 at 10:49:49PM -0800, Christoph Hellwig wrote: > This is a completely broken usage of the mmap interface. if you use > mmap on a device file you must use the actual mmap for the data > transfer. Really? V4L does exactly the same thing, from what I can see. It's just a way of a

[PATCH] usb: hid: Add new PID for Microchip Pick16F1454

2016-01-06 Thread Kristian Evensen
From: Kristian Evensen There seems to be a new version of the Microchip Pick16F1454 with a different PID (0xf2f7). This device should also be ignored by the HID driver. The PID was observed with the second version of the Yepkit Ykush USB hub. Signed-off-by: Kristian Evensen --- drivers/hid/hid

Re: usb: dwc2: regression on bcm2835 after commit 09c96980dc72

2016-01-06 Thread Stefan Wahren
Am 05.01.2016 um 21:39 schrieb John Youn: > > Ok, I'll get these fixes in. > > I'm not totally sure what the problem is. I'll see if I can get a > raspberry pi to test it out. So you don't need a proper patch series according to these regressions from me? > > Regards, > John -- To unsubscribe f

RE: [PATCH v2 1/2] usbip: vhci number of ports extension

2016-01-06 Thread fx IWATA NOBUO
> Why do these numbers have to be static? Because it is easy to implement. When event threads are reduced with patch 2/2, I thought it is acceptable. > Why can't we automatically add new controllers when there are no > more ports available? It possible. Some overhead may exist when extending. I

RE: [PATCH v6 04/11] usbip: kernel module for userspace URBs transmission

2016-01-06 Thread fx IWATA NOBUO
Dear Bjørn, I might not fully understand your comments but I try my best. > usbip-host.ko and vhci-hcd.ko are running on different hosts, likely > on different hardware and kernel versions, so this picture is > impossible. If this discusses USB level interoperability, the issue is came from USB/