Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Peter Chen
On Wed, Dec 16, 2015 at 09:05:35PM +0100, Maciej S. Szmigiero wrote: > Hi Fabio, > Hi Peter, > > On 16.12.2015 11:11, Fabio Estevam wrote: > > Hi Peter, > > > > On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen > > wrote: > > > >> Thanks, Fabio, but I am curious how things like that? The USBOH3 cloc

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Peter Chen
On Thu, Dec 17, 2015 at 12:13:07AM +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 16:59:39 Rob Herring wrote: > > On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: > > > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > > > > I agree on doing it properly, but am not sure tha

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-16 Thread Chanwoo Choi
Hi, On 2015년 12월 17일 11:16, Chanwoo Choi wrote: > Hi Sergei, > > On 2015년 12월 17일 03:07, Sergei Shtylyov wrote: >> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to >> enable a system with an integrated USB OTG dual-role transceiver to >> function as an USB OTG dual-role

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-16 Thread Chanwoo Choi
Hi Sergei, On 2015년 12월 17일 03:07, Sergei Shtylyov wrote: > Maxim Integrated MAX3355E chip integrates a charge pump and comparators to > enable a system with an integrated USB OTG dual-role transceiver to > function as an USB OTG dual-role device. In addition to sensing/controlling > Vbus, the chi

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-16 Thread Krzysztof Kozlowski
2015-12-17 3:07 GMT+09:00 Sergei Shtylyov : > Maxim Integrated MAX3355E chip integrates a charge pump and comparators to > enable a system with an integrated USB OTG dual-role transceiver to > function as an USB OTG dual-role device. In addition to sensing/controlling > Vbus, the chip also passes t

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Arnd Bergmann
On Wednesday 16 December 2015 16:59:39 Rob Herring wrote: > On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: > > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > > I agree on doing it properly, but am not sure that pwrseq binding for > MMC is proper. The pwrseq binding is fairly limite

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Rob Herring
On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: > On Monday 14 December 2015 15:26:11 Peter Chen wrote: >> Hi all, >> >> There is a known issue that the USB code can't handle USB HUB's >> external pins well, in that case, it may cause some onboard >> USB HUBs can't work since their PHY's clo

Re: [PATCH] usb: dwc2: fix transfer stop programming for out endpoint

2015-12-16 Thread John Youn
On 12/16/2015 8:58 AM, Felipe Balbi wrote: > > Hi, > > changbin...@intel.com writes: >> From: "Du, Changbin" >> >> To stop an out endpoint, software should set sets the Global OUT NAK, >> but not the Global Non-periodic IN NAK. This driver bug leads the out-ep >> failed be in disabled state with

Re: [PATCH] usb: dwc2: gadget: don't overwrite DCTL register on NAKEFF interrupts

2015-12-16 Thread John Youn
On 12/16/2015 8:58 AM, Felipe Balbi wrote: > > Hi, > > Gregory Herrero writes: >> When receiving GINTSTS_GINNAKEFF or GINTSTS_GOUTNAKEFF interrupt, >> DCTL will be overwritten with DCTL_CGOUTNAK or DCTL_CGNPINNAK values. >> Instead of overwriting it, write only needed bits. >> >> It could cause

Re: [PATCH 15/18] usb: dwc2: Improve handling of host and device hwparams

2015-12-16 Thread John Youn
On 12/16/2015 8:08 AM, Felipe Balbi wrote: > > Hi > > John Youn writes: >> On 12/10/2015 2:55 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> John Youn writes: > Interesting. You're getting a new parameter that's never been needed > in the code before and (as far as I can tell) isn't used

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Maciej S. Szmigiero
Hi Fabio, Hi Peter, On 16.12.2015 11:11, Fabio Estevam wrote: > Hi Peter, > > On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen wrote: > >> Thanks, Fabio, but I am curious how things like that? The USBOH3 clock >> is not opened, the usb driver will hang when it tries to access >> registers. If this c

Re: poweroff-issue with dwc2 on Felipe's testing/next branch

2015-12-16 Thread Doug Anderson
Hi, On Wed, Dec 16, 2015 at 9:36 AM, Doug Anderson wrote: > Hi, > > On Wed, Dec 16, 2015 at 7:35 AM, Felipe Balbi wrote: >> >> Hi, >> >> John Youn writes: >>> On 12/15/2015 3:49 PM, Heiko Stübner wrote: Hi, it seems the recent dwc2 additions to the testing/next branch [0] caused

[PATCH] USB: fix invalid memory access in hub_activate()

2015-12-16 Thread Alan Stern
Commit 8520f38099cc ("USB: change hub initialization sleeps to delayed_work") changed the hub_activate() routine to make part of it run in a workqueue. However, the commit failed to take a reference to the usb_hub structure or to lock the hub interface while doing so. As a result, if a hub is plu

[PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-16 Thread Sergei Shtylyov
Maxim Integrated MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as an USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID signal from the USB OTG connector. On som

Re: poweroff-issue with dwc2 on Felipe's testing/next branch

2015-12-16 Thread Felipe Balbi
Hi, Doug Anderson writes: it seems the recent dwc2 additions to the testing/next branch [0] caused some interesting issue for me. Setting is a regular 4.4-rc3/4 (only with some display-stuff added), and the testing/next branch merged in. If I attach a sin

Re: poweroff-issue with dwc2 on Felipe's testing/next branch

2015-12-16 Thread Doug Anderson
Hi, On Wed, Dec 16, 2015 at 7:35 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> On 12/15/2015 3:49 PM, Heiko Stübner wrote: >>> Hi, >>> >>> it seems the recent dwc2 additions to the testing/next branch [0] caused >>> some interesting issue for me. >>> >>> Setting is a regular 4.4-rc3/4

Re: [PATCH 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-16 Thread Dan Williams
On Wed, 2015-12-16 at 10:39 +0100, Daniele Palmas wrote: > This patch series add support in the cdc_ncm driver for two devices > based on the same platform, that are different only for carrier > customization. > > The devices do not have ARP capabilities. > > Daniele Palmas (2): > net: usb: cdc

Re: [PATCH] usb: dwc2: gadget: don't overwrite DCTL register on NAKEFF interrupts

2015-12-16 Thread Felipe Balbi
Hi, Gregory Herrero writes: > When receiving GINTSTS_GINNAKEFF or GINTSTS_GOUTNAKEFF interrupt, > DCTL will be overwritten with DCTL_CGOUTNAK or DCTL_CGNPINNAK values. > Instead of overwriting it, write only needed bits. > > It could cause an issue if GINTSTS_GINNAKEFF or GINTSTS_GOUTNAKEFF > in

Re: [PATCH] usb: dwc2: fix transfer stop programming for out endpoint

2015-12-16 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > From: "Du, Changbin" > > To stop an out endpoint, software should set sets the Global OUT NAK, > but not the Global Non-periodic IN NAK. This driver bug leads the out-ep > failed be in disabled state with below error. > > dwc2_hsotg_ep_stop_xfr: timeout DOEPCT

Re: [PATCH v2 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-16 Thread Felipe Balbi
Felipe Balbi writes: > Hi, > > David Eccher writes: >> Fix bad unlock balance: ep0_write enter with the locks locked from >> inode.c:1769, hence it must exit with spinlock held to avoid double >> unlock in dev_config. >> >> Signed-off-by: David Eccher > > which commit is this fixing ? Do we nee

Re: [PATCH v2 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-16 Thread Felipe Balbi
Hi, David Eccher writes: > Fix bad unlock balance: ep0_write enter with the locks locked from > inode.c:1769, hence it must exit with spinlock held to avoid double > unlock in dev_config. > > Signed-off-by: David Eccher which commit is this fixing ? Do we need this backported to stable kernels

RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep

2015-12-16 Thread Felipe Balbi
Hi, "Du, Changbin" writes: >> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h >> index 3d583a1..b566a4b 100644 >> --- a/include/linux/usb/gadget.h >> +++ b/include/linux/usb/gadget.h >> @@ -402,6 +402,9 @@ static inline void usb_ep_free_request(struct usb_ep >> *ep, >> stat

Re: [PATCH v3 0/3] usb: renesas_usbhs: More compat strings

2015-12-16 Thread Felipe Balbi
Hi, Simon Horman writes: > Hi, > > this short series adds generic, and soc-specific r8a7792 and r8a7793 compat > strings to the Renesas USBHS driver. The intention is to provide a complete > set of compat strings for known R-Car SoCs. > > Changes since v2: > * Split documentation of SoC names in

Re: [PATCH v2] usb: gadget: ether: Allow changing the MTU

2015-12-16 Thread Felipe Balbi
Hi, Mike Looijmans writes: > Just a "ping" reminder, I'd like to inquire about the status of this > patch... in my testing/next -- balbi signature.asc Description: PGP signature

Re: [PATCH 15/18] usb: dwc2: Improve handling of host and device hwparams

2015-12-16 Thread Felipe Balbi
Hi John Youn writes: > On 12/10/2015 2:55 PM, Felipe Balbi wrote: >> >> Hi, >> >> John Youn writes: Interesting. You're getting a new parameter that's never been needed in the code before and (as far as I can tell) isn't used anywhere in your series. I presume this is in prep

Re: [PATCH v6 0/3] USB MIDI Gadget improvements and bug fixes

2015-12-16 Thread Felipe Balbi
Hi Felipe Ferreri Tonello writes: > Hi all, > > On 01/12/15 18:30, Felipe F. Tonello wrote: >> Fixed all comments suggested by the linux-usb list. >> >> changes in v6: >> - Removed patches already applied in Balbi's tree >> - Cleanups on pre-allocation usb requrests patch >> - Fixed indenten

Re: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-16 Thread Felipe Balbi
Hi, Arnd Bergmann writes: >> +struct renesas_usb3; >> +struct renesas_usb3_request { >> +struct usb_request req; >> +struct list_headqueue; >> +}; > > There is already a list_head in struct usb_request. Could you use that? > (I don't know, just asking because this looks odd)

Re: poweroff-issue with dwc2 on Felipe's testing/next branch

2015-12-16 Thread Felipe Balbi
Hi, John Youn writes: > On 12/15/2015 3:49 PM, Heiko Stübner wrote: >> Hi, >> >> it seems the recent dwc2 additions to the testing/next branch [0] caused >> some interesting issue for me. >> >> Setting is a regular 4.4-rc3/4 (only with some display-stuff added), and the >> testing/next branch

RE: [PROBLEM] usb hub malformed packets causes null pointer dereference

2015-12-16 Thread Alan Stern
On Wed, 16 Dec 2015, Cornea, Alexandru wrote: > Hello, > > We verified the updated patch and everything seems to be ok. All 61 USB > hub testcases pass. Thanks for testing. I will submit the patch. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

[PATCH BACKPORT] xhci:_don't_finish_a_TD_if_we_get_a_short_transfer_event_mid_TD

2015-12-16 Thread Steve Bangert
Hi, This original patch was posted and applied to the 4.3-rcX kernel and tagged for stable kernels. http://marc.info/?l=linux-usb&m=144463835322214&w=2 But didn't to make it into the 4.1 and 3.14 kernels as it failed to apply in it's original form. A backport from Ben Hutchings was posted duri

RE: [PROBLEM] usb hub malformed packets causes null pointer dereference

2015-12-16 Thread Cornea, Alexandru
Hello, We verified the updated patch and everything seems to be ok. All 61 USB hub testcases pass. Regards, /Alex -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, December 15, 2015 10:54 PM To: Cornea, Alexandru Cc: linux-usb@vger.kernel

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-16 Thread Philipp Zabel
Hi Maxime, Am Mittwoch, den 16.12.2015, 11:29 +0100 schrieb Maxime Ripard: > On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: > > Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > > > Hi, > > > > > > On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: > > >

[patch] USB: ipaq.c: fix a timeout loop

2015-12-16 Thread Dan Carpenter
The code expects the loop to end with "retries" set to zero but, because it is a post-op, it will end set to -1. I have fixed this by moving the decrement inside the loop. Fixes: 014aa2a3c32e ('USB: ipaq: minor ipaq_open() cleanup.') Signed-off-by: Dan Carpenter diff --git a/drivers/usb/serial/

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-16 Thread Maxime Ripard
On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: > Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > > Hi, > > > > On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: > > > diff --git a/include/linux/reset.h b/include/linux/reset.h > > > index c4c097d..1cca8c

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Fabio Estevam
Hi Peter, On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen wrote: > Thanks, Fabio, but I am curious how things like that? The USBOH3 clock > is not opened, the usb driver will hang when it tries to access > registers. If this clock is always on, then, why the system will > hang later? I found the is

[PATCH 1/2] net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband Card

2015-12-16 Thread Daniele Palmas
Dell DW5812 is a mobile broadband card with no ARP capabilities: the patch makes this device to use wwan_noarp_info struct Signed-off-by: Daniele Palmas --- drivers/net/usb/cdc_ncm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c

[PATCH 2/2] net: usb: cdc_ncm: Adding Dell DW5813 LTE AT&T Mobile Broadband Card

2015-12-16 Thread Daniele Palmas
Dell DW5813 is a mobile broadband card with no ARP capabilities: the patch makes this device to use wwan_noarp_info struct Signed-off-by: Daniele Palmas --- drivers/net/usb/cdc_ncm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c

[PATCH 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-16 Thread Daniele Palmas
This patch series add support in the cdc_ncm driver for two devices based on the same platform, that are different only for carrier customization. The devices do not have ARP capabilities. Daniele Palmas (2): net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband Card net: usb

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

2015-12-16 Thread Fabio Estevam
Hi Maciej, On Tue, Dec 15, 2015 at 6:19 PM, Maciej S. Szmigiero wrote: > Can we now use this change for repairing the USB support on UDOO board? > > This seems to work fine if not 100% correct: > --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi > @@ -122,7 +1

Re: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-16 Thread Arnd Bergmann
On Wednesday 16 December 2015 02:26:26 Yoshihiro Shimoda wrote: > Hi Arnd again, > > > From: Yoshihiro Shimoda > > Sent: Wednesday, December 16, 2015 10:43 AM > < snip > > > > > +static void usb3_write(struct renesas_usb3 *usb3, u32 data, u32 offs) > > > > +{ > > > > + iowrite32(data, usb3->